* Gary V. Vaughan wrote on Tue, Jan 29, 2008 at 08:44:51AM CET: > On 29 Jan 2008, at 06:45, Ralf Wildenhues wrote: > >> I haven't reviewed your last two pending patches yet (but I'm not >> telling you to wait for me). > > Every little helps, even if you don't have time for a thorough review...
Your latest version of this patch is so badly mangled as to be unapplicable. This is not the first time it happens. Please consider sending patches as (text!) attachments, or at least try to apply patches from your mails to see whether that works. When I try to apply this patch by hand, build and install, get CVS HEAD GraphicsMagick, and run its bootstrap script, I end up with this failure, which I assume is due to one of your patches, or to messup resulting from manual patch application. Anyway you should look at it before applying the patch (hint: lt_libobj_prefix seems not set in configure): /bin/sh ./libtool --silent --tag=CC --mode=link gcc -std=gnu99 -g -O2 -Wall -pthread -module -avoid-version -L/usr/X11R6/lib -L/usr/lib -L/usr/lib -o ltdl/dlopen.la ltdl/loaders/dlopen.lo -ldl make[1]: *** No rule to make target `lt__strl.lo', needed by `ltdl/libltdlc.la'. Stop. make[1]: Leaving directory `/tmp/GraphicsMagick/build' make: *** [all] Error 2 Thanks, Ralf > Index: b/libltdl/m4/ltdl.m4 > =================================================================== > --- a/libltdl/m4/ltdl.m4 > +++ b/libltdl/m4/ltdl.m4 [...] > + > +AC_CONFIG_COMMANDS_PRE([ > + _ltdl_libobjs= > + _ltdl_ltlibobjs= > + if test -n "$_LT_LIBOBJS"; then > + # Remove the extension. > + sed_drop_objext='s/\.o$//;s/\.obj$//' This is code that ends up in configure. sed_drop_objext is not namespace clean, please prefix with _lt_ or so. > + for i in `for i in $_LT_LIBOBJS; do echo "$i"; done | sed > "$sed_drop_objext" | sort | uniq`; do `sort -u' is portable. > + _ltdl_libobjs="$_ltdl_libobjs $lt_libobj_prefix$i.$ac_objext" > + _ltdl_ltlibobjs="$_ltdl_ltlibobjs $lt_libobj_prefix$i.lo" > + done > + fi > + AC_SUBST([ltdl_LIBOBJS], [$_ltdl_libobjs]) > + AC_SUBST([ltdl_LTLIBOBJS], [$_ltdl_ltlibobjs]) > +]) > + > # Only expand once: > m4_define([LTDL_INIT]) > ])# LTDL_INIT
