Re: namespace / typing thrash ...

2012-04-18 Thread Lubos Lunak
On Wednesday 18 of April 2012, Stephan Bergmann wrote: > On 04/17/2012 02:38 PM, Lubos Lunak wrote: > > But maybe gbuild could be changed to include target-specific LDFLAGS? > > That way it'd be possible to build as 'make > > sc_ucalc_LDFLAGS=-Wl,--strip-all

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Lubos Lunak
sing the compiler stl on windows as well. The compiler > provided "list" header on msvc 2008 itself triggers a warning, which is > a real pain for WaE. What warning would that be? I do not see anything that seems relevant in tinderbox log

Copying sc/sd/sw into unittest libs (Re: namespace / typing thrash ...)

2012-04-18 Thread Lubos Lunak
On Wednesday 18 of April 2012, Bjoern Michaelsen wrote: > On Wed, Apr 18, 2012 at 06:09:06PM +0200, Lubos Lunak wrote: > > Does somebody see a problem with this? > > What should this possibly solve? This thread is a quite bit ADHD to me > pouring in way too many different t

Re: killing soffice.bin from oosplash (was: Re: [REVIEW][3-5] misc stuff)

2012-04-19 Thread Lubos Lunak
fice.bin is still listening on the pipe, so the new soffice.bin > cannot listen. > > is there some POSIX interface that will kill all children of a process? No. It is possible to kill all processes in a group, but I'm unsure on the exact details of what becoming a process group leaders c

Re: per library debug builds now possible via ./configure

2012-04-20 Thread Lubos Lunak
On Monday 16 of April 2012, Bjoern Michaelsen wrote: > On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote: > > Is it possible to do the build also the other way around, i.e. e.g. "all > > but sc"? > > Not yet, feel free to add it if you think it is essenti

Re: per library debug builds now possible via ./configure

2012-04-20 Thread Lubos Lunak
On Friday 20 of April 2012, Lubos Lunak wrote: > On Monday 16 of April 2012, Bjoern Michaelsen wrote: > > On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote: > > > Is it possible to do the build also the other way around, i.e. e.g. > > > "all but sc"?

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-23 Thread Lubos Lunak
am not sure if "make install" should strip by default or > not. Bjoern, Lubos, what do you think? It should not, it should do what the name says. If the functionality is deemed useful, it can be an extra target like other build systems have (e.g. automake has install-strip)

Re: per library debug builds now possible via ./configure

2012-04-23 Thread Lubos Lunak
On Friday 20 of April 2012, Lubos Lunak wrote: > On Monday 16 of April 2012, Bjoern Michaelsen wrote: > > On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote: > > > Is it possible to do the build also the other way around, i.e. e.g. > > > "all but sc"?

Re: [PUSHED] Some fixes for Clang warnings

2012-04-23 Thread Lubos Lunak
else turns out. Note that I do not get any crash with the test2.cc test file with "SUSE Linux clang version 3.1 (trunk 154660) (based on LLVM 3.1svn)", nor I see any other compiler crash during LO compile, so you might want to upgrade first. -

Re: Problem with "configure checks for gcc options that clang does not support"

2012-04-24 Thread Lubos Lunak
bug seems to exists only with Clang < 3.1, so the problem can be worked around by checking for such versions and overriding all results of such checks to values manually found out. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list Li

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread Lubos Lunak
lo.so from my devel build and strip it, the only difference is .debug* sections removed, so quite possibly even that table of internal symbols is a thing of the past. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list Lib

Re: [Libreoffice-commits] .: 26 commits - avmedia/source basctl/source basic/source configure.in connectivity/source cppu/inc dbaccess/source distro-configs/LibreOfficeMacOSX.conf distro-configs/Libre

2012-04-24 Thread Lubos Lunak
fi > +enable_cairo_canvas=no > +elif test -z "$enable_cairo_canvas"; then > +enable_cairo_canvas=yes -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Lubos Lunak
ion. It would be enough if --enable-system-libs=auto existed and was the default. Bonus points if configure at the end printed a list of which external dependencies were and were not picked up. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Problem with "configure checks for gcc options that clang does not support"

2012-04-24 Thread Lubos Lunak
3.1svn). The fix is dated "Tue Mar 13 20:09:56 2012 +". -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][3-5] Re: [REVIEW-3-5 3-5-3] default to Office 2007/2010 filters for export to ooxml

2012-04-24 Thread Lubos Lunak
actual Microsoft Office products > produce and consume. > > > The patch should be safe and will only change the position in the > > dialog and the order for the TypeDetection during export. > > [1] > > http://cgit.freedesktop.org/libreoffice/core/

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Caolán McNamara wrote: > On Tue, 2012-04-24 at 11:49 +0200, Lubos Lunak wrote: > > Right now all those 100 developers have to have a long list of options, > > half of them because they are needed, other half because they'd prefer > > not to b

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Caolán McNamara wrote: > On Wed, 2012-04-18 at 18:15 +0200, Lubos Lunak wrote: > > On Wednesday 18 of April 2012, Caolán McNamara wrote: > > > We moved to using the compiler stl on windows as well. The compiler > > > provided "list"

Re: [Libreoffice-commits] .: filter/inc filter/Library_msfilter.mk filter/Package_inc.mk filter/source sw/source writerfilter/Library_rtftok.mk writerfilter/source

2012-04-25 Thread Lubos Lunak
rcCharSet = RTL_TEXTENCODING_MS_1250; > -break; Are you sure this is right? The old code used SvxLanguageItem, not Application::GetSettings(). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-25 Thread Lubos Lunak
On Tuesday 24 of April 2012, Caolán McNamara wrote: > On Tue, 2012-04-24 at 17:16 +0200, Lubos Lunak wrote: > > Running "./autogen.sh --with-system-libs" fails as soon as it finds one > > external library that does not exist system-wide (and there's pretty much >

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-25 Thread Lubos Lunak
On Wednesday 25 of April 2012, Bjoern Michaelsen wrote: > On Wed, Apr 25, 2012 at 03:01:16PM +0200, Lubos Lunak wrote: > > Is there any reasonable use case for preferring almost all internal > > copies of libraries if the system-wide one is suitable? > > mu(*). You are aski

[Libreoffice-commits] .: 5 commits - sw/source writerfilter/source

2012-04-25 Thread Lubos Lunak
sw/source/core/unocore/unosett.cxx | 46 ++-- writerfilter/source/dmapper/NumberingManager.cxx | 52 +-- writerfilter/source/dmapper/NumberingManager.hxx |4 + 3 files changed, 76 insertions(+), 26 deletions(-) New commits: commit fb68711f

Re: make check problem in libtest_smoketest building master

2012-04-26 Thread Lubos Lunak
e are a number of distributions building that way (it's the default in openSUSE build service too AFAIK), so while 'everybody does that' is not an argument on its own, perhaps we should consider the possibility that it is not the toolchain that is broken. -- Lubo

Re: Weird build error on 3.5 l10ntools

2012-04-26 Thread Lubos Lunak
ks like the autogenerated operator is wrong, i.e. compiler bug. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/Module_sw.mk

2012-04-27 Thread Lubos Lunak
sw/Module_sw.mk |1 - 1 file changed, 1 deletion(-) New commits: commit e8897be1e1883b327cd324ab45e84fbed3af41df Author: Luboš Luňák Date: Fri Apr 27 19:29:07 2012 +0200 temporarily disable a test with a build race condition diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk index bc0

Re: [Libreoffice-commits] .: sw/Module_sw.mk

2012-04-27 Thread Lubos Lunak
On Friday 27 of April 2012, Lubos Lunak wrote: > sw/Module_sw.mk |1 - > 1 file changed, 1 deletion(-) > > New commits: > commit e8897be1e1883b327cd324ab45e84fbed3af41df > Author: Luboš Luňák > Date: Fri Apr 27 19:29:07 2012 +0200 > > temporarily disab

[Libreoffice-commits] .: 2 commits - solenv/gbuild writerfilter/source

2012-04-28 Thread Lubos Lunak
solenv/gbuild/gbuild.mk |7 +++-- writerfilter/source/dmapper/NumberingManager.cxx | 32 --- writerfilter/source/dmapper/NumberingManager.hxx |3 -- 3 files changed, 23 insertions(+), 19 deletions(-) New commits: commit 3fad0575328c010fe011fb

Re: make ENABLE_SYMBOLS=true no longer enables symbols

2012-04-28 Thread Lubos Lunak
On Saturday 28 of April 2012, Kohei Yoshida wrote: > As the subject says, running make ENABLE_SYMBOLS=true in a module > build doesn't seem to turn on symbols for that module any more. > Anyone has any clue what has changed? Update. -- Lubos Lunak l

Re: [PATCH] Replace more equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator

2012-04-28 Thread Lubos Lunak
On Saturday 28 of April 2012, Elton Chung wrote: > Hi there, > The patch replaces more equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with > == operator. > Replacement is done by using regex. Please compile with your patches before submitting. Your changes cause compilation errors.

[Libreoffice-commits] .: 2 commits - shell/source

2012-04-30 Thread Lubos Lunak
shell/source/unix/misc/senddoc.sh |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 87897ea7137ab2e6fc36f5986d8c0eb210836664 Author: Luboš Luňák Date: Mon Apr 30 16:15:09 2012 +0200 and be (not so) ultimately smart in the mailto handler diff --git a/

[Libreoffice-commits] .: 3 commits - solenv/gbuild writerfilter/source

2012-05-02 Thread Lubos Lunak
solenv/gbuild/gbuild.mk | 40 ++- writerfilter/source/dmapper/NumberingManager.cxx | 27 ++- 2 files changed, 50 insertions(+), 17 deletions(-) New commits: commit 9911ee515dd3d1e077dbf9c1fb4fd5c42a3c49b6 Author: Luboš Luňák Date:

[Libreoffice-commits] .: offapi/com sw/inc sw/source writerfilter/source

2012-05-02 Thread Lubos Lunak
offapi/com/sun/star/text/NumberingLevel.idl |5 + sw/inc/unoprnms.hxx |4 - sw/inc/unosett.hxx |4 - sw/source/core/unocore/unocoll.cxx |2 sw/source/core/unocore/unoprnms.cxx |1 sw/so

Re: [PUSHED] Re: [PATCH] fdo#31005: Table Autoformats does not save/apply all properties

2012-05-03 Thread Lubos Lunak
him a Windows build with the changes, it'd be great. > > the tinderboxes should provide daily builds somewhere... http://dev-builds.libreoffice.org/daily/ -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freed

Re: [PATCH proposed for 3.5 only] Re: vcl module fails to compile (3.5 branch)

2012-05-03 Thread Lubos Lunak
5 branch by using some pragmas. I > just learn how to use them so perhaps it's not the best efficient way to > use them. > I just wonder if the patch attached could be useful to push on 3.5 branch. > > Any idea ? Is there any point in building stable releases with -Werror? If

fdo#34814 - Importing doc with fonts unavailable on the system

2012-05-04 Thread Lubos Lunak
sily handle the fonts in the importer and call SetBulletFont(). -- Lubos Lunak l.lu...@suse.cz diff --git a/sw/source/core/unocore/unocrsrhelper.cxx b/sw/source/core/unocore/unocrsrhelper.cxx index ea77e4f..af0f746 100644 --- a/sw/source/core/unocore/unocrsrhelper.cxx +++ b/sw/sour

Re: fdo#34814 - Importing doc with fonts unavailable on the system

2012-05-04 Thread Lubos Lunak
On Friday 04 of May 2012, Caolán McNamara wrote: > On Fri, 2012-05-04 at 16:11 +0200, Lubos Lunak wrote: > > Hello, > > > > I've been looking at fdo#34814 and I know what the problem is, but I'm > > not sure how that should be fixed. > > > >

[Libreoffice-commits] .: 2 commits - sw/source writerfilter/source

2012-05-04 Thread Lubos Lunak
sw/source/core/unocore/unosett.cxx |1 - writerfilter/source/dmapper/GraphicHelpers.cxx | 12 2 files changed, 8 insertions(+), 5 deletions(-) New commits: commit 20a8768b1c6a6a1456cda9cd096a304e16473fbb Author: Luboš Luňák Date: Fri May 4 20:17:44 2012 +0200

[Libreoffice-commits] .: svtools/source

2012-05-09 Thread Lubos Lunak
svtools/source/control/ctrltool.cxx | 79 1 file changed, 44 insertions(+), 35 deletions(-) New commits: commit 13e6af8860f42daf49474a7ae9779baa0f8f2630 Author: Caolán McNamara Date: Tue May 8 16:08:16 2012 +0100 Related: fdo#34814 check if a missin

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - svtools/source

2012-05-09 Thread Lubos Lunak
svtools/source/control/ctrltool.cxx | 79 1 file changed, 44 insertions(+), 35 deletions(-) New commits: commit 1dc9f21667237bf61ec8d2a9e50b7fb8a61d475b Author: Caolán McNamara Date: Tue May 8 16:08:16 2012 +0100 Related: fdo#34814 check if a missin

Re: fdo#34814 - Importing doc with fonts unavailable on the system

2012-05-09 Thread Lubos Lunak
l to be used, so it's been already broken by a previous import. > and new .docxs created from > scratch are unchanged-working either way. *shrug* whatever works. The patch works for what I've tested, so I've pushed to master and 3.5, thanks. -- Lubos Lunak l.lu...@suse

[Libreoffice-commits] .: configure.in

2012-05-09 Thread Lubos Lunak
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 330d5185036638e4a54d73ab44884d31e6a986cc Author: Luboš Luňák Date: Wed May 9 17:22:00 2012 +0200 one more --enable-dbgutil typo diff --git a/configure.in b/configure.in index c471e34..73f2c48 100

[Libreoffice-commits] .: vcl/win

2012-05-09 Thread Lubos Lunak
vcl/win/source/gdi/winlayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f21316fbf0176ee23999504ce03917caac190cb3 Author: Luboš Luňák Date: Wed May 9 18:20:23 2012 +0200 conversion to void* needs an explicit cast diff --git a/vcl/win/source/gdi/win

Re: [Libreoffice-commits] .: 2 commits - accessibility/CustomTarget_bridge_inc.mk configure.in extensions/CustomTarget_so_activex_idl.mk extensions/Library_so_activex.mk extensions/Library_so_activex_

2012-05-09 Thread Lubos Lunak
aving directory `/home/tinderbox/libreoffice/writerfilter' I don't understand what the actual problem is, because if I copy&paste the command and run it manually, it works without problems. I've also checked the arguments passed to cl.exe and they seem to be split prop

[Libreoffice-commits] .: svtools/source

2012-05-09 Thread Lubos Lunak
svtools/source/control/ctrltool.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit df45d9d1c037b27291c2173c4d0bfa6e3a42a73f Author: Luboš Luňák Date: Wed May 9 19:19:11 2012 +0200 work around -Wreturn-type with compilers that cannot figure it out themse

[Libreoffice-commits] .: reportdesign/source

2012-05-10 Thread Lubos Lunak
reportdesign/source/filter/xml/xmlExport.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d3ec5c6a8f3c623d500d447ba89863c69486b74c Author: Luboš Luňák Date: Thu May 10 10:21:27 2012 +0200 -Wself-assign Change-Id: I89e93fdd9e89d37230321d52efe6d2f

Re: [Libreoffice-commits] .: 2 commits - accessibility/CustomTarget_bridge_inc.mk configure.in extensions/CustomTarget_so_activex_idl.mk extensions/Library_so_activex.mk extensions/Library_so_activex_

2012-05-10 Thread Lubos Lunak
oblem leads to such a misleading error message :(. > On 2012-05-09 19:12, Lubos Lunak wrote: > > I don't understand what the actual problem is, because if I copy&paste > > the command and run it manually, it works without problems. I've also > > checked th

Re: [Libreoffice-commits] .: 2 commits - accessibility/CustomTarget_bridge_inc.mk configure.in extensions/CustomTarget_so_activex_idl.mk extensions/Library_so_activex.mk extensions/Library_so_activex_

2012-05-10 Thread Lubos Lunak
to find out what exactly the culprint is or how to possibly do anything more than document it. > On 2012-05-10 14:09, Lubos Lunak wrote: > > That seems to be it. Rather lame that this problem leads to such a > > misleading error message :(. -- Lu

Re: [Libreoffice-commits] .: 2 commits - accessibility/CustomTarget_bridge_inc.mk configure.in extensions/CustomTarget_so_activex_idl.mk extensions/Library_so_activex.mk extensions/Library_so_activex_

2012-05-10 Thread Lubos Lunak
it? It was quite recent cygwin even before, but the problem persists even with the most recent, 1.7.15. > On 2012-05-10 14:26, Lubos Lunak wrote: > > Windows Server 2008R2 Enterprise, Service Pack 1 Visual Studio 2008 > > I'm not sure how to find out what exactly the culprint

[Libreoffice-commits] .: vcl/unx

2012-05-10 Thread Lubos Lunak
vcl/unx/kde4/KDE4FilePicker.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 5df9e10d27a071f878ed160f99129a7f3c34f5ed Author: Luboš Luňák Date: Thu May 10 18:29:12 2012 +0200 do not prepend \n twice, it confuses KFileDialog (rhbz#820439) Draw -> Export -> fil

Re: [Libreoffice-commits] .: 2 commits - accessibility/CustomTarget_bridge_inc.mk configure.in extensions/CustomTarget_so_activex_idl.mk extensions/Library_so_activex.mk extensions/Library_so_activex_

2012-05-11 Thread Lubos Lunak
u be able to figure out what the point is where it starts to break? Changing the path to c:/cygwin/home/tinderbox/master avoids the problem, but I don't think we can really protect against this. Somebody alters some -I options a bit and the limit changes again. -- Lubos Lunak l.lu...@suse.cz _

Re: [Libreoffice-commits] .: 2 commits - accessibility/CustomTarget_bridge_inc.mk configure.in extensions/CustomTarget_so_activex_idl.mk extensions/Library_so_activex.mk extensions/Library_so_activex_

2012-05-11 Thread Lubos Lunak
On Friday 11 of May 2012, Noel Grandin wrote: > On 2012-05-11 17:46, Lubos Lunak wrote: > > Why are you so sure about any of these? Does somebody build with this > > long parth successfully? E.g. your tinderbox does not. > > My tinderbox does. I was the tester before thi

[Libreoffice-commits] .: sd/source

2012-05-11 Thread Lubos Lunak
sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx | 45 +++ 1 file changed, 31 insertions(+), 14 deletions(-) New commits: commit e4450c54aee85b295b933e91d207fd8220c01107 Author: Luboš Luňák Date: Fri May 11 20:33:23 2012 +0200 avoid recursion that can mess up DND

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - writerfilter/Library_rtftok.mk writerfilter/source

2012-05-14 Thread Lubos Lunak
writerfilter/Library_rtftok.mk |1 + writerfilter/source/rtftok/rtfdocumentimpl.cxx |7 +++ writerfilter/source/rtftok/rtfdocumentimpl.hxx |1 + 3 files changed, 9 insertions(+) New commits: commit f644f31c8edf3e39b23d8cc4d4b484cca8e99910 Author: Miklos Vajna Date

[PUSHED] Re: [REVIEW:3-5] fdo#49683 implement RTF_KEYWORDS

2012-05-14 Thread Lubos Lunak
On Monday 14 of May 2012, Miklos Vajna wrote: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=831b712 > > Regression from 3.4; backported patch attached. > > Thanks, > > Miklos -- Lubos Lunak l.lu...@suse.cz _

[REVIEW-3.5] Fix DND with Impress slidesorter (fdo#41996)

2012-05-14 Thread Lubos Lunak
See http://cgit.freedesktop.org/libreoffice/core/commit/?id=e4450c54aee Thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: cygwin problem in building in deep directories

2012-05-14 Thread Lubos Lunak
its argv[], everything looked ok to me. To me it looks like the limit is there either when converting args between cygwin and pure-MS apps (or whatever it is that happens at that point), or in MSVC. Still, not much we can do about it, I think. -- Lubos Lunak l.lu...@suse.cz _

Re: cygwin problem in building in deep directories

2012-05-14 Thread Lubos Lunak
On Monday 14 of May 2012, Noel Grandin wrote: > On 2012-05-14 15:33, Lubos Lunak wrote: > > It shouldn't be make, when I built a small testapp that just printed > > out its argv[], everything looked ok to me. To me it looks like the > > limit is there either when converti

[Libreoffice-commits] .: writerfilter/inc writerfilter/source

2012-05-15 Thread Lubos Lunak
writerfilter/inc/ooxml/OOXMLDocument.hxx |2 -- writerfilter/source/ooxml/OOXMLDocumentImpl.cxx | 10 -- writerfilter/source/ooxml/OOXMLDocumentImpl.hxx |3 --- writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |2 -- 4 files changed, 17 deletions

--enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-16 Thread Lubos Lunak
the feature of selective debug symbols. > and consequently a different mechanism is used to set the corresponding > flags: they are set into global gb_LinkTarget_C{,XX}FLAGS. > > So move the selective symbol feature back to

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-16 Thread Lubos Lunak
On Wednesday 16 of May 2012, Stephan Bergmann wrote: > On 05/16/2012 03:09 PM, Lubos Lunak wrote: > > Now --enable-debug=-sc/ means that sc/ is built without -g and with > > -O2. In other words, the compiler spends extra time working on code I > > don't care about at a

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-16 Thread Lubos Lunak
On Wednesday 16 of May 2012, Stephan Bergmann wrote: > On 05/16/2012 04:07 PM, Lubos Lunak wrote: > > Given that those differences you mention should be either irrelevant in > > practice or compiler bugs, even I, having rather fast build system, do > > not see -O2 worth

[Libreoffice-commits] .: Branch 'libreoffice-3-5-4' - oox/Library_oox.mk

2012-05-16 Thread Lubos Lunak
oox/Library_oox.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 3a91ffeefdd442b28e982053379e9be75d090013 Author: Fridrich Å trba Date: Wed May 16 11:37:35 2012 +0200 Build fix on Windows Change-Id: If65286d5cda6d1a9bfd31b4c89623b836007a39e Signed-off-by:

[PUSHED] Re: [REVIEW:3-5-4] Missing symbol when linking oox

2012-05-16 Thread Lubos Lunak
9e5dc940 for 3-5-4 branch. > > Looks OK to me. Sorry, I obviously did not build-test the patch on > Windows when I cherry-picked it. +1, pushed. I didn't fully follow the discussion on IRC, but I'd agree that the proper solution might be removing the 'extern', 'exter

[Libreoffice-commits] .: 3 commits - sw/qa vcl/unx writerfilter/source

2012-05-18 Thread Lubos Lunak
sw/qa/extras/ooxmltok/data/n751077.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx| 32 +++ vcl/unx/generic/plugadapt/salplug.cxx |2 writerfilter/source/ooxml/OOXMLFastContextHandler.cxx | 26 writerfilter/source

[Libreoffice-commits] .: sw/qa

2012-05-18 Thread Lubos Lunak
sw/qa/extras/README | 148 +++- 1 file changed, 123 insertions(+), 25 deletions(-) New commits: commit 2a598ba330b64b85d63ce53b7f0bcd20b6cafcd5 Author: Luboš Luňák Date: Fri May 18 15:38:41 2012 +0200 be more kind to people who have not

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-18 Thread Lubos Lunak
On Friday 18 of May 2012, Stephan Bergmann wrote: > On 05/16/2012 05:01 PM, Lubos Lunak wrote: > > - non-debug/dbgutils (i.e. also the default) -> -O2 > > - symbols -> -g (probably even -g1, if this is actually meant for > > release builds with debug info suffi

[Libreoffice-commits] .: 2 commits - sw/qa

2012-05-18 Thread Lubos Lunak
sw/qa/extras/README | 20 sw/qa/extras/ooxmltok/data/n705956-1.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx| 25 + 3 files changed, 45 insertions(+) New commits: commit 1472935fd74c289717cd7783d99bc99d82d7866d Auth

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-21 Thread Lubos Lunak
On Friday 18 of May 2012, Stephan Bergmann wrote: > On 05/18/2012 04:05 PM, Lubos Lunak wrote: > > On Friday 18 of May 2012, Stephan Bergmann wrote: > >> On 05/16/2012 05:01 PM, Lubos Lunak wrote: > >>> - non-debug/dbgutils (i.e. also the default) -> -O2 > &

[Libreoffice-commits] .: 2 commits - writerfilter/inc writerfilter/Library_writerfilter.mk writerfilter/source

2012-05-21 Thread Lubos Lunak
writerfilter/Library_writerfilter.mk |5 - writerfilter/inc/resourcemodel/SubSequence.hxx |2 +- writerfilter/source/dmapper/PropertyIds.cxx|2 +- writerfilter/source/dmapper/PropertyMap.hxx|2 +- writerfilter/source/doctok/Dff.

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-22 Thread Lubos Lunak
On Monday 21 of May 2012, Stephan Bergmann wrote: > On 05/21/2012 05:10 PM, Lubos Lunak wrote: > > On Friday 18 of May 2012, Stephan Bergmann wrote: > >> Ah, you wanted --enable-dbgutil to disable -O2, the same way that > >> --enable-debug does. Had missed that point.

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-22 Thread Lubos Lunak
On Friday 18 of May 2012, Michael Stahl wrote: > On 16/05/12 15:09, Lubos Lunak wrote: > > these switches are actually supposed to do. As far as I can > > tell, --enable-symbols enables -g, --enable-debug does --enable-symbols > > and turns on logging+assertions and disabl

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-22 Thread Lubos Lunak
On Tuesday 22 of May 2012, Stephan Bergmann wrote: > On 05/22/2012 03:19 PM, Lubos Lunak wrote: > > On Monday 21 of May 2012, Stephan Bergmann wrote: > >> On 05/21/2012 05:10 PM, Lubos Lunak wrote: > >>> On Friday 18 of May 2012, Stephan Bergmann wrote: > >&g

[Libreoffice-commits] .: 3 commits - oox/inc oox/source sw/qa writerfilter/inc writerfilter/source

2012-05-22 Thread Lubos Lunak
oox/inc/oox/vml/vmlshapecontainer.hxx |6 +-- oox/source/shape/ShapeContextHandler.cxx |5 --- oox/source/vml/vmlshapecontainer.cxx | 11 --- sw/qa/extras/ooxmltok/data/n705956-2.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cx

[Libreoffice-commits] .: sw/qa

2012-05-22 Thread Lubos Lunak
sw/qa/extras/ooxmltok/ooxmltok.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7e656661684669b6d34d3f813d53fad9d9ffd047 Author: Luboš Luňák Date: Tue May 22 22:32:28 2012 +0200 ++I_hate_sal_Int32 Change-Id: Id6943713ade8a77f3f72aabf2e746358

[Libreoffice-commits] .: 3 commits - sw/qa sw/source

2012-05-23 Thread Lubos Lunak
sw/qa/extras/ooxmltok/data/n747461.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx | 36 +++ sw/source/core/unocore/unoframe.cxx |4 ++- sw/source/filter/ww8/docxattributeoutput.cxx | 24 -- 4 files changed, 50 insertions(+),

Re: build time optimization

2012-05-24 Thread Lubos Lunak
-system-foo hassle Implementing your suggestion is possibly more work than any of these. [1] http://lists.freedesktop.org/archives/libreoffice/2012-April/030645.html [2] http://lists.freedesktop.org/archives/libreoffice/2012-April/030897.html -- Lubos Lunak l.lu...@suse.cz ___

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-24 Thread Lubos Lunak
On Tuesday 22 of May 2012, Stephan Bergmann wrote: > On 05/22/2012 04:02 PM, Lubos Lunak wrote: > > On Tuesday 22 of May 2012, Stephan Bergmann wrote: > >> On 05/22/2012 03:19 PM, Lubos Lunak wrote: > >>>But --enable-debug also enables asserts, logging and si

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-24 Thread Lubos Lunak
p; a concrete proposal for the ESC call on Thursday ? I don't see the point, at least now. The thread is going on (and it's far from endless), because there is something to talk about, and it's mostly about the smaller things which wouldn't be reasonably handled within few m

[Libreoffice-commits] .: 4 commits - sw/qa sw/source writerfilter/source

2012-05-24 Thread Lubos Lunak
sw/qa/extras/ooxmltok/data/n652364.docx |binary sw/qa/extras/ooxmltok/data/n750255.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx | 88 +++- sw/qa/extras/ww8tok/data/n652364.doc|binary sw/qa/extras/ww8tok/data/n750255.doc|binary sw/qa

Re: Question about filter/source/msfilter/msdffimp.cxx

2012-05-28 Thread Lubos Lunak
und statement (i.e. block), just like any other. The only difference is that this one is not attached to anything but it's standalone. Its purpose seems to be to limit the scope for the xObjStg variable. And yes, it should be a cppcheck bug. -- Lubos Lunak l.lu...@suse.cz __

[Libreoffice-commits] .: 4 commits - filter/inc filter/source oox/source sw/qa sw/source

2012-05-28 Thread Lubos Lunak
filter/inc/filter/msfilter/msdffimp.hxx |2 + filter/source/msfilter/msdffimp.cxx | 20 +-- oox/source/vml/vmlshape.cxx |6 ++--- oox/source/vml/vmlshapecontext.cxx |9 sw/qa/extras/ww8tok/data/n757118.doc|binary sw/qa/extras/ww8tok/

Re: [PATCH] [PUSHED] disable unit tests wich depend on xmlsec was: sc filter test failures

2012-05-29 Thread Lubos Lunak
perimental) option that leads to breakage is still broken even if it's documented. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Advice needed about some cppcheck reports

2012-05-29 Thread Lubos Lunak
} > > 271 nRetValue /= 65536; > > also makes sense This is not the same, it looks more to me like it should be 'nRetValue = -nRetValue;' to negate the value, especially given the abs() above. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: i18npool/source

2012-05-29 Thread Lubos Lunak
i18npool/source/isolang/mslangid.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 8979193090f085d5d171a6daa6f8fa4a188b3130 Author: Luboš Luňák Date: Tue May 29 16:24:14 2012 +0200 Revert "fdo#45830: Indicate correct default locale setting" T

[Libreoffice-commits] .: oox/source

2012-05-29 Thread Lubos Lunak
oox/source/shape/ShapeContextHandler.cxx | 26 -- oox/source/shape/ShapeContextHandler.hxx |2 -- 2 files changed, 28 deletions(-) New commits: commit 099198a4224778fe6e43f5dc13b5b9b1b4dc828c Author: Luboš Luňák Date: Tue May 29 17:49:17 2012 +0200 Revert

Re: feature/gbuild_merge needs testing

2012-05-30 Thread Lubos Lunak
On Wednesday 30 of May 2012, Noel Grandin wrote: > Hi > > I'm still having issues building on Windows with cygwin. Build error log > attached. The "invalid argument 'long -I list'" error is probably again the annoying command line argument length limitatio

Re: potentially dead code in "sw/source/core/undo/undel.cxx"?

2012-05-30 Thread Lubos Lunak
ached to anything, it is there just to limit the scope and lifetime of the aPos variable. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW-3.5] Various .doc/.docx fixes

2012-05-30 Thread Lubos Lunak
) - the attached 0001-fix-UNO-ZOrder.patch, which is commits http://cgit.freedesktop.org/libreoffice/core/commit/?id=e05e77f4b737 and http://cgit.freedesktop.org/libreoffice/core/commit/?id=9365a3255875 merged Thanks. -- Lubos Lunak l.lu...@suse.cz From 9b909c372cd1e214a723aaae42bc3a0597ca5f86

Re: [REVIEW-3.5] Various .doc/.docx fixes

2012-05-30 Thread Lubos Lunak
On Wednesday 30 of May 2012, Lubos Lunak wrote: > Hello, > > could somebody please review and pick for 3-5 the following changes from > master? They all have nice descriptive commit messages and testcases in > sw/qa/extras :) . > > - http://cgit.freedesktop.org/libreo

Re: 1.6Gb of workdir/.../Dep - thoughts ...

2012-06-04 Thread Lubos Lunak
50% or possibly even more) - a significant part of .d content is the depend-on-nothing deps created by -MP , if those would be merged into one dedicated .d file that'd save a lot of space as well; not sure if this is easily doable though -- Lubos Lunak l.lu...@suse.cz __

[Libreoffice-commits] .: config_host.mk.in solenv/gbuild

2012-06-04 Thread Lubos Lunak
config_host.mk.in |1 - solenv/gbuild/platform/WNT_INTEL_MSC.mk |3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit b6526cfa9070c5b9734c92ca20f16b16807b1031 Author: Luboš Luňák Date: Mon Jun 4 16:40:51 2012 +0200 do not export INCLU

Re: [PUSHED][REVIEW-3.5] Various .doc/.docx fixes

2012-06-04 Thread Lubos Lunak
On Thursday 31 of May 2012, Caolán McNamara wrote: > On Wed, 2012-05-30 at 18:38 +0200, Lubos Lunak wrote: > > > - http://cgit.freedesktop.org/libreoffice/core/commit/?id=04d600d4be7c > > > - http://cgit.freedesktop.org/libreoffice/core/commit/?id=5935a6db6483 > > >

[Libreoffice-commits] .: glib/makefile.mk

2012-06-05 Thread Lubos Lunak
glib/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4cf7551c24f5dad694fecbb2b80b2b52173ffdb7 Author: Luboš Luňák Date: Tue Jun 5 12:02:39 2012 +0200 correct path to dirent.h for win32 glib build diff --git a/glib/makefile.mk b/glib/makefile.mk

[Libreoffice-commits] .: solenv/gbuild

2012-07-04 Thread Lubos Lunak
solenv/gbuild/platform/WNT_INTEL_MSC.mk |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit c42a8d41afbd8c49b68046eeb8480e04d4f072c4 Author: Luboš Luňák Date: Wed Jul 4 18:22:36 2012 +0200 use -nologo with other MSVC build tools too Except for no

[Libreoffice-commits] .: connectivity/source

2012-07-04 Thread Lubos Lunak
connectivity/source/drivers/postgresql/pq_allocator.hxx |6 -- connectivity/source/drivers/postgresql/pq_common.hxx| 41 2 files changed, 2 insertions(+), 45 deletions(-) New commits: commit bd493f15a5d9478739368e48f598d2cd7ed4ea30 Author: Luboš Luňák Date: Wed Ju

Re: Bogus call to OUString::matchAsciiL in /framework/source/lomenubar/MenuItemStatusListener.cxx ?

2012-07-09 Thread Lubos Lunak
ant ? > > Yes, it is. No, not anymore. The AsciiL variants and RTL_CONSTASCII_(U)STRINGPARAM macros are obsolete, with string literals it is now possible to use the "normal" version of the function. IOW, oULabel.matchAsciiL ("private:", 8, 0) is now best written simply as oULabel.match("private:", 0) . -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Question about calling a method with a default parameter

2012-07-09 Thread Lubos Lunak
ot; which is not what it is. The first case is also not exactly intuitive, but at least the 0 there is a hint. IMO the proper fix would be to remove the default value (which we can't do until 4.0 because that'd break backwards compatibility) and introduce OUString::startsWith() (which

Re: [PATCH] Build problem.

2012-07-09 Thread Lubos Lunak
#include > #include > +#include > > #include "oox/helper/propertyset.hxx" > #include "oox/core/xmlfilterbase.hxx" > > Regards. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: issue with HelpLinker (Bus Error, core dumped)

2012-07-10 Thread Lubos Lunak
gt; #11 0x000801d44040 in ?? () > #12 0x7fff0005 in ?? () > #13 0x000f in ?? () > #14 0x in ?? () Try running it in valgrind in gdb manually. Other than that, you use a development snapshot of gcc, so this is not very likely a LibreOffice

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-11 Thread Lubos Lunak
st does it and reports > findings in the bug? I have no idea how Callgrind handles Java. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 3 commits - sw/qa writerfilter/source

2012-07-11 Thread Lubos Lunak
sw/qa/extras/ooxmltok/data/numbering1.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx | 58 +++ writerfilter/source/dmapper/DomainMapper.cxx | 29 +++-- 3 files changed, 74 insertions(+), 13 deletions(-) New commits: commit 794caa58a7208921ad8f911d

<    1   2   3   4   5   6   7   8   >