[Libreoffice-commits] core.git: vcl/inc vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win

2018-05-11 Thread Khaled Hosny
23c5125148a8110d88385b29570bf0b7d4400458 Author: Khaled Hosny Date: Thu May 10 15:46:06 2018 +0200 Use HarfBuzz to get Kashida width One less platform-specific piece of code. Change-Id: Ib04c5f1434046e26ead2aaedace67127a5513e55 Reviewed-on: https://gerrit.libreoffice.org/54098

[Libreoffice-commits] core.git: vcl/inc vcl/source

2018-05-12 Thread Khaled Hosny
vcl/inc/sallayout.hxx |2 -- vcl/source/gdi/CommonSalLayout.cxx |4 ++-- vcl/source/gdi/sallayout.cxx |5 - 3 files changed, 2 insertions(+), 9 deletions(-) New commits: commit 4680ce8790e1a3bd7da6800f4feb4e3a70aaa088 Author: Khaled Hosny Date: Thu May 10 13

[Libreoffice-commits] core.git: vcl/inc vcl/source

2018-05-12 Thread Khaled Hosny
vcl/inc/sallayout.hxx|2 -- vcl/source/gdi/sallayout.cxx |6 +++--- 2 files changed, 3 insertions(+), 5 deletions(-) New commits: commit 5af60152d623aaa6e9c71c0cda0c2a8407e78fc9 Author: Khaled Hosny Date: Sat May 12 02:21:28 2018 +0200 SalLayout::CalcAsianKerning() can be

[Libreoffice-commits] core.git: vcl/inc

2018-05-12 Thread Khaled Hosny
vcl/inc/sallayout.hxx | 40 1 file changed, 20 insertions(+), 20 deletions(-) New commits: commit 4ad07c563e50524f86c074ae50c5e82f504a3dcb Author: Khaled Hosny Date: Sat May 12 04:18:39 2018 +0200 Make SalLayout overrides final We

[Libreoffice-commits] core.git: vcl/Library_vclplug_gtk3_kde5.mk vcl/Library_vclplug_gtk3.mk vcl/Library_vclplug_gtk.mk

2018-05-12 Thread Khaled Hosny
vcl/Library_vclplug_gtk.mk |6 -- vcl/Library_vclplug_gtk3.mk |2 ++ vcl/Library_vclplug_gtk3_kde5.mk |2 ++ 3 files changed, 8 insertions(+), 2 deletions(-) New commits: commit ab03a09745fe52209747fb901eca91ef14cda5a5 Author: Khaled Hosny Date: Sat May 12 16:29:06

[Libreoffice-commits] core.git: vcl/win

2018-05-12 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx |1 + vcl/win/gdi/winlayout.cxx |3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit e8d48dd75a1bb31b5bc500bc79fb80384a09bcc6 Author: Khaled Hosny Date: Sat May 12 15:11:10 2018 +0200 Fixup 23c5125148a8110d88385b29570bf0b7d4400458

[Libreoffice-commits] core.git: vcl/README.GDIMetaFile

2014-12-03 Thread Khaled Hosny
vcl/README.GDIMetaFile | 416 - 1 file changed, 208 insertions(+), 208 deletions(-) New commits: commit 5de46c11e48407acdeb9dbee8f80d4f6d063a0d2 Author: Khaled Hosny Date: Wed Dec 3 19:42:26 2014 +0200 Don’t use DOS line endings

Re: spadmin, fax machines, etc. is this still useful ?

2014-03-14 Thread Khaled Hosny
On Fri, Mar 14, 2014 at 12:31:50PM +0100, Alex Thurgood wrote: > Le 14/03/2014 11:45, Caolán McNamara a écrit : > > Hi Caolan, > > Judging from the posts I have seen on the user list since LO came into > existence, there are still some use cases where CUPS does not provide > the required support

Re: spadmin, fax machines, etc. is this still useful ?

2014-03-14 Thread Khaled Hosny
On Fri, Mar 14, 2014 at 02:37:06PM +0100, Alex Thurgood wrote: > The last one, in particular (seocnd to last comment), provides a > workaround for creating AFM/PFM files on Linux, but note that this > didn't used to be a requirement, before the switch to CUPS printing was > made - previously, Type1

[Libreoffice-commits] core.git: psprint_config/configuration psprint_config/Makefile psprint_config/Module_psprint_config.mk psprint_config/Package_fontunxppds.mk psprint_config/Package_fontunxpsprint

2014-03-21 Thread Khaled Hosny
e3d9b3406a2013cd4f9d4baf3a7800d1d95c2d90 Author: Khaled Hosny Date: Fri Mar 21 15:27:33 2014 +0200 Fold psprint_config into vcl The files are only used by the psprint stuff in vcl, so move them closer to it. We should kill all of this anyway, but that is for another day. Change

[Libreoffice-commits] core.git: vcl/source

2014-03-22 Thread Khaled Hosny
vcl/source/gdi/outdev2.cxx | 27 ++--- vcl/source/gdi/print.cxx | 47 - 2 files changed, 20 insertions(+), 54 deletions(-) New commits: commit 4e642a3f6b07163a030720f2043b0dde1fdfd66d Author: Khaled Hosny Date: Sat Mar 22

[Libreoffice-commits] core.git: svtools/source

2014-08-12 Thread Khaled Hosny
svtools/source/misc/sampletext.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 56dc7aecc3194dac8012ebc252fb893125f64ebc Author: Khaled Hosny Date: Tue Aug 12 19:25:21 2014 +0300 Related: fdo#82259 not all STIX are symbol fonts The new "

[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - svtools/source

2014-08-12 Thread Khaled Hosny
svtools/source/misc/sampletext.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 4fbf715763122215ae8d8d961d73a5b7867dd6c6 Author: Khaled Hosny Date: Tue Aug 12 19:25:21 2014 +0300 Related: fdo#82259 not all STIX are symbol fonts The new "

Re: Hi-DPI patches for 4.2

2014-03-11 Thread Khaled Hosny
On Tue, Mar 11, 2014 at 10:33:13AM +0100, Stefan Knorr wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi all, > > On 10/03/14 22:51, Keith Curtis wrote: > > Doubling bitmaps is a "hack" but since bigger bitmaps don't exist, it > > is better than doing nothing. I haven't looked into

[Libreoffice-commits] core.git: 2 commits - vcl/generic

2014-02-04 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) New commits: commit 9140d2795494cf318e2e149a5cef03088746fd80 Author: Khaled Hosny Date: Tue Feb 4 10:19:46 2014 +0200 Minor Change-Id

libreoffice@lists.freedesktop.org

2016-09-22 Thread Khaled Hosny
On Thu, Sep 22, 2016 at 04:48:16AM -0700, Kamil Landa wrote: > In TOOLS – OPTIONS – LANGUAGE SETTINGS – COMPLEX TEXT LAYUOT, there is > „Cursor Control“ Movement: Logical/Visual. > Please create „Logical/Visual“ also for Delete and Backspace, not only for > cursor control. Delete and backspace h

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 318 commits - android/source basctl/source basic/source binaryurp/source bin/check-elf-dynamic-objects bridges/inc bridges/source can

2016-09-22 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit b9959413ec22a8682d8b7156cfbc05862e9a0c7a Author: Khaled Hosny Date: Sun Sep 11 10:25:46 2016 +0200 Override GetCharWidths and ApplyDXArray in CSL A much simpler and saner implementation. This also unbreaks Awami Nastaliq

libreoffice@lists.freedesktop.org

2016-09-22 Thread Khaled Hosny
On Thu, Sep 22, 2016 at 05:56:44PM +0300, Mike Kaganski wrote: > 22.09.2016 17:46, Khaled Hosny пишет: > > On Thu, Sep 22, 2016 at 04:48:16AM -0700, Kamil Landa wrote: > > > In TOOLS – OPTIONS – LANGUAGE SETTINGS – COMPLEX TEXT LAYUOT, there is > > > „Cursor Contro

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 3 commits - config_host.mk.in configure.ac RepositoryExternal.mk vcl/source

2016-09-22 Thread Khaled Hosny
229558d95e1b247e312c107802bb308cce549845 Author: Khaled Hosny Date: Thu Sep 22 19:48:10 2016 +0200 Always pass BCP 47 tags to HarfBuzz This is what it is expecting anyway, no need to special case it for Chinese. Change-Id: I6732412375d19816b599005d78abd796f67599ee diff

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/source

2016-09-22 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit fb26f7993400b43b67b82b726b3de715677158f0 Author: Khaled Hosny Date: Thu Sep 22 19:48:10 2016 +0200 Always pass BCP 47 tags to HarfBuzz This is what it is expecting anyway, no need to special case it for Chinese. Change

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - external/harfbuzz

2016-09-22 Thread Khaled Hosny
external/harfbuzz/ExternalProject_harfbuzz.mk |1 + 1 file changed, 1 insertion(+) New commits: commit ab1b2c97c1155adfe66985a8a9f7ac335f79dd1c Author: Khaled Hosny Date: Thu Sep 22 07:57:04 2016 -0700 Build HarfBuzz with Core Text on Mac To enable support for AAT fonts

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 5 commits - configure.ac external/harfbuzz RepositoryExternal.mk vcl/inc vcl/Library_vcl.mk vcl/source

2016-09-22 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit 7697ef88cba36f6397693126fc2091a72e7b9821 Author: Khaled Hosny Date: Thu Sep 22 14:09:29 2016 -0700 Add missing override Change-Id: I6a309715e30eef1c99c390e95c91f81cc9d75d04 diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 16 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quart

2016-09-22 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit eae33101ca93533a22ae7b972356e37ae02a42ec Author: Khaled Hosny Date: Thu Sep 22 14:04:50 2016 -0700 Fix building HarfBuzz with Graphite on Mac A very ugly hack as We don’t have pkg-config on Mac, so search for graphite2

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 17 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quart

2016-09-23 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit c9d6b93dd2565fe76383242475163ce56648f82d Author: Khaled Hosny Date: Fri Sep 23 11:09:24 2016 +0200 Extend pkg-config hack to any non-Linux Change-Id: Iff3fb06b4b047bf0c37e4b3d0e8e02f1d2626290 diff --git a/external/harfbuzz

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/source

2016-09-23 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 4ca60788fbea3614c40ae68356c03ee6a8053054 Author: Khaled Hosny Date: Fri Sep 23 13:59:47 2016 +0200 Fix MSVC build Change-Id

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 5 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/CppunitTest_vcl_wmf_test.mk vcl/inc vcl/Librar

2016-09-23 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit a201c28ab4222dc014e25ff968e40cc69cb55a67 Author: Khaled Hosny Date: Thu Sep 22 07:57:04 2016 -0700 Build HarfBuzz with Core Text on Mac To enable support for AAT fonts. Change-Id: Ifcc7d1672e98f8c067482400b7e45226bed4dbf1

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - external/harfbuzz

2016-09-23 Thread Khaled Hosny
external/harfbuzz/ExternalProject_harfbuzz.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 82f3c06beeded71828da559818db8ee12b5028cf Author: Khaled Hosny Date: Thu Sep 22 14:04:50 2016 -0700 Fix building HarfBuzz with Graphite on non-Linux A very ugly hack as We

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 50 commits - chart2/source compilerplugins/clang config_host.mk.in configure.ac cui/source external/harfbuzz i18npool/inc i18npool/so

2016-09-23 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit e49dcc12463d6e23e4799c18a1b6b59070fae9c6 Author: Khaled Hosny Date: Thu Sep 22 14:04:50 2016 -0700 Fix building HarfBuzz with Graphite on non-Linux A very ugly hack as We don’t have pkg-config on non Linux platforms, so

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - external/harfbuzz RepositoryExternal.mk

2016-09-23 Thread Khaled Hosny
RepositoryExternal.mk |6 ++ external/harfbuzz/ExternalProject_harfbuzz.mk |1 + 2 files changed, 7 insertions(+) New commits: commit 01f8478a154e0717e0fcac3d9cc9c648d02b492f Author: Khaled Hosny Date: Fri Sep 23 18:34:09 2016 +0200 Make sure HarfBuzz

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 62 commits - accessibility/inc basctl/inc basctl/source basegfx/source basic/source chart2/inc codemaker/source config_host.mk.in con

2016-09-23 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit d974e4f83af17918d946ef99e62926c640910bd3 Author: Khaled Hosny Date: Fri Sep 23 18:34:09 2016 +0200 Make sure HarfBuzz module depends on Graphite Change-Id: I9c1cc9c679ceebeb4e5cd898876aaa7b61c18f17 diff --git a

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/source

2016-09-24 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx|1 - vcl/source/gdi/CommonSalLayout.cxx | 13 + 2 files changed, 5 insertions(+), 9 deletions(-) New commits: commit bd15b93f933f65ac1a8b9f7a51bd99fa18dfe3ed Author: Khaled Hosny Date: Sat Sep 24 13:32:38 2016 +0200 No need to copy

libreoffice@lists.freedesktop.org

2016-09-24 Thread Khaled Hosny
On Fri, Sep 23, 2016 at 02:51:23AM -0700, Kamil Landa wrote: > I also rather simplify things :-), but it is really terrible, if i write > document in two languages, Czech (non-CTL) and Arabic and Delete&Backspace > are switched for these two keyboards. At mistake, my hand press Delete or > Backspa

libreoffice@lists.freedesktop.org

2016-09-24 Thread Khaled Hosny
On Sat, Sep 24, 2016 at 06:33:35AM -0700, Kamil Landa wrote: > Please bug tracker is http://bugs.documentfoundation.org? Yes. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 2 commits - vcl/inc vcl/source

2016-09-24 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit c956c33793b539f96371cc6c393c129e505f0c4a Author: Khaled Hosny Date: Sat Sep 24 23:13:47 2016 +0200 Use range loop Change-Id: I5ce49e57ed57378b4b9e16c8bb020048644252a9 diff --git a/vcl/source/gdi/CommonSalLayout.cxx b/vcl/source

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/source

2016-09-26 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx | 41 ++--- 1 file changed, 34 insertions(+), 7 deletions(-) New commits: commit 279407d78c43da63ee88639f00482b1ea703f363 Author: Khaled Hosny Date: Mon Sep 26 19:09:52 2016 +0200 First try on vertical text in

[Libreoffice-commits] core.git: configure.ac download.lst external/harfbuzz

2016-09-30 Thread Khaled Hosny
- 5 files changed, 7 insertions(+), 20 deletions(-) New commits: commit 281bd0b08a1c678209befd2355c29d823a2e85d3 Author: Khaled Hosny Date: Wed Sep 28 08:52:45 2016 +0200 Update HarfBuzz to 1.3.2 * Only build the library, makes no-freetype patch redundant. * Don’t build

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 275 commits - basic/source bin/module-deps.pl bin/removetooltip_markups.sh chart2/uiconfig cli_ure/source comphelper/source compilerp

2016-09-30 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit 54abfb98f3fa8a8801707b15aebd82cfa5c570bc Author: Khaled Hosny Date: Mon Sep 26 19:09:52 2016 +0200 First try on vertical text in CommonSalLayout Does not work quite right yet. Change-Id

Re: [libreoffice-design] pdf import design docs?

2016-10-07 Thread Khaled Hosny
On Fri, Oct 07, 2016 at 01:00:05PM +0200, Michael Stahl wrote: > On 05.10.2016 23:50, Larry Evans wrote: > > On 10/05/2016 03:07 PM, Michael Stahl wrote: > >> On 05.10.2016 17:24, Michael Meeks wrote: > >> > >> actually the separate process is a potential security advantage, if we > >> would only r

Re: [libreoffice-design] pdf import design docs?

2016-10-07 Thread Khaled Hosny
On Fri, Oct 07, 2016 at 02:08:31PM +0200, Michael Stahl wrote: > On 07.10.2016 13:54, Khaled Hosny wrote: > > On Fri, Oct 07, 2016 at 01:00:05PM +0200, Michael Stahl wrote: > >> On 05.10.2016 23:50, Larry Evans wrote: > >>> On 10/05/2016 03:07 PM, Michael Stahl wro

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/source

2016-10-08 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) New commits: commit 8b32ead0b988b142cd9878f126d985d946fd4ccc Author: Khaled Hosny Date: Thu Oct 6 04:15:41 2016 +0200 Use HarfBuzz shape plan for a bit more control This way we

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/source

2016-10-09 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) New commits: commit 115121d5751d5ee489422e41a361a7da30a092b4 Author: Khaled Hosny Date: Sun Oct 9 19:08:18 2016 +0200 Revert "Use HarfBuzz shape plan for a bit more co

Re: Help with an old regression in text rendering needed

2016-07-29 Thread Khaled Hosny
On Wed, Jul 20, 2016 at 08:55:01AM +0200, Milos Sramek wrote: > > The problem is demonstrated by the attached files, which show pixel > overlays of documents rendered in LO a MSOffice. There are some > differences visible also in the 'good' file, but these are much bigger > in the 'bad' one where

[Libreoffice-commits] core.git: editeng/source

2016-01-22 Thread Khaled Hosny
editeng/source/items/numitem.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 65698ffa0e9274812df7fc997f9c3db7bb760ae2 Author: Khaled Hosny Date: Fri Jan 22 13:32:14 2016 +0400 Typo Change-Id: Ib4c474cab050cdef003dc5e611e8a9bc1fb46e86 diff

Questions about the font shaping tender

2016-02-01 Thread Khaled Hosny
I just came across this tender [1] and it is not quite clear to me what is it about. Am I right in thinking this is about having a shared cross-platform implementation of VCL text layout API (the dreaded SalLayout et all)? If so I don’t understand what AFM stuff is doing here since we don’t use any

Re: Questions about the font shaping tender

2016-02-02 Thread Khaled Hosny
On Tue, Feb 02, 2016 at 10:15:07AM +0100, Miklos Vajna wrote: > Hi, > > I think the problem to solve is that we have different layout on Linux, > Windows and OS X, which means it's next to impossible to write unit > tests that assert the text is laid out correctly, since there can be > small diffe

Re: Questions about the font shaping tender

2016-02-04 Thread Khaled Hosny
bly certain you have some good ideas around > how to fix the SalLayout mess... certainly you have the technical > expertise and experience to tackle this. > > Just a suggestion :-) > > Chris > > > On 1 Feb 2016, at 9:35 PM, Khaled Hosny wrote: > > > > I

Re: Feature branch request

2016-06-10 Thread Khaled Hosny
On Fri, Jun 03, 2016 at 07:20:45PM +0530, Akash Jain wrote: > Therefore I request a feature branch with commit access so I can push > code faster then the current work flow will allow. Can you we get a Akash commit access to push his work on a branch, he has sent several patches to gerrit already

Re: Feature branch request

2016-06-10 Thread Khaled Hosny
On Fri, Jun 10, 2016 at 03:27:00PM +0200, jan iversen wrote: > > > > On 10 Jun 2016, at 14:39, Khaled Hosny wrote: > > > >> On Fri, Jun 03, 2016 at 07:20:45PM +0530, Akash Jain wrote: > >> Therefore I request a feature branch with commit access so I can pu

Renaming sal_Unicode to a less misleading name?

2016-02-13 Thread Khaled Hosny
I’m wondering if it is possible to rename sal_Unicode, which is actually a unsigned 16 bit integer and thus can’t fit any Unicode character, to some less confusing name like sal_Ucs2 or even just use sal_uInt16 (but please not sal_Utf16 which would give the illusion that surrogate pairs and handled

Re: Renaming sal_Unicode to a less misleading name?

2016-02-15 Thread Khaled Hosny
On Mon, Feb 15, 2016 at 05:57:25PM +0100, Stephan Bergmann wrote: > >yeah, I mentioned the le/be variant to be 'complete', I will certainly > >concede that it would likely be overkill. > >still having sal_utf16. sal_utf32 and even sal_utf8 would not hurt, > >especailly comapred to sal_Int32, sal_Un

Re: Problem Building Libreoffice on Linux

2016-02-18 Thread Khaled Hosny
On Thu, Feb 18, 2016 at 10:39:40AM +0100, Stephan Bergmann wrote: > On 02/17/2016 05:47 PM, Pranav Ganorkar wrote: > >Program received signal SIGSEGV, Segmentation fault. > >0x2aaab93213d3 in ?? () from /usr/lib/libharfbuzz.so.0 > >(gdb) bt > >#0 0x2aaab93213d3 in ?? () from /usr/lib/libha

Re: Problem Building Libreoffice on Linux

2016-02-18 Thread Khaled Hosny
I want to ask if there is some switch for temporarily disabling these unit > tests. > > I am building it on a 64-bit Archlinux machine. > > Regards, > Pranav > > On Thu, Feb 18, 2016 at 3:24 PM, Khaled Hosny wrote: > > > On Thu, Feb 18, 2016 at 10:39:40AM +0100, S

Re: Problem Building Libreoffice on Linux

2016-02-19 Thread Khaled Hosny
On Thu, Feb 18, 2016 at 02:36:48PM +0100, Michael Stahl wrote: > On 18.02.2016 14:17, Khaled Hosny wrote: > > I don’t think it is just the unit test that is failing, running the > > application will most likely crash as well. Building with system > > HarfBuzz should fix the

Re: Brackets are not handled correctly with mixed English/Latin and Hebrew/Arabic texts

2016-02-22 Thread Khaled Hosny
The patch does not really fix the issue, it makes it even worse. I think she is just asking for pointers to further work on the issue, so submitting a patch to gerrit might not be the best course of action. Regards, Khaled On Mon, Feb 22, 2016 at 10:21:27AM +0100, jan iversen wrote: > Hi > > Tha

Re: is anybody able to build libreoffice on archlinux

2016-02-24 Thread Khaled Hosny
On Wed, Feb 24, 2016 at 07:22:27PM +0530, Pranav Ganorkar wrote: > Hi, > > I want to ask if anybody has been successful in building Libreoffice > recently on Archlinux. Do we need to use the switches given in PKGBUILD >

Re: is anybody able to build libreoffice on archlinux

2016-02-25 Thread Khaled Hosny
On Wed, Feb 24, 2016 at 10:34:40PM +0100, Łukasz Hryniuk wrote: > Do you have the newest version of packages? Perhaps Pranav and I have > a "special" package, which covers some default library. E.g. I wasn't > able to build LibreOffice with Python from Anaconda. I’ve an up to date system, no speci

Re: Windows / font / text futures ...

2016-03-07 Thread Khaled Hosny
On Fri, Mar 04, 2016 at 12:04:38PM +, Caolán McNamara wrote: > On Thu, 2016-03-03 at 13:44 +, Michael Meeks wrote: > > Hi guys, > > > Anyhow - what to do ? > >  > > While we could switch to DirectWrite on windows, which may > > solve some > > of our problems; this will be in itself

Re: Windows / font / text futures ...

2016-03-07 Thread Khaled Hosny
On Mon, Mar 07, 2016 at 02:04:41PM +, Michael Meeks wrote: > Hi Thorsten, > > I missed your mail; please do maintain the CC if you want a prompt > reply =) > > On Fri, 2016-03-04 at 00:43 +0100, Thorsten Behrens wrote: > > > Having looked at this heap; and worse - the two different he

Re: Windows / font / text futures ...

2016-03-07 Thread Khaled Hosny
On Tue, Mar 08, 2016 at 10:18:47AM +1100, Chris Sherlock wrote: > On 8 Mar 2016, at 5:38 AM, Khaled Hosny wrote: > > > > On Mon, Mar 07, 2016 at 02:04:41PM +, Michael Meeks wrote: > >> Hi Thorsten, > >> > >>I missed your mail; please do maint

Re: testing commonsallayout branch

2016-10-24 Thread Khaled Hosny
t settings to use? > > best > Milos > > On 2016-10-24 00:30, Khaled Hosny wrote: > > Hi, > > > > Things I’d like to test at this point: > > * master with and without the new layout code activated on the three > > platforms. To see if we have any regr

[Libreoffice-commits] core.git: vcl/quartz vcl/unx vcl/win

2016-10-25 Thread Khaled Hosny
: Khaled Hosny Date: Tue Oct 25 02:25:08 2016 +0200 Skip font formats not supported by CommonSalLayout Don’t list fonts we can’t handle, bad things would happen… Change-Id: Ic88486e34da69090deb3e8c394cb75a8e4e5cbd0 diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz

[Libreoffice-commits] core.git: vcl/win

2016-10-28 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 116 1 file changed, 50 insertions(+), 66 deletions(-) New commits: commit 8f0f5e0c709d01555a4069f8665889924ed181c7 Author: Khaled Hosny Date: Thu Oct 27 22:58:37 2016 +0200 tdf#103514: Always ignore bitmap fonts

Re: localization of ui

2016-10-28 Thread Khaled Hosny
On Fri, Oct 28, 2016 at 01:24:42PM +0200, Eike Rathke wrote: > > My recent goal is showing traditional mongolian horizontally left to > > right (in UI) just like english is OK, so I think vcl should already > > OK to handle this .? > > I don't know what happens if you use characters of a right-to-

[Libreoffice-commits] core.git: vcl/inc vcl/win

2016-10-28 Thread Khaled Hosny
3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a Author: Khaled Hosny Date: Fri Oct 28 04:19:46 2016 +0200 tdf#98879: Fix vertical text on Windows for the new layout The DirectWrite rendering code wasn’t handling vertical text correctly at least when used with CommonSalLayout. It has been fixed and now made

[Libreoffice-commits] core.git: cui/source sw/uiconfig

2016-10-29 Thread Khaled Hosny
cui/source/tabpages/page.cxx |2 +- sw/uiconfig/swriter/ui/frmaddpage.ui |4 2 files changed, 5 insertions(+), 1 deletion(-) New commits: commit 930a3d462b05e111da37d31de7f60998ce9454b3 Author: Khaled Hosny Date: Fri Oct 28 18:48:25 2016 +0200 tdf#33278: Enable UI

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-10-29 Thread Khaled Hosny
vcl/inc/svids.hrc|3 +++ vcl/source/app/svapp.cxx |8 vcl/source/src/app.src | 15 +++ 3 files changed, 26 insertions(+) New commits: commit f351b3624de79b5806a066202a3a0d6fa59c8469 Author: Khaled Hosny Date: Sat Oct 29 16:23:45 2016 +0200 Add

Re: MSVC 2015 Error C2397: conversion from 'double' to 'FLOAT' requires a narrowing conversion

2016-10-29 Thread Khaled Hosny
On Sat, Oct 29, 2016 at 09:08:29PM +, Luke Benes wrote: > I'm now getting the following error when I build with MSVC 2015: > > [build CXX] vcl/win/gdi/winlayout.cxx > C:/core/vcl/win/gdi/winlayout.cxx(3533): error C2397: conversion from > 'double' to 'FLOAT' requires a narrowing conversion >

[Libreoffice-commits] core.git: vcl/source

2016-10-29 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 7b4d921d8e4164a962cd10a2efc9c62ecf64ff17 Author: Khaled Hosny Date: Sun Oct 30 00:36:07 2016 +0200 tdf#103401: Fix applying DX array with font fallback Turns out

[Libreoffice-commits] core.git: config_host/config_graphite.h.in vcl/inc vcl/win

2016-10-29 Thread Khaled Hosny
config_host/config_graphite.h.in |2 -- vcl/inc/win/winlayout.hxx| 10 ++ vcl/win/gdi/winlayout.cxx| 11 --- 3 files changed, 2 insertions(+), 21 deletions(-) New commits: commit be1750d866dab7712ede4cbbba771b088d862d05 Author: Khaled Hosny Date: Sun

[Libreoffice-commits] core.git: compilerplugins/clang vcl/headless vcl/inc vcl/source vcl/unx

2016-10-30 Thread Khaled Hosny
0fd8ef082d6594cdc3ea8445f8f13e725b39cf89 Author: Khaled Hosny Date: Sun Oct 30 02:52:48 2016 +0100 Rename ServerFont to FreetypeFont This is what it is actually is, we dropped support for server-side fonts for a long time now. Renamed also a few related classes, but left ServerFontLayout* ones as

Re: localization of ui

2016-10-30 Thread Khaled Hosny
On Sun, Oct 30, 2016 at 09:54:03PM +0800, baigali wrote: > >AFAIK, traditional Mongolian has no history of being written > >horizontally, it is one of the vertical-only scripts. But if it must be > >written horizontally, then it seems the current practice is to write it > >from left to right. Mongo

[Libreoffice-commits] core.git: vcl/source

2016-10-30 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 3c80eea38add1b551261f86cc0f942c5f638d48c Author: Khaled Hosny Date: Sun Oct 30 17:59:23 2016 +0200 Avoid potential HarfBuzz asserts We need to update the buffer content type ourselves

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/source

2016-10-30 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx|2 ++ vcl/source/gdi/CommonSalLayout.cxx | 36 +--- 2 files changed, 19 insertions(+), 19 deletions(-) New commits: commit f65c8b7b48a94574d18cf554b45658f81cee Author: Khaled Hosny Date: Sun Oct 30 18:50:01 2016

[Libreoffice-commits] core.git: vcl/inc

2016-10-30 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 4814650c5021b72c81b4079f712a4c1baae0088b Author: Khaled Hosny Date: Sun Oct 30 18:59:32 2016 +0200 Minor Change-Id: I2bce822dd9f4c6b59a93e158ceced541ae52a01b diff --git

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-10-30 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx|8 ++-- vcl/source/gdi/CommonSalLayout.cxx |5 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) New commits: commit 641b9cb1d0934b3f8b4a80279cb3f3f81ecc4707 Author: Khaled Hosny Date: Sun Oct 30 22:09:10 2016 +0200 tdf#103588: Draw

Re: localization of ui

2016-10-30 Thread Khaled Hosny
On Mon, Oct 31, 2016 at 08:53:34AM +0800, baigali wrote: > Thank you, firstly. > > > >I’m curious how vertical UI would look like, do you have any examples of > >such UIs? VCL is the place to start, but I fear this might be a big > >undertaking. > > > There is no Libreoffice vertical UI offici

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/win

2016-10-30 Thread Khaled Hosny
vcl/inc/win/winlayout.hxx |2 +- vcl/win/gdi/winlayout.cxx | 16 2 files changed, 9 insertions(+), 9 deletions(-) New commits: commit 4b4abb73fcd7f2802e73102b3e7c30face8d309c Author: Khaled Hosny Date: Mon Oct 31 04:46:34 2016 +0200 Avoid excessive text clipping on

[Libreoffice-commits] core.git: external/harfbuzz

2016-10-30 Thread Khaled Hosny
external/harfbuzz/0001-graphite-Fix-shaping-with-varying-font-size.patch | 130 ++ external/harfbuzz/UnpackedTarball_harfbuzz.mk| 1 2 files changed, 131 insertions(+) New commits: commit 3d83c42008ab51202c0577f493e8ed3fde0310b7 Author: Khaled Hosny

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/win

2016-10-31 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 110 +--- 1 file changed, 49 insertions(+), 61 deletions(-) New commits: commit e80621fb04093d5ab950485357f6058dcbaf8aaf Author: Khaled Hosny Date: Thu Oct 27 22:58:37 2016 +0200 tdf#103514: Always ignore bitmap fonts

[Libreoffice-commits] core.git: vcl/README.vars vcl/source

2016-10-31 Thread Khaled Hosny
vcl/README.vars |2 +- vcl/source/gdi/sallayout.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit d79f43d0bebbe7b1f8d68d50734737aea9fe839d Author: Khaled Hosny Date: Mon Oct 31 16:53:50 2016 +0200 Enable the new text layout engine by

[Libreoffice-commits] core.git: 2 commits - external/harfbuzz vcl/inc vcl/source

2016-10-31 Thread Khaled Hosny
| 67 ++--- 4 files changed, 33 insertions(+), 167 deletions(-) New commits: commit e31f7f4c87d5501599daa8d11d08b6e4a8725356 Author: Khaled Hosny Date: Tue Nov 1 02:15:23 2016 +0200 tdf#103403: Wrong glyph advances with Graphite Always create

[Libreoffice-commits] core.git: vcl/README.vars vcl/source

2016-10-31 Thread Khaled Hosny
vcl/README.vars |2 +- vcl/source/gdi/sallayout.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 3950166877bf1308f9e449992e20b558342af825 Author: Khaled Hosny Date: Tue Nov 1 02:25:10 2016 +0200 Revert "Enable the new text layout e

CppunitTest_svgio fails on macOS with the new layout engine

2016-11-01 Thread Khaled Hosny
I’m having strange CppunitTest_svgio failure on macOS with the new layout engine. With the old layout engine the test passes just fine, but with the new engine: $ env SAL_USE_COMMON_LAYOUT=1 make CppunitTest_svgio make -j 2 -rs -f /Users/khaled/lode/dev/core/Makefile.gbuild CppunitTest_svgio [CUT]

[Libreoffice-commits] core.git: vcl/win

2016-11-01 Thread Khaled Hosny
vcl/win/gdi/winlayout.cxx | 16 1 file changed, 8 insertions(+), 8 deletions(-) New commits: commit 8d192b66e36576af4033d34ea895602a0c7a41ae Author: Khaled Hosny Date: Tue Nov 1 23:34:29 2016 +0200 Misplaced #if ENABLE_GRAPHITE Change-Id

[Libreoffice-commits] core.git: 2 commits - vcl/win

2016-11-01 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 181 +++- 1 file changed, 15 insertions(+), 166 deletions(-) New commits: commit 03bff1b6b953e4b7a54d2fb7bbf366bea7e959d9 Author: Khaled Hosny Date: Tue Nov 1 23:15:44 2016 +0200 tdf#71603: Improve font fallback on

[Libreoffice-commits] core.git: vcl/win

2016-11-01 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) New commits: commit 5d39c2013374727b1c8f147b8b99d54402a7ff02 Author: Khaled Hosny Date: Wed Nov 2 01:37:21 2016 +0200 tdf#71603: Create a new DC for the font fallback For some

[Libreoffice-commits] core.git: vcl/source

2016-11-02 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 1260bf28fc82616acfc3d0308eb2056ff6572cf2 Author: Khaled Hosny Date: Wed Nov 2 15:12:59 2016 +0200 Add a comment here Change-Id: I07f2fe400f20d8f52588db326851f310245b7d8d diff

Re: CppunitTest_svgio fails on macOS with the new layout engine

2016-11-02 Thread Khaled Hosny
On Tue, Nov 01, 2016 at 10:14:49PM +0100, Tomaž Vajngerl wrote: > Hi, > > On Tue, Nov 1, 2016 at 8:33 PM, Khaled Hosny wrote: > > I tried to find what is the source of difference, but to no avail. I > > can’t figure out why the choice of the layout engine can make a > &

[Libreoffice-commits] core.git: vcl/quartz

2016-11-02 Thread Khaled Hosny
vcl/quartz/ctfonts.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 8cef9b4dbafdebc0566d6d7f715f27f978ddfe5b Author: Khaled Hosny Date: Wed Nov 2 23:38:13 2016 +0200 Fix GetGlyphBoundRect() on macOS The Y sign should be reversed to match VCL

[Libreoffice-commits] core.git: vcl/README.vars vcl/source

2016-11-02 Thread Khaled Hosny
vcl/README.vars |2 +- vcl/source/gdi/sallayout.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533 Author: Khaled Hosny Date: Wed Nov 2 23:52:06 2016 +0200 Revert "Revert "Enable th

Re: CppunitTest_svgio fails on macOS with the new layout engine

2016-11-02 Thread Khaled Hosny
On Wed, Nov 02, 2016 at 06:34:32PM +0200, Khaled Hosny wrote: > On Tue, Nov 01, 2016 at 10:14:49PM +0100, Tomaž Vajngerl wrote: > > Hi, > > > > On Tue, Nov 1, 2016 at 8:33 PM, Khaled Hosny wrote: > > > I tried to find what is the source of difference, but to no a

Re: Merging feature/commonsallayout branch

2016-11-02 Thread Khaled Hosny
On Mon, Oct 17, 2016 at 09:30:14PM +0200, Khaled Hosny wrote: > Currently the new layout is off by default and can be enabled at runtime > by setting SAL_USE_COMMON_LAYOUT env variable. After merging with > master, I’m going to wait a week or so for any potential build issues > t

[Libreoffice-commits] core.git: officecfg/registry vcl/source

2016-11-03 Thread Khaled Hosny
officecfg/registry/schema/org/openoffice/Office/Common.xcs |7 +++ vcl/source/gdi/sallayout.cxx |5 - 2 files changed, 11 insertions(+), 1 deletion(-) New commits: commit 6324efd70dfa8c6be84cba1fa29658e3373cbbe3 Author: Khaled Hosny Date: Thu Nov

[Libreoffice-commits] core.git: vcl/inc

2016-11-03 Thread Khaled Hosny
vcl/inc/win/winlayout.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit a6ce5d391476e4b6a2cb2d92ff45548c1d75684b Author: Khaled Hosny Date: Fri Nov 4 01:26:50 2016 +0200 Misplaced #endif Change-Id: I199cf879c13cdd65ec9b6f1dbfef9b615bf8cefc

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/unx vcl/win

2016-11-03 Thread Khaled Hosny
/win/gdi/winlayout.cxx |2 +- 10 files changed, 32 insertions(+), 58 deletions(-) New commits: commit fb823544468150a2ef660095a511636be1bf6f9e Author: Khaled Hosny Date: Fri Nov 4 05:06:54 2016 +0200 Font features are not a Graphite-only feature We parse

Re: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine

2016-11-04 Thread Khaled Hosny
On Fri, Nov 04, 2016 at 11:12:59AM +0100, Stephan Bergmann wrote: > On 11/03/2016 06:23 PM, Khaled Hosny wrote: > > commit 6324efd70dfa8c6be84cba1fa29658e3373cbbe3 > > Author: Khaled Hosny > > Date: Thu Nov 3 19:21:01 2016 +0200 > > > > tdf#89870: Ad

Re: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine

2016-11-04 Thread Khaled Hosny
On Fri, Nov 04, 2016 at 02:51:26PM +0100, Stephan Bergmann wrote: > On 11/04/2016 01:11 PM, Khaled Hosny wrote: > > On Fri, Nov 04, 2016 at 11:12:59AM +0100, Stephan Bergmann wrote: > > > * How long will we keep supporting the old code? "Forever", or do we > >

Re: Cleaning up configuration (was: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine)

2016-11-04 Thread Khaled Hosny
On Fri, Nov 04, 2016 at 12:12:21PM +0100, Stephan Bergmann wrote: > On 11/04/2016 11:20 AM, Tor Lillqvist wrote: > > Also, would going through officecfg and looking for deprecated and > > actually no-op configuration thingies be a good Easy Hack? > > At least in principle, the tree of available co

[Libreoffice-commits] core.git: vcl/source

2016-11-04 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) New commits: commit 4e59168ef004e7520ea7d78237a18208216a757c Author: Khaled Hosny Date: Fri Nov 4 23:39:38 2016 +0200 tdf#103710: rotate all glyphs in vertical runs So that we

[Libreoffice-commits] core.git: vcl/source

2016-11-04 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 5b389c32eb3928c59387c2d6d48667632d7e9206 Author: Khaled Hosny Date: Fri Nov 4 23:46:22 2016 +0200 tdf#100936: Add Tangut to vertical scripts Change-Id

<    1   2   3   4   5   6   7   8   9   10   >