Re: Trouble with unittests testDmlTextshape and testDmlTextshapeB

2021-05-19 Thread Miklos Vajna
Hi Regina, On Tue, May 18, 2021 at 08:10:36PM +0200, Regina Henschel wrote: > after having looked over the problems again, I think that it is not enough > to improve the import. The export must be fixed at the same time, otherwise > the user gets a heavily modified document after saving and relo

Re: Trouble with unittests testDmlTextshape and testDmlTextshapeB

2021-05-18 Thread Regina Henschel
Hi Miklos, hi all, after having looked over the problems again, I think that it is not enough to improve the import. The export must be fixed at the same time, otherwise the user gets a heavily modified document after saving and reloading. Until now, saving and reloading deliver a mostly uncha

Re: Trouble with unittests testDmlTextshape and testDmlTextshapeB

2021-05-17 Thread Miklos Vajna
Hi Regina, On Sun, May 16, 2021 at 08:03:18PM +0200, Regina Henschel wrote: > May I remove the positioning parts from these unittests? If the test fails and your manual testing confirms that this is a poor test and not badness caught by the test, then it sounds reasonable to adjust the test. I

Trouble with unittests testDmlTextshape and testDmlTextshapeB

2021-05-16 Thread Regina Henschel
Hi all, I'm currently working on improving the import of group shapes in docx, see https://gerrit.libreoffice.org/c/core/+/115668 In that the unittests testDmlTextshape and testDmlTextshapeB in sw/qa/extras/ooxmlexport/ooxmlexport6.cxx fail. But I think, the problem is not my patch but an expo