Re: avoiding cppunit zerodiv correction

2014-05-30 Thread julien2412
Matteo Casalin-3 wrote > ... > I don't have any comment about your proposal, but just would like to > add that unless we know for sure that nHeight!=0 at that point, in > both codes the check should be > > if( nHeight <= 0 ) > > in order to solve the division by 0 completely. You're right of cou

Re: avoiding cppunit zerodiv correction

2014-05-30 Thread Lionel Elie Mamane
On Fri, May 30, 2014 at 10:01:49AM +0200, Matteo Casalin wrote: >> I wonder if we should not rather do something like: >> double dRatioPreV; >> if( nHeight < 0 ) >> { >> nHeight = 0; >> dRatioPreV = 1; // or rather zero? or +infinity? Do we want to >> // "force" a branch of

Re: avoiding cppunit zerodiv correction

2014-05-30 Thread Matteo Casalin
Hi, On Fri, 30 May 2014 07:17:57 +0200 Lionel Elie Mamane wrote: [...] > > I wonder if we should not rather do something like: > > double dRatioPreV; > if( nHeight < 0 ) > { > nHeight = 0; > dRatioPreV = 1; // or rather zero? or +infinity? Do we want to > // "force" a br