anshu khare kirjoitti 10.11.2020 klo 16.27:
Hi
Please review my patch
https://gerrit.libreoffice.org/c/core/+/105501
I have tested it. It's working fine.
Please merge it.
You did not address Jim's comment:
"Please see
https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf#19
Yes, no problem.
Thanks :)
On Mon, Oct 15, 2012 at 4:06 PM, Jan Holesovsky wrote:
> Hi Ricardo,
>
> Ricardo Montania (via Code Review) píše v Út 09. 10. 2012 v 20:31 +:
>
> > https://gerrit.libreoffice.org/851
>
> Thank you a lot for the patch! :-) Having seen it pushed, I've done a
>
Hi Ricardo,
Ricardo Montania (via Code Review) píše v Út 09. 10. 2012 v 20:31 +:
> https://gerrit.libreoffice.org/851
Thank you a lot for the patch! :-) Having seen it pushed, I've done a
small follow-up tweak:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ad86ef1caaa029b8c9
Hi Ivan,
Ivan Timofeev píše v Út 02. 10. 2012 v 21:00 +0400:
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9097843e6b2935dcab9f038b80e5a51bc5cfc94
>
> oh, right, I forgot about that, thanks! You have my sign-off.
[...]
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=509d
Hi Kendy,
On 02.10.2012 18:03, Jan Holesovsky wrote:
> Marking it pushed; and want to ask you to cherry-pick the following
> addition to the libreoffice-3-6 branch :-)
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9097843e6b2935dcab9f038b80e5a51bc5cfc94
oh, right, I forgot about t
Hi Ivan,
Marking it pushed; and want to ask you to cherry-pick the following
addition to the libreoffice-3-6 branch :-)
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9097843e6b2935dcab9f038b80e5a51bc5cfc94
Thank you,
Kendy
Jan Holesovsky píše v Út 02. 10. 2012 v 15:46 +0200:
> Hi Iva
Hi Ivan,
Ivan Timofeev píše v So 29. 09. 2012 v 21:52 +0400:
> this patch fixes bug 52268:
> https://bugs.freedesktop.org/show_bug.cgi?id=52268
> "Splash Screen: Messages on first start displayed in wrong colour in
> the wrong place"
Thanks f or that! :-) Pushed that both to master and libreoff
Hi Kendy, Michael,
sure, go ahead. You've disproved the only somewhat weighty argument I
had (the password requirement – sorry for not researching that before).
What remains is a purely philosophical argument (the desktop is the
user's space) which everyone has different opinions about.
So, I gues
On Thu, 2012-08-16 at 18:52 +0200, Jan Holesovsky wrote:
> Attached is a patch that I know you are not too happy about ;-) - change
> the default of creating the desktop icon on Windows back to 'yes'.
Patch itself seems reasonable; the ux-advise mail I saw seemed like
we'd got confused ab
On 07/17/2012 12:10 AM, Lionel Elie Mamane wrote:
Please cherry-pick 0cda6605844ef68e45db7a7c05cc4d09ef2bc49a
(http://cgit.freedesktop.org/libreoffice/core/commit/?id=0cda6605844ef68e45db7a7c05cc4d09ef2bc49a
and patch also attached)
to libreoffice-3-6 in time for rc2. This would allow me to get
Le 04/07/12 10:34, Lionel Elie Mamane a écrit :
Hi Lionel,
A big thumbs up from me. With a bit of luck, it might make hsqldb
embedded dbs a bit less corruption prone...
Alex
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.
Hi Lionel,
On Tue, 2012-07-03 at 20:33 +0200, Lionel Elie Mamane wrote:
> I'm unsure whether I should apply this to libreoffice-3-6 or maybe
> even libreoffice-3-5; I'd be glad of your opinions.
Sounds reasonable for -3-6 to me (but doesn't require approval there as
a bug fix:-).
> This
On Wed, Jul 04, 2012 at 10:34:36AM +0200, Lionel Elie Mamane
wrote:
> Yes, but *which* statement that is depends on the underlying database
> engine. For example:
>
> * HSQLDB: "CHECKOPOINT DEFRAG;" will do it on the whole database
>
> * MySQL: "OPTIMIZE TABLE foo, bar, qux;" will do it on t
On Wed, Jul 04, 2012 at 09:30:20AM +0200, Miklos Vajna wrote:
> On Tue, Jul 03, 2012 at 08:33:13PM +0200, Lionel Elie Mamane
> wrote:
>> The alternative would be to introduce an UI element
>> "compress/cleanup/defrag database", but:
>> 1) It would necessarily be specific to sdbc(x) direct drive
Hi Lionel,
On Tue, Jul 03, 2012 at 08:33:13PM +0200, Lionel Elie Mamane
wrote:
> The alternative would be to introduce an UI element
> "compress/cleanup/defrag database", but:
>
> 1) It would necessarily be specific to sdbc(x) direct drivers as AFAIK
>odbc / jdbc / ... don't have a standard
My approval for 3-5-5, one more needed.
Fridrich
On 02/07/12 15:51, Michael Stahl wrote:
> On 02/07/12 15:33, Lionel Elie Mamane wrote:
>> The fix to fdo#47473 exposed (the underlying reason for) fdo#51619
>> which could not be triggered before. So from the point of view of the
>> user, this is a
On Mon, Jul 02, 2012 at 03:33:21PM +0200, Lionel Elie Mamane wrote:
> diff --git a/connectivity/source/commontools/dbtools.cxx
> b/connectivity/source/commontools/dbtools.cxx
> index 755fe9e..9286efd 100644
> --- a/connectivity/source/commontools/dbtools.cxx
> +++ b/connectivity/source/commontools
On 02/07/12 15:33, Lionel Elie Mamane wrote:
> The fix to fdo#47473 exposed (the underlying reason for) fdo#51619
> which could not be triggered before. So from the point of view of the
> user, this is a regression in 3.5.5 wrt to 3.5.4: 3.5.4 did not crash
> and 3.5.5 does.
>
> Attached patch fix
On Wed, Jun 20, 2012 at 11:27:25AM +0200, Lionel Elie Mamane wrote:
> fdo#51243 caused by error in fix to fdo#48932, which introduced
> infinite loop, and thus from the user's POV a freeze of the whole LibO
> process.
Interestingly, the error is in the backport to libreoffice-3-5; the
original com
On 06/18/2012 10:14 PM, Caolán McNamara wrote:
On Mon, 2012-06-18 at 16:54 +0200, Lionel Elie Mamane wrote:
Legacy reports (not Sun/Oracle Report Builder ones) wizard show date
columns as an integer days-since-epoch instead of e.g. nicely
formatted "DD-MM-YY" (day-month-year) in *newly* *created
On Mon, Jun 18, 2012 at 09:14:09PM +0100, Caolán McNamara
wrote:
> On Mon, 2012-06-18 at 16:54 +0200, Lionel Elie Mamane wrote:
> > Legacy reports (not Sun/Oracle Report Builder ones) wizard show date
> > columns as an integer days-since-epoch instead of e.g. nicely
> > formatted "DD-MM-YY" (day-
On Mon, 2012-06-18 at 16:54 +0200, Lionel Elie Mamane wrote:
> Legacy reports (not Sun/Oracle Report Builder ones) wizard show date
> columns as an integer days-since-epoch instead of e.g. nicely
> formatted "DD-MM-YY" (day-month-year) in *newly* *created* reports.
>
> Commit message is explanator
On Wed, Jun 06, 2012 at 06:21:43AM +0200, Lionel Elie Mamane wrote:
> (And somebody find me a brown paper bag...)
Here you have one from my collection!
Best,
Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop
On Wed, Jun 06, 2012 at 06:11:31AM +0200, Lionel Elie Mamane wrote:
> On Tue, Jun 05, 2012 at 10:11:23PM +0200, Lionel Elie Mamane wrote:
>> Legacy reports (not Sun/Oracle Report Builder ones) created by the
>> wizard in LibreOffice 3.5 or later fail to open (in LibreOffice 3.5
>> and later): show
On Tue, Jun 05, 2012 at 10:11:23PM +0200, Lionel Elie Mamane wrote:
> Legacy reports (not Sun/Oracle Report Builder ones) created by the
> wizard in LibreOffice 3.5 or later fail to open (in LibreOffice 3.5
> and later): show empty data.
> Please apply to libreoffice-3-5 branch.
Wait... I causes
On 05/06/12 18:54, Lionel Elie Mamane wrote:
> Legacy reports (not Sun/Oracle Report Builder ones) created by
> LibreOffice 3.4 or earlier fail to open in LibreOffice 3.5 and later:
> show empty data.
>
> That's because LibreOffice 3.5 expects a hidden control named
> "Sorting" to be present; but
On Fri, Jun 01, 2012 at 05:15:57PM +0200, Lionel Elie Mamane wrote:
> Attached patch fixes a crash when a row fails to refresh
> correctly. (...)
The crash was as follows:
When doTryRefetch_throw fails (but does not throw an exception),
m_aKeyIter is incremented. In the case where after incremen
Hello,
Il 01/06/2012 17:15, Lionel Elie Mamane ha scritto:
Attached patch fixes a crash when a row fails to refresh
correctly. This can be triggered when the primary key is a timestamp
column with SQLite (because LibO truncates timestamp values and thus
does not find the exact same value back).
On 13 April 2012 15:58, David Ostrovsky wrote:
>
> Hi Matúš,
>
> this patch should fix the missing key in hash on Macos build [1]:
>
> illegal combination app/SDKBIN/URELIB at
> /Volumes/TBRAM/core/solenv/bin/macosx-change-install-names.pl line 70,
> line 2.
Nice catch, I think it will help, p
build LO wth idlc converted?
Thanks
David
[1]
http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1334322010.10061
Original Message
Subject: Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc
module -- build problems fixed
Date: Fri, 13
On 04/13/2012 01:39 PM, Matúš Kukan wrote:
On 13 April 2012 12:56, David Ostrovsky wrote:
Here is the corrected patch.
I fixed the build error with --enable-werror option enabled.
Hmm, I would not push it together.
Warning errors are somehow related to gbuild because there are
different setti
Hej Matúš,
you don't have to be scared, just push it ;-)
here is warning fix as a seperate patch.
David
On 13.04.2012 13:39, Matúš Kukan wrote:
On 13 April 2012 12:56, David Ostrovsky wrote:
Hi,
Here is the corrected patch.
I fixed the build error with --enable-werror option enabled.
Hmm,
On 13 April 2012 12:56, David Ostrovsky wrote:
> Hi,
>
> Here is the corrected patch.
> I fixed the build error with --enable-werror option enabled.
Hmm, I would not push it together.
Warning errors are somehow related to gbuild because there are
different settings but I would push that separatel
Hi David
On 12 April 2012 23:45, David Ostrovsky wrote:
>
> thank you for your comments on my patch. I changed it accordingly.
nice patch, thanks
I pushed it with few modifications:
- removed new_style from CustomTarget
- also removed makefile.mk from inc/
- and please, could you be consistent
Original Message
Subject: Fwd: Re: [PATCH][REVIEW] gbuild conversion: idlc module --
problem with --enable-werror
Date: Fri, 13 Apr 2012 11:26:03 +0200
From: David Ostrovsky
To: Libreoffice-dev
Hi,
my patch (that is apparently not pushed yet ;-) breaks the build with
On 04/13/2012 11:26 AM, David Ostrovsky wrote:
C++ error is about bison generated parser:
idlc/source/parser.y:261:13: Fehler: #pragma system_header außerhalb
include-Datei ignoriert [-Werror]
source/parser.y: In Funktion »int yyparse()«:
source/parser.y:604:65: Fehler: Um Zuweisung, die als Wah
r]
source/parser.y: In Funktion »int yyparse()«:
source/parser.y:604:65: Fehler: Um Zuweisung, die als Wahrheitswert
verwendet wird, werden Klammern empfohlen [-Werror=parentheses]
I'm investigating this.
David
Original Message
Subject: Re: [PATCH][REVIEW] gbuild c
at, how could we simplify the gnu_getopt treatment in
tools/Executable_rscdep.mk?
David
---- Original Message
Subject:Re: [PATCH][REVIEW] gbuild conversion: idlc module
Date: Thu, 12 Apr 2012 06:33:19 +0200
From: David Tardon
To: David Ostrovsky
CC: Libreoffice-dev
Hi David,
On 11 April 2012 23:18, David Ostrovsky wrote:
> this is gbuild conversion for idlc module.
nice
> We don't have lexer function for gbuild, so I converted dmake stuff directly
> in CustomTarget_scanner.mk.
With
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a45deba2be4a77d
On 12 April 2012 06:33, David Tardon wrote:
> Originally idlc is linked with salhelper too. It is possible it is no
> longer necessary, but it is also possible that it is necessary on a
> different platform.
salhelper is often needed only for Windows.
> ifeq ($(HAVE_GETOPT),YES)
>
> # nothing ne
On Wed, Apr 11, 2012 at 11:18:46PM +0200, David Ostrovsky wrote:
> Hi,
>
> this is gbuild conversion for idlc module.
Good. But it is not quite ready yet, see comments below.
> diff --git a/Repository.mk b/Repository.mk
> index 1a3851e..638f4f8 100644
> --- a/Repository.mk
> +++ b/Repository.mk
On 10/04/12 12:51, Caolán McNamara wrote:
> On Fri, 2012-04-06 at 09:01 +0100, Andrew Higginson wrote:
>> Ack! Sorry, forgot about them :)
>> They are now attached
>
> Seems to work, pushed now. I just tweaked the "website" button to be the
> "default" one.
>
> C.
>
Wow! thanks for the prompt r
On Fri, 2012-04-06 at 09:01 +0100, Andrew Higginson wrote:
> Ack! Sorry, forgot about them :)
> They are now attached
Seems to work, pushed now. I just tweaked the "website" button to be the
"default" one.
C.
___
LibreOffice mailing list
LibreOffice@li
On 05/04/12 20:11, Caolán McNamara wrote:
> On Fri, 2012-03-30 at 18:19 +0100, Andrew Higginson wrote:
>> Hi,
>>
>> So this is my first time contributing to LibreOffice so I was wondering
>> if I could have some critique on my patch.
>>
>> All the info is this the bug report
>> https://bugs.freedes
On Fri, 2012-03-30 at 18:19 +0100, Andrew Higginson wrote:
> Hi,
>
> So this is my first time contributing to LibreOffice so I was wondering
> if I could have some critique on my patch.
>
> All the info is this the bug report
> https://bugs.freedesktop.org/show_bug.cgi?id=31022 but basically what
Hi David,
cpputools/prj/makefile.mk was missing in my patch, and this broke the
build, fixed:
David
Original Message
Subject:Re: [PATCH][REVIEW] gbuild conversion: module cpputools
Date: Mon, 02 Apr 2012 22:32:28 +0200
From: David Ostrovsky
To: David Tardon
Hi David,
thank you for your comments. Here is another try.
As you haven't merged feature/gbuild_components branch to master
I let "gb_Executable_add_api" in place:
As you suggested the next modules to convert are:
idlc, l10ntools, rdbmaker, soltools, unodevtools
David
PS:
contribution notice.
On Sunday 01 of April 2012, Arnaud Versini wrote:
> Hi,
>
> This patch fix a memory leak in SwWW8ImplReader::ReadPlainChars during
> import of the RTF specification (
> http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=10725in
> doc format).
Altered slightly to avoid the copy in
Hi David,
On 1 April 2012 16:32, David Ostrovsky wrote:
> Hi,
>
> this patch convert cpputools module to gbuild
Wow, this is great.
We are quite far with the gbuild conversion but still much has to be
done, mostly for external libraries.
Any help is appreciated.
There is only a little documenta
On Sun, Apr 01, 2012 at 04:32:16PM +0200, David Ostrovsky wrote:
> Hi,
>
> this patch convert cpputools module to gbuild
Hi, David,
it is a good start, but unfortunately not quite correct yet. See the
comments below.
> From f44e44974d14be4482f1676600b8b3c407f60684 Mon Sep 17 00:00:00 2001
> Fr
On Mon, Mar 19, 2012 at 04:31:34PM +0100, Petr Mladek wrote:
> Lionel Elie Mamane píše v Čt 15. 03. 2012 v 18:53 +0100:
>> Attached patch fixes fdo#46843, namely that the graphical query editor
>> loses the query's sorting order. (most annoying, severity critical)
>> Culprit:
>> commit 33b9b857e
Lionel Elie Mamane píše v Čt 15. 03. 2012 v 18:53 +0100:
> Attached patch fixes fdo#46843, namely that the graphical query editor
> loses the query's sorting order. (most annoying, severity critical)
>
> Culprit:
>
> commit 33b9b857ea6cb5a6f731de68f58e532242c43d30
> Author: Ocke Janssen [oj]
> D
On 14/02/12 15:37, Lionel Elie Mamane wrote:
> Yet another odbc on 64 bit crash because of wrong buffer size. This is
> supposed to be a SQLLEN but was hardcoded as 4 bytes.
>
> You can see that e.g. in
> connectivity/source/drivers/odbcbase/OPreparedStatement.cxx,
> OPreparedStatement::setNull:
>
2012/2/14 Michael Stahl :
> On 14/02/12 15:46, Lionel Elie Mamane wrote:
>> I corrected an error (bad link/reference) in the API documentation for
>> com::sun::star::sdbc::XDatabaseMetaData. Do we backport that kind of
>> things? It would suck somewhat for our on-line version to be wrong
>> until a
On 14/02/12 15:46, Lionel Elie Mamane wrote:
> I corrected an error (bad link/reference) in the API documentation for
> com::sun::star::sdbc::XDatabaseMetaData. Do we backport that kind of
> things? It would suck somewhat for our on-line version to be wrong
> until after the release of 3.6.
>
> So
On Mon, 2012-02-13 at 18:08 +0100, Lionel Elie Mamane wrote:
> On Mon, Feb 13, 2012 at 05:39:51PM +0100, Radek Doulik wrote:
>
> > looks OK to me. I have cherry-picked it from master, because the
> > attached patch didn't apply.
>
> Oh, sorry, some difference between my work tree and pristine
> l
On Mon, Feb 13, 2012 at 05:39:51PM +0100, Radek Doulik wrote:
> looks OK to me. I have cherry-picked it from master, because the
> attached patch didn't apply.
Oh, sorry, some difference between my work tree and pristine
libreoffice-3-5 must have made a mess.
The "sorted by concatenation" proble
Hi,
looks OK to me. I have cherry-picked it from master, because the
attached patch didn't apply.
Pushed. Thanks.
Cheers
Radek
On Thu, 2012-02-09 at 19:27 +0100, Lionel Elie Mamane wrote:
> getColumns() is a XDatabaseMetadata interface function to get the list
> of columns of a table and info o
Hi,
looks OK to me. Pushed. Thanks.
Cheers
Radek
On Thu, 2012-02-09 at 18:44 +0100, Lionel Elie Mamane wrote:
> With a PostgreSQL-SDBC database, Base query design does not allow the
> user to use groupings and aggregate functions.
>
> Change PostgreSQL-SDBC so that it declares to support Core S
On 08/02/12 13:51, Lionel Elie Mamane wrote:
> Attached patch restores compatibility of PostgreSQL-SDBC with
> PostgreSQL server version 8.4. LibO 3.5.0 accidentally works only with
> 9.0 and later. (9.0 came after 8.4, there is no 8.5.)
>
> Basically, it replaces "try to be extra-smart and look d
Hi Lionel,
Lionel Elie Mamane píše v Po 06. 02. 2012 v 14:42 +0100:
> Attached patch (by Michael Stahl) fixes fdo#37024, a "most annoying"
> bug for 3.4 and 3.5. It causes forms made in older versions to clip
> (not show) controls outside of a fixed area, although there is enough
> place on scree
Hi Lionel,
Lionel Elie Mamane píše v Po 06. 02. 2012 v 15:34 +0100:
> Attached patch fixes a build issue with large num-cpus in postgresql
> module: a .h file is generated, but one of the two .c files that
> #include it doesn't depend on it in the Makefile.
>
> Let's fix it in libreoffice-3-5 so
On 30/01/12 15:43, Lionel Elie Mamane wrote:
> I attach here the "less invasive" variant originally meant for
> libreoffice-3-5.
>
> However, if people are happy with cherry-picking the (more invasive)
> master commit, by all means, cherry-pick it. This would have the
> advantage of not "forking"
On 19/01/12 20:47, Lionel Elie Mamane wrote:
> Attached patch fixes fdo#44025; the original symptom is "search in a
> database does not go beyond prefetch window". The underlying reason is
> that dbaccess::ORowSetCache::isLast() returns true on the last line of
> the *prefetch* *window* even if it
Hi Petr,
On 2011-03-18 at 17:56 +0100, Petr Mladek wrote:
> > and I'd like backport three concrete and fairly trivial fixes which
> > address the reproducible parts to 3-3-2
Caolán - thank you for that!
> > Firstly, the hang.
> > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=7482695
On Tue, 2010-12-07 at 00:46 -0500, Kohei Yoshida wrote:
> Please someone review my patch at
>
> https://bugs.freedesktop.org/show_bug.cgi?id=32133
>
> which fixes the aforementioned bug for 3.3. The patch in comment 7 is
> the one that needs reviewing.
Just to note on the list that this is reso
66 matches
Mail list logo
