Re: [PATCH] libzmf: Fix installation when using Doxygen 1.14

On 2025-05-29 09:29, Christoph Grüninger wrote: Installation of libzmf fails when the documentation is built using Doxygen 1.14. The latest Doxygen does no longer create PNG images and provides JavaScript files instead. Please find a proposed patch attached. Further, some changes to the build

Re: [PATCH] Remove leftover cast of fResolutionDPI

Hi, Am 11.11.20 um 19:30 schrieb Brett T. Warden: > When building with --disable-pdfium, compilation fails due to a > reference to fResolutionDPI, which is now only defined within the > #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block. Already fixed? https://cgit.freedesktop.org

Re: [PATCH] Remove leftover cast of fResolutionDPI

Brett T. Warden kirjoitti 11.11.2020 klo 20.30: When building with --disable-pdfium, compilation fails due to a reference to fResolutionDPI, which is now only defined within the #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block. --- vcl/source/filter/ipdf/pdfread.cxx | 1 - 1

Re: Patch review

anshu khare kirjoitti 10.11.2020 klo 16.27: Hi Please review my patch https://gerrit.libreoffice.org/c/core/+/105501 I have tested it. It's working fine. Please merge it. You did not address Jim's comment: "Please see https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf#19

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 9:34, Roland Illig wrote: > On 19.05.2020 07:32, Mike Kaganski wrote: >> >> See >> https://libreoffice-dev.blogspot.com/2020/05/create-patch-for-libreoffice-directly.html >> > > Thanks for this pointer.  I had previously bailed out when I had to > select a project, and I typed "libre

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 07:32, Mike Kaganski wrote: On 19.05.2020 2:28, Jan-Marek Glogowski wrote: Am 18.05.20 um 20:57 schrieb Roland Illig: On 18.05.2020 09:21, Miklos Vajna wrote: Could you please push your patch to gerrit? Nope. I won't clone a 1 GB repository and install several tools just for fi

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 2:28, Jan-Marek Glogowski wrote: > Am 18.05.20 um 20:57 schrieb Roland Illig: >> On 18.05.2020 09:21, Miklos Vajna wrote: >>> Could you please push your patch to gerrit? >> >> Nope. I won't clone a 1 GB repository and install several tools just for >> fixing a single line of code. It'

Re: [PATCH] libetonyek: std::for_each

Am 18.05.20 um 20:57 schrieb Roland Illig: > On 18.05.2020 09:21, Miklos Vajna wrote: >> Could you please push your patch to gerrit? > > Nope. I won't clone a 1 GB repository and install several tools just for > fixing a single line of code. It's much more efficient if you do that, > since you alr

Re: [PATCH] libetonyek: std::for_each

On 18.05.2020 09:21, Miklos Vajna wrote: Hi Roland, Could you please push your patch to gerrit? Nope. I won't clone a 1 GB repository and install several tools just for fixing a single line of code. It's much more efficient if you do that, since you already have all the infrastructure set up.

Re: [PATCH] libetonyek: std::for_each

Hi Roland, Could you please push your patch to gerrit? See . It's much easier to take patches from there. Thanks, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https

[SOLVED] Re: Patch ok locally but fails on gerrit

Thank you Miklos and Stephan (who responded on gerrit). The use of rtl::isSurrogate() avoids to call ICU libs from starmath. Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing l

Re: Patch ok locally but fails on gerrit

Hi Julian, On Thu, Apr 09, 2020 at 12:20:30AM -0700, julien2412 wrote: > I gave a try to tdf#129372 (FILEOPEN: PPTX: File format error found at > SfxBaseModel::storeToStorage: 0x20d(row,col) – works w/ PowerPoint 2013) > with https://gerrit.libreoffice.org/c/core/+/91941. > The pb is it builds o

Re: [PATCH] Icon themes clean-up

Fallback is now [1] much simpler than before OUString ImplImageTree::fallbackStyle(const OUString& rsStyle) { OUString sResult; if (rsStyle == "colibre" || rsStyle == "helpimg") sResult = ""; else if (rsStyle == "sifr_dark" ) sResult = "breeze_dark"; else if (rsSty

Re: [PATCH] Icon themes clean-up

Hi Heiko, On 12/05/18 11:03, Heiko Tietze (via Code Review) wrote: > https://gerrit.libreoffice.org/54158 As per IRC: wrt. the INDUSTRIAL_FALLBACK in postprocess/ foo.mk Just delete all of the lines that have that mentioned =) Having said all this - it makes

Re: [PATCH feature/new-vcl-scheduler] noop commit: trigger test build for branch feature/new-vcl-s...

Hi Jan-Marek, On Thu, Jul 13, 2017 at 08:43:24PM +, Jan-Marek Glogowski wrote: > Nothing from my heart. The scheduler was asked to process all pending events, > but for whatever reason there is still an idle event left (Idle). > > My guess is that I broke something with my revert and my qu

Re: [PATCH feature/new-vcl-scheduler] noop commit: trigger test build for branch feature/new-vcl-s...

Am 13. Juli 2017 21:08:29 MESZ schrieb Miklos Vajna : >Hi Jan-Marek, > >Jenkins just failed in a vcl/scheduler assertion for me: > >https://ci.libreoffice.org/job/lo_gerrit/14865/Config=linux_clang_dbgutil_64/console > >It does not seem to be clang, I can reproduce the same with a local gcc >build.

Re: [PATCH feature/new-vcl-scheduler] noop commit: trigger test build for branch feature/new-vcl-s...

Hi Jan-Marek, Jenkins just failed in a vcl/scheduler assertion for me: https://ci.libreoffice.org/job/lo_gerrit/14865/Config=linux_clang_dbgutil_64/console It does not seem to be clang, I can reproduce the same with a local gcc build. I guess the relevant line is: cppunittester: /home/tdf/lod

Re: [PATCH] Fix typo in configure.ac (mk68 -> m68k)

On Sun, Nov 27, 2016 at 07:16:02PM +0100, John Paul Adrian Glaubitz wrote: > Signed-off-by: John Paul Adrian Glaubitz > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 731e903..4480ed0 100644 > --- a/configure.ac > +

[PUSHED] Re: [PATCH] Fix typo in configure.ac (mk68 -> m68k)

Rene pushed the patch, see https://cgit.freedesktop.org/libreoffice/core/commit/?id=f35d29c8388744be1f95ec4acfca12eec706911a -- View this message in context: http://nabble.documentfoundation.org/PATCH-Fix-typo-in-configure-ac-mk68-m68k-tp4201156p4201163.html Sent from the Dev mailing list arch

Re: [PATCH] libvisio: Fix tests without tools

Could you send it as "git format-patch" or submit to gerrit, so that I can credit you properly? Cheers F. On 07/02/16 15:28, Andreas Sturmlechner wrote: > I'd like to submit an easy patch that fixes the tests when libvisio is built > without tools (in that case it was missing librevenge-stream

Re: Re: [PATCH] libvisio: Fix tests without tools

Thanks for fixing it that quick! ---Original Message--- On Sunday, 7 February 2016 at 21:35, Fridrich Strba wrote: > Actually, it is ok, I managed to massage it a bit and commit like this: > > https://cgit.freedesktop.org/libreoffice/libvisio/commit/?id=13431c9e425d93f61a7fc16f99f8d8c6e71ed82b >

Re: [PATCH] libvisio: Fix tests without tools

Actually, it is ok, I managed to massage it a bit and commit like this: https://cgit.freedesktop.org/libreoffice/libvisio/commit/?id=13431c9e425d93f61a7fc16f99f8d8c6e71ed82b Thanks a lot for noticing this. Cheers Fridrich On 07/02/16 21:09, Fridrich Strba wrote: > Could you send it as "git for

Re: patch

Thanks for your license statement. I see you are already on our wiki: https://wiki.documentfoundation.org/Development/Developers I you want help to get started or have any questions, then please contact me. I am here to help you (and others) getting their first patch submitted. LibreOffice is a

Re: Patch: convert InsertDeleteFlags to use o3tl::typed_flags

On 11/17/2015 03:07 PM, Alex McMurchy wrote: Is there a way to determine which branch/release this patch is going to appear in - http://cgit.freedesktop.org/libreoffice/core/commit/?id=eaa34b4e29478770c4707d56aa102491bc8e058a as it was pushed to master only recently, it will only appear in the

Re: [PATCH] install_cygwin.ps1

On 30 October 2015 at 01:13, Norbert Thiebaud wrote: > On Thu, Oct 29, 2015 at 6:32 PM, jan iversen > wrote: > > > > > > > > Thanks for the answer, I will make a copy of that repo (so much for > "core is > > the only repo you will ever need") > > if you downloaded and used that ps1 file, that in

Re: [PATCH] install_cygwin.ps1

On Thu, Oct 29, 2015 at 6:32 PM, jan iversen wrote: > > > > Thanks for the answer, I will make a copy of that repo (so much for "core is > the only repo you will ever need") if you downloaded and used that ps1 file, that indicate that you were following the 'lode' ways of setting up a build envir

Re: [PATCH] install_cygwin.ps1

On Friday, 30 October 2015, Norbert Thiebaud wrote: > On Thu, Oct 29, 2015 at 6:07 PM, jan iversen > wrote: > > Hi. > > > > During the hackfest in Hamburg I noticed that install_cygwin.ps1 did not > > install python3 (tested on a 64 bit system). > > > > In fact it only installs python, due to a

Re: [PATCH] install_cygwin.ps1

On Thu, Oct 29, 2015 at 6:07 PM, jan iversen wrote: > Hi. > > During the hackfest in Hamburg I noticed that install_cygwin.ps1 did not > install python3 (tested on a 64 bit system). > > In fact it only installs python, due to a dependency from git. > > It turns out the -P flags needs a bit of reor

Re: [PATCH]

On Tue, 2015-08-25 at 06:38 -0700, Olivier R. wrote: > Hi *, > > Here is a patch to update the French spelling dictionary. > For 5.0 and master. > > 0001-Update-French-spelling-dictionary-v5.patch > h-spelling-dictionary-v5.p

Re: [PATCH] resolved: crash while closing ImageMap Editor

Hi Szymon, On Sun, 2015-08-16 at 10:19 +, Szymon Kłos (via Code Review) wrote: > Change subject: resolved: crash while closing ImageMap Editor Thanks so much for that =) I've pushed to 5-0 and gerrit for -5-0-1 - extra reviews appreciated: https://gerrit.libreoffice.

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

Hi Olivier, Regina Henschel schrieb: Hi Olivier, So I moved the file to text/sbasic/shared/ and it has now the syntax highlighting. I've not yet tested it, but if you write the basic code as snippet on a file located in sbasic and embed that section in your file in shared, it should work too.

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

Hi Olivier, Olivier Hallot schrieb: HI Regina On 03/08/2015 20:59, Regina Henschel wrote: Hi Olivier, (...) Look into /core/helpcompiler/source/HelpCompiler.cxx, method HelpCompiler::saveXhpForJar, line #102-105. It seems the syntax highlighting is restricted to files from the folder "sbas

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

HI Regina On 03/08/2015 20:59, Regina Henschel wrote: > Hi Olivier, > (...) > > Look into /core/helpcompiler/source/HelpCompiler.cxx, method > HelpCompiler::saveXhpForJar, line #102-105. > It seems the syntax highlighting is restricted to files from the folder > "sbasic". > > Kind regards > Reg

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

Hi Olivier, Olivier Hallot schrieb: Em qua 29 jul 2015, às 16:29:52, Regina Henschel escreveu: [..] . Another issue I > > could'nt fix is that paragraph with "role=basicode" should display with > > colored fonts depending on the keywords and that does not happened with > > the sample we

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

Em qua 29 jul 2015, às 16:29:52, Regina Henschel escreveu: > Hi Olivier, > > I will answer here, because it starts private. But I think, the > discussion should be on dev@. Agree. But I am sending this mail from a mail account that will require clearance from the moderator. > > Olivier Hallot

Re: Patch: Fix bug 90222 - Replace ScaList with std container

Hi Ryan, On Thursday, 2015-07-30 14:25:04 +1200, Ryan McCoskrie wrote: > > Apparently we don't have your license statement on file > > I've already done that. > http://lists.freedesktop.org/archives/libreoffice/2014-September/063297.html Don't know why I missed that in https://wiki.documentfou

Re: Patch: Fix bug 90222 - Replace ScaList with std container

On Wednesday, July 29, 2015 03:27:07 PM Eike Rathke wrote: > On Wednesday, 2015-07-29 22:45:18 +1200, Ryan McCoskrie wrote: > > (I'm having trouble with logerrit) > > That is why? We much prefer patches on gerrit, it eases review and > handling a lot. Using git review might also be an option for y

Re: Patch: Fix bug 90222 - Replace ScaList with std container

Hi Ryan, Thanks for your patch! On Wednesday, 2015-07-29 22:45:18 +1200, Ryan McCoskrie wrote: > (I'm having trouble with logerrit) That is why? We much prefer patches on gerrit, it eases review and handling a lot. Using git review might also be an option for you. If for some reason you *have*

Re: [PATCH] French dictionary update

On Sat, 2015-04-25 at 07:25 -0700, Olivier R. wrote: > Hello *, > > Here is a patch to update the French dictionary: > 0001-Update-French-dictionary-v5.patch > > > > For 4.4 and 4.5/5.0 > http://lists.f

Re: [Patch] Removed inheritance from std vector and std map.

Hey, so this is the wrong format to submit patches. The preferred way is to use gerrit and follow the instructions at https://wiki.documentfoundation.org/Development/gerrit There is still the discouraged way of attaching the result of got format-patch to a mail but if possible please use gerrit.

Re: [PATCH] Remove Inheritance from std::vector

This is weird. This is the not what I intended to submit. Obviously this won't compile. 2015-04-08 22:22 GMT+01:00 Delveri chick : > diff --git a/idl/inc/basobj.hxx b/idl/inc/basobj.hxx > index c601fb1..807b861 100644 > --- a/idl/inc/basobj.hxx > +++ b/idl/inc/basobj.hxx > @@ -88,8 +88,8 @@ prote

Re: patch for alloca on xstreamos/illumos

On 23.01.2015 10:01, Gabriele Bulfon wrote: > Hi, > > going on building, I found a couple of vcl sources using "alloca", > requiring an include on solaris/illumos. > So I had to patch both toolkit/source/awt/vclxgraphics.cxx and > toolkit/source/awt/vclxfont.cxx to add this: > > #ifdef __sun__ >

Re: patch for alloca on xstreamos/illumos

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 23/01/15 10:01, Gabriele Bulfon a écrit : > Hi, > > going on building, I found a couple of vcl sources using "alloca", requiring > an include on solaris/illumos. > So I had to patch both toolkit/source/awt/vclxgraphics.cxx and > toolkit/source/aw

Re: Patch of the LibreOfficeKit

On 12/09/2014 10:16 AM, Juergen Funk Mailinglist wrote: I have found 3 solution for solve the problem with the Headless mode on Windows. should be fixed now with "Fake --headless more cleanly"

Re: [PATCH] configure.ac: turn valgrind automagic into --enable-valgrind option

Hi, On 2 November 2014 13:48, Andreas Sturmlechner wrote: > Hi! > > Please consider a patch to configure.ac. > > - valgrind headers might be present, but not wished for libreoffice > - if valgrind support is desired but for some reason not found, configure > should not keep quiet and continue A

Re: Patch for [Bug 79082] FILESAVE: Tab positions not being retained in PPT

Hi Piet, On Sun, Nov 02, 2014 at 06:19:56PM +0100, Piet van Oostrum wrote: > I have a patch for bug https://bugs.freedesktop.org/show_bug.cgi?id=79082 > (tested on LibreOffice 4.3.2.2). There is a test file on bugzilla > (https://bugs.freedesktop.org/attachment.cgi?id=106377), and also the pat

Re: [PATCH] Update French spelling dictionary

Hi Olivier, On Mon, Sep 22, 2014 at 8:17 AM, Olivier R. wrote: > Hi, > > Here is a patch to update the French spelling dictionary to version 5.2. > 0001-French-dictionary-update-v5.patch > Pushed, thanks.

Re: [PATCH] Update French spelling dictionary

For master and 4.3. -- View this message in context: http://nabble.documentfoundation.org/PATCH-Update-French-spelling-dictionary-tp4123110p4123111.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lis

Re: Patch for compilation against boost-1.56.0

On Thu, 2014-08-28 at 12:46 +0200, Thomas Klausner wrote: > Hi! > > Jörg Sonnenberger made a patch fixing the compilation of > libreoffice-4.2.5.2 against boost-1.56.0. I've applied the patches to > git head (only one patch needed slight modifications). The result is > attached. ... > Please int

Re: [PATCH 01/17] XSLT: Better error messages in measure_conversion.xsl

deleted. Am 19.08.2014 15:49, schrieb Kohei Yoshida: On Tue, 2014-08-19 at 12:12 +0100, Andrew Sayers wrote: https://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines The content of this page is now gone. If you are an admin and/or has more clue about how the wiki pages are o

Re: [PATCH 01/17] XSLT: Better error messages in measure_conversion.xsl

On Tue, 2014-08-19 at 12:12 +0100, Andrew Sayers wrote: > https://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines The content of this page is now gone. If you are an admin and/or has more clue about how the wiki pages are organized, feel free to clean this up. Thanks, Kohei _

Re: [PATCH 01/17] XSLT: Better error messages in measure_conversion.xsl

On Mon, Aug 18, 2014 at 02:05:15pm +0200, Jan-Marek Glogowski wrote: > Thanks for the patches, but they won't be accepted in this form. > > Please follow > > https://wiki.documentfoundation.org/Development/gerrit Er, ok. I had been following Google's first link for "libreoffice patch process":

Re: [PATCH 01/17] XSLT: Better error messages in measure_conversion.xsl

Hi Andrew! Am 14.08.2014 23:53, schrieb andrew-libreoffice@pileofstuff.org: > From: Andrew Sayers > > Earlier this year I needed to do some work with HTML document export. This > patchset represents the sundry improvements I made along the way. The code > has > been stable for a while now

[PUSHED] Re: [PATCH] typo: and -> an

Thank you Jan for your patch, I pushed it on master sources (future 4.4.0), see http://cgit.freedesktop.org/libreoffice/core/commit/?id=04a65e2704ee80701ca750f2e7c8c0565d2aa830 Could you please send a license mail to libreoffice@lists.freedesktop.org as described on this page: https://wiki.docume

Re: Patch to huge memory consumption in LO Calc

Hello Willam, On Thu, 2014-05-29 at 11:34 +0200, William Bonnet wrote: > Hello Kohei, > > Thanks for your feedback. I'll do my best to be C++03 compliant for my > next patches . So far i haven't found an equivalent to shrink_to_fit, > but i think i have another to do it... i'll given it a look

Re: Patch to huge memory consumption in LO Calc

Hello Kohei, Thanks for your feedback. I'll do my best to be C++03 compliant for my next patches . So far i haven't found an equivalent to shrink_to_fit, but i think i have another to do it... i'll given it a look during this week end. Meanwhile, i think we can improve things a little with t

Re: Patch to huge memory consumption in LO Calc

Hello William, On Sat, 2014-05-24 at 14:47 +0200, William Bonnet wrote: > I attach to this bug entry a proposal for a patch which solve this > problem. A call to shrink_to_fit has been added in the resize_block > method. In order to limit the number of call to this method, and wasting > too mu

Re: Patch to huge memory consumption in LO Calc

On 05/24/2014 02:47 PM, William Bonnet wrote: Even if it may look like a memory leak, it is not really one since the memory will be released after the document is closed. The problem exist on recent versions of LO, including master. ("Space leak" is jargon for such symptoms, cf.

Re: [patch] [solved] build failure

Hi, On Wed, May 07, 2014 at 08:29:26AM +0200, David Tardon wrote: > You do not need an option for that. All you need is to add > > CXX=g++ -std=c++98 > > to autogen.input. Or run Though, then e.g. SAL_OVERRIDE will evaluate to an empty macro, and you can introduce build issues which are only

Re: [patch] [solved] build failure

Hi, On Tue, May 06, 2014 at 03:35:32AM -0700, julien2412 wrote: > Sorry Terrence, my fault here :-( > Thanks to Kohei, I could fix these at the beginning of the morning (UTC+2) > > It could be useful to force building in C++98 or at least put an option in > autogen.input. You do not need an opti

Re: [patch] [solved] build failure

Sorry Terrence, my fault here :-( Thanks to Kohei, I could fix these at the beginning of the morning (UTC+2) It could be useful to force building in C++98 or at least put an option in autogen.input. Julien -- View this message in context: http://nabble.documentfoundation.org/patch-solved-buil

Re: [patch] [solved] build failure

Silly me, I should have waited before sending the last message. Or I should have checked commit cbd4986. On Tue, 2014-05-06 at 01:54 -0400, Terrence Enger wrote: > gcc (Debian 4.7.2-5) 4.7.2 on debian-wheezy just choked on > sfx2/source/control/querystatus.cxx ... And exactly similar errors with

Re: Patch for the bug 69195: Crash when delete a style in use

I thought it was visible by everyone ^^ . It is now effectively published : https://gerrit.libreoffice.org/#/c/8917/ -- View this message in context: http://nabble.documentfoundation.org/Patch-for-the-bug-69195-Crash-when-delete-a-style-in-use-tp4104801p4104959.html Sent from the Dev mailing

Re: Patch for the bug 69195: Crash when delete a style in use

It is actually published as a draft here: https://gerrit.libreoffice.org/#/c/8917/ Dali -- View this message in context: http://nabble.documentfoundation.org/Patch-for-the-bug-69195-Crash-when-delete-a-style-in-use-tp4104801p4104923.html Sent from the Dev mailing list archive at Nabble.com. __

Re: Patch for the bug 69195: Crash when delete a style in use

On Thu, 2014-04-10 at 07:50 -0700, Dali wrote: > Hi, > I submitted a patch to fix the issue in 4.1.4.2 version: > https://gerrit.libreoffice.org/#/c/8917/ > > Thank you for reviewing it. I don't see this in gerrit anywhere. C. ___ LibreOffice mailing

Re: patch fixing bug 73588

On Thu, 2014-04-03 at 12:05 -0400, Kohei Yoshida wrote: > On Thu, 2014-04-03 at 11:45 -0400, Hannah Lyhne wrote: > > Hello, > > > > This is my patch for bug 73588. Currently when working in RTL mode in > > calc if a user wrote in a language that was written from left to > > right, calc failed to a

Re: patch fixing bug 73588

On Thu, 2014-04-03 at 11:45 -0400, Hannah Lyhne wrote: > Hello, > > This is my patch for bug 73588. Currently when working in RTL mode in > calc if a user wrote in a language that was written from left to > right, calc failed to automatically left align the text as it had in > previous versions. T

Re: [PATCH] LTO parallelism

On 03/26/2014 11:43 AM, Martin Liška wrote: following patch increases parallelism for LTO. I tried to add -flto=+jobserver, but didn't help. According to , the "+" needs to go at the start of the Make recipe

Re: [PATCH] LTO parallelism

Sure, there's correct patch. Martin On 03/26/2014 12:59 PM, Miklos Vajna wrote: Hi Margin, On Wed, Mar 26, 2014 at 11:43:24AM +0100, Martin Liška wrote: diff --git a/solenv/gbuild/platform/com_GCC_defs.mk b/solenv/gbuild/platform/com_GCC_defs.mk index a4b18a3..93d3fe7 100644 --- a/solen

Re: [PATCH] LTO parallelism

Hi Margin, On Wed, Mar 26, 2014 at 11:43:24AM +0100, Martin Liška wrote: > diff --git a/solenv/gbuild/platform/com_GCC_defs.mk > b/solenv/gbuild/platform/com_GCC_defs.mk > index a4b18a3..93d3fe7 100644 > --- a/solenv/gbuild/platform/com_GCC_defs.mk > +++ b/solenv/gbuild/platform/com_GCC_defs.mk

Re: "[PATCH] fdo#76181: cleanup constructors in ucalc.cxx"

Hi Manas, First - thanks for the patch - the code looks a lot nicer, more readable and shorter now - which is great. I removed the trailing whitespace on some lines - the git commit hook should have complained about that too (can you run './g -z' to install those hooks (IIRC)).

Re: [PATCH]

Thanks Adam. I followed the procedure and now the code is on Gerrit. On Thu, Mar 13, 2014 at 5:18 AM, Adam Fyne wrote: > Hi Matteo, > >Thanks for working on this issue and having a patch > ready for review! However, the proper way to submit patches > for code-review (and subsequent

Re: [PATCH]

Hi Matteo, Thanks for working on this issue and having a patch ready for review! However, the proper way to submit patches for code-review (and subsequent submission on master) is using the gerrit. You can find details on how to do that here

[PUSHED] Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

On 09/03/14 17:30, Tarun Kumar K wrote: > Here I go :-) > > Hi Michael, > > I have attached the patch in the email as well. > I Hope now I understand the steps as how to contribute the patch. Feels good > to learn and contribute. thanks, pushed to master and libreoffice-4-2 branch. __

RE: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

March 2014 2:39 AM To: Tarun Kumar K; libreoffice@lists.freedesktop.org Subject: Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format On 07/03/14 09:35, Tarun Kumar K wrote: > Hi Michael, > > As you suggested, I have created the patch with "git commi

Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

On 07/03/14 09:35, Tarun Kumar K wrote: > Hi Michael, > > As you suggested, I have created the patch with "git commit" and put the > bug ID "fdo#75243" in the first line of the commit message, and then > "git format-patch HEAD~" > Kindly guide is I should do something else as well and where I ca

Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

Hi Michael, As you suggested, I have created the patch with "git commit" and put the bug ID "fdo#75243" in the first line of the commit message, and then "git format-patch HEAD~" Kindly guide is I should do something else as well and where I can see action of patch-making-into-mainstream. Th

Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

Hi Michael Many thanks for the review. i'm not sure whether it is better or worse to store e.g. an Author property that is empty; have you thought about this? .. [Tarun] In most of the big organizations, workflow systems require some of the custom properties to be present which are later

Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

On 26/02/14 08:07, Tarun Kumar wrote: > Hi, > > The Bug is filed and accepted at: > https://bugs.freedesktop.org/show_bug.cgi?id=75243 > > Steps to reproduce: > 1. Open Writer and use a document .doc > 2. Add it a custom property. Don't enter any value for the property > 3. Save it and close Wri

Re: [PATCH] fdo#61320: Allow user to choose whether to create thumbnails

Hi Christian, On Mon, 2014-02-10 at 11:53 +0100, Michael Stahl wrote: > On 10/02/14 08:42, Christian Junker wrote: > > Hello developers, > > > > this is my first LO patch for review. It enhances LibreOffice by making > > the thumbnail creation inside odf archive files optional. In some cases > >

Re: Patch for bug 71984

Hi Pavel, On Fri, Feb 21, 2014 at 11:41 AM, Pavel Laštovička wrote: > Hi all, > > I have finally posted a fix for > https://bugs.freedesktop.org/show_bug.cgi?id=71984 > The patch is against 4.1.3, hopefully it applies on master. Thanks for the patch. As far as I can tell you're not already liste

Re: [PATCH] Update French spelling dictionary

On Fri, Feb 14, 2014 at 12:22 PM, Olivier R. wrote: > Thanks. Unfortunately there is a issue in version 5.0.1. > > Here is another patch for the dictionary. > 0001-Update-French-spelling-dictionary-v5.0.2.patch >

Re: [PATCH] Update autocorrections (fr)

On Sat, Feb 15, 2014 at 1:37 AM, Olivier R. wrote: > Olivier R. wrote >> Here is a patch to update the autocorrections file for locale /fr/. >> 0001-Update-autocorrections-fr.patch >> > > Forget this patch. >

Re: [PATCH] Update autocorrections (fr)

Olivier R. wrote > Here is a patch to update the autocorrections file for locale /fr/. > 0001-Update-autocorrections-fr.patch > > Forget this patch. Here is a new one. 0001-Update-autocorrections-for-loca

Re: [PATCH] Update autocorrections (fr)

Olivier R. wrote > Here is a patch to update the autocorrections file for locale /fr/. > 0001-Update-autocorrections-fr.patch > > For master and 4.2 only. -- View this message in context: http://nabble

Re: [PATCH] Update French spelling dictionary

Thanks. Unfortunately there is a issue in version 5.0.1. Here is another patch for the dictionary. 0001-Update-French-spelling-dictionary-v5.0.2.patch For master, 4.2 and 4.1. Regards, Oli

Re: [PATCH] fdo#61320: Allow user to choose whether to create thumbnails

On 10/02/14 08:42, Christian Junker wrote: > Hello developers, > > this is my first LO patch for review. It enhances LibreOffice by making > the thumbnail creation inside odf archive files optional. In some cases > users might not want to have a thumbnail included inside their document, > because

Re: [PATCH][PUSHED] Update French spelling dictionary

On Tue, 2013-12-10 at 09:17 -0800, Olivier R. wrote: > Hi * > > Here is a patch to update the French spelling dictionary to version 5.0.1. > 0001-Update-French-dictionary-v5.0.1.patch > > > > For ma

Re: [PATCH][PUSHED] fdo#43157: Clean up OSL_ASSERT, DBG_ASSERT, etc.

On Fri, 2014-01-31 at 22:36 +0100, Tim Markle wrote: > Here is a small contribution I tried for one of the easy hacks. Thanks for this, merged now. caolanm->sbergman: The links at the top of https://bugs.freedesktop.org/show_bug.cgi?id=43157 that point to https://wiki.documentfoundation.org/Devel

Re: Patch for wrong fontnames on bigendian systems

On Tue, Jan 28, 2014 at 8:26 AM, Matthieu Riolo wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hello everyone > > I just fixed a bug which only occurs on bigendian systems. The bug and > the patch can be found on: > > https://issues.apache.org/ooo/show_bug.cgi?id=124134 > > Feel free

Re: [PATCH] HiDPI fixes for squiggly underlines

HI Kendy, Thank you! I've pulled your diff and doing a rebuild now. I have found that 5 pixels is a good value on my machine but I'll try 6, and it needs to be shifted down one more pixel. Also, there may be dirt because it increases the waveheight after the check. I believe Linux will return 96 d

Re: [PATCH] HiDPI fixes for squiggly underlines

Hi Keith, Keith Curtis píše v Pá 13. 12. 2013 v 15:58 -0500: > Good to hear from you. I've got a number of things in progress on my > computer beyond the underlines > (https://wiki.documentfoundation.org/Development/HiDpi) but I wait to > get an API first as I'm just writing "if (1) //hidpi". So

Re: [PATCH] HiDPI fixes for squiggly underlines

Hi Kendy, I had no idea to where to put this so I appreciate your help. I verified your idea works for all of the places I worked on so far because it can get to a Window. If there were static constructors that loaded and cached shared bitmaps, I think it could be a problem, but the earliest I've

Re: [PATCH] HiDPI fixes for squiggly underlines

Hi Keith, Keith Curtis píše v Pá 13. 12. 2013 v 15:58 -0500: > Good to hear from you. I've got a number of things in progress on my > computer beyond the underlines > (https://wiki.documentfoundation.org/Development/HiDpi) but I wait to > get an API first as I'm just writing "if (1) //hidpi". I

Re: [PATCH 5/5] src: Fix build with Borland C++ compiler

Hi, On 16.12.2013 13:14, Norbert Thiebaud wrote: > On Mon, Dec 16, 2013 at 4:48 AM, Bernhard Sessler > wrote: >> Signed-off-by: Bernhard Sessler >> --- >> src/cppunit/PlugInManager.cpp | 9 - >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/src/cppunit/PlugInManager.

Re: [PATCH 5/5] src: Fix build with Borland C++ compiler

On Mon, Dec 16, 2013 at 4:48 AM, Bernhard Sessler wrote: > Signed-off-by: Bernhard Sessler > --- > src/cppunit/PlugInManager.cpp | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/cppunit/PlugInManager.cpp b/src/cppunit/PlugInManager.cpp > index 4f8b371..0ebe4c5

Re: [PATCH] HiDPI fixes for squiggly underlines

Unfortunately, there is no resolution-independent back-end as the interface from LibreOffice to the OS is in discrete pixels and it has made extensive use of that ubiquitous design. I agree for user-created objects such as arrows and such, things should be defined in terms of resolution-independen

Re: [PATCH] HiDPI fixes for squiggly underlines

Hi, On Fri, Dec 13, 2013 at 9:58 PM, Keith Curtis wrote: > Hi Kendy, > > Good to hear from you. I've got a number of things in progress on my > computer beyond the underlines > (https://wiki.documentfoundation.org/Development/HiDpi) but I wait to get an > API first as I'm just writing "if (1) //h

Re: [PATCH] HiDPI fixes for squiggly underlines

Hi Kendy, Good to hear from you. I've got a number of things in progress on my computer beyond the underlines ( https://wiki.documentfoundation.org/Development/HiDpi) but I wait to get an API first as I'm just writing "if (1) //hidpi". I personally don't think a floating point value is a good ide

Re: [PATCH] HiDPI fixes for squiggly underlines

Hi Keith, Keith Curtis píše v Po 09. 12. 2013 v 19:36 -0500: > LibreOffice looks good on a HiDPI screens but there are a few small > bugs such as (fdo#51735) > > So I'm working on fixing the squiggly underlines. Patch included below. First of all, thank you so much for the patches you have subm

  1   2   3   4   5   6   7   8   9   10   >