Here I go :-)
Hi Michael,
I have attached the patch in the email as well.
I Hope now I understand the steps as how to contribute the patch. Feels good to
learn and contribute.
Regards,
Tarun
________________________________________
From: Michael Stahl [mst...@redhat.com]
Sent: Saturday, 08 March 2014 2:39 AM
To: Tarun Kumar K; libreoffice@lists.freedesktop.org
Subject: Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in
.doc format
On 07/03/14 09:35, Tarun Kumar K wrote:
> Hi Michael,
>
> As you suggested, I have created the patch with "git commit" and put the
> bug ID "fdo#75243" in the first line of the commit message, and then
> "git format-patch HEAD~"
> Kindly guide is I should do something else as well and where I can see
> action of patch-making-into-mainstream.
there is just one missing step: attach the patch to your mail ;)
From eaf2dd8a022583261cae7945ceb82bdd7a39bd5b Mon Sep 17 00:00:00 2001
From: Tarun Kumar <tk7ua1...@gmail.com>
Date: Fri, 7 Mar 2014 13:50:40 +0530
Subject: [PATCH] fdo#75243
LO removes empty properties while saving the doc. This is required in some business scenraioes.
Bug@75243 has been raised for this.
bSkipEmpty is set to false by default to enable LibreOffice to save even empty properties.
---
sfx2/source/doc/oleprops.hxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sfx2/source/doc/oleprops.hxx b/sfx2/source/doc/oleprops.hxx
index 8e09a5b..de15a66 100644
--- a/sfx2/source/doc/oleprops.hxx
+++ b/sfx2/source/doc/oleprops.hxx
@@ -310,7 +310,7 @@ public:
void SetBoolValue( sal_Int32 nPropId, bool bValue );
/** Inserts a string property with the passed value.
@return true = Property inserted; false = String was empty, property not inserted. */
- bool SetStringValue( sal_Int32 nPropId, const OUString& rValue, bool bSkipEmpty = true );
+ bool SetStringValue( sal_Int32 nPropId, const OUString& rValue, bool bSkipEmpty = false );
/** Inserts a time stamp property with the passed value. */
void SetFileTimeValue( sal_Int32 nPropId, const ::com::sun::star::util::DateTime& rValue );
/** Inserts a date property with the passed value. */
--
1.7.9.5
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
