On 14.02.25 09:40, Michael Weghorn wrote:
For me personally, consistency ("principle of least surprise") helps
reduce distraction and focus on the actual issue I'm looking into.
(Now this arguably applies less for the exact placement of the space
character in an if statement and more for things
On 2025-02-13 14:18, Stephan Bergmann wrote:
On 13.02.25 11:36, Chris Sherlock wrote:
I see commits all the time where someone changes a line of code and
changes the whitespacing in that same line of code.
I occasionally see such too, and always wonder why people do that. My
objections are t
On 14.02.25 09:09, Ilmari Lauhakangas wrote:
On 14.2.2025 9.06, Stephan Bergmann wrote:
(but yeah, every analogy, ultimately, is a stretch; and there's value
in the beauty of your work, for sure; but a messy source and a clean
little diff can have beauty too---I tried to get that across somewha
On 14.2.2025 9.06, Stephan Bergmann wrote:
(but yeah, every analogy, ultimately, is a stretch; and there's value in
the beauty of your work, for sure; but a messy source and a clean little
diff can have beauty too---I tried to get that across somewhat in a talk
I once gave, can't remember which
On 14.02.25 05:59, Chris Sherlock wrote:
I'm not following the argument. If whitespacing changes don't make the
code less readable or more readable, then why would a small whitespacing
change that makes the code more consistent with the surrounding code
style on the lines of code you are modify
On Fri, Feb 14, 2025 at 12:18 AM Stephan Bergmann <
stephan.bergm...@allotropia.de> wrote:
> On 13.02.25 11:36, Chris Sherlock wrote:
> > I see commits all the time where someone changes a line of code and
> changes the whitespacing in that same line of code.
>
> I occasionally see such too, and a
Hi Chris, László, all,
[replying to parts of multiple emails here]
On 2025-02-13 13:45, Chris Sherlock wrote:
It appears I misunderstood and didn’t notice the other changes I had made. I apologise for my misunderstanding.
No problem. Misunderstandings can happen and it's good to sort them out
Hi Chris, hi all,
Chris Sherlock ezt írta (időpont: 2025. febr.
13., Cs, 11:37):
> Hi all,
>
> I see commits all the time where someone changes a line of code and
> changes the whitespacing in that same line of code.
>
> So for example, in https://gerrit.libreoffice.org/c/core/+/178504 I have
>
On 13.02.25 11:36, Chris Sherlock wrote:
I see commits all the time where someone changes a line of code and changes the
whitespacing in that same line of code.
I occasionally see such too, and always wonder why people do that. My
objections are twofold:
For one, unnecessary and unrelated
> The devil is in the details. Michael is right that there are lines where only
> spaces have been changed, but his first comment didn't show exactly the lines
> he was suggesting for correction, maybe that is why he was unwittingly
> opening old wounds. Chris' e-mail shows for me that the mot
> On 13 Feb 2025, at 9:56 pm, Michael Weghorn wrote:
>
> Hi Chris,
>
> On 2025-02-13 11:36, Chris Sherlock wrote:
>> I see commits all the time where someone changes a line of code and changes
>> the whitespacing in that same line of code.
>> So for example, in https://gerrit.libreoffice.org
Hi Chris,
On 2025-02-13 11:36, Chris Sherlock wrote:
I see commits all the time where someone changes a line of code and changes the
whitespacing in that same line of code.
So for example, in https://gerrit.libreoffice.org/c/core/+/178504 I have
removed the using namespaces and added css:: as
12 matches
Mail list logo
