Hi Chris, László, all, [replying to parts of multiple emails here]
On 2025-02-13 13:45, Chris Sherlock wrote:
It appears I misunderstood and didn’t notice the other changes I had made. I apologise for my misunderstanding.
No problem. Misunderstandings can happen and it's good to sort them out. On 2025-02-13 13:44, Németh László wrote:
Michael is right that there are lines where only spaces have been changed, but his first comment didn't show exactly the lines he was suggesting for correction
Indeed - sorry if my initial review comment wasn't clear enough and caused this misunderstanding.
The right solution will be one where we don't get any more wounds, but who knows what it is. That is why I have corrected the 5-6 lines, where there were only space differences, hoping the best!
Thanks, László!
For what it's worth, I’m trying to make small changes that have limited impact on the codebase and that make bisecting easy if I did something wrong. After my last large scale change, I realise I made some errors and before I had a chance to even look into the issues they had been fixed by Caolan, and for that I’m very grateful. I was told that it caused huge problems and stopped paid contributors from progressing their work, and I’m trying my very best to ensure this doesn’t happen again.
I'm unaware of the details of the particular instance you're referring to, but I think everyone contributing to LibreOffice makes mistakes at times (I for sure do!) and it's great to learn from them.
Code review is there to catch (at least some) issues and trying to keep single changes in a manageable size (independent of whether they're reviewed by somebody else or not) is generally an approach that I think helps everyone involved, where reasonably possible.
Thanks for your contributions!
OpenPGP_signature.asc
Description: OpenPGP digital signature
