Re: Interdependent, failing commits

On 09.01.25 01:21, Bjoern Michaelsen wrote: On 1/8/25 20:52, Noel Grandin wrote: If it's not possible to trigger that tinderbox on changes, I can run tests for you on my ubsan box, but only from next week, when I'm back in the office. Awesome, thanks! This change ReReReReverts and fixes the i

Re: Interdependent, failing commits

Hi Noel, On 1/8/25 20:52, Noel Grandin wrote: If it's not possible to trigger that tinderbox on changes, I can run tests for you on my ubsan box, but only from next week, when I'm back in the office. Awesome, thanks! This change ReReReReverts and fixes the issues. As it now also dyncast-asse

Re: Interdependent, failing commits

On Wed, 8 Jan 2025 at 20:09, Bjoern Michaelsen < bjoern.michaelsen-...@libreoffice.org> wrote: > Aye, sorry. Is it by chance possible to trigger that tinderbox on a > change before it is merged? Untangling SwClient/SwModify in Writer is a > bit Jenga-Driven Development, because retrofitting typing

Re: Interdependent, failing commits

Hi Stephan, On 1/8/25 10:54, Stephan Bergmann wrote: Björn, Noel, I would be grateful if you could refrain from pushing further commits in those areas until the above Gerrit chain has been pushed and a fresh build of (which I'll trigger once the chain

Re: Interdependent, failing commits

On 08.01.25 10:54, Stephan Bergmann wrote: So I'm now at a chain of four reverts * "Revert 'fix ubsan failure'" * "Revert 'convert RES_OBJECTDYING to SfxHint'" *

Re: Interdependent, failing commits

On 08.01.25 08:58, Stephan Bergmann wrote: On 1/6/25 22:27, Stephan Bergmann wrote: The two recent commits "Revert 'Revert 'stronger typing for SwClient::GetRegisteredIn'' and fix SwIterator cast" and

Re: Interdependent, failing commits

On 1/6/25 22:27, Stephan Bergmann wrote: The two recent commits "Revert 'Revert 'stronger typing for SwClient::GetRegisteredIn'' and fix SwIterator cast" and

Re: Interdependent, failing commits

On Tue, 7 Jan 2025 at 18:12, Stephan Bergmann < stephan.bergm...@allotropia.de> wrote: > On 1/7/25 15:08, Noel Grandin wrote: > > Should be fixed once https://gerrit.libreoffice.org/c/core/+/179890 > > goes in > > What exactly should be fixed by tha

Re: Interdependent, failing commits

On 1/7/25 15:08, Noel Grandin wrote: Should be fixed once https://gerrit.libreoffice.org/c/core/+/179890 goes in What exactly should be fixed by that? With the above change cherry-picked on top of recent master 61c12dd1c80e4b7227a614227bb690b0

Re: Interdependent, failing commits

Should be fixed once https://gerrit.libreoffice.org/c/core/+/179890 goes in On Tue, 7 Jan 2025 at 01:04, Bjoern Michaelsen < bjoern.michaelsen-...@libreoffice.org> wrote: > Hi Stephan, > > ok from my site. While I am still working on a fix, it was unfortunately > not as trivial as I thought and I

Re: Interdependent, failing commits

Hi Stephan, ok from my site. While I am still working on a fix, it was unfortunately not as trivial as I thought and I currently do not find the time to commit to fix this by tomorrow. Best, Bjoern On 1/6/25 22:27, Stephan Bergmann wrote: The two recent commits