Re: Fwd: [ABANDONED] Remove some excessive log formatting

2019-11-22 Thread Stephan Bergmann
On 22/11/2019 14:55, Luboš Luňák wrote: SAL_LOG=+INFO.sal.osl-INFO.sal.osl.noisyarea . Problem solved :). Sure, if one is willing to invest in adding sal.osl.noisyarea and reclassifying existing uses. Which is typically not the case when you do a one-off SAL_LOG=... debug run. Which is wh

Re: Fwd: [ABANDONED] Remove some excessive log formatting

2019-11-22 Thread Luboš Luňák
On Friday 22 of November 2019, Stephan Bergmann wrote: > On 22/11/2019 12:13, Luboš Luňák wrote: > > On Thursday 21 of November 2019, Stephan Bergmann wrote: > >> * Too much trivial SAL_INFO noise (that was once added ad-hoc and should > >> arguably have only been in a developer's local build) can

Re: Fwd: [ABANDONED] Remove some excessive log formatting

2019-11-22 Thread Stephan Bergmann
On 22/11/2019 12:13, Luboš Luňák wrote: On Thursday 21 of November 2019, Stephan Bergmann wrote: * Too much trivial SAL_INFO noise (that was once added ad-hoc and should arguably have only been in a developer's local build) can make it unnecessarily hard to see the more relevant SAL_INFOs (and l

Re: Fwd: [ABANDONED] Remove some excessive log formatting

2019-11-22 Thread Luboš Luňák
On Thursday 21 of November 2019, Stephan Bergmann wrote: > My concerns are: > > * We may eventually want to enable SAL_WARN/SAL_INFO for production > builds, at which point the space cost of log message strings might > become an issue. Space cost? The size of /usr/lib64/libreoffice/program/*.so h

Re: Fwd: [ABANDONED] Remove some excessive log formatting

2019-11-21 Thread Stephan Bergmann
On 21/11/2019 12:47, Luboš Luňák wrote: Hm, sounds rather like a misuse of the SAL log facility to me. (Each use of it comes at a cost, so it shouldn't be used too lightly for anything but logging unusual events.) E.g. currently while writing the Skia VCL backend I've added SAL_INFO to prett

Re: Fwd: [ABANDONED] Remove some excessive log formatting

2019-11-21 Thread Luboš Luňák
On Thursday 21 of November 2019, Stephan Bergmann wrote: > On 21/11/2019 11:25, Chris Sherlock wrote: > > Just a quick query to the ML - when I’m attempting to troubleshoot > > issues with EMF files, I use SAL_INFO to see what records it is reading. > > It’s already helped me work out some issues,

Re: Fwd: [ABANDONED] Remove some excessive log formatting

2019-11-21 Thread Stephan Bergmann
On 21/11/2019 11:25, Chris Sherlock wrote: Just a quick query to the ML - when I’m attempting to troubleshoot issues with EMF files, I use SAL_INFO to see what records it is reading. It’s already helped me work out some issues, in particular the last one was around custom line caps. How else