Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom

2011-06-02 Thread Cor Nouws
Hi Christina, Chr. Rossmanith wrote (31-05-11 14:03) more duplicate code cleanup. Good to see your work :-) Class SfxObjectShell has two nearly identical methods: ImportFrom and InsertFrom. The latter has a few lines of code more, so I've removed InsertFrom (which was added to the code base

Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom

2011-06-01 Thread Christina Rossmanith
+0100 > Von: Noel Power > An: "Chr. Rossmanith" > CC: libreoffice@lists.freedesktop.org > Betreff: Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and > InsertFrom > On 31/05/11 13:03, Chr. Rossmanith wrote: > > Hi, > > > > more dup

Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom

2011-06-01 Thread Noel Power
On 31/05/11 13:03, Chr. Rossmanith wrote: Hi, more duplicate code cleanup. Class SfxObjectShell has two nearly identical methods: ImportFrom and InsertFrom. The latter has a few lines of code more, so I've removed InsertFrom (which was added to the code base later than ImportFrom), added a b