Yesterday everything built fine. Then I did a "./g pull -r" which caused the build to fail. As soon as I have a successfull build again I'll push everything which has queued up until now :-)
Christina -------- Original-Nachricht -------- > Datum: Wed, 01 Jun 2011 10:16:54 +0100 > Von: Noel Power <nopo...@novell.com> > An: "Chr. Rossmanith" <chrrossman...@gmx.de> > CC: libreoffice@lists.freedesktop.org > Betreff: Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and > InsertFrom > On 31/05/11 13:03, Chr. Rossmanith wrote: > > Hi, > > > > more duplicate code cleanup. > > > > Class SfxObjectShell has two nearly identical methods: ImportFrom and > > InsertFrom. The latter has a few lines of code more, so I've removed > > InsertFrom (which was added to the code base later than ImportFrom), > > added a boolean parameter to ImportFrom and adjusted the few calls to > > those methods. And InsertFrom is not virtual like ImportFrom. Please > > review the attached patches. I'll commit them if I get an "ok". > looks good to me, please commit it to master ( or I will commit it later > after I get a build /me unfortunately accidently did a make clean on his > master build ) > > thanks > Noel > _______________________________________________ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Christina Rossmanith Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
