Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters

2012-03-13 Thread Stephan Bergmann
On 03/13/2012 09:41 AM, Miklos Vajna wrote: On Mon, Mar 12, 2012 at 01:40:07PM +, Caolán McNamara wrote: Doesn't really matter, but in the ctor member init lists, there isn't really a need to call the default ctors explicitly, e.g. , m_aUnicodeBuffer() , m_aHexBuffer() could just be left o

Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters

2012-03-13 Thread Miklos Vajna
On Mon, Mar 12, 2012 at 01:40:07PM +, Caolán McNamara wrote: > Doesn't really matter, but in the ctor member init lists, there isn't > really a need to call the default ctors explicitly, e.g. > , m_aUnicodeBuffer() > , m_aHexBuffer() > could just be left out OK, I'll keep that in mind for ne

Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters

2012-03-12 Thread Caolán McNamara
On Mon, 2012-03-12 at 09:33 +0100, Miklos Vajna wrote: > I'm attaching a backport of these patches for -3-5 Pushed to 3-5. C. Doesn't really matter, but in the ctor member init lists, there isn't really a need to call the default ctors explicitly, e.g. , m_aUnicodeBuffer() , m_aHexBuffer() could