Re: [PUSHED] vcl/source/window/status.cxx: Translate German comments

2014-01-17 Thread Stephan Bergmann
On 01/17/2014 01:24 PM, Philipp Weissenbacher wrote: BTW: It's good practice to at least run ./autogen.sh before commiting (that catches these nasty syntax errors). That would only catch syntax errors in configure.ac. Preferable to run "make check" or at least "make", but that can of course b

Re: [PUSHED] vcl/source/window/status.cxx: Translate German comments

2014-01-17 Thread Stephan Bergmann
On 01/17/2014 12:50 PM, Sven Wehner wrote: sorry, I guess I misspoke: Those examples, which I listed, are rather obvious problems that aren't translation related. So let me rephrase: How to call a developer's attention to small pieces of code? And especially: may I combine that w

Re: [PUSHED] vcl/source/window/status.cxx: Translate German comments

2014-01-17 Thread Philipp Weissenbacher
Hi Sven, I hope Stephan does not mind I chime in on this. I am in the same situation: still wanting to contribute, but not investing too much free time. > How to call a developer's attention to small pieces of code? > In my experience the developers already know about that and there's no need to

Re: [PUSHED] vcl/source/window/status.cxx: Translate German comments

2014-01-17 Thread Sven Wehner
Hi Stephan, Hi List, sorry, I guess I misspoke: Those examples, which I listed, are rather obvious problems that aren't translation related. So let me rephrase: How to call a developer's attention to small pieces of code? And especially: may I combine that with translation patches

Re: [PUSHED] vcl/source/window/status.cxx: Translate German comments

2014-01-17 Thread Stephan Bergmann
[would probably have been better to start a new mail thread] On 01/17/2014 11:34 AM, Sven Wehner wrote: When I scroll through the source code, I sometimes see odd code. Things that a real developer should seriously take a look at. Something like one of the multiple "DELETEZ" defines, an "OSL_ENS

Re: [PUSHED] vcl/source/window/status.cxx: Translate German comments

2014-01-17 Thread Sven Wehner
Hi Miklos, Hi List, I was just wondering: When I scroll through the source code, I sometimes see odd code. Things that a real developer should seriously take a look at. Something like one of the multiple "DELETEZ" defines, an "OSL_ENSURE(false, \"cannot happen.\")", German function names etc. Sh

Re: [PUSHED] vcl/source/window/status.cxx: Translate German comments

2014-01-17 Thread Miklos Vajna
Hi Sven, On Sat, Jan 11, 2014 at 05:55:35PM +0100, Sven Wehner wrote: > here's my small contribution: > I translated all comments in 'vcl/source/window/status.cxx' from > German to English. Pushed, thanks! Miklos signature.asc Description: Digital signature __