[PUSHED] Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

2014-03-10 Thread Michael Stahl
On 09/03/14 17:30, Tarun Kumar K wrote: > Here I go :-) > > Hi Michael, > > I have attached the patch in the email as well. > I Hope now I understand the steps as how to contribute the patch. Feels good > to learn and contribute. thanks, pushed to master and libreoffice-4-2 branch. __

RE: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

2014-03-09 Thread Tarun Kumar K
March 2014 2:39 AM To: Tarun Kumar K; libreoffice@lists.freedesktop.org Subject: Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format On 07/03/14 09:35, Tarun Kumar K wrote: > Hi Michael, > > As you suggested, I have created the patch with "git commi

Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

2014-03-07 Thread Michael Stahl
On 07/03/14 09:35, Tarun Kumar K wrote: > Hi Michael, > > As you suggested, I have created the patch with "git commit" and put the > bug ID "fdo#75243" in the first line of the commit message, and then > "git format-patch HEAD~" > Kindly guide is I should do something else as well and where I ca

Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

2014-03-07 Thread Tarun Kumar K
Hi Michael, As you suggested, I have created the patch with "git commit" and put the bug ID "fdo#75243" in the first line of the commit message, and then "git format-patch HEAD~" Kindly guide is I should do something else as well and where I can see action of patch-making-into-mainstream. Th

Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

2014-03-04 Thread Tarun Kumar
Hi Michael Many thanks for the review. i'm not sure whether it is better or worse to store e.g. an Author property that is empty; have you thought about this? .. [Tarun] In most of the big organizations, workflow systems require some of the custom properties to be present which are later

Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

2014-03-04 Thread Michael Stahl
On 26/02/14 08:07, Tarun Kumar wrote: > Hi, > > The Bug is filed and accepted at: > https://bugs.freedesktop.org/show_bug.cgi?id=75243 > > Steps to reproduce: > 1. Open Writer and use a document .doc > 2. Add it a custom property. Don't enter any value for the property > 3. Save it and close Wri

[Libreoffice] [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

2014-02-27 Thread Tarun Kumar
Hi, The Bug is filed and accepted at: https://bugs.freedesktop.org/show_bug.cgi?id=75243 Steps to reproduce: 1. Open Writer and use a document .doc 2. Add it a custom property. Don't enter any value for the property 3. Save it and close Writer 4. Open again Writer and use same document