Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

2013-09-16 Thread Eike Rathke
Hi Winfried, On Monday, 2013-09-16 19:08:29 +0200, Eike Rathke wrote: > I still did not see that assertion, Ok, I did.. > but I see a bunch of other assertions, and reimplemented OpCodeMap::copyFrom() to take care of these things. You'd need to rebase or cherry-pick these commits: 2f2ee162ac

Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

2013-09-16 Thread Eike Rathke
Hi Winfried, On Monday, 2013-09-16 14:03:20 +0200, Winfried Donkers wrote: > > >>-DBG_ASSERT( 0 < eOp && sal_uInt16(eOp) < mnSymbols, > > >>"OpCodeMap::putOpCode: OpCode out of range"); > > >>-if (0 < eOp && sal_uInt16(eOp) < mnSymbols) > > >>+DBG_ASSERT( sal_uInt16(eOp) < mnSymbols,

RE: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

2013-09-16 Thread Winfried Donkers
Hi Eike, Just got back from holidays, sorry I have kept you waiting. > >>-DBG_ASSERT( 0 < eOp && sal_uInt16(eOp) < mnSymbols, > >>"OpCodeMap::putOpCode: OpCode out of range"); > >>-if (0 < eOp && sal_uInt16(eOp) < mnSymbols) > >>+DBG_ASSERT( sal_uInt16(eOp) < mnSymbols, "OpCodeMap::p

Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

2013-09-05 Thread Eike Rathke
Hi Winfried, Sorry, I didn't notice your reply until now. On Tuesday, 2013-08-27 19:01:00 +0200, Winfried Donkers wrote: > >>-DBG_ASSERT( 0 < eOp && sal_uInt16(eOp) < mnSymbols, > >>"OpCodeMap::putOpCode: OpCode out of range"); > >>-if (0 < eOp && sal_uInt16(eOp) < mnSymbols) > >>+D

Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

2013-08-27 Thread Winfried Donkers
Hi Eike, Op 27-08-13 16:20, Eike Rathke wrote: Hi Winfried, On Tuesday, 2013-08-27 06:48:28 -0700, Winfried Donkers wrote: commit e5321437322fd812b93fee266af309e782479488 Author: Winfried Donkers Date: Thu Aug 22 17:03:58 2013 +0200 get rid of unnecessary warning A value o

Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

2013-08-27 Thread Eike Rathke
Hi Winfried, On Tuesday, 2013-08-27 06:48:28 -0700, Winfried Donkers wrote: > commit e5321437322fd812b93fee266af309e782479488 > Author: Winfried Donkers > Date: Thu Aug 22 17:03:58 2013 +0200 > > get rid of unnecessary warning > > A value of 0 for Opcode eOp produces a debug asse