Re: [Libreoffice] sylk unit tests

2011-07-19 Thread Maciej Rumianowski
Hi Michael, > Hey ! - so unit tests are -never- useless, particularly if they are > fast, small and run during the build. Indeed - I would -love- to have > much more unit test coverage of calc. I also like the Idea of unit tests and an Easy Hack with calc unit tests is on my radar :) >

Re: [Libreoffice] sylk unit tests

2011-07-19 Thread Michael Meeks
Hi there, On Sun, 2011-07-17 at 18:50 +0200, Maciej Rumianowski wrote: > > Hmm, well I've now added a sylk import unit test to sc, i.e. > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8ac49ef8ab4f065d7b729dcb15505c602c77 > > > > Thanks, but as Nigel pointed out it's hard to unit

Re: [Libreoffice] sylk unit tests

2011-07-17 Thread Maciej Rumianowski
Hi Caolán, > Hmm, well I've now added a sylk import unit test to sc, i.e. > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8ac49ef8ab4f065d7b729dcb15505c602c77 > Thanks, but as Nigel pointed out it's hard to unit test every peace of LO and I don't think my small change is worth it.

[Libreoffice] sylk unit tests

2011-07-13 Thread Caolán McNamara
On Tue, 2011-07-12 at 00:31 +0200, Maciej Rumianowski wrote: > But I wasn't successful using ScImportExport::ImportStream and > ScImportExport::ExportStream, which use Sylk2Doc. Hmm, well I've now added a sylk import unit test to sc, i.e. http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8ac