Hi there, On Sun, 2011-07-17 at 18:50 +0200, Maciej Rumianowski wrote: > > Hmm, well I've now added a sylk import unit test to sc, i.e. > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8ac49ef8ab4f065d7b7277779dcb15505c602c77 > > > > Thanks, but as Nigel pointed out it's hard to unit test every peace of > LO and I don't think my small change is worth it.
Hey ! - so unit tests are -never- useless, particularly if they are fast, small and run during the build. Indeed - I would -love- to have much more unit test coverage of calc. > Later on I will mail my Patch "getting rid of SvULongs in calc". It would be simply excellent if we could find a way of doing this. One thing I would strongly recommend is not trying to create your own, stand-alone unit test harness, but instead building on top of an existing test by adding a new test method in sc/qa/unit/ucalc.cxx :-) [ indeed, reading that it is encouraging to see the growth in unit-testage there particularly for data-pilots etc. ;-]. Anyhow - thanks for your work ! Regards, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice