On Thu, 2011-07-21 at 10:00 +0200, Fridrich Strba wrote:
> I need several reviews to get these two fixes to the 3-4-2 branch.
Ack'd both fixes - much cleaner than this (::std::max)(a,b) type
ugliness IMHO :-) I'd also love to drop the mdds patch that added those.
Thanks,
Hello, good people,
I need several reviews to get these two fixes to the 3-4-2 branch.
http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?h=libreoffice-3-4
(2 reviews)
and
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=a027bee4bb2565f14eb70c4325592b23a86c007a
(3 review
Hi Tor,
On Tue, 2011-07-19 at 08:45 -0600, Tor Lillqvist wrote:
> This seems to fix fdo#34805. If I understand correctly, the autosave
> files are always written in ODF formats, but the recovery code still
> tried to load them using the filter for the original document.
:-)
> It should o
This seems to fix fdo#34805. If I understand correctly, the autosave files are
always written in ODF formats, but the recovery code still tried to load them
using the filter for the original document. That caused the bug, for the
specific case described in the initial bug report, it tried to use
On Tue, Jul 19, 2011 at 02:35:42PM +0200, Markus Mohrhard wrote:
> Hello David,
>
> I think the original version should be safe. Our formula api can't deal with
> broken documents during import especially the oox import can't deal with
> errors of any kinds in formulas. But a broken document won't
Hello David,
I think the original version should be safe. Our formula api can't deal with
broken documents during import especially the oox import can't deal with
errors of any kinds in formulas. But a broken document won't create a crash
only a #Name entry in the cell that is not correct.
I know
On Tue, Jul 19, 2011 at 04:29:32PM +0530, Muthu Subramanian K wrote:
> Hi,
>
> +if( maCurrCell.mnSharedId >= 0 )
> +{
> +Reference< XFormulaTokens > xTokens( maCurrCell.mxCell,
> UNO_QUERY_THROW );
> +ExtCellFormulaContext aContext( *this, xTokens,
> maCur
> Looks good to me. Will push it to 3.4.
>
> 2011/7/19 Muthu Subramanian K
>
> > Hi,
> >
> > It would be great if somebody could review+push the attached patch to
> > 3.4 branch(s). This is _not_ a problem in master.
> > Without this patch shared formula(s) would not be imported correctly in
>
Looks good to me. Will push it to 3.4.
2011/7/19 Muthu Subramanian K
> Hi,
>
> It would be great if somebody could review+push the attached patch to
> 3.4 branch(s). This is _not_ a problem in master.
> Without this patch shared formula(s) would not be imported correctly in
> builds from 3.4 bra
Hi,
It would be great if somebody could review+push the attached patch to
3.4 branch(s). This is _not_ a problem in master.
Without this patch shared formula(s) would not be imported correctly in
builds from 3.4 branches.
Thanks to Markus (moggi) for debugging this to quite some level (and
also f
On Fri, 2011-05-20 at 12:11 -0400, Kohei Yoshida wrote:
> On Fri, 2011-05-20 at 07:48 -0600, Tor Lillqvist wrote:
> > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
>
> > Not marked as a mostly annoying bug, but it is a crasher, so perhaps
> >
On Fri, 2011-05-20 at 07:48 -0600, Tor Lillqvist wrote:
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
> Not marked as a mostly annoying bug, but it is a crasher, so perhaps
> should be cherry-picked to the -3-4 or even -3-4-0 branches?
if
Giving you first signoff and pushing to 3-4
Fridrich
On Fri, 2011-05-20 at 07:48 -0600, Tor Lillqvist wrote:
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
>
> A proper fix would be to make sure the code doesn't even get into a
> situa
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
A proper fix would be to make sure the code doesn't even get into a situation
where it feels the need to try to use elements in an empty vector, but
whatever...
Not marked as a mostly annoying
OK to apply to the branch?
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Please review and cherry-pick to libreoffice-3-4. I have verified that it
doesn't break the installer. The two files in question are not needed; we have
no idea in what situation they are supposed to be run by the user and/or
sysadmin. And rebasegui.exe (which just displays some information) doe
Hi Tor
On 04/02/11 15:34, Tor Lillqvist wrote:
I would like to cherry-pick that to libreoffice-3-3. (Otherwise it can't be
built on Windows with a recent DirectX SDK.)
looks ok to me, I would say go for it
___
LibreOffice mailing list
LibreOffice@l
I would like to cherry-pick that to libreoffice-3-3. (Otherwise it can't be
built on Windows with a recent DirectX SDK.)
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
> However - I would like to do the same thing in the toolbar code:
I don't notice the same kind of lagginess in the toolbars, so maybe not for
3.3.0. For 3.3 and master, yes, go ahead.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freede
Pushed to libreoffice-3-3 and libreoffice-3-3-0. Not master yet, we should do
even bigger cleanups of the related messy places there.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/lib
Signoff me :)
F.
On Tue, 2011-01-18 at 06:36 -0700, Tor Lillqvist wrote:
> Thorsten asked for an actual diff, so here:
>
> diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
> index e4e2716..e269766
> --- a/vcl/source/window/menu.cxx
> +++ b/vcl/source/window/menu.cxx
> @@ -11
Tor Lillqvist wrote:
> diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
> index e4e2716..e269766
> --- a/vcl/source/window/menu.cxx
> +++ b/vcl/source/window/menu.cxx
> @@ -1119,9 +1119,6 @@ void Menu::Highlight()
> if ( pStartMenu && ( pStartMenu != this ) )
>
On Tue, 2011-01-18 at 06:36 -0700, Tor Lillqvist wrote:
> Thorsten asked for an actual diff, so here:
You have an approval from me.
However - I would like to do the same thing in the toolbar code:
diff --git a/vcl/source/window/toolbox2.cxx
b/vcl/source/window/toolbox2.cxx
index
On Tue, 2011-01-18 at 06:36 -0700, Tor Lillqvist wrote:
> Thorsten asked for an actual diff, so here:
>
> diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
> index e4e2716..e269766
> --- a/vcl/source/window/menu.cxx
> +++ b/vcl/source/window/menu.cxx
> @@ -1119,9 +1119,6 @@ void
Thorsten asked for an actual diff, so here:
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index e4e2716..e269766
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -1119,9 +1119,6 @@ void Menu::Highlight()
if ( pStartMenu && ( pStartMenu != this )
See https://bugs.freedesktop.org/show_bug.cgi?id=33088#c23
I would like to remove two lines of code from Menu::Highlight() in
(libs-gui/)vcl/source/window/menu.cxx in the libreoffice-3-3 and
libreoffice-3-3-0 branches.
(Not maybe in master, yet, in the hope that either the OOO people will fix t
Jan Holesovsky píše v Út 18. 01. 2011 v 10:37 +0100:
> Hi Fridrich,
>
> On 2011-01-18 at 10:22 +0100, Thorsten Behrens wrote:
>
> > > -::SolarMuexGuard aGuard;
> > > +::SolarMutexGuard aGuard;
> > >
> > Of course, fine by me.
>
> You have my OK too.
Sure, go for it.
Best Regards,
Pe
Hi Fridrich,
On 2011-01-18 at 10:22 +0100, Thorsten Behrens wrote:
> > -::SolarMuexGuard aGuard;
> > +::SolarMutexGuard aGuard;
> >
> Of course, fine by me.
You have my OK too.
Regards,
Kendy
___
LibreOffice mailing list
LibreOffice@lists.f
OK from me.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
> -::SolarMuexGuard aGuard;
> +::SolarMutexGuard aGuard;
>
Of course, fine by me.
-- Thorsten
pgpnzEQsJeCI7.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/lis
>From a8b9ca32a544bdd6b6feae334cf3799f15ed6361 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fridrich=20=C5=A0trba?=
Date: Tue, 18 Jan 2011 09:38:53 +0100
Subject: [PATCH] Fix a typo SolarMuexGuard -> SolarMutexGuard
---
binfilter/bf_so3/source/ole/socli.cxx |2 +-
1 files changed, 1 insertions
Okay if you ask me.
KAMI
2011-01-14 18:15 keltezéssel, Tor Lillqvist írta:
>> Good point! I've attached two additional patches to cover the
>> extensions and sw modules.
> I approve all three.
>
> --tml
>
signature.asc
Description: OpenPGP digital signature
___
> Good point! I've attached two additional patches to cover the
> extensions and sw modules.
I approve all three.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Fri, 2011-01-14 at 17:46 +0100, Kálmán „KAMI” Szalai wrote:
> It is right! +1
>
> However we might have to change all of these files:
>
> ./writer/sw/uiconfig/swform/menubar/menubar.xml
> ./writer/sw/uiconfig/swxform/menubar/menubar.xml
> ./writer/sw/uiconfig/swreport/menubar/menubar.xml
> ./b
It is right! +1
However we might have to change all of these files:
./writer/sw/uiconfig/swform/menubar/menubar.xml
./writer/sw/uiconfig/swxform/menubar/menubar.xml
./writer/sw/uiconfig/swreport/menubar/menubar.xml
./base/dbaccess/uiconfig/dbtdata/menubar/menubar.xml
./components/extensions/sourc
Hi there,
I'd like my patch attached in
https://bugs.freedesktop.org/show_bug.cgi?id=33112
reviewed for the inclusion for the 3.3.0 branch, which needs three
sign-offs.
The patch simply removes one 'Registration...' menu item from Base's
data view window. It's simple & safe.
Thanks!
Kohei
On Thu, 2011-01-13 at 17:04 +, Caolán McNamara wrote:
> Well, it looks reasonable, I can't be completely sure though. Still, go
> for it I say, but someone else will have to merge it in for the moment.
Pushed to libreoffice-3-3-0 and libreoffice-3-3.
Thanks,
On Wed, 2011-01-12 at 10:57 +, Michael Meeks wrote:
> Caolan - can you give it a 3rd review and merge it if you're happy :-)
> If we're not completely ecstatic about it perhaps libreoffice-3-3 would
> be adequate.
Well, it looks reasonable, I can't be completely sure though. Still, go
fo
On Thu, 2011-01-13 at 08:50 +0100, Jonathan Aquilina wrote:
> Not trying to hijack, but i'm still a novice developer still learning
> the ways of development, but is there such a thing as over optimization?
Certainly :-) eg. writing in-line assembly for the "button clicked"
method (or an
Not trying to hijack, but i'm still a novice developer still learning
the ways of development, but is there such a thing as over optimization?
On 1/12/11 7:36 PM, Noel Power wrote:
On 12/01/11 18:03, Norbert Thiebaud wrote:
On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez
wrote:
On Wed, 12
On 12/01/11 18:03, Norbert Thiebaud wrote:
On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez
wrote:
On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote:
Hi there
fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is
riskless etc.
http://cgit.freedesktop.org/libreoffic
On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez
wrote:
> On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote:
>
>> Hi there
>>
>> fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is
>> riskless etc.
>>
>>
>> http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe22660
On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote:
Hi there
fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is
riskless etc.
http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daacead0e1
is ripe for signoff and cherrypicking, be g
Hi Noel,
On Wed, 2011-01-12 at 11:18 +, Noel Power wrote:
> fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is
> riskless etc.
wow - that is a surprising code flow :-)
> http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daace
Hi there
fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is
riskless etc.
http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daacead0e1
is ripe for signoff and cherrypicking, be grateful if someone could help
with that
thanks,
Noel
On Tue, 2011-01-11 at 20:29 +0100, Cedric Bosdonnat wrote:
> I'ld like to get a crasher fix around the enhanced fields into
> libreoffice-3-3 branch...
..
> Could anyone review and cherry-pick this commit?
> http://cgit.freedesktop.org/libreoffice/writer/commit/?id=0921bd5dc88dfd212fc5a332e0902347
Hello,
I'ld like to get a crasher fix around the enhanced fields into
libreoffice-3-3 branch...
Could anyone review and cherry-pick this commit?
http://cgit.freedesktop.org/libreoffice/writer/commit/?id=0921bd5dc88dfd212fc5a332e0902347377be119
Thanks,
--
Cédric Bosdonnat
LibreOffice hacker
htt
Hi All,
Few days ago I sent patches for LibreOffice (and OxygenOffice-only
related changes). Can you review and push them?
From:
http://lists.freedesktop.org/archives/libreoffice/2010-December/author.html
Subjects are:
[PATCH] Updates for LightProof extension handling
[PATCH] Fix-font-assignatio
Norbert Thiebaud wrote:
> The attached patches are pending... I am submitting them to the list
> for comments or objections before pushing them.
>
Hi Norbert - patches seem to be pushed - many thanks for the
cleanup!
Cheers,
-- Thorsten
pgp52GbxTjXhW.pgp
Description: PGP signature
On Sun, 2010-10-31 at 23:07 -0500, Norbert Thiebaud wrote:
> The attached patches are pending... I am submitting them to the list
> for comments or objections before pushing them.
Looks reasonable to me anyway, most of this is in toolkit, maybe
Thorsten can have a double-check of that as I'd guess
50 matches
Mail list logo
