Re: [Libreoffice] Mi first very little patch

2011-09-20 Thread CaStarCo
2011/9/20 Lionel Elie Mamane > On Mon, Sep 12, 2011 at 10:45:31PM +0200, CaStarCo wrote: > > > @Lionel , What is the QuadPart member of the structure? The high > > part? the low part? or another thing? > > The union is fully described at > http://msdn.microsoft.com/en-us/library/aa383713(v=vs.85)

Re: [Libreoffice] Mi first very little patch

2011-09-20 Thread Lionel Elie Mamane
On Mon, Sep 12, 2011 at 10:45:31PM +0200, CaStarCo wrote: > @Lionel , What is the QuadPart member of the structure? The high > part? the low part? or another thing? The union is fully described at http://msdn.microsoft.com/en-us/library/aa383713(v=vs.85).aspx Are you familiar with the concept of

Re: [Libreoffice] Mi first very little patch

2011-09-12 Thread CaStarCo
@Lionel , What is the QuadPart member of the structure? The high part? the low part? or another thing? Thanks in advance :) . 2011/9/12 Lionel Elie Mamane > On Sun, Sep 11, 2011 at 10:04:52PM +0200, CaStarCo wrote: > > I've created a second (very little too) patch to reduce the scope of a > > v

Re: [Libreoffice] Mi first very little patch

2011-09-12 Thread CaStarCo
Thanks you very much :) , I'll take a look and try to make better patches. And, of course, all my patches will be licensed under MPL1.1/LGPLv3+ . ^_^ . ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/li

Re: [Libreoffice] Mi first very little patch

2011-09-12 Thread Stephan Bergmann
On 09/12/2011 01:03 AM, Lionel Elie Mamane wrote: On Sun, Sep 11, 2011 at 10:04:52PM +0200, CaStarCo wrote: I've created a second (very little too) patch to reduce the scope of a variable. --- a/sal/osl/w32/file_dirvol.cxx +++ b/sal/osl/w32/file_dirvol.cxx @@ -60,7 +60,6 @@ extern "C" BOOL Ti

Re: [Libreoffice] Mi first very little patch

2011-09-11 Thread Lionel Elie Mamane
On Sun, Sep 11, 2011 at 10:04:52PM +0200, CaStarCo wrote: > I've created a second (very little too) patch to reduce the scope of a > variable. > --- a/sal/osl/w32/file_dirvol.cxx > +++ b/sal/osl/w32/file_dirvol.cxx > @@ -60,7 +60,6 @@ extern "C" BOOL TimeValueToFileTime(const TimeValue > *cpTimeV

Re: [Libreoffice] Mi first very little patch

2011-09-11 Thread Norbert Thiebaud
On Sun, Sep 11, 2011 at 2:39 PM, CaStarCo wrote: > Hello, I've created a very little patch to solve the next CppCheck warning ( > http://libreoffice.boldandbusted.com/464.html ) . (This is my first patch in > LibreOffice) Welcome to libreoffice and thanks for the patch. Unfortunately you got the

Re: [Libreoffice] Mi first very little patch

2011-09-11 Thread CaStarCo
Ups :( , my patch introduced a bug, it's not valid. 2011/9/11 CaStarCo > Hello, I've created a very little patch to solve the next CppCheck warning > ( http://libreoffice.boldandbusted.com/464.html ) . (This is my first > patch in LibreOffice) > > -- - Per la llibertat del coneixement - - Per

Re: [Libreoffice] Mi first very little patch

2011-09-11 Thread CaStarCo
I've created a second (very little too) patch to reduce the scope of a variable. From 7c434fd7af9892fee7b120e00a135d01693265af Mon Sep 17 00:00:00 2001 From: Andreu Correa Casablanca Date: Sun, 11 Sep 2011 22:01:10 +0200 Subject: [PATCH] Reduced the scope of a variable in core/sal/osl/w32/file_dir

[Libreoffice] Mi first very little patch

2011-09-11 Thread CaStarCo
Hello, I've created a very little patch to solve the next CppCheck warning ( http://libreoffice.boldandbusted.com/464.html ) . (This is my first patch in LibreOffice) From b7646c6393ae557c9f3e11ea68651fca0589360c Mon Sep 17 00:00:00 2001 From: Andreu Correa Casablanca Date: Sun, 11 Sep 2011 21:28: