On 09/12/2011 01:03 AM, Lionel Elie Mamane wrote:
On Sun, Sep 11, 2011 at 10:04:52PM +0200, CaStarCo wrote:
I've created a second (very little too) patch to reduce the scope of a
variable.

--- a/sal/osl/w32/file_dirvol.cxx
+++ b/sal/osl/w32/file_dirvol.cxx
@@ -60,7 +60,6 @@ extern "C" BOOL TimeValueToFileTime(const TimeValue 
*cpTimeVal, FILETIME *pFTime

Thank you for your contribution to LibreOffice, it is most
welcome. Looking at that function in that file, it needs a more
thorough cleanup, and maybe other functions in that file and/or in
other files in the same directory; see
http://msdn.microsoft.com/en-us/library/ms724284%28v=VS.85%29.aspx, in
particular:
[...]

Also, the scope of localTime can be reduced even further, changing the line that assigns it into also declaring it, as in

  __int64 localTime = cpTimeVal->...;

-Stephan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to