Hi Kohei
On 29/07/11 15:59, Kohei Yoshida wrote:
after applying your patch, because, before your change, FillScRange was
called first *then* xModel was assigned an instance, but you got them
flipped in your new code.
aha gottcha
This may not affect anything but I've seen in the past a differen
On Fri, 2011-07-29 at 11:26 +0100, Noel Power wrote:
> If I understand what you mean then I think it is the patch output is
> confusing things
Hmm... I'm not sure about that. Basically what I was suggesting was to
make the following change
--- a/sc/source/ui/vba/vbarange.cxx
+++ b/sc/source/ui
On 29/07/11 11:49, Caolán McNamara wrote:
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=38cae5f0a09508f48825a7049cb1508b0251fbf0
is apparently the commit that removed the last use of the three argument
CopyRangeNamesToClip variant.
C.
And needless to say that this really is a valid fin
On 29/07/11 11:49, Caolán McNamara wrote:
On Fri, 2011-07-29 at 11:36 +0100, Noel Power wrote:
On 29/07/11 10:40, Caolán McNamara wrote:
Are you sure? on master ScDocument::CopyRangeNamesToClip(ScDocument*
pClipDoc, const ScRange& rClipRange, SCTAB nTab) was changed to
ScDocument::CopyRangeNam
On Fri, 2011-07-29 at 11:36 +0100, Noel Power wrote:
> On 29/07/11 10:40, Caolán McNamara wrote:
> > On Thu, 2011-07-28 at 12:48 -0400, Kohei Yoshida wrote:
> >> Ok. So, I did verify that that particular ScViewFunc::CopyToClip()
> >> method
> > Maybe unrelated but I saw the word "Clip" and I see th
On 29/07/11 10:40, Caolán McNamara wrote:
On Thu, 2011-07-28 at 12:48 -0400, Kohei Yoshida wrote:
Ok. So, I did verify that that particular ScViewFunc::CopyToClip()
method
Maybe unrelated but I saw the word "Clip" and I see that the three
argument
void ScDocument::CopyRangeNamesToClip(ScDocume
Hi Kohei
On 28/07/11 17:48, Kohei Yoshida wrote:
Hi Noel,
[...]
where these lines ScUnoConversion::FillScRange( aRange,
thisRange.getCellRangeAddressable()->getRangeAddress() );
uno::Reference< frame::XModel > xModel = excel::GetModelFromRange(
mxRange );and the line are flipped before and a
On Thu, 2011-07-28 at 12:48 -0400, Kohei Yoshida wrote:
> Ok. So, I did verify that that particular ScViewFunc::CopyToClip()
> method
Maybe unrelated but I saw the word "Clip" and I see that the three
argument
void ScDocument::CopyRangeNamesToClip(ScDocument* pClipDoc, const
ScRange& rClipRange,
Hi Noel,
On Wed, 2011-07-27 at 20:08 +0100, Noel Power wrote:
> Hi Kohei,
>
> On 27/07/11 19:23, Kohei Yoshida wrote:
> > Hi Noel,
> >
> > On Wed, 2011-07-27 at 11:50 +0100, Noel Power wrote:
> >> I would really like to get this patch into 3.4,
> [...]
> > Hmm... did you forget to attach your pat
Hi Kohei,
On 27/07/11 19:23, Kohei Yoshida wrote:
Hi Noel,
On Wed, 2011-07-27 at 11:50 +0100, Noel Power wrote:
I would really like to get this patch into 3.4,
[...]
Hmm... did you forget to attach your patch by any chance?
yes, ouch I did forget :-) ( although it is attached to the bug )
Hi Noel,
On Wed, 2011-07-27 at 11:50 +0100, Noel Power wrote:
> I would really like to get this patch into 3.4, the patch affects vba
> related calls only and imo safe. Basically the patch allows copy to work
> for appropriate multi-area ranges. The core calc function 'CopyToClip'
> variant tha
I would really like to get this patch into 3.4, the patch affects vba
related calls only and imo safe. Basically the patch allows copy to work
for appropriate multi-area ranges. The core calc function 'CopyToClip'
variant that is modified is used *only* by vba api implementation code
so shouldn
12 matches
Mail list logo
