On Fri, 2011-07-29 at 11:26 +0100, Noel Power wrote:
> If I understand what you mean then I think it is the patch output is
> confusing things
Hmm... I'm not sure about that. Basically what I was suggesting was to
make the following change
--- a/sc/source/ui/vba/vbarange.cxx
+++ b/sc/source/ui/vba/vbarange.cxx
@@ -2629,8 +2629,8 @@ ScVbaRange::Copy(const ::uno::Any& Destination) throw
(uno::RuntimeException)
{
ScRange aRange;
RangeHelper thisRange( mxRange );
- uno::Reference< frame::XModel > xModel = excel::GetModelFromRange(
mxRange );
ScUnoConversion::FillScRange( aRange,
thisRange.getCellRangeAddressable()->getRangeAddress() );
+ uno::Reference< frame::XModel > xModel = excel::GetModelFromRange(
mxRange );
excel::implnCopyRange( xModel, aRange );
}
}
after applying your patch, because, before your change, FillScRange was
called first *then* xModel was assigned an instance, but you got them
flipped in your new code.
This may not affect anything but I've seen in the past a difference of
night and day just by re-ordering two lines of code, so I have my own
reason to be paranoid. ;-)
I hope I'm making sense....
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kyosh...@novell.com>
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
