Re: [Libreoffice] [REVIEW] [3-5][3-5-0] problems with encryption if thunderbird is installed

2012-02-02 Thread Noel Power
On 02/02/12 16:02, Stephan Bergmann wrote: On 02/02/2012 04:56 PM, Kohei Yoshida wrote: Pushed to 3-5 with my sign-off. We need 2 more sign-off's for 3-5-0. Are we still pushing to -3-5-0? In which case, you have my sign-off. think it's too late by me too if I'm wrong __

Re: [Libreoffice] [REVIEW] [3-5][3-5-0] problems with encryption if thunderbird is installed

2012-02-02 Thread Stephan Bergmann
On 02/02/2012 04:56 PM, Kohei Yoshida wrote: Pushed to 3-5 with my sign-off. We need 2 more sign-off's for 3-5-0. Are we still pushing to -3-5-0? In which case, you have my sign-off. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedeskto

Re: [Libreoffice] [REVIEW] [3-5][3-5-0] problems with encryption if thunderbird is installed

2012-02-02 Thread Kohei Yoshida
On Thu, 2012-02-02 at 01:01 +0100, Markus Mohrhard wrote: > >> Another easy solution to improve the situation might be to increase > >> the timeout in MNSInit.cxx:235 from 1 to 10 or even 100, but I think > >> that is more a workaround than fixing the underlying problem. > > > > > > Sounds like th

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

2012-02-01 Thread Petr Mladek
Markus Mohrhard píše v Út 31. 01. 2012 v 21:55 +0100: > Hey, > > 2012/1/31 Kohei Yoshida : > > On Tue, 2012-01-31 at 20:54 +0100, Eike Rathke wrote: > >> Hi Kohei, > >> > >> On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: > >> > >> > Well, for expediting the process (since the release

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

2012-01-31 Thread Markus Mohrhard
Hey, 2012/1/31 Kohei Yoshida : > On Tue, 2012-01-31 at 20:54 +0100, Eike Rathke wrote: >> Hi Kohei, >> >> On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: >> >> > Well, for expediting the process (since the release of 3.5.0 is >> > nearing), could you take this over?  Sounds like you kn

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

2012-01-31 Thread Kohei Yoshida
On Tue, 2012-01-31 at 20:54 +0100, Eike Rathke wrote: > Hi Kohei, > > On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: > > > Well, for expediting the process (since the release of 3.5.0 is > > nearing), could you take this over? Sounds like you know exactly what > > needs to get done,

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

2012-01-31 Thread Eike Rathke
Hi Kohei, On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: > Well, for expediting the process (since the release of 3.5.0 is > nearing), could you take this over? Sounds like you know exactly what > needs to get done, so it's probably better than me trying to figure this > out on my o

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

2012-01-31 Thread Michael Stahl
On 31/01/12 17:31, Lubos Lunak wrote: > On Tuesday 31 of January 2012, Jan Holesovsky wrote: >> As a fix, I propose this: >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d >> e9d9979b5b699e6840454 >> >> Just get rid of the background image; in my opinion, it even loo

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

2012-01-31 Thread Noel Power
On 31/01/12 16:31, Lubos Lunak wrote: On Tuesday 31 of January 2012, Jan Holesovsky wrote: As a fix, I propose this: http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d e9d9979b5b699e6840454 Just get rid of the background image; in my opinion, it even looks better witho

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

2012-01-31 Thread Lubos Lunak
On Tuesday 31 of January 2012, Jan Holesovsky wrote: > As a fix, I propose this: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d >e9d9979b5b699e6840454 > > Just get rid of the background image; in my opinion, it even looks > better without that, and is the least intr

[Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

2012-01-31 Thread Jan Holesovsky
Hi, https://bugs.freedesktop.org/show_bug.cgi?id=42543 When you use the report designer, at some stage you get to a page (step 2) which is blank; but when you click there, you can edit the data. The problem is that commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=efc6b840a0423099d

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-30 Thread Eike Rathke
Hi Kohei, On Friday, 2012-01-27 17:08:14 -0500, Kohei Yoshida wrote: > I'd like to have the attached patch pushed to the 3-5 branch and > preferably to the 3-5-0 branch as well. > > It fixes > > https://bugs.freedesktop.org/show_bug.cgi?id=45084 It seems to fix the symptom and the document is

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-30 Thread Eike Rathke
Hi Caolán, On Monday, 2012-01-30 12:58:29 +, Caolán McNamara wrote: > > https://bugs.freedesktop.org/show_bug.cgi?id=45084 > > With > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=611472edb12ba1d8a38bda1857c952eef0bb3568 > already in place in 3-5-0 to sort the

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-30 Thread Kohei Yoshida
Hi Caolan, On Mon, 2012-01-30 at 12:58 +, Caolán McNamara wrote: > With > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=611472edb12ba1d8a38bda1857c952eef0bb3568 > already in place in 3-5-0 to sort the writer detection to the end of the > list does it work "out-

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-30 Thread Caolán McNamara
On Fri, 2012-01-27 at 17:08 -0500, Kohei Yoshida wrote: > Hi there, > > I'd like to have the attached patch pushed to the 3-5 branch and > preferably to the 3-5-0 branch as well. > > It fixes > > https://bugs.freedesktop.org/show_bug.cgi?id=45084 With http://cgit.freedesktop.org/libreoffice/co

Re: [Libreoffice] [REVIEW 3-5, 3-5-0]

2012-01-30 Thread Michael Stahl
On 28/01/12 13:53, Fridrich Strba wrote: > Hello, a little safe patch that prevents that "compatibility symbol" we > added for backward compatibility with older versions of Duden Korrektor > from landing in the uwinapi.lib import library. This assures that no > accidental linking with it will ha

[Libreoffice] [REVIEW 3-5, 3-5-0]

2012-01-28 Thread Fridrich Strba
Hello, a little safe patch that prevents that "compatibility symbol" we added for backward compatibility with older versions of Duden Korrektor from landing in the uwinapi.lib import library. This assures that no accidental linking with it will happen inside LO and for applications that would u

[Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-27 Thread Kohei Yoshida
Hi there, I'd like to have the attached patch pushed to the 3-5 branch and preferably to the 3-5-0 branch as well. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=45084 I haven't committed this yet to master, since I wanted to have someone else's opinion first. To the best of my knowled

[Libreoffice] [REVIEW:3-5, 3-5-0] use the correct application icon of Writer/Web under Windows

2012-01-27 Thread Andras Timar
Hi, I made a typo in my soffice.bin/soffice.exe icon reduction patch, so Writer/Web has the wrong application icon under Windows in rc2. The following commit fixes it. http://cgit.freedesktop.org/libreoffice/core/commit/?id=764674700d35d86890e3538039209f0397015096 Not a big deal, but a user has s

[Libreoffice] [REVIEW:3-5, 3-5-0] fix configuration migration on Linux

2012-01-27 Thread Petr Mladek
Hi, we moved the used configuration from ~/.libreoffice to ~/.config/libreoffice between LO-3.4 and 3.5 on Linux. Unfortunately, the old configuration is not migrated. I have finally got time to dig into it again. The result is the attached patch. It works well here. Another solution would be to

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

2012-01-26 Thread Kohei Yoshida
Hi Eike, On Fri, 2012-01-27 at 00:03 +0100, Eike Rathke wrote: > Maybe worth a thought. So, I took a second look at this, and came up with the attached version which I think is better and more correct than the first one. This one will correctly honor the delete note flag, and also maintains the

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

2012-01-26 Thread Kohei Yoshida
On Fri, 2012-01-27 at 00:03 +0100, Eike Rathke wrote: > Further down the pOldCell->ReleaseBroadcaster() and pOldCell->Delete() > would only have to be executed if (pOldCell != pNoteCell) > > Maybe worth a thought. Yeah. This method is one of those convoluted "catch all in one place" type of meth

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

2012-01-26 Thread Kohei Yoshida
On Fri, 2012-01-27 at 00:23 +0100, Eike Rathke wrote: > Hi Kohei, > > On Friday, 2012-01-27 00:03:29 +0100, Eike Rathke wrote: > > > > Then the second part is in ScDPOutput::Output(), where the old content > > > gets removed before writing out a new one. The thing is, this method > > > only gets

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

2012-01-26 Thread Eike Rathke
Hi Kohei, On Friday, 2012-01-27 00:03:29 +0100, Eike Rathke wrote: > > Then the second part is in ScDPOutput::Output(), where the old content > > gets removed before writing out a new one. The thing is, this method > > only gets called from ScDPObject::Output(), and that method already > > delet

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

2012-01-26 Thread Eike Rathke
Hi Kohei, On Thursday, 2012-01-26 16:03:56 -0500, Kohei Yoshida wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=af70bc00c6714eb8695babdf5af07416552f7034 > > cherry-picked to 3-5 and preferably to 3-5-0 as well. IMO this is a > safe change. > > The change consists of two parts.

[Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

2012-01-26 Thread Kohei Yoshida
Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=af70bc00c6714eb8695babdf5af07416552f7034 cherry-picked to 3-5 and preferably to 3-5-0 as well. IMO this is a safe change. The change consists of two parts. The real bug is in the first part (ScColumn::DeleteRan

Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken

2012-01-26 Thread Fridrich Strba
On 26/01/12 15:27, Michael Meeks wrote: Gosh; I'd rather like to know why the explicit code to sort it to the front was there in the first instance. The code was there because that detector is catch-all it will in a certain branch simply not allow anything to be detected any more, so w

Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken

2012-01-26 Thread Michael Meeks
On Thu, 2012-01-26 at 14:40 +0100, Fridrich Strba wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d9aa8cce792d69d5147a2230b61b1cbdc089206 > > fixes a bug where the catch-all type detector was called first in the > list of type detectors when an extension-less document was passe

Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken

2012-01-26 Thread Fridrich Strba
On 26/01/12 14:40, Fridrich Strba wrote: Please, gather enough support for both 3-4 and 3-5-0 branches My bad, the affected code is not in the 3-4 branch and adding it there would be much more intrusive. Cheers F. ___ LibreOffice mailing list Libr

[Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken

2012-01-26 Thread Fridrich Strba
Hello, This patch: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d9aa8cce792d69d5147a2230b61b1cbdc089206 fixes a bug where the catch-all type detector was called first in the list of type detectors when an extension-less document was passed. This caused quite a number of macintosh

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012-01-26 Thread Andras Timar
2012/1/25 Caolán McNamara : > On Wed, 2012-01-25 at 16:44 +0100, Andras Timar wrote: >> Result on Windows is confusing. My test language was Hindi (hi). >> >> Case 1 - without the patch in officecfg >> ... >> default-font entry for "hi" "IN" "" added > ... >> searching for a node for "hi" "" "" for

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012-01-25 Thread Caolán McNamara
On Wed, 2012-01-25 at 16:44 +0100, Andras Timar wrote: > Result on Windows is confusing. My test language was Hindi (hi). > > Case 1 - without the patch in officecfg > ... > default-font entry for "hi" "IN" "" added ... > searching for a node for "hi" "" "" for type UI_SANS > BTW it was not calle

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012-01-25 Thread Andras Timar
2012/1/25 Caolán McNamara : > > So it seems to have been working correctly under Linux anyway. Can > you find out what the value of aLocale is in > OutputDevice::GetDefaultFont under windows for your failing case, i.e. a > trace with the attached patch in place. Result on Windows is confusing. My

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012-01-25 Thread Caolán McNamara
On Wed, 2012-01-25 at 12:03 +, Caolán McNamara wrote: > Anyway, best would be to find the bit of locale matching code and see > why it doesn't do the right thing The default fonts get selected via OutputDevice::GetDefaultFont in vcl/source/gdi/outdev3.cxx which calls DefaultFontConfiguration::

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012-01-25 Thread Caolán McNamara
On Wed, 2012-01-25 at 11:52 +0100, Andras Timar wrote: > Hi, > > Yesterday two bugs came to my attention. > fdo#44208 - under Windows crash occurred when user selected Tools - > Options in selected Indian locales Doesn't seem to be a lot of info wrt backtraces or anything like that in that bug. I

[Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012-01-25 Thread Andras Timar
Hi, Yesterday two bugs came to my attention. fdo#44208 - under Windows crash occurred when user selected Tools - Options in selected Indian locales fdo#45107 - under Windows garbage characters appeared at random places in selected Indian locales I suspected a font issue. Interestingly, these bugs