Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-13 Thread Michael Meeks
On Thu, 2011-01-13 at 08:50 +0100, Jonathan Aquilina wrote: > Not trying to hijack, but i'm still a novice developer still learning > the ways of development, but is there such a thing as over optimization? Certainly :-) eg. writing in-line assembly for the "button clicked" method (or an

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Jonathan Aquilina
Not trying to hijack, but i'm still a novice developer still learning the ways of development, but is there such a thing as over optimization? On 1/12/11 7:36 PM, Noel Power wrote: On 12/01/11 18:03, Norbert Thiebaud wrote: On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez wrote: On Wed, 12

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Noel Power
On 12/01/11 18:03, Norbert Thiebaud wrote: On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez wrote: On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote: Hi there fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is riskless etc. http://cgit.freedesktop.org/libreoffic

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Norbert Thiebaud
On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez wrote: > On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote: > >> Hi there >> >> fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is >> riskless etc. >> >> >> http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe22660

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Octavio Alvarez
On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote: Hi there fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is riskless etc. http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daacead0e1 is ripe for signoff and cherrypicking, be g

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Michael Meeks
Hi Noel, On Wed, 2011-01-12 at 11:18 +, Noel Power wrote: > fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is > riskless etc. wow - that is a surprising code flow :-) > http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daace

[Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-12 Thread Noel Power
Hi there fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is riskless etc. http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daacead0e1 is ripe for signoff and cherrypicking, be grateful if someone could help with that thanks, Noel