Re: [Libreoffice] [REVIEW] Fix for fdo#36667 for 3.4

2011-05-12 Thread Fridrich Strba
Pushed to master and cherry-picked with "-s" to libreoffice-3-4 F. On Wed, 2011-05-11 at 17:36 +0200, Cedric Bosdonnat wrote: > Attached is a patch fixing the sw table formulas update in 3.4. Could > someone review and sign it off? It's a partial revert from > > http://cgit.freedesktop.org/lib

Re: [Libreoffice] [REVIEW] Fix for fdo#36667 for 3.4

2011-05-12 Thread Noel Power
On 11/05/11 16:36, Cedric Bosdonnat wrote: Hi all, Attached is a patch fixing the sw table formulas update in 3.4. Could someone review and sign it off? It's a partial revert from http://cgit.freedesktop.org/libreoffice/writer/commit/?id=2b9726405495529d64e7ab8537ea30119f607d1e The test in the

[Libreoffice] [REVIEW] Fix for fdo#36667 for 3.4

2011-05-11 Thread Cedric Bosdonnat
Hi all, Attached is a patch fixing the sw table formulas update in 3.4. Could someone review and sign it off? It's a partial revert from http://cgit.freedesktop.org/libreoffice/writer/commit/?id=2b9726405495529d64e7ab8537ea30119f607d1e The test in the if, was actually setting pNewVal... which w