Re: [Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239

2011-05-24 Thread Petr Mladek
Cedric Bosdonnat píše v Čt 19. 05. 2011 v 14:51 +0200: > Hi Michael, > > On Thu, 2011-05-19 at 12:21 +0100, Michael Meeks wrote: > > Hi Cedric, > > > > On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: > > > could you please review / push this patch to 3.4 and 3.4.0? It's a > > > simple

Re: [Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239

2011-05-19 Thread Bjoern Michaelsen
On Thu, 19 May 2011 12:44:08 +0200 Cedric Bosdonnat wrote: > could you please review / push this patch to 3.4 and 3.4.0? It's a > simple fix that would save quite some crashes. Looks good. I would prefer an explicit if instead of a ternary operators for readability next time, but that might be a

Re: [Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239

2011-05-19 Thread Cedric Bosdonnat
Hi Michael, On Thu, 2011-05-19 at 12:21 +0100, Michael Meeks wrote: > Hi Cedric, > > On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: > > could you please review / push this patch to 3.4 and 3.4.0? It's a > > simple fix that would save quite some crashes. > > Looks fine to me - o

Re: [Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239

2011-05-19 Thread Tor Lillqvist
+1 from me. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239

2011-05-19 Thread Michael Meeks
Hi Cedric, On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: > could you please review / push this patch to 3.4 and 3.4.0? It's a > simple fix that would save quite some crashes. Looks fine to me - of course I'd prefer: -xub_StrLen nEndPos = rEnd == rStart ? rEnd.nConten

[Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239

2011-05-19 Thread Cedric Bosdonnat
Hi all, could you please review / push this patch to 3.4 and 3.4.0? It's a simple fix that would save quite some crashes. Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr >From dad2c6ac2dba139364b93cb7