Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

2012-01-31 Thread Tommy
On Mon, 30 Jan 2012 22:35:46 +0100, Kohei Yoshida wrote: Hi, I'd like http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 cherry-picked to the 3-5 branch. It is probably too late for change like this to be in the 3-5-0 branch so I won't even tr

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

2012-01-31 Thread Kohei Yoshida
Hi Eike, On Tue, 2012-01-31 at 14:27 +0100, Eike Rathke wrote: > Hi Kohei, > > On Monday, 2012-01-30 16:35:46 -0500, Kohei Yoshida wrote: > > > I'd like > > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 > > > > cherry-picked to the 3-5 bra

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

2012-01-31 Thread Eike Rathke
Hi Kohei, On Monday, 2012-01-30 16:35:46 -0500, Kohei Yoshida wrote: > I'd like > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 > > cherry-picked to the 3-5 branch. It is probably too late for change > like this to be in the 3-5-0 branch so

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

2012-01-31 Thread Michael Meeks
On Mon, 2012-01-30 at 16:35 -0500, Kohei Yoshida wrote: > increases its reference counter by one. The problem is, this counter is > unsigned 16-bit integer, and as soon as it goes above 65535 it rolls > back to zero, and eventually the token instance gets deleted > prematurely. Wow - tha

[Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

2012-01-30 Thread Kohei Yoshida
Hi, I'd like http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 cherry-picked to the 3-5 branch. It is probably too late for change like this to be in the 3-5-0 branch so I won't even try. To reproduce the problem, open the following file in Calc