Re: [Libreoffice] [PATCH] starmath: check for existing edit window

2011-07-15 Thread Jonas Finnemann Jensen
> > Please let me know if it looks problematic Looks great :) -- Regards Jonas Finnemann Jensen. On Fri, Jul 15, 2011 at 18:25, Miklos Vajna wrote: > Hi Jonas, > > On Fri, Jul 15, 2011 at 01:45:42PM +0200, Jonas Finnemann Jensen < > jop...@gmail.com> wrote: > > Your patch looks good, have you

Re: [Libreoffice] [PATCH] starmath: check for existing edit window

2011-07-15 Thread Miklos Vajna
Hi Jonas, On Fri, Jul 15, 2011 at 01:45:42PM +0200, Jonas Finnemann Jensen wrote: > Your patch looks good, have you pushed it? I just did so. > I don't think it hides a deeper problem (except lack of comments :) ), as > far as I remember there're other places where pViewShell->GetEditWindow()

Re: [Libreoffice] [PATCH] starmath: check for existing edit window

2011-07-15 Thread Jonas Finnemann Jensen
Hi, Your patch looks good, have you pushed it? - Otherwise please do, my LibreOffice clone isn't up to date at the moment :( in case my patch would just hide a deeper problem. I don't think it hides a deeper problem (except lack of comments :) ), as far as I remember there're other places where

[Libreoffice] [PATCH] starmath: check for existing edit window

2011-07-14 Thread Miklos Vajna
Hi, When I try to open http://people.freedesktop.org/~vmiklos/math.word2007.docx on master (with experimanl features disabled, so the inline formula editor is disabled), double-click on the math formula, Math opens, finally I click on the formula, Math crashes. The attached patch fixes the proble