Hi, Your patch looks good, have you pushed it? - Otherwise please do, my LibreOffice clone isn't up to date at the moment :(
in case my patch would just hide a deeper problem. I don't think it hides a deeper problem (except lack of comments :) ), as far as I remember there're other places where pViewShell->GetEditWindow() is NULL tested. Also the method explicity returns NULL when the edit window doesn't exists (I'm guessing either not created yet, or disabled). - So I think it's okay. By the way, nice to see that you're working GSoC again this year. -- Regards Jonas Finnemann Jensen. On Thu, Jul 14, 2011 at 16:50, Miklos Vajna <vmik...@frugalware.org> wrote: > Hi, > > When I try to open > http://people.freedesktop.org/~vmiklos/math.word2007.docx on master > (with experimanl features disabled, so the inline formula editor is > disabled), double-click on the math formula, Math opens, finally I click > on the formula, Math crashes. > > The attached patch fixes the problem here, but I'm sending it for review > as I'm totally unfamiliar with the starmath code - in case my patch > would just hide a deeper problem. > > Thanks. >
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
