On Tue, Jul 19, 2011 at 11:06:49AM +0200, Maciej Rumianowski wrote:
> Hi Kohei,
> > 4) Last but not least, please state that you are submitting your patches
> > under LGPLv3+/MPL 1.1.
>
> Of course and future also.
Hi, could you add yourself to
http://wiki.documentfoundation.org/Development/Devel
Hi Maciej,
On Wed, Jul 20, 2011 at 5:24 PM, Maciej Rumianowski
wrote:
> I'm working further on Bug 38831 - [EasyHack] Get rid of SV_DECL_VARARR,
> SV_DECL_VARARR_PLAIN, SV_DECL_VARARR_SORT ...
>
> Where can I mark that I'm working on it? In Bug comments?
Well, you can probably just mention that
Dnia 2011-07-20, śro o godzinie 17:12 -0400, Kohei Yoshida pisze:
>
> So, I've reviewed your revised patches and they look good. I've
> pushed
> them to master with one minor syntactic change.
Great thanks :)
> Anyway, thanks for your patches again, and we look forward to
> receiving
> more pat
On Tue, 2011-07-19 at 11:06 +0200, Maciej Rumianowski wrote:
> Hi Kohei,
Hi Maciej,
So, I've reviewed your revised patches and they look good. I've pushed
them to master with one minor syntactic change.
I've changed in ScTabViewShell::Execute()
if ( aIndexList.size() )
to
if ( !aIndexLis
Hi Kohei,
Thanks for review!
> First, for your svl patch:
>
> 1) in SfxIntegerListItem::GetList(), you do
>
> +rList.insert( aIt, m_aList[n] );
>
> but you can simply call push_back here to append new data to the end of
> the vector. Also, let's use pre-increment on iterators in the "f
Hi Maciej,
First of all, thanks for submitting your patches. I've done my review
of both of your patches, and I'll leave my comments below.
First, for your svl patch:
1) in SfxIntegerListItem::GetList(), you do
+rList.insert( aIt, m_aList[n] );
but you can simply call push_back here t
Spotted some mistakes in calc patch.
>From e7db01344f8fef4ca2f2f59868736033d0126b1b Mon Sep 17 00:00:00 2001
From: Maciej Rumianowski
Date: Mon, 18 Jul 2011 09:22:57 +0200
Subject: [PATCH] Get rid of SvULongs in calc
Instead of SvULongs use ::std::vector < sal_uLong >
---
.../itemsetwrapper/Data
Hi,
I'm sending a Patch which converts SvULongs to std::vector < sal_uLong
>.
> I would like to add a constructor
> SfxIntegerListItem::SfxIntegerListItem( const ::com::sun::star::uno::Sequence
> < sal_Int32 > rList ), because DataPointItemConverter and
> SeriesOptionsItemConverter are copying
