On Tue, 2011-07-19 at 11:06 +0200, Maciej Rumianowski wrote: > Hi Kohei,
Hi Maciej, So, I've reviewed your revised patches and they look good. I've pushed them to master with one minor syntactic change. I've changed in ScTabViewShell::Execute() if ( aIndexList.size() ) to if ( !aIndexList.empty() ) For vector both are fine performance-wise though for other STL containers using empty() is faster. But even with vector it's better to make this a habit IMO. Anyway, thanks for your patches again, and we look forward to receiving more patches from you in the future. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc <kyosh...@novell.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
