On Tue, 20 Sep 2011 20:32:57 +0200
Bjoern Michaelsen
wrote:
> As there is quite a bit of meddling involved, I would indeed prefer
> just a revert by now.
As discussed on IRC:
http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4&id=b6b7eb97b48937132638aeeef18270624201a930
On Tue, 20 Sep 2011 00:10:29 -0500
Norbert Thiebaud
wrote:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=ff1c626fa1380c7af5a135f80b45de7e62025eed
That one got reverted on master and is replaced by:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=17a2dcabe15f24567b5b68f92ede6
Hi Norbert, Hi Stephan,
On Mon, 19 Sep 2011 18:14:22 -0500
Norbert Thiebaud
wrote:
> so 3.4 may have accidentally worked because nothing that produce
> delivered Executable was gbuildified... but at least it was
> 'working'... with that patch alone I'm afraid 3.4 may not build
> anymore on MacOS
actually I get further using
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ff1c626fa1380c7af5a135f80b45de7e62025eed
which should probably be ported back to 3.4 too if you keep the
previous patch in.
Norbert
___
LibreOffice mailing list
LibreO
On Mon, Sep 19, 2011 at 5:34 PM, Bjoern Michaelsen
wrote:
> On Mon, 19 Sep 2011 23:20:32 +0200
> Stephan Bergmann
> wrote:
>
>> What good is that backport to 3.4?
>
> Well, it is a clearcut regression (the error was introduced between
> 3.3 and 3.4) and a good fix (even breaking on link is better
On Mon, 19 Sep 2011 23:20:32 +0200
Stephan Bergmann
wrote:
> What good is that backport to 3.4?
Well, it is a clearcut regression (the error was introduced between
3.3 and 3.4) and a good fix (even breaking on link is better than
breaking at runtime) -- so I automatically backported after review
Björn,
What good is that backport to 3.4? For one, the fix turns out to not
work yet (as executables already built using gbuild but only used during
the build itself use a "NONEBIN" token in solenv/gbuild/platform/*.mk
instead of the "NONE" token used in solenv/inc/*.mk, so that
macosx-chang
