On 13/01/2011 22:18, Tor Lillqvist wrote:
The symptom of the bug was that only the first 20 or so languages in
the setup.ini file were recognized. German happens to be among those,
which explains why it worked for Thalion72. Hungarian, Swedish and
Portuguese (Brazil) are not, so they didn't work.
>>> On 2011-01-14 at 15:41, wrote:
> On Thu, Jan 13, 2011 at 3:18 PM, Tor Lillqvist wrote:
>>> So the problem must be in setup.exe, in some cases it fails to understand
>>> that it should use a transform. That is good, because it means we can debug
> it.
>>
>> Which I did. Which was fun. Or at l
On Fri, 2011-01-14 at 07:41 -0600, Norbert Thiebaud wrote:
> f(x)
> while()
> {
> f(x)
> }
I guess: the existing (broken) code did that, and we're making minimal
changes in libreoffice-3-3-0 which this targetted for.
Then again; on master we should make it beautiful, obviousl
On Thu, Jan 13, 2011 at 3:18 PM, Tor Lillqvist wrote:
>> So the problem must be in setup.exe, in some cases it fails to understand
>> that it should use a transform. That is good, because it means we can debug
>> it.
>
> Which I did. Which was fun. Or at least entertaining. The code in
> libs-co
Hi Tor,
On Thu, 2011-01-13 at 14:18 -0700, Tor Lillqvist wrote:
> Which I did. Which was fun. Or at least entertaining.
Great catch and analysis (and speed) :-) patch looks ok to me; though I
would prefer:
+while ( nRet && ( nRet + 2 == rSize ) ) // buffer was too small, retry
until
On 13/01/11 21:18, Tor Lillqvist wrote:
So the problem must be in setup.exe, in some cases it fails to understand
that it should use a transform. That is good, because it means we can debug it.
[...]
The symptom of the bug was that only the first 20 or so languages in the
setup.ini file were r
Good for me, go for it!
On Thu, 2011-01-13 at 14:18 -0700, Tor Lillqvist wrote:
> > So the problem must be in setup.exe, in some cases it fails to understand
> > that it should use a transform. That is good, because it means we can debug
> > it.
>
> Which I did. Which was fun. Or at least ente
Tor Lillqvist wrote:
> Please review the patch. Three approvals are needed to get this
> into the 3.3 installer.
>
Approved from my side.
-- Thorsten
pgpaOhFsALG2r.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedeskt
> So the problem must be in setup.exe, in some cases it fails to understand
> that it should use a transform. That is good, because it means we can debug
> it.
Which I did. Which was fun. Or at least entertaining. The code in
libs-core/desktop/win32/source/setup/setup.cpp is, what shall I say,
