https://bugs.documentfoundation.org/show_bug.cgi?id=90290
jan iversen changed:
What|Removed |Added
Whiteboard| target:5.2.0 |ToBeReviewed
--
You are receiving
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #20 from Commit Notification
---
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":
http://cgit.freedesktop.org/libreoffice/core/commit/?id=aaa7b7c87dc0d685e2a0edf2763aaeacd2d6e579
tdf#9
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
Commit Notification changed:
What|Removed |Added
Whiteboard|| target:5.2.0
--
You are r
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
Eike Rathke changed:
What|Removed |Added
Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #18 from Commit Notification
---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b36dbb499e19fe8a497a48d7c78ad3cb5d40a83d
Revert "t
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
Commit Notification changed:
What|Removed |Added
Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #17 from Commit Notification
---
ritztro committed a patch related to this issue.
It has been pushed to "master":
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab9663ed187ba4776d9ff3d9c21f83eed478a268
tdf#90290 red
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #16 from David Tardon ---
(In reply to Brent Ritzema from comment #15)
> I have submitted a patch to gerrit for this, however I will amend what I did
> to accommodate these new suggestions. I will use CPPUNIT_ASSERT_MESSAGE
> i
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #15 from Brent Ritzema ---
I have submitted a patch to gerrit for this, however I will amend what I did to
accommodate these new suggestions. I will use CPPUNIT_ASSERT_MESSAGE instead.
However I will be gone these next few days
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #14 from Markus Mohrhard ---
(In reply to David Tardon from comment #13)
> (In reply to Markus Mohrhard from comment #0)
> > ucalc is one of the mail calc tests and is split between many files in
> > sc/qa/unit
> >
> > This ta
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
David Tardon changed:
What|Removed |Added
CC||dtar...@redhat.com
--- Comment #13
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #12 from Tor Lillqvist ---
Brent: The line number and file name in messages about failed unit tests come
(in the examples in the initial comment) from where the CPPUNIT_FAIL macro is
called. So if CPPUNIT_FAIL is moved into som
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #11 from Brent Ritzema ---
Okay thank you for the information. However, I am also a GSOC hopeful haha :).
I have submitted a patch however I can submit another one that will use your
suggestions. I just want to get something in
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
Brent Ritzema changed:
What|Removed |Added
Status|ASSIGNED|NEW
--
You are receiving this ma
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
Tor Lillqvist changed:
What|Removed |Added
Assignee|tapanpraka...@gmail.com |libreoffice-b...@lists.free
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #10 from Tor Lillqvist ---
Re: comment #7, maybe it might be a good idea to add API to cppunit (we are its
upstream now, aren't we?) that also take an explicit line number, so that the
checkFormula(*m_pDoc, aPos, "SUM(A3:A7)",
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #9 from Brent Ritzema ---
I noticed this was a quick fix so I submitted a patch... Sorry if I invaded
your space Tapan. I just figured this might help you more than hurt you.
--
You are receiving this mail because:
You are on
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #8 from Kohei Yoshida ---
Anyway, once again, my comment is just for informational purposes. It is by no
means meant to discourage the cleanup proposed here. :-)
--
You are receiving this mail because:
You are on the CC list
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #7 from Kohei Yoshida ---
BTW, just to mention this for the record, I did this type
if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)"))
CPPUNIT_FAIL("Wrong formula!");
of checks so that when it fails, you can get the line num
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #6 from Tapan Prakash T ---
Any branch name convention?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.fr
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #5 from Tapan Prakash T ---
How to I submit patch for this specific bug.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
Lib
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
Michael Stahl changed:
What|Removed |Added
Attachment #114489|0 |1
is obsolete|
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #3 from Markus Mohrhard ---
(In reply to Tapan Prakash T from comment #2)
> Created attachment 114489 [details]
> Fix Bug 90290
Please use gerrit. See https://wiki.documentfoundation.org/Development/gerrit
The attached file
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
Tapan Prakash T changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|lib
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #1 from Markus Mohrhard ---
And inside of the checkFormula implementation we should use
CPPUNIT_ASSERT_EQUAL_MESSAGE which will print the expected and actual string in
case of a failure.
--
You are receiving this mail because
https://bugs.documentfoundation.org/show_bug.cgi?id=90290
Markus Mohrhard changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
CC|
26 matches
Mail list logo
