https://bugs.documentfoundation.org/show_bug.cgi?id=90290
David Tardon <dtar...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dtar...@redhat.com
--- Comment #13 from David Tardon <dtar...@redhat.com> ---
(In reply to Markus Mohrhard from comment #0)
> ucalc is one of the mail calc tests and is split between many files in
> sc/qa/unit
>
> This task is about improving the existing pattern around checkFormula in
> sc/qa/unit/ucalc_formula.cxx
>
> A typical piece of code looks like this:
>
> if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)"))
> CPPUNIT_FAIL("Wrong formula!");
>
> This should be changed to something like:
>
> checkFormula(*m_pDoc, aPos, "SUM(A3:A7)", "Wrong formula!");
What is wrong with
CPPUNIT_ASSERT_MESSAGE("Wrong formula!", checkFormula(*m_pDoc, aPos,
"SUM(A3:A7)"))
? That would address Kohei's concerns without any necessary changes to cppunit.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
