core.git: compilerplugins/clang drawinglayer/source ios/UnitTest solenv/clang-format vcl/Library_vcl.mk vcl/source

c4c93d1a3ebfcf40bdfda28c1b269a1efc014895 Author: Christopher Sherlock AuthorDate: Tue Sep 9 22:20:38 2025 +1000 Commit: Julien Nabet CommitDate: Mon Sep 29 09:36:45 2025 +0200 vcl: pdfwriter_impl1.cxx and pdfwriter_impl2.cxx from gdi/ to pdf/ directory Update clang plugin. Change-Id

Re: Harbuzz error on macOS 26

> On 28 Sep 2025, at 7:31 pm, Chris Sherlock wrote: > > > >> On 28 Sep 2025, at 4:06 pm, Chris Sherlock >> wrote: >> >> >> Sent from my iPhone >> >>> On 28 Sep 2025, at 12:58 am, Patrick Luby wrote: >>> >>

Re: Harbuzz error on macOS 26

Sent from my iPhone > On 28 Sep 2025, at 12:58 am, Patrick Luby wrote: > >  > >> On Sep 26, 2025, at 10:35 PM, Chris Sherlock >> wrote: >> >> It is :-) that seems to a Darwin command, is that a script I don’t know >> about? > > The scr

Re: Harbuzz error on macOS 26

Sent from my iPhone > On 27 Sep 2025, at 8:04 am, Patrick Luby wrote: > >  >> On Sep 26, 2025, at 2:50 PM, Chris Sherlock >> wrote: >> >> Apologies to Ilmari, I seem to have replied to him directly a few times - >> that was not my intention. >>

Re: Harbuzz error on macOS 26

> On 27 Sep 2025, at 4:50 am, Chris Sherlock wrote: > > > >> On 27 Sep 2025, at 3:24 am, Chris Sherlock >> wrote: >> >> >> >>> On 27 Sep 2025, at 2:54 am, Ilmari Lauhakangas >>> wrote: >>> >>> On 9/26/25 1

Re: Harbuzz error on macOS 26

> On 27 Sep 2025, at 3:24 am, Chris Sherlock wrote: > > > >> On 27 Sep 2025, at 2:54 am, Ilmari Lauhakangas >> wrote: >> >> On 9/26/25 19:34, Chris Sherlock wrote: >>> Found ninja-1.13.1 at /opt/homebrew/bin/ninja >> >> I see this

Harbuzz error on macOS 26

I am now running the latest macOS v26. When compiling harfbuzz I am getting the following error: Build targets in project: 8 harfbuzz 11.5.1 Directories prefix: /usr/local bindir: bin libdir: lib includedir

Re: Loplugin:stringadd on chars

> On 19 Sep 2025, at 12:52 pm, Chris Sherlock > wrote: > > Pinging mailing list > > Sent from my iPhone > >> On 19 Sep 2025, at 12:33 am, Chris Sherlock >> wrote: >> >> I’m getting errors from buildbots triggering on code such as this:

core.git: vcl/source

vcl/source/app/scheduler.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit c5f4ff057e78ab69c14423c269e2040a7ec15f78 Author: Christopher Sherlock AuthorDate: Sat Aug 16 19:22:09 2025 +1000 Commit: Michael Weghorn CommitDate: Wed Sep 10 08:46:19 2025

Re: Loplugin:stringadd on chars

Pinging mailing list Sent from my iPhone > On 19 Sep 2025, at 12:33 am, Chris Sherlock > wrote: > > I’m getting errors from buildbots triggering on code such as this: > > aCreationMetaDateString.append(char('0' + ((aDT.Year / 1000) % 10))); > aCreati

core.git: vcl/IwyuFilter_vcl.yaml

vcl/IwyuFilter_vcl.yaml |4 1 file changed, 4 deletions(-) New commits: commit 5d20f6a4aefaeeb9a852b79fa8c27d220aa6fb2a Author: Christopher Sherlock AuthorDate: Fri Sep 19 01:33:40 2025 +1000 Commit: Michael Weghorn CommitDate: Thu Sep 18 21:57:23 2025 +0200 iwyu: remove

Loplugin:stringadd on chars

I’m getting errors from buildbots triggering on code such as this: aCreationMetaDateString.append(char('0' + ((aDT.Year / 1000) % 10))); aCreationMetaDateString.append(char('0' + ((aDT.Year / 100) % 10))); aCreationMetaDateString.append(char('0' + ((aDT.Year / 10) % 10))); aCreationMetaDateString.

core.git: vcl/source

vcl/source/control/calendar.cxx | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) New commits: commit 924c559c7df097be3d86fb415209b061ef709eaa Author: Christopher Sherlock AuthorDate: Mon Apr 14 04:28:12 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/bitmap.cxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit bbc20e3ac2defbe0c1a0f320fa2047f84b8d670d Author: Christopher Sherlock AuthorDate: Thu Aug 14 22:31:34 2025 +1000 Commit: Michael Weghorn CommitDate: Wed Sep 17 09:28:20 2025

Removing unnecessary includes

Hey all, I removed a bunch of unnecessary included headers in the following patch: https://gerrit.libreoffice.org/c/core/+/190709 I have done many, many patches with no issues until now. However, Michael has reasonably asked for guidance around what includes should and shouldn’t be used. Ca

core.git: 2 commits - solenv/clang-format vcl/Library_vcl.mk vcl/source

solenv/clang-format/excludelist |2 +- vcl/Library_vcl.mk |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 09ac4fb3e125ad1c0b1918f9ce621f8c3780cca5 Author: Christopher Sherlock AuthorDate: Tue Sep 9 22:03:59 2025 +1000 Commit: Michael

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) New commits: commit 0308304366bf1874365b7472ff567411a05550c7 Author: Christopher Sherlock AuthorDate: Thu Aug 14 22:13:50 2025 +1000 Commit: Michael Weghorn

core.git: solenv/clang-format vcl/Library_vcl.mk vcl/source

solenv/clang-format/excludelist |2 +- vcl/Library_vcl.mk |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit b24d9ab858a142b806822ba038d3173d35589626 Author: Christopher Sherlock AuthorDate: Tue Sep 9 21:38:00 2025 +1000 Commit: Michael

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit c9321bab19cc7c23f8143f05936871be635f4823 Author: Christopher Sherlock AuthorDate: Thu Aug 14 22:01:11 2025 +1000 Commit: Michael Weghorn CommitDate: Tue Sep 16 08:59:16

core.git: vcl/Library_vcl.mk vcl/source

vcl/Library_vcl.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0f78e4b7e9a112b285d66ee8cbbe94768279f6e4 Author: Christopher Sherlock AuthorDate: Tue Sep 9 21:33:55 2025 +1000 Commit: Michael Weghorn CommitDate: Thu Sep 11 09:25:29 2025 +0200 vcl

core.git: vcl/source

vcl/source/animate/AnimationRenderer.cxx | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) New commits: commit 29113a6c63e98216d98b93e4f6790640470f6796 Author: Christopher Sherlock AuthorDate: Sun Feb 23 18:51:12 2025 +1100 Commit: Michael Weghorn CommitDate

Struggling to see what needs Bitmap::DrawDeviceAlphaBitmapSlowPath()

I'm going to see if I can write a unit test of Bitmap:: DrawDeviceAlphaBitmapSlowPath(), but I am struggling to know what backend uses this. Skia doesn't need it, nor does the macOS backend, the Windows backend doesn't really need it either. Cairo doesn't seem to need it either. What else is ther

core.git: vcl/source

vcl/source/outdev/gradient.cxx | 54 - 1 file changed, 27 insertions(+), 27 deletions(-) New commits: commit 6ef6e31e32f33d77fa23bd5e07300f15b5ceb6f4 Author: Christopher Sherlock AuthorDate: Sat Aug 16 01:57:46 2025 +1000 Commit: Michael Weghorn

core.git: include/vcl vcl/source

include/vcl/outdev.hxx |4 ++-- vcl/source/outdev/bitmap.cxx | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 1fd581290cea2edf4c31f0f860e2b178e91c8101 Author: Christopher Sherlock AuthorDate: Sat Aug 2 17:33:51 2025 +1000 Commit: Michael

Right coupling of GDIMetafile to OutputDevice

Can someone explain why GDIMetafile is so tightly coupled to OutputDevice? We record each draw primitive into a GDIMetafile is there is a current mpMetaFile. I’m trying to understand why this is a core concern of OutputDevice. Any help in understanding this would be appreciated. Chris

Re: Right coupling of GDIMetafile to OutputDevice

> On 2 Sep 2025, at 4:57 pm, Thorsten Behrens > wrote: > > Hi Chris, all, > > Chris Sherlock wrote: >> Can someone explain why GDIMetafile is so tightly coupled to OutputDevice? >> > Because by definition, as you say - it is faithfully recording every

Re: Splitting off the doc and docx import and export libraries

> On 2 Sep 2025, at 5:18 am, John Cooper wrote: > > Hi, > > To make it easier to maintain the code and enable other open source software > to use it, it can be useful to split off the import export code as libraries. > This way other software such as NAPS2, can then use the libraries to sc

core.git: vcl/source

vcl/source/animate/AnimationRenderer.cxx | 34 +++ 1 file changed, 17 insertions(+), 17 deletions(-) New commits: commit 168b24b76a886cc0633fd7fcbb90c77d2a4d628c Author: Christopher Sherlock AuthorDate: Sun Feb 23 18:47:40 2025 +1100 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/animate/AnimationRenderer.cxx | 180 +++ 1 file changed, 91 insertions(+), 89 deletions(-) New commits: commit 33f050624eb5c8e1c5e37aca61bc93da695b2726 Author: Christopher Sherlock AuthorDate: Sun Feb 23 18:47:00 2025 +1100 Commit: Michael Weghorn

Re: Struggling to see what needs Bitmap::DrawDeviceAlphaBitmapSlowPath()

You are doing some amazing work - this is great!ChrisOn 2 Sep 2025, at 2:29 am, Noel Grandin wrote:It was used in the past, but is no longer necessary, and is about to be removed in   https://gerrit.libreoffice.org/c/core/+/190497On Mon, 1 Sept 2025 at 17:29, Chris Sherlock <chris.sher

core.git: vcl/source

vcl/source/outdev/gradient.cxx | 88 - 1 file changed, 44 insertions(+), 44 deletions(-) New commits: commit 78c26e59e397f7be10a19a4e3272032c1950b008 Author: Christopher Sherlock AuthorDate: Thu Aug 14 23:46:06 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/gradient.cxx | 100 - 1 file changed, 50 insertions(+), 50 deletions(-) New commits: commit bf348b395f0ed66e3e7263144d77200d8f176010 Author: Christopher Sherlock AuthorDate: Thu Aug 14 23:44:58 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/bitmap.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 98e54efc2098f428314cc5c9e7c2e0f52947f0aa Author: Christopher Sherlock AuthorDate: Sat Aug 2 17:30:58 2025 +1000 Commit: Michael Weghorn CommitDate: Sun Aug 24 22:34:50 2025 +0200

Re: Less insults, please

OK, that may be the case. Interestingly, after the ScopedPush() change was made, it actually meant the flattening becomes more readable. It appears that it was the additional Pop() statement that was the concern. Now that isn't there any more, the concern has gone away. If it had been pointed out

Less insults, please

I don't appreciate comments that I do flattening of code "at all costs". Can we please have less presumptuous and frankly insulting comments in gerrit reviews? I realise some of you don't like me, and you work on the code full time, but you don't need to be insulting. Chris

core.git: vcl/source

vcl/source/outdev/font.cxx | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) New commits: commit 2a3039e3d0617c5253061890a0e102561dbbed68 Author: Christopher Sherlock AuthorDate: Sat Aug 16 01:36:37 2025 +1000 Commit: Michael Weghorn CommitDate: Mon

core.git: include/vcl vcl/source

include/vcl/outdev.hxx |2 +- vcl/source/outdev/bitmap.cxx |9 + 2 files changed, 6 insertions(+), 5 deletions(-) New commits: commit 45e1e63cce018e2e21a67c0ded4122ef0a5c599f Author: Christopher Sherlock AuthorDate: Sat Aug 2 17:29:22 2025 +1000 Commit: Noel

core.git: vcl/source

vcl/source/outdev/gradient.cxx | 138 - 1 file changed, 69 insertions(+), 69 deletions(-) New commits: commit 9e172b671a42e5c31a2d434db31af9b982ee3c1f Author: Christopher Sherlock AuthorDate: Thu Aug 14 23:43:48 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/font.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit d17a8c8ee680290584a01160746e33b60a879722 Author: Christopher Sherlock AuthorDate: Sat Aug 16 01:33:52 2025 +1000 Commit: Michael Weghorn CommitDate: Fri Aug 15 22:28:04 2025

core.git: vcl/source

vcl/source/outdev/hatch.cxx | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) New commits: commit 790d17beb823f59f59564806925122e175991cbc Author: Christopher Sherlock AuthorDate: Thu Aug 14 23:51:36 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/eps.cxx | 50 +++--- 1 file changed, 25 insertions(+), 25 deletions(-) New commits: commit b914d1853e047452ed441a89db3b56e9fddd21a5 Author: Christopher Sherlock AuthorDate: Thu Aug 14 23:27:40 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/hatch.cxx | 78 ++-- 1 file changed, 39 insertions(+), 39 deletions(-) New commits: commit 186a020f5eab98f3b97da80d543b7101ffb4232d Author: Christopher Sherlock AuthorDate: Thu Aug 14 23:50:13 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/font.cxx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit d57d5ac146e79864aaefe41a069e7ea35160c64b Author: Christopher Sherlock AuthorDate: Thu Aug 14 23:35:09 2025 +1000 Commit: Noel Grandin CommitDate: Fri Aug 15 08:12:00

core.git: vcl/source

vcl/source/outdev/bitmap.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 6d964225e7b304332d303c00321d4b036b60353d Author: Christopher Sherlock AuthorDate: Sat Aug 2 17:14:05 2025 +1000 Commit: Noel Grandin CommitDate: Fri Aug 15 07:22:23 2025 +0200

Build failure

Does anyone know why this is failing? https://gerrit.libreoffice.org/c/core/+/188805 Console log here: https://ci.libreoffice.org/job/gerrit_windows/203603/console Chris

core.git: include/vcl vcl/source

include/vcl/image.hxx|2 +- vcl/source/image/Image.cxx |2 +- vcl/source/outdev/bitmap.cxx |5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) New commits: commit 26ab75625abfb9f614ca2d90686845d38b04a07e Author: Christopher Sherlock AuthorDate: Tue Aug 12 20:15

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 76 +-- 1 file changed, 38 insertions(+), 38 deletions(-) New commits: commit d0a5366b8232f7c9e45f58d7c4fa2475c98e7df5 Author: Christopher Sherlock AuthorDate: Sat Aug 9 19:12:29 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 44 ++- 1 file changed, 19 insertions(+), 25 deletions(-) New commits: commit 7b93ad1ff2621c294786be4801d1eb1f168b1033 Author: Christopher Sherlock AuthorDate: Sat Aug 9 19:04:14 2025 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) New commits: commit 4a133770430a90050a5f78c3e1e2bd92770c8b91 Author: Christopher Sherlock AuthorDate: Sat Aug 2 16:46:11 2025 +1000 Commit: Noel Grandin CommitDate: Mon Aug 11 08

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit bdafaec3a654cf96f2a6b9d8b53ff4fb39945ce2 Author: Christopher Sherlock AuthorDate: Sat Aug 2 16:39:12 2025 +1000 Commit: Noel Grandin CommitDate: Sat Aug 9 18:08:07 2025

core.git: vcl/source

vcl/source/outdev/bitmap.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 18720bd36aae7b3bef5364a690e40849c7d27fdb Author: Christopher Sherlock AuthorDate: Sat Aug 2 16:23:49 2025 +1000 Commit: Noel Grandin CommitDate: Sat Aug 9 09:31:12 2025 +0200

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) New commits: commit 10599fd334e6459963a779c64fe75a68af2cdc22 Author: Christopher Sherlock AuthorDate: Sat Aug 2 16:22:50 2025 +1000 Commit: Noel Grandin CommitDate: Fri Aug 8 15:55:35 2025

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-) New commits: commit e68ae6bbdaa9b39949c7e1215e48ef31f0e32efd Author: Christopher Sherlock AuthorDate: Sat Aug 2 16:18:40 2025 +1000 Commit: Noel Grandin

core.git: vcl/source

vcl/source/outdev/bitmap.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a143ed3bee8db2848623f27b951d2d08e6366d72 Author: Christopher Sherlock AuthorDate: Sat Aug 2 15:39:44 2025 +1000 Commit: Noel Grandin CommitDate: Thu Aug 7 15:41:35 2025 +0200

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) New commits: commit 47a8ba44e619f0c80c0a1611d56f58df5f6575bd Author: Christopher Sherlock AuthorDate: Sat Aug 2 15:38:19 2025 +1000 Commit: Noel Grandin CommitDate: Tue Aug 5 15:52:06

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 8c19a807f6c3128baf0eb205e9ffb0a255ea4f61 Author: Christopher Sherlock AuthorDate: Sat Aug 2 15:33:21 2025 +1000 Commit: Noel Grandin CommitDate: Mon Aug 4 19:55:03 2025

core.git: vcl/source

vcl/source/outdev/bitmap.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 157a0d5d8465b9227ea14b065df145ca6b93e414 Author: Christopher Sherlock AuthorDate: Sat Aug 2 15:30:54 2025 +1000 Commit: Noel Grandin CommitDate: Sun Aug 3 19:52:17 2025 +0200

core.git: vcl/source

vcl/source/outdev/bitmap.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit ce72458a4492c93b4429e2173057e7afbdbbc51e Author: Christopher Sherlock AuthorDate: Sat Aug 2 15:28:31 2025 +1000 Commit: Noel Grandin CommitDate: Sat Aug 2 20:49:09 2025

core.git: include/vcl vcl/source

include/vcl/outdev.hxx | 10 -- vcl/source/outdev/bitmap.cxx | 155 +-- 2 files changed, 76 insertions(+), 89 deletions(-) New commits: commit 0de1d5e85efb70c2c28eedf783aaab9097460927 Author: Christopher Sherlock AuthorDate: Mon Jul 28 16:39

core.git: vcl/source

vcl/source/animate/Animation.cxx | 12 1 file changed, 4 insertions(+), 8 deletions(-) New commits: commit bf248da3aad67abd2ccd154b747314217111719c Author: Christopher Sherlock AuthorDate: Sun Feb 23 14:14:32 2025 +1100 Commit: Michael Weghorn CommitDate: Thu Apr 17 14

core.git: solenv/clang-format vcl/Library_vcl.mk vcl/source

/source/edit/textdata.cxx | 41 - vcl/source/edit/texteng.cxx |1 7 files changed, 124 insertions(+), 59 deletions(-) New commits: commit 77bfb60031e38bd3aa5b7e910e3b625681aea98f Author: Christopher Sherlock AuthorDate: Fri Jan 3 19:43:35 2025 +1100 Commit

core.git: vcl/source

vcl/source/bitmap/BitmapDarkenBlendFilter.cxx | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) New commits: commit 921e6117bc0309705a49067287056089fd400a4f Author: Chris Sherlock AuthorDate: Sat Sep 21 01:01:46 2024 +1000 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/control/calendar.cxx | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) New commits: commit bb75bdc570e6764cd101c47318bc791c9313c0de Author: Chris Sherlock AuthorDate: Thu Oct 10 00:06:40 2024 +1100 Commit: Noel Grandin CommitDate: Mon Apr 14 08:31:37 2025

core.git: vcl/source

vcl/source/app/help.cxx | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) New commits: commit a9caf1506b5e4b78cf98ab23fc495fb324282e49 Author: Christopher Sherlock AuthorDate: Sun Feb 23 18:58:18 2025 +1100 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/control/spinbtn.cxx | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) New commits: commit e262ddf89c21966c56fe41483045b40ee461c80a Author: Christopher Sherlock AuthorDate: Wed Dec 25 20:34:52 2024 +1100 Commit: Michael Weghorn CommitDate: Tue Mar 4 16:08:30

core.git: include/vcl svgio/source vcl/qa vcl/source

insertions(+), 30 deletions(-) New commits: commit a43320a3ad867d65a9d9c8b332abc4dad10b430e Author: Chris Sherlock AuthorDate: Sat Sep 21 00:58:52 2024 +1000 Commit: Tomaž Vajngerl CommitDate: Sun Mar 2 13:15:53 2025 +0100 vcl: make BitmapDarkenBlendFilter use BitmapFilter

core.git: vcl/inc vcl/source

vcl/source/bitmap/BitmapDuoToneFilter.cxx |3 ++- vcl/source/graphic/UnoGraphic.cxx |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) New commits: commit 27d027e5704d15639b4b06653a1ee68e8d1c5b0b Author: Christopher Sherlock AuthorDate: Sun Mar 2 03:23:04 2025 +1100

core.git: include/vcl vcl/source

include/vcl/toolkit/scrbar.hxx |9 + vcl/source/control/scrbar.cxx | 221 + 2 files changed, 149 insertions(+), 81 deletions(-) New commits: commit 9d35ad8ee8aefedb5978f0c22aa08e1d9971c9b7 Author: Christopher Sherlock AuthorDate: Mon Dec 23 23

core.git: vcl/source

vcl/source/control/fmtfield.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 91ce2860cc21d4a20888310b8b8835391f20fca6 Author: Christopher Sherlock AuthorDate: Sat Feb 15 13:51:44 2025 +1100 Commit: Michael Weghorn CommitDate: Fri Feb 28 09:54:54 2025

core.git: vcl/source

vcl/source/animate/Animation.cxx | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) New commits: commit e4f7dd75937e9f7eaf92c7e9e244a03a3f17f48d Author: Christopher Sherlock AuthorDate: Sun Feb 23 14:49:19 2025 +1100 Commit: Tomaž Vajngerl CommitDate: Thu Feb 27 02:40

core.git: include/vcl vcl/inc vcl/qa vcl/source

/source/animate/Animation.cxx |2 +- 7 files changed, 14 insertions(+), 4 deletions(-) New commits: commit 08d940d3b7b194808385bd25bac6aa3160013e17 Author: Christopher Sherlock AuthorDate: Sun Feb 23 14:37:45 2025 +1100 Commit: Tomaž Vajngerl CommitDate: Thu Feb 27 02:39:24 2025

core.git: vcl/source

vcl/source/control/imivctl1.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 1d98bf6caaf4582f53e3a3eb57306a95633bbb6d Author: Christopher Sherlock AuthorDate: Mon Dec 23 17:55:04 2024 +1100 Commit: Michael Weghorn CommitDate: Wed Feb 26 17:30:06 2025 +0100 vcl

core.git: solenv/clang-format vcl/Library_vcl.mk vcl/source

- 5 files changed, 338 insertions(+), 226 deletions(-) New commits: commit 8b998ed161f0c7e72530e5f02aa9be13edb4f703 Author: Christopher Sherlock AuthorDate: Mon Dec 23 16:24:15 2024 +1100 Commit: Michael Weghorn CommitDate: Tue Feb 25 08:53:46 2025 +0100 vcl: move

core.git: vcl/source

vcl/source/control/calendar.cxx | 102 1 file changed, 53 insertions(+), 49 deletions(-) New commits: commit e014935a645c56182d15463c2692616c29308313 Author: Chris Sherlock AuthorDate: Wed Oct 9 23:56:56 2024 +1100 Commit: Michael Weghorn

core.git: include/vcl vcl/source

include/vcl/toolkit/throbber.hxx |2 +- vcl/source/control/throbber.cxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 2068c08a9d831248863ae1e94a618dc307ba5b6c Author: Christopher Sherlock AuthorDate: Sat Feb 22 21:58:06 2025 +1100 Commit: Michael

Re: BitmapFilter fix

A friendly ping to the mailing list. :-) Chris > On 13 Feb 2025, at 9:41 pm, Chris Sherlock wrote: > > Hi all, > > Would someone be able to have a look at the following patches? > > https://gerrit.libreoffice.org/c/core/+/180822/ > > https://gerrit.libreoff

core.git: include/vcl solenv/clang-format toolkit/source vcl/inc vcl/Library_vcl.mk vcl/source

: Christopher Sherlock AuthorDate: Sat Feb 15 14:14:28 2025 +1100 Commit: Michael Weghorn CommitDate: Tue Feb 18 09:52:23 2025 +0100 vcl: menubtn.[hc]xx -> MenuButton.[hc]xx Change-Id: I0b037261c753df6cd7efc2ee605abc02304c226c Reviewed-on: https://gerrit.libreoffice.org/c/c

core.git: vcl/source

vcl/source/control/slider.cxx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit 56390eefb11558d2c24f0e820fedc808361c6f7f Author: Christopher Sherlock AuthorDate: Tue Dec 24 23:28:30 2024 +1100 Commit: Michael Weghorn CommitDate: Tue Feb

core.git: framework/source include/vcl sfx2/source toolkit/inc toolkit/source vcl/inc vcl/source

/window/window2.cxx |6 ++-- vcl/source/window/wrkwin.cxx |4 +-- 32 files changed, 97 insertions(+), 97 deletions(-) New commits: commit b666efedd669d652c05deac4a6f9734b461e5074 Author: Christopher Sherlock AuthorDate: Wed Dec 11 00:32:05 2024 +1100 Commit

core.git: vcl/source

vcl/source/control/combobox.cxx |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) New commits: commit de018733fc1fa793848d319d1a962536c5a5d762 Author: Christopher Sherlock AuthorDate: Tue Dec 10 21:40:19 2024 +1100 Commit: Michael Weghorn CommitDate: Tue Feb 18 09:36:45

core.git: include/vcl vcl/source

include/vcl/toolkit/edit.hxx |4 ++-- vcl/source/control/edit.cxx |8 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit e4a2fa75e3d361ecb60942747a3c9f72aea27029 Author: Christopher Sherlock AuthorDate: Sun Dec 15 21:05:05 2024 +1100 Commit: Michael

core.git: vcl/source

vcl/source/control/spinfld.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit ac07c380ac24557a0c383e68728bded571df1281 Author: Christopher Sherlock AuthorDate: Thu Dec 26 01:30:15 2024 +1100 Commit: Michael Weghorn CommitDate: Tue Feb 18 09:29

core.git: vcl/source

vcl/source/control/tabctrl.cxx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit 67a25eb13f5a2b6a9efeb4af80c7288b07cd33e0 Author: Christopher Sherlock AuthorDate: Thu Dec 26 15:12:19 2024 +1100 Commit: Michael Weghorn CommitDate: Tue Feb

core.git: include/vcl vcl/source

include/vcl/window.hxx |1 + vcl/source/window/window.cxx |8 2 files changed, 5 insertions(+), 4 deletions(-) New commits: commit 0f53e4237dd7e16783f039b8ffee184513f4c86b Author: Christopher Sherlock AuthorDate: Tue Feb 18 00:34:28 2025 +1100 Commit: Michael

core.git: solenv/clang-format vcl/source

/textview.cxx|2 6 files changed, 97 insertions(+), 59 deletions(-) New commits: commit 8d01f7a927970bc205b816be6be4f79570192808 Author: Christopher Sherlock AuthorDate: Fri Jan 3 19:36:17 2025 +1100 Commit: Michael Weghorn CommitDate: Mon Feb 17 09:00:13 2025 +0100 vcl: move TextLine

core.git: vcl/source

vcl/source/control/edit.cxx | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) New commits: commit b01c3dc872b370a7314c7f65b63f32b5a1e315a8 Author: Christopher Sherlock AuthorDate: Sun Dec 15 20:54:09 2024 +1100 Commit: Michael Weghorn CommitDate: Mon Feb 17 08:45

core.git: vcl/source

vcl/source/control/fixed.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 67d0f364bb729025822f21e8e24a31cd5e8ffb38 Author: Christopher Sherlock AuthorDate: Sun Dec 22 22:42:57 2024 +1100 Commit: Michael Weghorn CommitDate: Mon Feb 17 08:42:06

core.git: vcl/source

vcl/source/control/hyperlabel.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 90b2fd021247cfb1e737f4a189dfbda2729ff76f Author: Christopher Sherlock AuthorDate: Sat Feb 15 13:56:28 2025 +1100 Commit: Michael Weghorn CommitDate: Mon Feb 17 08:38:47

core.git: vcl/source

vcl/source/control/hyperlabel.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit db83a93b7349e94b9658558e0a8ca4e9f7700a99 Author: Christopher Sherlock AuthorDate: Mon Dec 23 17:46:08 2024 +1100 Commit: Michael Weghorn CommitDate: Mon Feb 17 08:38:06

core.git: include/vcl

include/vcl/bitmap/BitmapFilter.hxx | 22 ++ 1 file changed, 22 insertions(+) New commits: commit 3b4793b366982d84b07fefe26470d0d12bf49733 Author: Christopher Sherlock AuthorDate: Tue Jan 28 18:58:14 2025 +1100 Commit: Tomaž Vajngerl CommitDate: Fri Feb 14 12:38

Re: Minor whitespace changes relating to lines of code that are being changed

On Fri, Feb 14, 2025 at 12:18 AM Stephan Bergmann < stephan.bergm...@allotropia.de> wrote: > On 13.02.25 11:36, Chris Sherlock wrote: > > I see commits all the time where someone changes a line of code and > changes the whitespacing in that same line of code. > > I occasi

core.git: vcl/source

vcl/source/control/edit.cxx | 116 +--- 1 file changed, 56 insertions(+), 60 deletions(-) New commits: commit 4159d6238e7c7b9549de51a71ca78c37a6826ba2 Author: Christopher Sherlock AuthorDate: Sun Dec 15 20:53:21 2024 +1100 Commit: Michael Weghorn

Re: Minor whitespace changes relating to lines of code that are being changed

> The devil is in the details. Michael is right that there are lines where only > spaces have been changed, but his first comment didn't show exactly the lines > he was suggesting for correction, maybe that is why he was unwittingly > opening old wounds. Chris' e-mail shows for me that the mot

Re: Minor whitespace changes relating to lines of code that are being changed

> On 13 Feb 2025, at 9:56 pm, Michael Weghorn wrote: > > Hi Chris, > > On 2025-02-13 11:36, Chris Sherlock wrote: >> I see commits all the time where someone changes a line of code and changes >> the whitespacing in that same line of code.

BitmapFilter fix

Hi all, Would someone be able to have a look at the following patches? https://gerrit.libreoffice.org/c/core/+/180822/ https://gerrit.libreoffice.org/c/core/+/173743 I created the BitmapFilter idea some time ago and these have been successfully adopted for a number of features in LibreOffice

Minor whitespace changes relating to lines of code that are being changed

Hi all, I see commits all the time where someone changes a line of code and changes the whitespacing in that same line of code. So for example, in https://gerrit.libreoffice.org/c/core/+/178504 I have removed the using namespaces and added css:: as the prefix, but at the same time *only* on

core.git: vcl/source

vcl/source/control/combobox.cxx | 46 1 file changed, 23 insertions(+), 23 deletions(-) New commits: commit 95609ed61346d4ad3f38f354963f7d809e8effa6 Author: Christopher Sherlock AuthorDate: Tue Dec 10 21:17:21 2024 +1100 Commit: Michael Weghorn

core.git: vcl/source

vcl/source/control/imivctl1.cxx | 40 1 file changed, 40 deletions(-) New commits: commit e554da3b298a45abe0532a67b478a90a3bf34fb1 Author: Christopher Sherlock AuthorDate: Mon Dec 23 17:53:46 2024 +1100 Commit: Michael Weghorn CommitDate: Mon

core.git: vcl/inc vcl/source

vcl/inc/slider.hxx|1 - vcl/source/control/slider.cxx |9 ++--- 2 files changed, 2 insertions(+), 8 deletions(-) New commits: commit 8a3a2ab67d8db2a99936671a24ed300fd965c303 Author: Christopher Sherlock AuthorDate: Tue Dec 24 23:26:38 2024 +1100 Commit: Michael

core.git: include/vcl vcl/source

include/vcl/toolkit/spin.hxx |2 -- vcl/source/control/spinbtn.cxx | 13 - 2 files changed, 4 insertions(+), 11 deletions(-) New commits: commit 58cc936ec70ae352f9574167ffe32144e7b7933f Author: Christopher Sherlock AuthorDate: Wed Dec 25 20:25:36 2024 +1100 Commit

  1   2   3   4   5   6   7   8   9   10   >