Re: HttpClient -> HttpComponents

Hello, used to progamm a bit, but due to lack of time, was not able to contribute with the speeding up of the tree... But as it seems to be a very low level priority task, I will have a try. >> " The Commons HttpClient project is now end of life, and is no to remove at least this dependency.

Re: internal compiler error: in connect_traces, at dwarf2cfi.c:2676

Hello, works fine by me. Did you try with another compiler / compiler version ? I have gcc version 4.7.2 20130108 [gcc-4_7-branch revision 195012] (SUSE Linux) and last commit in master being: d8dedc775cedf0e9daf9284bc7e3a0331ccd2963 EMF+: Integer coordinate values are signed. regards Pierre-And

Re: Beginner

Hello, if you want to contribute with coding, I would suggest you: - first (try to) build LibreOffice, depend on OS it can be tricky, but less than it used to be. This implies to download the source code, resolve dependencies and use the compiler - if not yet, get familiar with git (some basic c

Re: Cppunit-1.13.0 released

hello, git clone git://anongit.freedesktop.org/git/libreoffice/cppunit/ or http://cgit.freedesktop.org/libreoffice/cppunit/ regards On 07/07/2012 09:40 AM, Andreas Radke wrote: Am Sat, 7 Jul 2012 04:19:39 +0200 schrieb Markus Mohrhard : Hey, after we have no longer any build issues with cpp

Re: Cppunit-1.13.0 released

hello, updated :-) http://en.wikipedia.org/wiki/CppUnit regards On 07/07/2012 04:19 AM, Markus Mohrhard wrote: Hey, after we have no longer any build issues with cppunit I have now officially tagged the 1.13.0 release of cppunit. I would like to thank everybody who helped during this release.

Re: bug 49610 in impress: suspicious commit found, but help needed

he one that fit to my knowledge there. Or have you time to investigate it and fix it ? Sorry, this sounds not very constructive, but in this period I do not have a lot of free time, so I can not offer more. Tack regards Pierre-André On 06/20/2012 11:10 PM, Thorsten Behrens wrote: Pierre

Re: [Libreoffice] What is bibisect? And what is it doing in my office?

Hi, just to say thanks for bibisect Impressive example with fdo49610 to find the problematic commit. Regards Pierre-André On 12/09/2011 02:59 PM, Bjoern Michaelsen wrote: Hi all, So I hope with this, we make regression finding some more fun and allow us -- QA and developers together -- to st

Re: [ANN] Please use Gerrit from now on for Patch Review

Hello, well as free time contributor with commit access to current repository, I followed this gerrit story. So not kind of surprise, but yeah, until THIS mail and posts, was me very unclear what it would mean. To say it, first I had a lot of doubt. Reading mails, entry in the wiki, looking t

bug 49610 in impress: suspicious commit found, but help needed

hello, this bug is a bad regression. Following with debugger, I had as suspect the function void Outliner::ProvideNextTextObject (void) line 979 in sd/source/ui/view/Outliner.cxx (or something called late from this) as main suspect. After bibisect from QA the commit bdfbbb33a491f3ce34375de1

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

Hello, On 05/20/2012 11:24 PM, Norbert Thiebaud wrote: On Wed, May 16, 2012 at 11:30 PM, Pierre-André Jacquod wrote: expecting to get symbols without optimization, not wanting all asserts outputs. If you are intending to debug why wouldn't you want the misnamed 'assert output

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

hello, On 05/16/2012 04:07 PM, Lubos Lunak wrote: If somebody does a developer build, there are not many good reasons why -O2 should be used - it takes noticably more time and it makes debugging miserable. I can't think of anything else than final builds and profiling as a good non-corner-case

Re: [PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

Hello, On 05/03/2012 11:30 AM, Thorsten Behrens wrote: So what I suggest is a more defensive fix (or some larger review across the code is in order): make GetLineArrow() return the B2DPolyPolygon right away, and have *that one* be empty (i.e. not a Since I do not intend to become a specialist

some license statement

Hello, just to confirm that all of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Best regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/

[PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

Hello, back again after a while. On 02/15/2012 11:30 AM, Thorsten Behrens wrote: Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you like, would be cool to chase down why in the first place the ppt import creates polygons with empty sub-paths, that looks like a worthwhile optimiza

Re: input for fdo#45779 from a basegfx knowledgeable person needed

hello, Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you thanks import creates polygons with empty sub-paths, that looks like a worthwhile optimization - code is around filter/source/msfilter/msdffimp.cxx probably. as soon as I have more spare time, I will have a try. Regards

input for fdo#45779 from a basegfx knowledgeable person needed

hello, I have quickly investigated the crash in fdo#45779 when saving an impress document. The reason of the crash is in basegfx/inc/basegfx/point/b2dpoint.hxx (line 82) where this is called: 2DPoint::B2DPoint (this=0xbfffc850, rPoint=...) : B2DTuple(rPoint) (from back-trace) It tur

Re: [ANN] Referencing bugs in commits

hello, The bug reference has to have fdo#ABCDE form (where ABCDE is the bug number), and has to be at the first line of the commit (it does not matter where on that line). Sorry, one point is for me not clear: by the first line, do you mean "title line" or would it works also as first line o

Re: [Libreoffice] bug 36874 (label printing) further improvement?

Hello, Just to mix in the middle: from this and a previous mail from you: >> It would be much better if the label-definitions contain all dimensions, i.e. yes > My calculation is based on the assumption (presumption?) that the > page containing the labels is symmetrical, i.e. rotating the p

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

Hi Eicke, The second one: 0001-fdo42286-extend-down-but-also-shrink-if-cells-are-em.patch For consistency it makes sense to also shrink the area, as re-initializing the filter area with only one cell or one row selected . erroneously included. Please go ahead with this one. OK Please

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

Hello, To give you a background, this "extend range downward" functionality was Thanks for your explanation. Following the remark of Eicke, I ended up with 3 possible patches :-/ which all have small differences in behaviour. I have a favorite, but do not want to choose alone. Please push th

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

Hello, sorry, I was sure there was more about it...but too early this morning, I could not sort out all points. Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to not include newly appended columns of an area. Why? by the way, this reflect the comment in void ScDBData::Ex

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

Hi Eike Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to not include newly appended columns of an area. half true: the condition is exactly that the newly appended column data touch by an angle the already defined area (like C3 to B2) and that all other cells below the

Re: [Libreoffice] final and override

Hello, However, given that override and final will only make it into GCC 4.7 (according to ), it according to gcc.gnu.org too.. but since it seems that MSCV (according the same wiki) supports it / will support it, why not just wait a bit an

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

Hi, BUT this is a workaround, to compensate the not so correct behaviour of GetDataArea :-( The behaviour in bINcludeOld = false seems me strange (ergh I think wrong but you told me to be cautious), since it removes from the "side" of the area that has not yet been extended above the last li

[Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

hello, here attached an new patch (hopefully wiser) to solve the mentioned bug. This ensure that the call to ExtendDataArea does as commented in the code sc/source/core/tool/dbdata.cxx : // Extend the DB area to include data rows immediately below. and does not shrink the original area... So h

Re: [Libreoffice] [PATCH] fdo 42286 in calc solved ?

Hello, thanks for the answer My solution: suppress this call... is that, you've just removed a valid functionality. I'm afraid I can't push your change, since the line you wish to remove is there for a reason. which is ?? (not to argue, just to understand since I really tried to find a sense

Re: [Libreoffice] [PATCH] fdo 42286 in calc solved ?

Hello, Thanks for your hints. It took some times, but know I have clearly identified the problem , but I do not if my solution is right or could create more problems. In short, the problem is that GetAreadData is called each time the filter determines its values, instead of using the current

Re: [Libreoffice] some hints needed for fdo 42286 in calc

hello, and query information. The query is executed in ScDBDocFunc::Query and related functions. thanks I will look there & come back if needed P.S. Do you know if this is a regression against 3.3? Then it might be No 3.3 available to test (and a bit short of place on HD). But happens on

[Libreoffice] some hints needed for fdo 42286 in calc

hello, I am trying to debug fdo 42286 in calc. It has to do with autofilter, where some empty lines (rows) are shown despite the filter criteria that is set. (and a strange filter behaviour). As entry point, I found sc/.. tools/queryparam.cxx & dbdata.cxx but it seems that there all is Ok.

Re: [Libreoffice] master build fails in basegfx

hello, On 10/09/2011 02:04 PM, Jean-Baptiste Faure wrote: > Le 09/10/2011 09:18, Matúš Kukan a écrit : >> On 9 October 2011 09:13, Jean-Baptiste Faure : I try to build the master and I get an error in building basegfx. git revert 49861a0246547554e285b4d14f049a28addd4ddc But I can't reproduce.

Re: [Libreoffice] Declarations after statements

Hello, Declarations after statements are possible only in C99. And MSVC does not support C99 (refrain from bitching here, please). sorry Tor, I was not enthusiasm, just systematic and from *xes world. ... and I am - almost - too young to know there was a C89 before... If time allows, I will t

Re: [Libreoffice] master build fails in basegfx

hello, On 10/09/2011 02:04 PM, Jean-Baptiste Faure wrote: Le 09/10/2011 09:18, Matúš Kukan a écrit : On 9 October 2011 09:13, Jean-Baptiste Faure : I try to build the master and I get an error in building basegfx. git revert 49861a0246547554e285b4d14f049a28addd4ddc But I can't reproduce. Fe

Re: [Libreoffice] oox/source/drawingml/customshapepresets.cxx is just too much for gcc

On 10/07/2011 03:51 PM, Norbert Thiebaud wrote: 2011/10/7 Marc-André Laverdière: Wow, I really missed the 'big debate' :) me too :- ) - I don't think we can expect developers to run a build before each push, Yes we absolutely can expect that. it is actually a bare minimum ! rebase, clea

Re: [Libreoffice] dmake/win95: deprecated directory ?

Hello, dmake is 3rd-party software, thanks, with "One git", not being familiar with all part of the code and the structure, not always easy to know what is LO and 3rd-party. Should it not belongs to "external/" ? Or what is the semantic there ? Or would it make sense to have at the top leve

[Libreoffice] scope of variable reduction, cppcheck-error free build and new bugs

Hello, since I had free time, I have taken over to eliminate the "scope reduction" warning from cppcheck in order to reduce the noise by checks. This has been done almost successfully, about 10 such warnings are still available due to #ifdefn or macros. This also allowed me to reduce other wa

[Libreoffice] dmake/win95: deprecated directory ?

hello, I found a directory that seems to be deprecated since win95 is not supported anymore. There is another directory: dmake/winnt which seems to be more or less the clone of dmake/win95. Since I am not able to compile under windows, -hence not able to check what I would break - I mention

Re: [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code

Hello, That should happen in a DdeInstData ctor instead. I intended to do something easier: struct DdeInstData { short x; DdeInstData(); // and of course implementing this } I've moved it into the ctor now. Thanks, I was not able to react very quickly, making this during free tim

[Libreoffice] [patch] memset used on struc with std::vector / Windows code

hello, I allow me to send also this patch (I should really find out a Windows box in order to compile / test by myself). In short: since a39d4eae Remove DECLARE_LIST(DdeConnections,DdeConnection*) the struct DdeInstData contains a std::vector, but was initialized with memset( pData,0,sizeof(D

Re: [Libreoffice] Cppcheck defect when @ is present

Hello, What's the best thing to do : - to keep objective C++ parts ? - to replace objective C++ by plain (with or without boost) C++ ? for me there are already too many languages and flavour of languages. I would stay with plain C++, not adding objective C++ on top Just my feelings regar

Re: [Libreoffice] [PATCH] some cleaning for Windows part - need a review

Hello, I will have a look at your patches on Monday, unless somebody beats me to it during the weekend. Thanks, based on some remarks, here exactly the same patches, but with improved commit comments. Will be probably better to integrate these. Regards Pierre-André >From 94bed68189f2298d039

Re: [Libreoffice] Bringing some sanity to interline spacing

hello With http://cgit.freedesktop.org/libreoffice/core/commit/?id=052f181dad89ad34d90513bc9dcd3e3239727933 the new spacing is used only if SAL_USE_NEW_LINEHEIGHT=1 is set in the environment, else the old metrics are used. sorry, I am unable to find out the commit and the link point to nothin

[Libreoffice] [PATCH] some cleaning for Windows part - need a review

hello, liking systematic work, I was cleaning the unreadVariable warning from cppchecker.:-) This also let improve my programming knowledge and style... Here a bunch of changes that touch only Win product,... that I am unable to test, having only unix. Neverless, I did it would it be to redu

[Libreoffice] how to handle this bug (if this is one?)

hello, in vcl/win/source/gdi/winlayout.cxx, around line 695 there is: long SimpleWinLayout::FillDXArray( long* pDXArray ) const { +if( !mnWidth ) +{ +long mnWidth = mnBaseAdv; +for( int i = 0; i < mnGlyphCount; ++i ) +mnWidth += mpGlyphAdvances[ i ]; +}

[Libreoffice] code simplification: please logic review, to be sure

Hello, I am trying to wipe some unneeded calls and I see the following: while( ) { - SwFrm* pFrm; if( 0 != ( pONd = aIdx.GetNode().GetOLENode() ) && aName.Equals( pONd->GetChartTblName() ) && 0 != ( pFrm = pONd->getLayoutFrm( rVSh.GetLayout

[Libreoffice] [patch] unused variable in Windows build

Hello, a small patch to suppress an unused variable (within a WNT define) according cppchecker Since I can not build on Windows, if someone could review / compile it for me before pushing ? Thanks and regards Pierre-André 0001-unused-variable-in-Windows-build.patch Description: applicatio

Re: [Libreoffice] minutes of tech steering call ...

Hi, * announcing binfilter as deprecated in 3.4 + want to warn people in plenty of time + officially deprecate it, we drop save support in 3.4 The code cleaning is not yet finished, I still have commits (and done commits) that missed the 3.4 freeze (argh, missing free time) an

Re: [Libreoffice] release plan : inconsistency between 3.3.3 and 3.4

Hello, jumping late into the subject, but On 04/11/2011 12:25 PM, Michael Meeks wrote: The plan is (of course), to keep releasing 3.3.x releases as long as people are interested in creating them I suppose[1] - we should come up May I disagree ?? This is not a very predictable use f

Re: [Libreoffice] Calc's status bar is blank

Hello, I have the same on master. calc -> ca6285bd996927f797 libs-gui -> e29b73f64c3d5d4cf42 as header. This is previous libreoffice-3-4 branch, so breakage comes from master. Actually, I did not notice this before you wrote. But I had build from master 1-2 days before the above mentioned commi

Re: [Libreoffice] -Woverloaded-virtual

Hello, On 03/25/2011 02:13 PM, Lubos Lunak wrote: On Friday 25 of March 2011, Caolán McNamara wrote: argh!, I meant to say "then things are *not* too bad", not "*too* bad". I mean that's far less that I would have feared, quite manageable. Ok. In that case, if there are no objections, I'll

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, On 03/25/2011 10:12 PM, Caolán McNamara wrote: On Fri, 2011-03-25 at 22:09 +0100, Pierre-André Jacquod wrote: something... Hopefully my tests are good And make check was successful,.. at last :- ) in case you're relying on it as some oracle :-) No, the other way around:

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, after working, hibernating, rebasing after changes,... and changing my way of doing this, I push again some deletions. I have done some deletions of functions that are not used any more within the binfilter and replaced theyre return value. All the code is not yet cleaned. I have don

[Libreoffice] .fodt format broken

Hello, after having made a full compile, I have seen that the support for .fodt file format (plain xml) is broken. I tested this file format (created a file,...) about one month ago, and all was well, but now you just get a general I/O error, by reading or saving it. I do not know it this is

Re: [Libreoffice] [PATCH] [PUSHED] Translate Comments

Hello, looks good, pushed. Thanks Pierre-André On 03/23/2011 11:19 PM, Rob Snelders wrote: Hi, I have translated some comments in the libs-core/connectivity-directory. I submit this patch under LGPLv3+/MPL-Licence. ___ LibreOffice mailing list Lib

Re: [Libreoffice] [PUSHED] [PATCH] Remove commented out code

Hello, all seems to me OK, then I pushed. Thanks regards Pierre-André On 03/08/2011 12:19 PM, Bálint Dózsa wrote: > Hi, > > I have removed some commented out code form// //xmloff/. > My code is under the LGPLv3+/MPL dual license. > > Regards, > Balint Dozsa > > > > ___

Re: [Libreoffice] [PATCH] [PUSHED] Easy Hacks: Translation of Comments from German to English

Hello, thanks, just changed a typo best regards Pierre-André On 03/06/2011 04:10 PM, Daniel Di Marco wrote: > Hi, > > I translated some more comments. The patch is attached. > > > Cheers, > Daniel > > > > ___ > LibreOffice mailing list > LibreOffic

Re: [Libreoffice] Remove "using namespace ::rtl"

Hello, > Finally since I'm not sure for the moment about what must be done on > "using namespace com::sun::star::uno", I did the work on binfilters. Thanks regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.

Re: [Libreoffice] Remove "using namespace ::rtl"

Hello, > Even if binfilters is going to be "extracted" from LO, doesn't it worth I am doing, this, leting it be only an "import" filter. > to purge "using namespace ::rtl" from it (I think about the people I think that when "cross-module" cleaning is done, this is worth to do it also within binfi

Re: [Libreoffice] [PUSHED][PATCH]Cleanup comments

Hello, pushed, thanks, Maybe not forgetting the [patch] tag in subject will help not to miss your submission. best regards On 02/27/2011 04:51 PM, Arnaud Versini wrote: > Hi, > > This patch remove some useless comments in msfilter. > > Thanks > > -- > Arnaud Versini > > > > ___

Re: [Libreoffice] Nonsense comments?

On 02/25/2011 09:46 PM, Caolán McNamara wrote: > po files can have translator-comments in them to help translators > about ambiguous terms/words, while the .src/.sdf format doesn't though, translation with gettext would support this with comment using key-words / tags. Key words are configurable,

Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config

On 02/24/2011 08:33 PM, Kohei Yoshida wrote: > On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: >> Martin i think it would be easier as well as not to end up having ur >> email black listed for sending out large amounts of emails, but if its >> for a single module i would attach them

[Libreoffice] binfilter, filter & co: some questions

Hello, still working on this %&@#filter removing and I am crossing within binfilter/bf_sc a lot of "if" statement, testing if the current handled format is StarOffice, Excel95, Execl97 etc... A lot of theses "if" are typically like: else if (aFltName.EqualsAscii(pFilterLotus)) { D

Re: [Libreoffice] Patch handling guideline

Hello, if you do not mind, I wanted to propose the following points: patch submission: creating patches with >> git format-patch or sending them directly with git send-email I suggest the following options: --thread and --no-chain-reply-to if there are several patches, which results in: [PATCH 0/

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, after quite a long time, I have done a push again concerning this topic. Sorry, I was very busy at work and had barely the time to go ahead. Here is the following work in cleaning within binfilter/bf_sw the code allowing to write in StarWriter format. Without touching dependencies outside

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, > Wonderful :-) do you want help with this ? we could add an easy hack, > and ask people to contact you, for impress / calc etc. > Thanks for this point. I will think if this is easily feasible. But I am still myself on the (intensive) learning part, so I currently do not feel me yet

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, On 01/24/2011 03:43 PM, Caolán McNamara wrote: > > You also needed to adjust the smoketest "make check" because that has a > save as staroffice binary file format test in it. I noticed this failed > this morning and bodged it up to work again. Oops, sorry, I was not aware of it. Could you

[Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, from now I have started to delete within binfilter the code allowing to *save* using the StarOffice file format. The import (read) is still possible and will remain. Bye bye saving sdw, sxw This will of course not happens in one go... With this push, I have done the following changes:

[Libreoffice] error compiling in libs-gui/canevas

hello, there is an error compiling canevas: the reason: in vcl/inc/vcl/sysdata.hxx there has been a change at line 125: -void* pRenderFormat; // render format for drawable +void* pXRenderFormat; // render format for drawable This produce the error (see below) in canevas compilation. Si

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

Hi, On 01/14/2011 07:33 PM, Regina Henschel wrote: > Hi all, > > there is something wrong actually. Removing *Export*-filter is > reasonable, but now in LibO RC3 I cannot *read* my SO5 files. > > Kind regards > Regina Up to now, nothing has been committed. On trunk master, all is OK, I just teste

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

Hi Jan / Hi Michael, some more testing and code reading. Here some answers. [I was writing this mail while testing, mostly written before Michael's mail. Hence this will answers both mails. ] > This is a good point - as you say, I agree we can omit the creation of > the lock file. It would be go

Re: [Libreoffice] starmath / cppunit breakage in master

Hi, > Does setting > #define MDDS_HASH_CONTAINER_STLPORT 1 > before > #include > > help? > > I also saw someone having a similar issue in the same exact spot, which > I haven't been able to reproduce. Maybe this is related. I had also a problem after having upgraded to mds 0.4.0 with an up to d

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

Hi, >> in binfilter as read-only filters (using as filter flag >> SFX_FILTER_OPENREADONLY defined as 0x0001L) This will make the >> opening read-only. By this way, this is not possible any more to save > IIRC the resolution was a bit different ;-) you are right:-) > This way the user will

[Libreoffice] making binfilter aka StarOffice FileFormat read-only

Hello, these days, I have tried (and not really with full success) to understand how binfilter works... My goal: since it is an old legacy format, make StarOffice formats read-only, and clean binfilter component of all code used for writing files. Reason: with read-only, you will still be able to

[Libreoffice] fighting with debug macros...

Hello, still trying to learn a bit the code. Compiling without DEBUG on gives some new warnings:- ) This lead me to look at some code construct. Here is in pseudo-code a typical construct I am crossing: var y = ; var x = ; code if ( y > MAXVALUE) { ASSERT(x, "out of range"); // only u

Re: [Libreoffice] binfilter and features...

Hi, > There is alright, a phonecon typically once a week or so. maybe we can > put this topic on the agenda would be great > and you could dial in if its at a suitable time. doing this during free time, I may really depend if the possibility arise or not. But basically, we could think of a kind

[Libreoffice] [PATCH 01/16] warning variable unused fix in binfilter bf_sw attr

Hello again, can't figure where the first patch is, currently only 2 -> 16 are on the list. Here again the first one. But if this is as last time, tomorrow you will have this mail twice.. regards Hi, here some patches to supp

[Libreoffice] [PATCH 16/16] removing code due to endless loop

regards >From 6551d69a5fbc85f3af92cada84bf543a083d4453 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 22:05:10 +0100 Subject: [PATCH 16/16] removing code due to endless loop these part of code have been removed. The While(true) loop means either that

[Libreoffice] [PATCH 15/16] fix warning unused var in binfilter - bf_sw unocore

regards >From 151194c8a68754f9521bd485a9124f6e08f36239 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 21:58:35 +0100 Subject: [PATCH 15/16] fix warning unused var in binfilter - bf_sw unocore trying to stay on the safe side, means not always removing

[Libreoffice] [PATCH 14/16] fix warning unused param in binfilter bf_sw txtnode

regards >From 1a50712d282fd282ab53deb2fd7fb2e5acfa3807 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 21:23:38 +0100 Subject: [PATCH 14/16] fix warning unused param in binfilter bf_sw txtnode --- binfilter/bf_sw/source/core/txtnode/sw_atrfld.cxx |

[Libreoffice] [PATCH 13/16] fix warning in binfilter bf_sw tox

regards >From 239641e4b675424de81e45cb455e66b8127f9ff3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 21:01:39 +0100 Subject: [PATCH 13/16] fix warning in binfilter bf_sw tox --- binfilter/bf_sw/source/core/tox/sw_txmsrt.cxx |2 +- 1 files change

[Libreoffice] [PATCH 12/16] fix warning unused var binfilter bf_sw text

regards >From 22f6a25fcbba5eb41b73436f36a9542b2f898ef4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 20:38:53 +0100 Subject: [PATCH 12/16] fix warning unused var binfilter bf_sw text --- binfilter/bf_sw/source/core/text/sw_atrstck.cxx |5 ++---

[Libreoffice] [PATCH 11/16] fix warning unused var in binfilter bf_sw swg

regards >From c8861cfc5de23428356c1a5cf6aaed6d2a0eced3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 20:13:44 +0100 Subject: [PATCH 11/16] fix warning unused var in binfilter bf_sw swg --- binfilter/bf_sw/source/core/swg/sw_rdflds.cxx |2 +- bin

[Libreoffice] [PATCH 10/16] fix warning unused var in binfilter bf_sw sw3io

regards >From 18b052aa37f4adb95f3250de4967b739bd14be11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 20:07:52 +0100 Subject: [PATCH 10/16] fix warning unused var in binfilter bf_sw sw3io --- binfilter/bf_sw/source/core/sw3io/sw_sw3field.cxx |2 +

[Libreoffice] [PATCH 09/16] fix warning unused var in binfilter bf_sw ole

regards >From 5a619e9399713a488eeadc484617e630ed9d06ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 20:02:57 +0100 Subject: [PATCH 09/16] fix warning unused var in binfilter bf_sw ole --- binfilter/bf_sw/source/core/ole/sw_ndole.cxx |2 +- 1 fi

[Libreoffice] [PATCH 08/16] fix warning unused var in binfilter bf_sw layout

regards >From 86062da5291cc62d4f378fb8adb366d696ee11b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 17:32:49 +0100 Subject: [PATCH 08/16] fix warning unused var in binfilter bf_sw layout --- binfilter/bf_sw/source/core/layout/sw_atrfrm.cxx | 22

[Libreoffice] [PATCH 07/16] fix warning unused var in binfilter bf_sw fields

regards >From 0049d6aa3dd25887c742b51a764776103e67daf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 15:44:52 +0100 Subject: [PATCH 07/16] fix warning unused var in binfilter bf_sw fields still only fixes, no optimization has been done. On purpose, a

[Libreoffice] [PATCH 06/16] warning fix unused var in binfilter bf_sw draw

regards >From eac219396edebdf58deba912b02edac9a7999554 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 15:30:11 +0100 Subject: [PATCH 06/16] warning fix unused var in binfilter bf_sw draw --- binfilter/bf_sw/source/core/draw/sw_dcontact.cxx | 75 +++

[Libreoffice] [PATCH 05/16] warning fix unused var in binfilter bf_sw docnode

regards >From dafaabb2c38990bf4141c6074e15f0ca35d7e160 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 15:19:44 +0100 Subject: [PATCH 05/16] warning fix unused var in binfilter bf_sw docnode only warning removal, not code optimization, hence some funct

[Libreoffice] [PATCH 04/16] warning fix for unused var in binfilter bf_sw doc

regards >From 76026a3ef610c3b348f2fa514591e452eff3cd8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 14:56:23 +0100 Subject: [PATCH 04/16] warning fix for unused var in binfilter bf_sw doc This is warning removing, not code optimization => minimum ri

[Libreoffice] [PATCH 03/16] fix warning unused var in binfilter bf_sw crsr

regards >From fe0b41fe4378e18478263caf8d09af1f3adafa28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 11:12:21 +0100 Subject: [PATCH 03/16] fix warning unused var in binfilter bf_sw crsr this is fixing warning, not optimizing. This means, some functio

[Libreoffice] [PATCH 02/16] warning fix unused variable in binfilter bf_sw bastyp

regards >From a03ec223cf70c17a1cd6bbf397dc954c8d9d13fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 10:25:53 +0100 Subject: [PATCH 02/16] warning fix unused variable in binfilter bf_sw bastyp --- binfilter/bf_sw/source/core/bastyp/sw_calc.cxx|

[Libreoffice] [PATCH 01/16] warning variable unused fix in binfilter bf_sw attr

Hi, here some patches to suppress warnings within binfilter. I took a - sometimes too - conservative approach for doing this. Hope I did not harm this module regards >From 3c2cd665fe8a344626265f6c8a2a3b195556441d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 D

Re: [Libreoffice] binfilter and features...

On 12/05/2010 12:39 PM, Caolán McNamara wrote: > All true. It was just a note that it might be easier, if you have an > interest in binfilter, to just take the conservative approach and > silence warnings with e.g converting I was thinking of taking a 2 steps approach: first silent warning in a c

Re: [Libreoffice] binfilter and features...

On 12/04/2010 09:49 PM, Caolán McNamara wrote: > I wouldn't like to see too much effort spent on binfilter though. I understand the point. On the other side, leting it behind generate a lot of - not very useful - job when wanting to do global changes, like the RTL_CONST... macro, or getting ride o

[Libreoffice] crossing strange code: a little help

Hi within filters/binfilter/bf_sw/source/core/txtnode/sw_thints.cxx line 955, I crossed this code construct: if() { . while (TRUE) { DBG_BF_ASSERT(0, "STRIP"); } } With and without debugging option on, if the if is entered, then this is an endless loop? Does it m

[Libreoffice] binfilter and features...

Hi, currently trying to reduce the number of warning coming from binfilter, I found quite a lot functions like: func(var x) {} or func(var x) { ASSERT ("lksd") }. sometimes func (var x) {return false} Would someone mind if I track down the call of such functions, remove the calls and at the end re

[Libreoffice] [PATCH] making binfilter compiling again

Thanks to review and push it quite quickly if possible. Changes have been done (for RTL_OUSTRING_...) without looking that the namespace rtl is not declared. I did not introduced it but just corrected the entries, since I am not enough familiar to know which is the prefered situation within the pro

Re: [Libreoffice] Script to find undocumented classes

Beware - I am a newcomer - maybe my point of view is quite wrong due to lack of understanding. But then at least I will understand something better :- ) My first remark: stepping in seems to me to be very difficult despite the very friendly behaviour of people here. > un-documented code-base is a

[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)

regards >From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Mon, 29 Nov 2010 08:20:37 +0100 Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1) --- .../source/core/unocore/sw_SwXTextDefaults.cxx |

[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)

regards >From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Mon, 29 Nov 2010 08:20:37 +0100 Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1) --- .../source/core/unocore/sw_SwXTextDefaults.cxx |

[Libreoffice] [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2)

regards >From 09642903881c193ff01f2801461dcddeae0931ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Mon, 29 Nov 2010 22:13:22 +0100 Subject: [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2) --- binfilter/bf_sw/source/core/unocore/sw_unodraw.cxx |

  1   2   >