[PATCH] add a check to catch typos in Package names

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#6). Change subject: add a check to catch typos in Package names .. add a ch

[REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-21 Thread Winfried Donkers
Can this fix be cherry-picked for 4.0 releases (4.0.3 would be extremely nice)? The fix solves various small erroneous results of the calc function YEARFAC. Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freede

[Libreoffice-commits] core.git: jurt/Package_jnilib.mk

2013-04-21 Thread David Tardon
jurt/Package_jnilib.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 65d3bc8d40f0e10557523117464fa7c2a103636b Author: David Tardon Date: Mon Apr 22 08:44:58 2013 +0200 fix stupid typo Change-Id: I901a25894e4229dfae9393960b2f55aac604ab45 diff --git

[PATCH] replace python-core zip built in pyuno with direct use of Pa...

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3525 to look at the new rebased patch set (#3). Change subject: replace python-core zip built in pyuno with direct use of Package .

[PATCH] add a check to catch typos in Package names

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#5). Change subject: add a check to catch typos in Package names .. add a ch

[Libreoffice-commits] core.git: 3 commits - jpeg/ExternalPackage_jpeg.mk jurt/CustomTarget_jnilib.mk jurt/Package_jnilib.mk vcl/source

2013-04-21 Thread David Tardon
jpeg/ExternalPackage_jpeg.mk |1 - jurt/CustomTarget_jnilib.mk | 13 +++-- jurt/Package_jnilib.mk|6 ++ vcl/source/filter/jpeg/transupp.c | 34 +++--- 4 files changed, 32 insertions(+), 22 deletions(-) New commits: commit

[REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-21 Thread Winfried Donkers
Can this fix be cherry-picked for 4.0 releases (4.0.3 would be extremely nice)? The fix solves various small erroneous results of the calc function YEARFAC. BTW, http://wiki.services.openoffice.org/wiki/Documentation/How_Tos/Calc:_YEARFRAC_function now no lnger applies for LibreOffice ;-) Wi

Re: [PROPOSAL] enable gerrit buildbot trigger for all in group commiter

2013-04-21 Thread Lionel Elie Mamane
On Sun, Apr 21, 2013 at 11:06:20PM +0200, Bjoern Michaelsen wrote: > so this is a proposal to enable the ability to trigger a build for all in the > group commiter (...) This sounds attractive. We can do this ~immediately and do the "through web interface / gerrit" when we figured out how to do i

[PATCH] Bug 62096 - Replace O(U)String compareTo with ==

2013-04-21 Thread Anurag Kanungo (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3547 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3547/1 Bug 62096 - Replace O(U)String compareTo with == Change-Id: I3a8befcf51cea862e9bcc2670bce506004c1be9a --- M odk/

Fwd: Help to make it possible to add custom animation to Master Slides.

2013-04-21 Thread Janit Anjaria
-- Forwarded message -- From: Janit Anjaria Date: Tue, Apr 16, 2013 at 2:55 PM Subject: Help to make it possible to add custom animation to Master Slides. To: libreoffice-dev Hey! I have been looking into this bug/feature( and others too ;) ) since quite a time and have figured

[PATCH] add a check to catch typos in Package names

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#4). Change subject: add a check to catch typos in Package names .. add a ch

[Libreoffice-commits] core.git: jurt/Package_jnilib.mk

2013-04-21 Thread David Tardon
jurt/Package_jnilib.mk |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 6e205903f044186392a9aca24203148167552159 Author: David Tardon Date: Mon Apr 22 06:55:25 2013 +0200 add missing package name This means the file has not been delivered since gbui

[PATCH] Replace chained O(U)StringBuffer::append() with operator+

2013-04-21 Thread Anurag Kanungo (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3546 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3546/1 Replace chained O(U)StringBuffer::append() with operator+ modified: basctl/source/basicide/basides2.cx

[PATCH] add a check to catch typos in Package names

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#3). Change subject: add a check to catch typos in Package names .. add a ch

[Libreoffice-commits] core.git: external/Module_external.mk

2013-04-21 Thread David Tardon
external/Module_external.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fdd24a57655c3d15addeeca12e844cc1cd4e1765 Author: David Tardon Date: Mon Apr 22 06:43:52 2013 +0200 msvc80 dlls are only needed for mozab driver Change-Id: I6225926807122ed6b6a

[PATCH] silence odk check

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3536 to look at the new patch set (#5). Change subject: silence odk check .. silence odk check Change-Id: I1b2

[Libreoffice-commits] core.git: svx/source

2013-04-21 Thread Takeshi Abe
svx/source/xml/xmleohlp.cxx | 14 +++--- svx/source/xml/xmlgrhlp.cxx |4 ++-- svx/source/xml/xmlxtexp.cxx |2 +- svx/source/xml/xmlxtimp.cxx |8 svx/source/xoutdev/_xoutbmp.cxx |6 +++--- svx/source/xoutdev/_xpoly.cxx |2 +- svx/source/xoutd

Calc header/Footer mirroring in page. Is it working at all?

2013-04-21 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am working to port the calc header and footer editing dialog to widgets ui. I am discovering a very complex setting that I guess is related to page mirrorring. But I am actually unable to see it working. * Had anyone seen if left and right head

Re: [PROPOSAL] enable gerrit buildbot trigger for all in group commiter

2013-04-21 Thread Norbert Thiebaud
On Sun, Apr 21, 2013 at 4:06 PM, Bjoern Michaelsen wrote: > > Opinions? as of now the only way to do that is to give buildbot admin ACL and to use a command line to schedule build... The intent was to find a way to trigger these semi-automatically using the gerrit web gui... at which point yes e

Re: [ANN] LibreOffice 4.0.3 RC1 available

2013-04-21 Thread Thorsten Behrens
Dear Community, due to a build issue on Mac, that resulted in non-working python extensions, just pushed and published new Mac x86 install sets for 4.0.3 RC1. The source tarballs, lang packs and all other platforms remain unmodified. Apologies for the mistake. With kind regards, -- Thorsten si

[PATCH] replace python-core zip built in pyuno with direct use of Pa...

2013-04-21 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3525 to look at the new patch set (#2). Change subject: replace python-core zip built in pyuno with direct use of Package .

[Libreoffice-commits] core.git: 2 commits - solenv/gbuild

2013-04-21 Thread Michael Stahl
solenv/gbuild/LinkTarget.mk |6 +- solenv/gbuild/platform/com_MSC_class.mk |4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) New commits: commit d5e5de641cef7664a605f474bf7c18a70008806b Author: Michael Stahl Date: Sun Apr 21 18:07:43 2013 +0200 gbuild: work

[Libreoffice-commits] core.git: jpeg/ExternalPackage_jpeg.mk vcl/source

2013-04-21 Thread Tomaž Vajngerl
jpeg/ExternalPackage_jpeg.mk|1 + vcl/source/filter/jpeg/Exif.cxx |5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) New commits: commit 8ecf0d45d8301b95385eda64671df828c3003c62 Author: Tomaž Vajngerl Date: Sun Apr 21 23:31:03 2013 +0200 Add jpegint.h to jpeg module.

Re: [PUSHED] Re: Bug 58505 - Tweak F5 for slide display, and add Shift-F5

2013-04-21 Thread kuba
On 04/16/2013 08:29 PM, Thorsten Behrens wrote: I wrote: Jan Holesovsky wrote: Looks like great work to me - if you clarify the situation with the accelerator, I think we can push that, unless Thorsten has more ideas of course :-) Nope. :) So, since I don't see why this should not be merged

[PROPOSAL] enable gerrit buildbot trigger for all in group commiter

2013-04-21 Thread Bjoern Michaelsen
Hi, so this is a proposal to enable the ability to trigger a build for all in the group commiter and not some rather restricted and nonobvious set of people (including me). Securitywise, this presents no new risks as everyone in group committer already has the ability to push stuff to master whic

[Libreoffice-commits] core.git: vcl/source

2013-04-21 Thread Tomaž Vajngerl
vcl/source/filter/jpeg/Exif.hxx |1 - 1 file changed, 1 deletion(-) New commits: commit 2fa3cde17c90eb0eb7e9fda93909b02a2aebf1c9 Author: Tomaž Vajngerl Date: Sun Apr 21 22:55:41 2013 +0200 WaE: unused variable in Exif Change-Id: I921ba50f1d251489bfb56703247890f9ff23200f dif

[Libreoffice-commits] core.git: vcl/source

2013-04-21 Thread Tomaž Vajngerl
vcl/source/filter/GraphicNativeTransform.cxx |6 +++--- vcl/source/filter/jpeg/Exif.cxx |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 4cbe623af84f4a6761bf996fec82f2ea791a0769 Author: Tomaž Vajngerl Date: Sun Apr 21 22:52:30 2013 +0200

[PATCH]fdo#62096 Replace O(U)String compareTo with ==

2013-04-21 Thread Janit Anjaria
Hey! I am hereby attaching my patch for fdo#62096 where we replace .compareTo() calls with '==' operator. Any suggestions would be helpful and appreciated.Hope this finds you in good health. Regards, Janit 0001-fdo-62096-Replace-O-U-String-compareTo-with-operator.patch Description: Binary dat

adding a property to a published service [was: Value of a ListBox, FMC paradigm for Form elements (controls)]

2013-04-21 Thread Lionel Elie Mamane
On Sat, Apr 20, 2013 at 11:34:10PM +0200, Lionel Elie Mamane wrote: > I'm tempted to (...) add a "SelectedValues" property for easy access > to the selected storage values, (...) And this property looks like it belongs in service com::sun::star::form::component::DatabaseListBox That service is

[PATCH] fdo#62096 Corrected stupid error in previous patch

2013-04-21 Thread Sameer Deshmukh (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3545 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/3545/1 fdo#62096 Corrected stupid error in previous patch Change-Id: Ieb3ed1201918c5b4ba64e6f767353497e697 --- M xm

Stack trace in Windows

2013-04-21 Thread V Stuart Foote
So having a bit of a chore when grabbing a stack trace in Windows. Application to use seems to be the Sysinternals (Microsoft TechNet) Russinovich & Cogswell developed Process Monitor utility. It will completely capture to log ALL system activity on a Windows OS. The problem then becomes filteri

[PATCH] add a check to catch typos in Package names

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#2). Change subject: add a check to catch typos in Package names .. add a ch

[Libreoffice-commits] dictionaries.git: Dictionary_pt-PT.mk

2013-04-21 Thread David Tardon
Dictionary_pt-PT.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 36a0d3a959604b5c5af4adb17ca10a1d85542846 Author: David Tardon Date: Sun Apr 21 20:24:25 2013 +0200 fix typo Change-Id: If45a7a269ba94639b02209bc0e5191dd1815e682 diff --git a/Dictiona

[Libreoffice-commits] core.git: dictionaries

2013-04-21 Thread David Tardon
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 252b6b608f5fc35b154846c3487809fe5e147ab7 Author: David Tardon Date: Sun Apr 21 20:24:25 2013 +0200 Updated core Project: dictionaries 36a0d3a959604b5c5af4adb17ca10a1d85542846 diff --git a/dicti

[PATCH] fdo#62096 - Replaced compareTo with ==

2013-04-21 Thread Sameer Deshmukh (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3544 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3544/1 fdo#62096 - Replaced compareTo with == Change-Id: Ie5d3b3181038ddc2ffe2875aca1a5b8b18ab7a4f --- M writerfilter/s

[PATCH] fdo#62096 replaced some compareTo's with ==

2013-04-21 Thread Sameer Deshmukh (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3543 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3543/1 fdo#62096 replaced some compareTo's with == Change-Id: I2a8e835cdd7d00a31ec4acab433527ce8b6134ca --- M sal/inc/r

[RESTORED] Changed a few compareTo's to '=='

2013-04-21 Thread Sameer Deshmukh (via Code Review)
Sameer Deshmukh has restored this change. Change subject: Changed a few compareTo's to '==' .. Patch Set 1: Restored restore -- To view, visit https://gerrit.libreoffice.org/3523 To unsubscribe, visit https://gerrit.libreoffi

[PATCH] add a check to catch typos in Package names

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3542 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3542/1 add a check to catch typos in Package names Change-Id: Icae1d4f9f96d8e79e4992f546aad0630f5ae9236 --- M solenv/gb

[PATCH] silence odk check

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3536 to look at the new patch set (#4). Change subject: silence odk check .. silence odk check Change-Id: I1b2

[Libreoffice-commits] core.git: scripting/Package_ScriptsPython.mk

2013-04-21 Thread David Tardon
scripting/Package_ScriptsPython.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cde3a2b2c422d2d31e9cb5f36bfa8ca74dbce107 Author: David Tardon Date: Sun Apr 21 19:53:40 2013 +0200 fix typo Change-Id: Iaf1875bd7223743aa4309c970601fca3417afe17 diff -

Re: Python scripts other than Logo missing in master build

2013-04-21 Thread julien2412
Hello Alex, I've made some changes on this lately and noticed a typo in scripting/Package_ScriptsPython.mk The third line shows "Scripting" instead of "scripting". Badfully i don't have access to my laptop to change this. Could Anyone do it? Julien -- View this message in context: http://nabb

[PATCH] gbuild: fix generated deps for API headers

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3506 to look at the new patch set (#2). Change subject: gbuild: fix generated deps for API headers .. gbuild: f

[PATCH] silence odk check

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3536 to look at the new patch set (#3). Change subject: silence odk check .. silence odk check Change-Id: I1b2

[Libreoffice-commits] core.git: l10ntools/inc l10ntools/source

2013-04-21 Thread Zolnai Tamás
l10ntools/inc/export.hxx |5 - l10ntools/source/merge.cxx |8 2 files changed, 13 deletions(-) New commits: commit 2d8e4f91feeba58dbe4dc38e484a3be0f578ae9f Author: Zolnai Tamás Date: Sun Apr 21 19:09:27 2013 +0200 Delete more unused member from export Chan

[Libreoffice-commits] core.git: editeng/source

2013-04-21 Thread Matteo Casalin
editeng/source/editeng/textconv.cxx |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit 8e73c8ebcb4110e09d386927ffbe95a49ac5565c Author: Matteo Casalin Date: Sun Apr 21 19:05:34 2013 +0200 Avoid multiple appends on OUString Change-Id: I877c4520be33

[Libreoffice-commits] core.git: android/sdremote l10ntools/inc l10ntools/source librelogo/CustomTarget_librelogo.mk solenv/gbuild

2013-04-21 Thread Zolnai Tamás
android/sdremote/Makefile |8 ++- l10ntools/inc/export.hxx|1 l10ntools/inc/helpmerge.hxx |6 +- l10ntools/inc/po.hxx|1 l10ntools/source/common.cxx |2 l10ntools/source/helpex.cxx | 22 ++-- l10ntools/sourc

[PATCH] silence odk check

2013-04-21 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3536 to look at the new patch set (#2). Change subject: silence odk check .. silence odk check Change-Id: I1b2

[Libreoffice-commits] core.git: apple_remote/Library_AppleRemote.mk

2013-04-21 Thread David Tardon
apple_remote/Library_AppleRemote.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8560c2df78072533007b84b31fc930b82191e9a3 Author: David Tardon Date: Sun Apr 21 18:53:41 2013 +0200 blind fix for MacOS X build problem Change-Id: I56f0fd27fa246643d611

[PATCH] bDocumentDone is always false

2013-04-21 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3538 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3538/1 bDocumentDone is always false Change-Id: Ifde4d9235d3eacf0317b19885f5ea57e1c695cb3 --- M editeng/source/misc/han

[PATCH] Do not store return value for later, just exit

2013-04-21 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3541 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3541/1 Do not store return value for later, just exit Change-Id: If71398ee5a29652303ae492d23e3910526307d3c --- M editen

[PATCH] Prefer standard prefix for data members

2013-04-21 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3540 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3540/1 Prefer standard prefix for data members Change-Id: Ic0d0cdc88ee17bdeeb53855162085c30b25f9004 --- M editeng/sourc

[PATCH] Slightly simplify loop

2013-04-21 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3539 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3539/1 Slightly simplify loop Change-Id: If44e86ceecd4a407d3b4e294a03a84ad010f95e1 --- M editeng/source/misc/hangulhanj

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/shells...

2013-04-21 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3512 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3512 To unsubscribe, visit

[PATCH] make odk inst. check a check target

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3535 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/3535/1 make odk inst. check a check target Change-Id: I1bd8ee091a3c74ad05af69a4b7d5a2db21731b76 --- M odk/Module_odk.mk

[PATCH] silence odk check

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3536 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3536/1 silence odk check Change-Id: I1b2e224cb3b709e3c693f18918dcef5e0304894e --- M odk/CustomTarget_check.mk M odk/uti

[PATCH] replace CustomTarget_odk/odkcommon/settings by Package

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3534 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/3534/1 replace CustomTarget_odk/odkcommon/settings by Package Change-Id: Iee97a510be822836b2115f50d0b1c9e7e14b5e1a ---

[PATCH] chip more files off the odkcommon.zip block

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3533 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/3533/1 chip more files off the odkcommon.zip block Change-Id: I3d5d841d094f397130e37799a2f26e4d85f7c136 --- M odk/Custo

[PATCH] replace CustomTarget_odk/odkcommon/lib by Package

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3532 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/3532/1 replace CustomTarget_odk/odkcommon/lib by Package Change-Id: I929384077255b2fd944abf2da573c66572dec62b --- M odk

[PATCH] use Package for unowinreg

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3531 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/3531/1 use Package for unowinreg Change-Id: I7546e8938ba41e1462e704bd0405c5a887151d7b --- M odk/CustomTarget_check.mk M

[PATCH] replace CustomTarget_odk/odkcommon/cli by Package

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3530 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/3530/1 replace CustomTarget_odk/odkcommon/cli by Package Change-Id: I1d747fec9b1bf2aeef2a1886981f7f07a338ea12 --- M odk

[PATCH] replace CustomTarget_odk/odkcommon/bin by Package

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3529 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/3529/1 replace CustomTarget_odk/odkcommon/bin by Package Change-Id: Ia57ed471294595f1a8ee0aa0af05f3b82d439393 --- D odk

[PATCH] fix typo

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3528 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/3528/1 fix typo Change-Id: I58f0cd2248310fd7c5f1c82a6d10acc5a2446169 --- M odk/CustomTarget_check.mk 1 file changed, 1

[PATCH] allow odk/util/check.pl to use two base dirs

2013-04-21 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3527 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/3527/1 allow odk/util/check.pl to use two base dirs This is in preparation for my plan to move stuff out of odkcommon.z

[Libreoffice-commits] core.git: sw/source

2013-04-21 Thread Matthias Freund
sw/source/ui/shells/annotsh.cxx | 18 +-- sw/source/ui/shells/basesh.cxx | 193 +--- 2 files changed, 94 insertions(+), 117 deletions(-) New commits: commit 5741492149f39c4afa0c9cf575294f83ee4b3316 Author: Matthias Freund Date: Sun Apr 21 00:08:09 2013 +

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-21 Thread Ioan Radu (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3526 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3526/1 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT - replaced osl_trace with sal_info - replaced dbg_* with sal_* Ch

[Libreoffice-commits] core.git: 3 commits - smoketest/com smoketest/Extension_TestExtension.mk smoketest/Module_smoketest.mk smoketest/Package_smoketestdoc.mk smoketest/Zip_smoketestdoc.mk smoketest/Z

2013-04-21 Thread David Tardon
smoketest/Extension_TestExtension.mk| 14 +++ smoketest/Module_smoketest.mk |3 smoketest/Package_smoketestdoc.mk | 14 +++ smoketest/Zip_TestExtension.mk | 48 -- smoket

[Libreoffice-commits] libvisio.git: src/lib

2013-04-21 Thread Fridrich Štrba
src/lib/VSDXMLParserBase.cpp |3 +++ src/lib/VSDXParser.cpp |4 2 files changed, 7 insertions(+) New commits: commit 721c81593b2fb698b00d556e5509f570f692c765 Author: Fridrich Å trba Date: Sun Apr 21 17:33:50 2013 +0200 HideText for xml parsers too diff --git a/src/lib/

[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Rainer Bielefeld changed: What|Removed |Added Depends on||42939 --- Comment #139 from Rainer Bi

[ABANDONED] Changed a few compareTo's to '=='

2013-04-21 Thread Sameer Deshmukh (via Code Review)
Sameer Deshmukh has abandoned this change. Change subject: Changed a few compareTo's to '==' .. Patch Set 1: Abandoned wrong commit -- To view, visit https://gerrit.libreoffice.org/3523 To unsubscribe, visit https://gerrit.li

[Libreoffice-commits] libvisio.git: src/lib

2013-04-21 Thread Fridrich Štrba
src/lib/VDXParser.cpp | 31 +++ src/lib/VDXParser.h |1 + src/lib/VSDCollector.h |1 + src/lib/VSDContentCollector.cpp | 15 --- src/lib/VSDContentCollector.h |2 ++ src/lib/VSDParser.cpp | 15

[Libreoffice-commits] core.git: 2 commits - pyuno/source RepositoryFixes.mk scp2/source

2013-04-21 Thread Michael Stahl
RepositoryFixes.mk |2 +- pyuno/source/module/pyuno_module.cxx | 10 +++--- scp2/source/python/file_python.scp |4 3 files changed, 12 insertions(+), 4 deletions(-) New commits: commit 288c8b9d59024897e88b55b9001f9922998d1302 Author: Michael Stahl Date: S

[PATCH] replace python-core zip built in pyuno with direct use of Pa...

2013-04-21 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3525 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/3525/1 replace python-core zip built in pyuno with direct use of Package - python3: deliver files to INSTDIR, with same

[PATCH] Resolved bug fdo#63766

2013-04-21 Thread gokul s (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3524 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/3524/1 Resolved bug fdo#63766 This check is not required as the option merge will be disabled for merged cells, this co

[Libreoffice-commits] core.git: solenv/gbuild

2013-04-21 Thread Michael Stahl
solenv/gbuild/platform/unxgcc.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a12d25ac87fa01aa05b8cd4fe8606e066a4c1d03 Author: Michael Stahl Date: Sun Apr 21 14:24:13 2013 +0200 accidentally renamed variable Change-Id: I940a807a6bd92393fa4bf01790c1

[PATCH] Changed a few compareTo's to '=='

2013-04-21 Thread Sameer Deshmukh (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3523 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/3523/1 Changed a few compareTo's to '==' Change-Id: I0a0ba87ec517e5dd776ab45b232dd7f227451466 --- M ucb/source/ucp/webd

Re: Calc statistical accuracy

2013-04-21 Thread Chris Sherlock
On Sunday, 21 April 2013, Markus Mohrhard wrote: > > > 2013/4/21 Chris Sherlock 'cvml', 'chris.sherloc...@gmail.com');>> > >> On Sunday, 21 April 2013, Markus Mohrhard wrote: >>> >>> >>> No and as long as you don't plan to work on them I doubt anyone is going >>> to do it soon. >> >> >> There's a

Python scripts other than Logo missing in master build

2013-04-21 Thread Alex Thurgood
Hi all, In my 32bit master build : Version: 4.1.0.0.alpha0+ Build ID: ec2b98f4bcbe3b8a47b3b2b7127ac608d83ac6e the Python scripts are not available either via the Macro management UI, or via the command line, only the LibreLogo scripts show up. The "Enable Experimental Features" options box is t

Re: Calc statistical accuracy

2013-04-21 Thread Markus Mohrhard
2013/4/21 Chris Sherlock > On Sunday, 21 April 2013, Markus Mohrhard wrote: >> >> >> No and as long as you don't plan to work on them I doubt anyone is going >> to do it soon. > > > There's a friendly response... Where did you get that idea? > Please understand that posting at the developer mail

Re: Calc statistical accuracy

2013-04-21 Thread Noel Grandin
On Sun, Apr 21, 2013 at 1:56 PM, Chris Sherlock wrote: >> I think it is off-topic here and should be moved to the discuss list. > > > Why is that? It's a fairly innocent enquiry. > This is a list for people actually working on modifying the code of LO. Discussions about what modifications are de

Fwd: Calc statistical accuracy

2013-04-21 Thread Chris Sherlock
On Sunday, 21 April 2013, Markus Mohrhard wrote: > > > No and as long as you don't plan to work on them I doubt anyone is going > to do it soon. There's a friendly response... Where did you get that idea? > Additionally as long as this mainly serves as theoretical discussion Why do you consid

Setting up one's git identity [was: Patch for postgresql driver]

2013-04-21 Thread Lionel Elie Mamane
On Sun, Apr 21, 2013 at 12:26:52PM +0100, Wols Lists wrote: > On 20/04/13 22:42, Lionel Elie Mamane wrote: >> Both of these methods allow to use git "natively" to apply the patch, >> and (assuming your git is setup properly) to automatically get your >> suggested commit message and the informatio

Re: Patch for postgresql driver

2013-04-21 Thread Wols Lists
On 20/04/13 22:42, Lionel Elie Mamane wrote: > Both of these methods allow to use git "natively" to apply the patch, >> > and (assuming your git is setup properly) to automatically get your >> > suggested commit message and the information of authorship recorded >> > into git. For example, now I do

Re: Calc statistical accuracy

2013-04-21 Thread Regina Henschel
Hi Chris, Chris Sherlock schrieb: Hi all, This is a question more from curiosity than anything. Today I was reading that the Journal of Computational Statistics and Data Analysis was not at all happy with Microsoft Excel 2003, stating that: "Given Microsoft’s track record, we recommend that n

[PATCH] Converted Tools -> Protect Document-> Document widget.

2013-04-21 Thread Abdulelah Alarifi (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3522 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/3522/1 Converted Tools -> Protect Document-> Document widget. Change-Id: Ia947ee7430fba8151a682299e7221339dd61dcd1 ---

Re: Master branch now requires liborcus 0.5.0 or higher.

2013-04-21 Thread Bjoern Michaelsen
Hi, (sorry for the late reply, I missed this mail) On Tue, Apr 16, 2013 at 12:32:13PM -0400, Kohei Yoshida wrote: > I'd say gbuild itself, compounded by some regular build breakage related to > ccache (particular if you use a combination of gcc-wrapper with ccache > directly specified in CC and CX

Re: Calc statistical accuracy

2013-04-21 Thread Markus Mohrhard
> This is a question more from curiosity than anything. > > Today I was reading that the Journal of Computational Statistics and Data > Analysis was not at all happy with Microsoft Excel 2003, stating that: > > "Given Microsoft’s track record, we recommend that no statistical > procedure be used un

Re: Value of a ListBox, FMC paradigm for Form elements (controls)

2013-04-21 Thread Alex Thurgood
Le 20/04/2013 23:34, Lionel Elie Mamane a écrit : Hi Lionel, > One last question: where can I edit the help to document a new feature > I'm introducing (namely, the option that the storage value is the > index in the list)? I grepped for a string that appears in the right > help page, but no resu

Different Gerrit workflows -- was Master branch now requires liborcus 0.5.0 or higher.

2013-04-21 Thread David Ostrovsky
On Tue Apr 16 09:32:13 PDT 2013, Kohei Yoshida wrote: >>On Sat, Apr 13, 2013 at 5:55 AM, Bjoern Michaelsen < >>bjoern.michaelsen at canonical.com> wrote: >> >> BTW, this seems like a prime example benefitting from "upload to gerrit, >> let >> someone schudule a test build on all platforms" -- an

Calc statistical accuracy

2013-04-21 Thread Chris Sherlock
Hi all, This is a question more from curiosity than anything. Today I was reading that the Journal of Computational Statistics and Data Analysis was not at all happy with Microsoft Excel 2003, stating that: "Given Microsoft’s track record, we recommend that no statistical procedure be used unles

Re: [PATCH] Add HarfBuzz support to the build system

2013-04-21 Thread Khaled Hosny
Hi, I didn't know that it will submit each commit separately (git review), should I abandon this and the next commits and squash them into one? Also, there are some unresolved issues that I can't handle, may be submitting to gerrit wasn't the best idea after all. Regards, Khaled On Sun, Apr 21,

[PATCH] Allow switching between HarfBuzz and LE at runtime

2013-04-21 Thread Khaled Hosny (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3521 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/3521/1 Allow switching between HarfBuzz and LE at runtime Using the env variable SAL_USE_HARFBUZZ. Change-Id: If83d4e0

[PATCH] Add some comments

2013-04-21 Thread Khaled Hosny (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3520 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/3520/1 Add some comments Change-Id: I2a0dbf5f69efa0f35170c77a1efc9936cf9ecb94 --- M vcl/generic/glyphs/gcach_layout.cxx

[PATCH] Determine if glyph is diacritic from GDEF table

2013-04-21 Thread Khaled Hosny (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3519 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/3519/1 Determine if glyph is diacritic from GDEF table GDEF table should have the definitive answer about glyph class,

[PATCH] Add support for using HarfBuzz instead of ICU LE

2013-04-21 Thread Khaled Hosny (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3518 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/3518/1 Add support for using HarfBuzz instead of ICU LE Change-Id: I07e698f7486379bae68329771695cd94d6e561b5 --- M vcl/

[PATCH] Add HarfBuzz support to the build system

2013-04-21 Thread Khaled Hosny (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3517 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/3517/1 Add HarfBuzz support to the build system To be used in the next commit. No support for non-system build, yet. C

[PATCH] Converted Tools -> Protect Document-> Sheet widget.

2013-04-21 Thread Abdulelah Alarifi (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3516 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/3516/1 Converted Tools -> Protect Document-> Sheet widget. Change-Id: Ic701a2a92ddbf48be6998c0b278ec5f232f49983 --- A s

[PATCH] modifylayer.ui widget

2013-04-21 Thread Aliah Almusaireae (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3515 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/3515/1 modifylayer.ui widget Change-Id: I1bc3cb888c44df590993e1ebd32e5544dd08e805 --- A sd/uiconfig/sdraw/ui/modifylaye

[PATCH] insertlayer.ui widget

2013-04-21 Thread Aliah Almusaireae (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3514 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/3514/1 insertlayer.ui widget Change-Id: Ida59f58f6a2c4f65d83ad5ed2375bf934bd81d0c --- A sd/uiconfig/sdraw/ui/insertlaye

[PATCH] inserttable.ui widget

2013-04-21 Thread Aliah Almusaireae (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3513 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/3513/1 inserttable.ui widget Change-Id: I9de1975b5eeda09e3f356d20c05a2d8f6ebdcfc1 --- A sd/uiconfig/sdraw/ui/inserttabl