Re: [ANN] --enable-dbgutil: everyone gets a Debug STL!

2013-04-16 Thread Tor Lillqvist
>writing numbers to std streams now suppresses all output to > those streams, so that e.g., SAL_WARN("foo","bar") only writes "warn:foo:" Ah! Thanks for hunting this down, I had noticed but had not had time to dig deeper... > Why _GLIBCXX_DEBUG causes this problem on Mac OS X now, and how to solv

Re: [ANN] --enable-dbgutil: everyone gets a Debug STL!

2013-04-16 Thread Stephan Bergmann
On 04/15/2013 03:34 PM, Michael Stahl wrote: with commit f14f7a2e4568e3e85a0c8860beebd0376c5a8b51 MSVC builds will link everything against the debug runtimes (MSVCRTD etc.), which enables debug STL and other things. [...] since we have this enabled on other GCC platforms for years i'm not much

Re: Trying to locate who/what fixed fdo#53030

2013-04-16 Thread Lior Kaplan
Anyone ? On Sun, Mar 31, 2013 at 10:39 AM, Lior Kaplan wrote: > Hi, > > The good news is that fdo#53030 "Calc deletes current sheet, not > right-clicked on sheet when trying to delete opposite directionality > sheets" is fixed between 4.0.0 and 4.0.1, the problem is who/what fixed > it (I'm just

[PATCH] fix fdo#63546 : set appropriate alignment when writing direc...

2013-04-16 Thread navin patidar (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3424 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/3424/1 fix fdo#63546 : set appropriate alignment when writing direction is changed. Change-Id: I3aa22be6ae85b6f18ed48e3

Re: %PRODUCTNAME vs $[officename]

2013-04-16 Thread Andras Timar
Hi Markus, On Wed, Apr 17, 2013 at 6:45 AM, Markus Mohrhard wrote: > while looking through the help to see which special strings I need to > replace during runtime I noticed that we have %PRODUCTNAME and $[officename] > which both seem to be mapped to the same string. The same is true for > $[off

%PRODUCTNAME vs $[officename]

2013-04-16 Thread Markus Mohrhard
Hey Andras, *, while looking through the help to see which special strings I need to replace during runtime I noticed that we have %PRODUCTNAME and $[officename] which both seem to be mapped to the same string. The same is true for $[officeversion] and %PRODUCTVERSION while all the vendor strings

[PUSHED] fdo#63197, convert Zip_accessoriesgallery

2013-04-16 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3416 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3416 To unsubscribe, visit

[Libreoffice-commits] core.git: extras/ExternalPackage_accessoriesgallery.mk extras/Module_extras.mk extras/Zip_accessoriesgallery.mk scp2/source

2013-04-16 Thread Julien Nabet
extras/ExternalPackage_accessoriesgallery.mk | 317 ++ extras/Module_extras.mk |2 extras/Zip_accessoriesgallery.mk | 319 --- scp2/source/accessories/file_gallery_accessories.scp |7 4 files chang

officecfg: reformat using xmllint

2013-04-16 Thread Thomas Arnhold
Hi, does anyone have objections against running xmllint on officecfg like fe4260c53e7df91a4d2dad06104d7979a212de29 did? Those xml files are such messed up that this would be a pretty good improvement in my eyes. Thomas ___ LibreOffice mailing list

[Libreoffice-commits] core.git: officecfg/registry

2013-04-16 Thread Thomas Arnhold
officecfg/registry/schema/org/openoffice/LDAP.xcs | 96 ++ 1 file changed, 63 insertions(+), 33 deletions(-) New commits: commit fe4260c53e7df91a4d2dad06104d7979a212de29 Author: Thomas Arnhold Date: Wed Apr 17 03:13:23 2013 +0200 reformat xml file with xmllint

Re: [Libreoffice-commits] core.git: 7 commits - liborcus/ExternalProject_liborcus.mk Library_merged.mk RepositoryModule_host.mk sd/source solenv/bin solenv/gbuild solenv/gdb solenv/Package_gdb.mk

2013-04-16 Thread Peter Foley
Miklos, Sorry, should be fixed now. Thanks, Peter On Mon, Apr 15, 2013 at 10:55 AM, Miklos Vajna wrote: > Hi Peter, > > On Sat, Apr 13, 2013 at 05:15:30PM -0700, Peter Foley > wrote: >> commit ffe09728cb829016dbbe24ffc5ed10cfc15cfd5c >> Author: Peter Foley >> Date: Sat Apr 13 17:11:26 201

Re: patch for postgresql driver

2013-04-16 Thread Lionel Elie Mamane
On Tue, Apr 16, 2013 at 09:24:03PM +0100, Wols Lists wrote: > On 16/04/13 20:28, Lionel Elie Mamane wrote: >> On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote: >>> I can't get my argument casting right - in the original >>> code, matchIgnoreAsciiCaseAsciiL wraps its argument in >>> RTL_C

[Libreoffice-commits] core.git: solenv/bin

2013-04-16 Thread Peter Foley
solenv/bin/install-gdb-printers |3 +++ 1 file changed, 3 insertions(+) New commits: commit 346431a13853c651ca4fb4db7893bfc7bfcbf2ab Author: Peter Foley Date: Tue Apr 16 21:12:12 2013 -0400 fix gdb pretty-printers for non-merged Change-Id: I7e248a48ee8443b0f9209be708ce65dab57

[Libreoffice-commits] core.git: officecfg/registry

2013-04-16 Thread Thomas Arnhold
officecfg/registry/schema/org/openoffice/Office/Commands.xcs| 11 -- officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs | 12 -- officecfg/registry/schema/org/openoffice/Office/Draw.xcs| 48 - officecfg/registry/schema/org/openoffice/Office/Impre

[Libreoffice-commits] core.git: svx/source

2013-04-16 Thread Takeshi Abe
svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.cxx | 4 svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.hxx | 4 svx/source/unodialogs/textconversiondlgs/chinese_translation_unodialog.cxx | 4 svx/source/unodialogs/textconversiondlgs/ch

[Libreoffice-commits] core.git: sc/source

2013-04-16 Thread Markus Mohrhard
sc/source/filter/xml/xmlcondformat.cxx | 50 - 1 file changed, 25 insertions(+), 25 deletions(-) New commits: commit 9e0f880937174486030612961a518260fc76005e Author: Markus Mohrhard Date: Mon Apr 15 04:33:38 2013 +0200 let us use startsWith instead of ind

[PUSHED] General cleanup of OfficeBeans

2013-04-16 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3413 Approvals: Noel Grandin: Looks good to me, but someone else must approve Thomas Arnhold: Verified; Looks good to me, approved -- To vie

[Libreoffice-commits] core.git: bean/com

2013-04-16 Thread Chris Sherlock
bean/com/sun/star/comp/beans/CallWatchThread.java |9 - bean/com/sun/star/comp/beans/ContainerFactory.java |2 bean/com/sun/star/comp/beans/Frame.java |6 - bean/com/sun/star/comp/beans/JavaWindowPeerFake.java| 16 +-- bean/com/sun/star/comp/beans/Loca

Re: patch for postgresql driver

2013-04-16 Thread Michael Meeks
Hi Wols, On Tue, 2013-04-16 at 21:03 +0100, Wols Lists wrote: > if( args[i].Name.matchIgnoreAsciiCase( OUString( > keyword_list[j]), strlen( keyword_list[j] ))) > { I guess that a different matchIgnoreAsciiCase call is happening and/or the OUString constructor is c

[Libreoffice-commits] libvisio.git: src/lib

2013-04-16 Thread Fridrich Štrba
src/lib/VSDContentCollector.cpp |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit 471f32deacf03b44749d62eed99bbb873bbe1fe5 Author: Fridrich Å trba Date: Tue Apr 16 23:42:57 2013 +0200 Trying to get the short texts right diff --git a/src/lib/VSDContentCo

Re: [Libreoffice-qa] Triaging Goals - Net Minus 10 per Day Against Version 4

2013-04-16 Thread Joel Madero
Thanks to the great work of our team, some help from devs, and a couple new people along the way, we're now down to 162 bugs, down nearly 30 just in the past 36 hours. Many of the remaining 162 are quite complicated so any input from devs, advanced users, etc... greatly appreciated. Also some req

Re: [Libreoffice-qa] Triaging Goals - Net Minus 10 per Day Against Version 4

2013-04-16 Thread Joel Madero
On Tue, Apr 16, 2013 at 2:07 PM, Marc Kaulisch wrote: > Hi guys, > > I started to go through this list and I can confirm four bugs (see below) > where formatting is lost when documents are saved in .doc format. > Somehow we still have a problem with this file format which is still a > very often

Re: [Libreoffice-qa] Triaging Goals - Net Minus 10 per Day Against Version 4

2013-04-16 Thread Marc Kaulisch
Hi guys, I started to go through this list and I can confirm four bugs (see below) where formatting is lost when documents are saved in .doc format. Somehow we still have a problem with this file format which is still a very often used one. I have not looked for duplicates, but my guess is th

[PUSHED] Convert SwDrawTextInfo.pText from XubString to OUString

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3417 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3417 To unsubscribe, visi

[Libreoffice-commits] core.git: sw/source

2013-04-16 Thread Noel Grandin
sw/source/core/inc/drawfont.hxx |9 ++--- sw/source/core/text/txtfly.cxx |4 +- sw/source/core/txtnode/fntcache.cxx | 61 +--- sw/source/core/txtnode/fntcap.cxx |6 +-- sw/source/core/txtnode/swfont.cxx | 12 +++ 5 files changed, 46

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-16 Thread Ioan Radu (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3423 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/3423/1 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT - replaced osl_trace with sal_info - replaced dbg_* with sal_* Ch

[PUSHED] Convert SmFontPickList from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3398 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3398 To unsubscribe, visi

[PUSHED] remove dead class SfxPtrAr and it's header sfx/inc/sfx2/mina...

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3399 Approvals: Thomas Arnhold: Looks good to me, but someone else must approve Michael Stahl: Verified; Looks good to me, approved -- To vi

[Libreoffice-commits] core.git: cui/source sfx2/inc sfx2/Library_sfx.mk sfx2/Package_inc.mk sfx2/source

2013-04-16 Thread Noel Grandin
cui/source/inc/acccfg.hxx |1 cui/source/inc/cfg.hxx |1 cui/source/inc/selector.hxx |1 sfx2/Library_sfx.mk |1 sfx2/Package_inc.mk |1 sfx2/inc/arrdecl.hxx|1 sfx2/inc/sfx2/bindings.hxx |1 sfx2/inc/sf

[Libreoffice-commits] core.git: starmath/inc starmath/source

2013-04-16 Thread Noel Grandin
starmath/inc/utility.hxx| 104 +++--- starmath/source/utility.cxx | 150 ++-- 2 files changed, 64 insertions(+), 190 deletions(-) New commits: commit c6e9926468b1ab7eade9c1afc9e2216dd7c97330 Author: Noel Grandin Date: Mon Ap

Re: patch for postgresql driver

2013-04-16 Thread Wols Lists
On 16/04/13 20:28, Lionel Elie Mamane wrote: > On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote: >> The attached patch is not in logerrit (I've yet to set that up), and >> there's an error in it so I'm hoping someone can help. It does a TODO in >> the file, but I can't get my argument cas

Re: Basic font for labels in a Base form

2013-04-16 Thread Dan Lewis
On 04/16/2013 02:05 AM, Lionel Elie Mamane wrote: On Thu, Mar 28, 2013 at 10:43:30AM -0400, Dan Lewis wrote: Edit a Base form using LibreOffice 4.0.2.2 (32 bit Debian). Control+right click a label in the form. Select Control from the context menu. Click the elliplse ( ... ) for the Font pr

[Libreoffice-commits] core.git: canvas/source include/postx.h include/prex.h tools/inc tools/Package_inc.mk vcl/inc vcl/unx

2013-04-16 Thread Tor Lillqvist
canvas/source/cairo/cairo_xlib_cairo.cxx |4 - include/postx.h | 65 ++ include/prex.h| 60 tools/Package_inc.mk |2 tools/inc/tools/pos

[Libreoffice-commits] core.git: sfx2/source

2013-04-16 Thread Tor Lillqvist
sfx2/source/appl/workwin.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c3fa18254a24c1f260ff655fce9f100da800a28c Author: Tor Lillqvist Date: Tue Apr 16 23:08:41 2013 +0300 Fix error: cannot cast from type 'int' to pointer type 'SfxChild_Impl *' C

[PUSHED] remove dead code minstack.hxx

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3397 Approvals: Thomas Arnhold: Looks good to me, but someone else must approve Michael Stahl: Verified; Looks good to me, approved -- To vi

[Libreoffice-commits] core.git: sfx2/inc sfx2/Package_inc.mk sfx2/source

2013-04-16 Thread Noel Grandin
sfx2/Package_inc.mk |1 sfx2/inc/sfx2/minstack.hxx | 56 sfx2/source/menu/mnumgr.cxx |1 3 files changed, 58 deletions(-) New commits: commit 187a592df9bc9c1ef4b53fe6dce40a3c74f6bb67 Author: Noel Grandin Date: Mon Apr 15 11:26:4

[PUSHED] Convert SfxShellStack_Impl from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3394 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3394 To unsubscribe, visi

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-16 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#21). Change subject: WIP: date/time IDL datatypes incompatible change .

[Libreoffice-commits] core.git: sfx2/inc sfx2/source

2013-04-16 Thread Noel Grandin
sfx2/inc/sfx2/dispatch.hxx |4 + sfx2/source/control/dispatch.cxx | 99 ++- 2 files changed, 49 insertions(+), 54 deletions(-) New commits: commit 7e4db91a3900fd0bbce0f0592a045458a37862b3 Author: Noel Grandin Date: Mon Apr 15 11:21:16 2013 +0200

Re: patch for postgresql driver

2013-04-16 Thread Wols Lists
On 16/04/13 19:25, Noel Grandin wrote: > On Tue, Apr 16, 2013 at 6:36 PM, Wols Lists wrote: >> >> I need to force some type of type conversion - basically from "const >> char *" to "const rtl::OUString&", I presume. > > You can either call >matchIgnoreAsciiCase( OUString ( p ) ) > or >mat

Re: GSoC-2013 Support for Firebird Database in Base

2013-04-16 Thread Robinson Tryon
On Tue, Apr 16, 2013 at 1:50 PM, Jitesh Varandani wrote: > Sir > I'm a undergraduate from BITS Pilani pursuing my MSc in Information Systems. > I went through GSoC ideas and i show my interest in LibreOffice database. > I have a command in C and SQL as well as good experience on Linux. > So please

Need help

2013-04-16 Thread Anurag Kanungo
Hello, Finally i was able to build the libre office using the clang compiler on master branch and i built it on open suse . But my compiler plugings are not working as it says compiler headers missing . Please guide me how to proceed in an easy hack... I have removed some of the warnings , like i

[PUSHED] fdo#63290 - UI: Goal Seek - incorrect term "current cell"

2013-04-16 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3338 Approvals: Caolán McNamara: Verified; Looks good to me, approved Joren De Cuyper: Looks good to me, but someone else must approve -- To

[Libreoffice-commits] core.git: sc/source

2013-04-16 Thread Joren De Cuyper
sc/source/ui/src/globstr.src | 18 +- sc/source/ui/view/viewfun2.cxx | 12 +--- 2 files changed, 10 insertions(+), 20 deletions(-) New commits: commit af4a947174aafe669c129c54c304caa43d90eac7 Author: Joren De Cuyper Date: Thu Apr 11 15:43:20 2013 +0200 fdo#63

Re: patch for postgresql driver

2013-04-16 Thread Lionel Elie Mamane
On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote: > The attached patch is not in logerrit (I've yet to set that up), and > there's an error in it so I'm hoping someone can help. It does a TODO in > the file, but I can't get my argument casting right - in the original > code, matchIgnoreAs

[PUSHED] Convert SfxChildWindows_Impl from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3390 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3390 To unsubscribe, visi

[Libreoffice-commits] core.git: sfx2/source

2013-04-16 Thread Noel Grandin
sfx2/source/appl/workwin.cxx | 125 --- sfx2/source/inc/workwin.hxx | 10 --- 2 files changed, 63 insertions(+), 72 deletions(-) New commits: commit 74af27fef6505d4e47b53ea765b9cc4a96629fa4 Author: Noel Grandin Date: Mon Apr 15 09:57:55 2013 +0200

[Libreoffice-commits] help.git: helpers/help_hid.lst source/text

2013-04-16 Thread Caolán McNamara
helpers/help_hid.lst |9 - source/text/scalc/01/0604.xhp | 14 +++--- source/text/shared/00/0001.xhp |4 ++-- 3 files changed, 9 insertions(+), 18 deletions(-) New commits: commit 0a2a1d9d34779e473405adcae1a96710686c9cec Author: Caolán McNamara D

[Libreoffice-commits] core.git: helpcontent2

2013-04-16 Thread Caolán McNamara
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 431b265af7a66c15a35e8a388d2aa8c9ddb106e1 Author: Caolán McNamara Date: Tue Apr 16 20:23:34 2013 +0100 Updated core Project: help 0a2a1d9d34779e473405adcae1a96710686c9cec diff --git a/helpconte

[PUSHED] Convert SfxChildList_Impl from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3388 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3388 To unsubscribe, visi

[Libreoffice-commits] core.git: sfx2/source

2013-04-16 Thread Noel Grandin
sfx2/source/appl/workwin.cxx | 80 +++ sfx2/source/inc/workwin.hxx |4 +- 2 files changed, 38 insertions(+), 46 deletions(-) New commits: commit f1c91970cba512452bb138c5af262b910068589e Author: Noel Grandin Date: Fri Apr 12 17:06:07 2013 +0200

[Libreoffice-commits] core.git: sc/AllLangResTarget_sc.mk sc/inc sc/source sc/uiconfig sc/UIConfig_scalc.mk

2013-04-16 Thread Caolán McNamara
sc/AllLangResTarget_sc.mk |1 sc/UIConfig_scalc.mk|1 sc/inc/globstr.hrc |7 + sc/source/ui/inc/solvrdlg.hrc | 39 -- sc/source/ui/inc/solvrdlg.hxx | 21 ++--- sc/source/ui/miscdlgs/solvrdlg.cxx | 118 ++

[PUSHED] Convert SfxViewFactoryArr_Impl from SfxPtrArray to std::vect...

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3360 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3360 To unsubscribe, visi

[Libreoffice-commits] core.git: vbahelper/source

2013-04-16 Thread Bjoern Michaelsen
vbahelper/source/msforms/vbanewfont.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit f789cdaea74e84243bc2e917173c6a750b20 Author: Bjoern Michaelsen Date: Tue Apr 16 21:11:18 2013 +0200 Revert "add missing include" This reverts commit 6b08209ae4cebe9c71fe5496499

[Libreoffice-commits] core.git: sfx2/source

2013-04-16 Thread Noel Grandin
sfx2/source/doc/docfac.cxx | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) New commits: commit 9b9f1c4b6f21eb30eb365da3cca4ca4a1d2d0069 Author: Noel Grandin Date: Fri Apr 12 16:35:25 2013 +0200 Convert SfxViewFactoryArr_Impl from SfxPtrArray to std::vector

[PUSHED] Convert SfxObjectUIArr_Impl from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3359 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3359 To unsubscribe, visi

Re: [PATCH] BUG#62096 Replace O(U)String compareTo with ==

2013-04-16 Thread Janit Anjaria
Hey Joren! Yeah i have had a look at this wiki page : https://wiki.documentfoundation.org/Development/gerrit#Setting_Yourself_Up_For_Gerrit lng back(when i started hacking on LO codebase) and had played around with it for a time being .But seriously and frankly speaking i am more comfortable

[Libreoffice-commits] core.git: sfx2/inc sfx2/source

2013-04-16 Thread Noel Grandin
sfx2/inc/sfx2/objface.hxx | 17 -- sfx2/source/control/objface.cxx | 65 ++-- 2 files changed, 30 insertions(+), 52 deletions(-) New commits: commit 3f153805b84e91dec3819a15ae04d2ba1a9721dc Author: Noel Grandin Date: Fri Apr 12 16:24:02 201

[PUSHED] Convert SfxPtrArray to std::vector in SfxTabDialogItem

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3358 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3358 To unsubscribe, visi

[Libreoffice-commits] core.git: sfx2/source

2013-04-16 Thread Noel Grandin
sfx2/source/dialog/tabdlg.cxx | 72 ++ 1 file changed, 32 insertions(+), 40 deletions(-) New commits: commit a43dc5802eacca8451e65bf2229858cfe89408eb Author: Noel Grandin Date: Fri Apr 12 15:35:07 2013 +0200 Convert SfxPtrArray to std::vector in S

[Libreoffice-commits] core.git: vbahelper/source

2013-04-16 Thread Bjoern Michaelsen
vbahelper/source/msforms/vbanewfont.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 6b08209ae4cebe9c71fe5496499f2e9a4d42def3 Author: Bjoern Michaelsen Date: Tue Apr 16 20:54:35 2013 +0200 add missing include diff --git a/vbahelper/source/msforms/vbanewfont.cxx b/vbahelp

[PUSHED] Convert usage of SfxPtrArray to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3356 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3356 To unsubscribe, visi

[Libreoffice-commits] core.git: sfx2/inc sfx2/source

2013-04-16 Thread Noel Grandin
sfx2/inc/sfx2/bindings.hxx |3 - sfx2/source/control/bindings.cxx | 95 --- 2 files changed, 52 insertions(+), 46 deletions(-) New commits: commit d3a279cbd308486250e2b652aac01d41e2a52f14 Author: Noel Grandin Date: Fri Apr 12 09:38:45 2013 +0200

Re: cherry-pick across renames [was: minutes of ESC call ...]

2013-04-16 Thread Miklos Vajna
Hi, On Tue, Apr 16, 2013 at 10:06:02AM -0500, Norbert Thiebaud wrote: > > I think Norbert meant: > > [...] > Yep Ah, I see. I hoped we won't have to deal with that, just like we didn't deal with the conflicts caused by the rtl:: prefix mass-removal. I just asked the contributor to rebase his/h

[Libreoffice-commits] core.git: solenv/gbuild

2013-04-16 Thread David Tardon
solenv/gbuild/platform/WNT_INTEL_GCC.mk |2 +- solenv/gbuild/platform/com_MSC_class.mk |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit eda61605d1843a87fc67039fa73be616040b581d Author: David Tardon Date: Tue Apr 16 20:39:36 2013 +0200 fix path for shlinf

Re: [PATCH] BUG#62096 Replace O(U)String compareTo with ==

2013-04-16 Thread JorenDC
Hi Janit, I see your patches keeps passing by. Sending your patch by email is not wrong, but we have another handy tool to review/comment/... patches -> Gerrit. Please have a look at https://wiki.documentfoundation.org/Development/gerrit#Setting_Yourself_Up_For_Gerrit so you can send them t

Re: [PUSHED] Re: Bug 58505 - Tweak F5 for slide display, and add Shift-F5

2013-04-16 Thread Thorsten Behrens
I wrote: > Jan Holesovsky wrote: > > Looks like great work to me - if you clarify the situation with the > > accelerator, I think we can push that, unless Thorsten has more > > ideas of course :-) > > > Nope. :) > So, since I don't see why this should not be merged to master, I did just that - th

Re: [PATCH] BUG#62096 Replace O(U)String compareTo with ==

2013-04-16 Thread Janit Anjaria
Hey! I am hereby attaching my patch for fdo #62096 : https://bugs.freedesktop.org/show_bug.cgi?id=62096 Any suggestions would be great to be implemented. Regards, Janit On Tue, Apr 16, 2013 at 11:52 PM, Janit Anjaria wrote: > Hey Stephan! > I think that was due to hurry(the things for "!=" t

[PUSHED] move headers from solenv/inc/ to include/

2013-04-16 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3403 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3403 To unsubscribe, visit

[Libreoffice-commits] core.git: vbahelper/source

2013-04-16 Thread Tor Lillqvist
vbahelper/source/msforms/vbanewfont.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 2c4a7fa98383ca46bca9f6c222ac19e0b940b874 Author: Tor Lillqvist Date: Tue Apr 16 21:26:51 2013 +0300 Add missing #include Change-Id: Ic00146442a679c39d0af4a287cbcf759826f35cd dif

Re: patch for postgresql driver

2013-04-16 Thread Noel Grandin
On Tue, Apr 16, 2013 at 6:36 PM, Wols Lists wrote: > > I need to force some type of type conversion - basically from "const > char *" to "const rtl::OUString&", I presume. You can either call matchIgnoreAsciiCase( OUString ( p ) ) or matchIgnoreAsciiCase( p, strlen(p) )

[Libreoffice-commits] core.git: configure.ac include/postmac.h include/postwin.h include/premac.h include/prewin.h include/shlinfo.rc include/version.hrc include/wntgcci solenv/inc

2013-04-16 Thread Matúš Kukan
configure.ac |5 include/postmac.h| 41 ++ include/postwin.h| 252 +++ include/premac.h | 50 +++ include/prewin.h | 77 +++ include/shlinfo.rc

[PUSHED libreoffice-3-6] rhbz#867808 Do not throw RuntimeException by pointer

2013-04-16 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3420 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3420 To unsubscribe, visit

[Libreoffice-commits] core.git: officecfg/registry sd/inc sd/sdi sd/source sd/uiconfig svx/inc

2013-04-16 Thread Jakub Golebiewski
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu | 5 + officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu | 8 + sd/inc/sdcommands.h | 1 sd/sdi/SlideSorterController.sdi

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - bridges/test i18npool/source sdext/source stoc/source testtools/source toolkit/source

2013-04-16 Thread Stephan Bergmann
bridges/test/java_uno/nativethreadpool/testnativethreadpoolclient.cxx |4 +- bridges/test/java_uno/nativethreadpool/testnativethreadpoolserver.cxx |2 - i18npool/source/transliteration/transliteration_Numeric.cxx |6 ++-- sdext/source/presenter/PresenterController.cxx

fdo#61189 - Printer Bug Triage Needed - Office PS Laser Printer Required

2013-04-16 Thread Joel Madero
Another one of those really specific bugs that need triaged. Someone using LibreOffice in an office setting should be able to triage this one but you'll need a office quality PS printer (ie. no cheap ink jet will do the trick). https://bugs.freedesktop.org/show_bug.cgi?id=61189 Thanks in adv

[Libreoffice-commits] core.git: xmlscript/Module_xmlscript.mk xmlscript/Package_dtd.mk xmlscript/Package_inc.mk

2013-04-16 Thread Bjoern Michaelsen
xmlscript/Module_xmlscript.mk |1 + xmlscript/Package_dtd.mk | 17 + xmlscript/Package_inc.mk |7 --- 3 files changed, 18 insertions(+), 7 deletions(-) New commits: commit f4ebb99de6e93f6d38e7b0486d66e99a196b1f6e Author: Bjoern Michaelsen Date: Tue Apr 1

[Libreoffice-commits] core.git: sw/source

2013-04-16 Thread Tor Lillqvist
sw/source/filter/ww8/writerwordglue.cxx | 42 1 file changed, 21 insertions(+), 21 deletions(-) New commits: commit 30fd46fd54c764dae676fc70dd2a207bc38a3870 Author: Tor Lillqvist Date: Tue Apr 16 21:01:41 2013 +0300 Bin pointless comments describing alle

[Libreoffice-commits] core.git: sw/source

2013-04-16 Thread Tor Lillqvist
sw/source/filter/ww8/docxattributeoutput.cxx |1 + sw/source/filter/ww8/rtfattributeoutput.cxx |1 + sw/source/filter/ww8/writerwordglue.cxx |2 ++ 3 files changed, 4 insertions(+) New commits: commit 564cff72197f992afc19c127a721d4792d38c4cf Author: Tor Lillqvist Date: Tue Ap

GSoC-2013 Support for Firebird Database in Base

2013-04-16 Thread Jitesh Varandani
Sir I'm a undergraduate from BITS Pilani pursuing my MSc in Information Systems. I went through GSoC ideas and i show my interest in LibreOffice database. I have a command in C and SQL as well as good experience on Linux. So please help me to as where to start and what else is required to do. Thank

Re: Removing C++ SDK examples, clearly encouraging Python extensions

2013-04-16 Thread Olivier R.
Hi, Tor Lillqvist-2 wrote > Needed also for soffice.bin . (I don't recall, but it might be that > editbin doesn't believe a file called .bin is an exectuable, so you > might need to temporarily rename soffice.bin to foo.exe, run editbin > on it, and rename back.) Thanks. It works. (Renaming soff

[Libreoffice-commits] core.git: sc/source

2013-04-16 Thread Tor Lillqvist
sc/source/filter/html/htmlpars.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 162676d826200a6612da195f5241490ee307f498 Author: Tor Lillqvist Date: Tue Apr 16 20:42:54 2013 +0300 Add missing #include Change-Id: Iad969bf9b32cbfe045248fb17dc4c0d7c66c2c94 diff -

[PATCH] fdo#62096 - replace some O(U)String compareTo with ==

2013-04-16 Thread Artur Dryomov (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3422 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/3422/1 fdo#62096 - replace some O(U)String compareTo with == Change-Id: I98d04d7da4c2b7ea0b769df9c2bfa8c1ad86bf2d --- M

[PATCH] forward RTL_CONTEXT_foo logging to SAL_INFO in default debug...

2013-04-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3421 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/3421/1 forward RTL_CONTEXT_foo logging to SAL_INFO in default debugging * RTL_CONTEXT_foo is originally intended to be

[Libreoffice-commits] core.git: cppu/source

2013-04-16 Thread Tor Lillqvist
cppu/source/uno/lbenv.cxx |4 1 file changed, 4 deletions(-) New commits: commit 8a9398fad0c5267f25ce8bc68eb63e91334faff5 Author: Tor Lillqvist Date: Tue Apr 16 20:24:07 2013 +0300 WaE: variable 'hMod' set but not used Change-Id: Iae64943671a576159be0fa311bc503aa96b2b5df

[Libreoffice-commits] core.git: scripting/source

2013-04-16 Thread Stephan Bergmann
scripting/source/stringresource/stringresource.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 617e7c623167308e6fb8501822158fe1af72ba47 Author: Stephan Bergmann Date: Tue Apr 16 19:07:36 2013 +0200 Missing include Change-Id: I1be082b7db5592ad5090c

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - xmlhelp/prj

2013-04-16 Thread Petr Mladek
xmlhelp/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 243df043a4ee78509049c5fd5a9f72cce46b029c Author: Petr Mladek Date: Tue Apr 16 18:14:55 2013 +0200 xmlhelp depends on vcl now The dependency has been added by the commit "icon style

Re: patch for postgresql driver

2013-04-16 Thread Wols Lists
On 16/04/13 16:13, Lubos Lunak wrote: > On Tuesday 16 of April 2013, Wols Lists wrote: >> The attached patch is not in logerrit (I've yet to set that up), and >> there's an error in it so I'm hoping someone can help. It does a TODO in >> the file, but I can't get my argument casting right - in the

Re: Master branch now requires liborcus 0.5.0 or higher.

2013-04-16 Thread Kohei Yoshida
On Sat, Apr 13, 2013 at 5:55 AM, Bjoern Michaelsen < bjoern.michael...@canonical.com> wrote: > Hi Kohei, > > On Sat, Apr 13, 2013 at 02:46:33AM -0400, Kohei Yoshida wrote: > > FYI, I've updated liborcus on the master branch just now. You now need > > liborcus 0.5.0 or higher in order to build. It

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - xmlhelp/prj

2013-04-16 Thread Petr Mladek
xmlhelp/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3b593c9b9c014bbfffa3d19b7649229d2c4747b3 Author: Petr Mladek Date: Tue Apr 16 18:14:55 2013 +0200 xmlhelp depends on vcl now The dependency has been added by the commit "icon style

Re: [Libreoffice-qa] Enhancements - Getting User Input

2013-04-16 Thread Wols Lists
On 16/04/13 15:04, Robinson Tryon wrote: >> > If they wanted to work on them, they would work on >> > them independently on the voting results. >> > > Hmm... I imagine that some of the volunteers might like a little > guidance as to what bugs/issues are most affecting our users right > now? > Or,

[Libreoffice-commits] core.git: sc/uiconfig

2013-04-16 Thread Abdulelah Alarifi
sc/uiconfig/scalc/ui/goalseekdlg.ui | 244 1 file changed, 244 insertions(+) New commits: commit 163a64ef2610f2f3e1f3a9acc5bf1e9545b02ffe Author: Abdulelah Alarifi Date: Tue Apr 16 11:52:10 2013 +0300 Converted Tools -> Goal Seek widget. Chan

[PUSHED] Converted Tools -> Goal Seek widget.

2013-04-16 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3405 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3405 To unsubscribe, vi

[Libreoffice-commits] core.git: solenv/gbuild

2013-04-16 Thread David Tardon
solenv/gbuild/Dictionary.mk | 24 1 file changed, 24 deletions(-) New commits: commit 41dc2dbc6d5d87f9f008ab140a0cd2b41fcc8fa5 Author: David Tardon Date: Tue Apr 16 18:04:19 2013 +0200 Revert "add spec. handling for xcu files to gb_Dictionary" Michael w

[Libreoffice-commits] core.git: solenv/gbuild

2013-04-16 Thread Michael Stahl
solenv/gbuild/Dictionary.mk | 14 ++ 1 file changed, 14 insertions(+) New commits: commit 4ff3a87282185a3bd3dfa69128596e6e3b41ce18 Author: Michael Stahl Date: Tue Apr 16 17:54:24 2013 +0200 gbuild: add gb_Dictionary_add_localized_xcu_file ... which fixed en-US only

[Libreoffice-commits] dictionaries.git: Dictionary_en.mk Dictionary_hu.mk Dictionary_pt-BR.mk Dictionary_ru.mk

2013-04-16 Thread Michael Stahl
Dictionary_en.mk|4 ++-- Dictionary_hu.mk|4 ++-- Dictionary_pt-BR.mk |4 ++-- Dictionary_ru.mk|4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) New commits: commit faf63ac08a9f3f1463a7f119083964f76b71141c Author: Michael Stahl Date: Tue Apr 16 17:52:11 2013

[Libreoffice-commits] core.git: 2 commits - dictionaries solenv/gbuild

2013-04-16 Thread Michael Stahl
dictionaries|2 +- solenv/gbuild/Dictionary.mk | 24 2 files changed, 25 insertions(+), 1 deletion(-) New commits: commit b3a60fc6c4588481a394aaddd0ff0a55c48c7eee Author: Michael Stahl Date: Tue Apr 16 17:52:11 2013 +0200 Updated core Pro

[PUSHED] stoc: do not use rtl/unload.h functionality

2013-04-16 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3316 -- To view, visit https://gerrit.libreoffice.org/3316 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PUSHED] do not use deprecated rtl_registerModuleForUnloading

2013-04-16 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3315 -- To view, visit https://gerrit.libreoffice.org/3315 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PUSHED] API CHANGE: remove some of useless rtl/unload.h functionalit...

2013-04-16 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3317 -- To view, visit https://gerrit.libreoffice.org/3317 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

  1   2   3   >