On Tue, Apr 16, 2013 at 09:24:03PM +0100, Wols Lists wrote: > On 16/04/13 20:28, Lionel Elie Mamane wrote: >> On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote:
>>> I can't get my argument casting right - in the original >>> code, matchIgnoreAsciiCaseAsciiL wraps its argument in >>> RTL_CONSTASCII_STRINGPARAM. >> RTL_CONSTASCII_STRINGPARAM is a hack/optimisation specific to >> compile-time constants. With your change, the string is not anymore >> a compile-time constant, so just use >> equalsIgnoreAsciiCaseAscii() > I'm puzzled that it's not a compile-time constant Well, it is not even a run-time constant: at each iteration of the loop, it is a different value. > As soon as LO has built successfully, I'll sort out the patch and ask > someone to test it :-) The PostgreSQL driver is (particularly) my area, so keep me in CC. If you are interested in working on the Postgres driver, have a look at https://bugs.freedesktop.org/show_bug.cgi?id=43369 There are also a few bugs I didn't have time to look at. -- Lionel _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
