[Libreoffice-commits] core.git: connectivity/Library_tdeabdrv1.mk vcl/Library_vclplug_tde.mk

2013-03-18 Thread Timothy Pearson
connectivity/Library_tdeabdrv1.mk |4 vcl/Library_vclplug_tde.mk|4 2 files changed, 8 insertions(+) New commits: commit edd2531f5d84c184257f161d56b89e6fe6e90469 Author: Timothy Pearson Date: Tue Mar 19 01:00:50 2013 + Fix single core build when TDE integrati

[PATCH] fix fdo#62050 : Initially disable RTL for comment window.

2013-03-18 Thread navin patidar (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2831 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/2831/1 fix fdo#62050 : Initially disable RTL for comment window. In RTL UI, comment window is RTL and editbox’s (editen

Re: [libreoffice-users] Development of Extensions for LibreOffice

2013-03-18 Thread Tor Lillqvist
> (on Linux and OS X the executable file is called "soffice", on Windows > "soffice.bin"). Oops, sorry, thinko: It's soffice.bin on Linux, too. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/li

Re: [RFC] add --pidfile switch to write libo pid to a file

2013-03-18 Thread Tor Lillqvist
>.It would thus look more natural to be interested in pid files > from the client-facing process rather than from soffice.bin processes (which > your patch would implement). Ah, but his very point is that he is working on the --enable-headless thing, where (if I understand correctly) there is no "

Re: [libreoffice-users] Development of Extensions for LibreOffice

2013-03-18 Thread Tor Lillqvist
I have no clue about Eclipse, except that I can only strongly agree with what Michael said: It is fairly unlikely that Eclipse (or any other similar tool) would be able to make sense out of the whole LibreOffice source code (or just the Calc-related parts), at least not using reasonable time and sp

Re: #ifdef vs #if for feature checks

2013-03-18 Thread Tor Lillqvist
> otoh, #pragma once is supported by all the compiler we use isn't it ? Excellent! Let's do that, unless somebody comes up with a counter-argument in a week or so. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedes

[Libreoffice-commits] core.git: cui/source svx/inc svx/source

2013-03-18 Thread Takeshi Abe
cui/source/options/optdict.cxx |5 ++--- svx/inc/svx/langbox.hxx |2 +- svx/source/dialog/_contdlg.cxx |8 svx/source/dialog/contimp.hxx|6 +++--- svx/source/dialog/fntctrl.cxx| 12 ++-- svx/source/dialog/graphctl.cxx | 10 +- svx

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/qa

2013-03-18 Thread Kohei Yoshida
sc/qa/unit/ucalc.cxx | 34 ++ 1 file changed, 34 insertions(+) New commits: commit a646a42e3d2fdaf5fe1b597a513d0be22a6d8557 Author: Kohei Yoshida Date: Mon Mar 18 23:36:55 2013 -0400 Unit test for formula token array vectorization state. Change-I

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - 2 commits - sc/inc sc/Library_sc.mk sc/qa sc/source

2013-03-18 Thread Kohei Yoshida
sc/Library_sc.mk |1 sc/inc/bigrange.hxx | 20 +- sc/inc/cell.hxx |2 + sc/inc/chgtrack.hxx |3 +- sc/inc/column.hxx

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-18 Thread Markus Mohrhard
Hey Eric, I pused your patch to master and the test file to the test-file repository. I only moved in a follow-up patch the handling for gnumeric values from chart2 into xmloff. IMO the handling of file format issues should be kept in the filter code and not be moved to the chart core code. Than

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - 2 commits - formula/inc formula/source sc/inc sc/source

2013-03-18 Thread Kohei Yoshida
formula/inc/formula/compiler.hrc |4 + formula/inc/formula/tokenarray.hxx |6 ++ formula/source/core/api/token.cxx | 21 +++-- sc/inc/tokenarray.hxx | 10 sc/source/core/tool/token.cxx | 80 - 5 files changed, 114 inse

[Libreoffice-commits] calc/chart

2013-03-18 Thread Libreoffice Gerrit user
calc/chart/test stepped lines.ods |binary 1 file changed New commits: commit 994bf7225dd36eaa28d8e49187b557315b03f271 Author: Eric Seynaeve Date: Tue Mar 19 02:57:18 2013 +0100 add test file for stepped lines chart diff --git a/calc/chart/test stepped lines.ods b/calc/chart/test stepped

[Libreoffice-commits] core.git: sc/Module_sc.mk sc/qa

2013-03-18 Thread Markus Mohrhard
sc/Module_sc.mk |2 ++ sc/qa/unit/ucalc.cxx |2 +- 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit 60ab9a0bc8af439a7b7d0f57ea6b5215dc8aa9fa Author: Markus Mohrhard Date: Tue Mar 19 02:42:42 2013 +0100 that should not have been in the patch diff --git a/sc

[PUSHED] fdo#61135 stepped lines graph: handle ods files

2013-03-18 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2476 -- To view, visit https://gerrit.libreoffice.org/2476 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[Libreoffice-commits] core.git: 2 commits - chart2/source offapi/com sc/Module_sc.mk sc/qa xmloff/inc xmloff/source

2013-03-18 Thread Markus Mohrhard
chart2/source/controller/chartapiwrapper/WrappedSplineProperties.cxx | 59 +++- chart2/source/view/charttypes/AreaChart.cxx | 143 +- chart2/source/view/charttypes/AreaChart.hxx |4 offapi/com/sun/star/chart2/CurveStyle.idl

[PATCH] Fix single core build when TDE integration is enabled

2013-03-18 Thread Timothy Pearson (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2830 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/2830/1 Fix single core build when TDE integration is enabled Change-Id: I15d537a8ea7d3a42c9a1924dd81e83ba9b4aa421 --- M

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - sd/source

2013-03-18 Thread Pavel Janík
sd/source/ui/presenter/PresenterHelper.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e8c4da9a7aacbf0d89b7c7b4d59375f936349ea0 Author: Pavel Janík Date: Mon Mar 18 20:00:34 2013 + Initialize variable to prevent warning. diff --git a/sd/source/ui/pre

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/inc sc/source

2013-03-18 Thread Kohei Yoshida
sc/inc/tokenarray.hxx|3 +++ sc/source/core/tool/compiler.cxx |1 + sc/source/core/tool/token.cxx| 21 +++-- 3 files changed, 19 insertions(+), 6 deletions(-) New commits: commit 526782001ff6ab3110ef1da6e114eb0c738ce6e3 Author: Kohei Yoshida Date: Mon

Re: #ifdef vs #if for feature checks

2013-03-18 Thread Norbert Thiebaud
On Mon, Mar 18, 2013 at 11:17 AM, Lubos Lunak wrote: > On Monday 18 of March 2013, Tor Lillqvist wrote: >> > Sounds great to me too; though of course I'd prefer to keep the diff >> > smaller and not replace all the header guards: >> > >> > #ifndef INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX >> > #defi

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - formula/source

2013-03-18 Thread Kohei Yoshida
formula/source/core/api/FormulaCompiler.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 533a088d51bf4fe1c216d2a2806e55ae85a42c06 Author: Kohei Yoshida Date: Mon Mar 18 17:14:51 2013 -0400 Fix indentation. Change-Id: Ia277ac4e9eeb34a2b0244ebb5f09c4

Re: Re: Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-18 Thread Eric Seynaeve
On Monday 18 March 2013 21:07:08 Markus Mohrhard wrote: > As Michael pointed out values are not namespaced. So the code should > just map the gnm values to the normal ODF properties. I'll set that up. Michael also mentioned that the changes in StyleOASISTContext.cxx are not needed. I will drop th

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/qa sc/source

2013-03-18 Thread Kohei Yoshida
sc/qa/unit/ucalc.cxx|6 +++--- sc/source/core/data/cell2.cxx |2 ++ sc/source/core/data/column.cxx |1 + sc/source/core/data/column3.cxx |2 ++ 4 files changed, 8 insertions(+), 3 deletions(-) New commits: commit 84e8f0c171c835abb4ccc62cd84ea9ee0ba1491b Author: Kohe

[Bug 60270] LibreOffice 4.1 most annoying bugs

2013-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60270 Joel Madero changed: What|Removed |Added Depends on||61940 -- You are receiving this mail beca

[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Joel Madero changed: What|Removed |Added Depends on|61940 | -- You are receiving this mail because:

[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Joel Madero changed: What|Removed |Added Depends on||61940 -- You are receiving this mail beca

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-18 Thread Eric Seynaeve
On Monday 11 March 2013 21:59:47 Michael Stahl wrote: > in the latter Sun days there were plans to query the ODF version from > the configuration in the UI and only allow inserting those content > elements that are supported by the selected ODF version. i can't > remember if anything was ever impl

[PATCH] fdo#60780, Save a Copy wip

2013-03-18 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2829 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2829/1 fdo#60780, Save a Copy wip The saving seems to work fine, but immediately opening the copy doesn't work, you hav

[PATCH] move files.mk to officecfg directory

2013-03-18 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2823 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/2823/1 move files.mk to officecfg directory Change-Id: Ia2b793491e4d378ac012debf0beaf6c40d0ee1e1 --- M officecfg/Custom

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/qa sc/source

2013-03-18 Thread Michael Meeks
sc/qa/unit/ucalc.cxx| 58 sc/source/core/data/cell2.cxx | 14 +++-- sc/source/core/data/column3.cxx |4 -- 3 files changed, 69 insertions(+), 7 deletions(-) New commits: commit e5617cec76d2d6ad70175d7ffddf6cbcb8eabe85 Author: Mich

Re: [libreoffice-users] Development of Extensions for LibreOffice

2013-03-18 Thread Stephen Morris
On 03/18/2013 10:54 PM, Michael Meeks wrote: Hi Stephen, On Mon, 2013-03-18 at 08:34 +1100, Stephen Morris wrote: I am having all sorts of problems with the source code in Eclipse. I have created a new blank C++ project in Eclipse and imported the entire sc directory into that project. Su

Re: [RFC] add --pidfile switch to write libo pid to a file

2013-03-18 Thread Stephan Bergmann
On 03/16/2013 07:55 PM, Riccardo Magliocchetti wrote: attached a patch to add a switch to have libreoffice store its pid in a file. I need that so that when libo runs in headless mode i can have a supervisor process checking if libo is running and in case just restart it. The error handling is a

[SOLVED] Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

2013-03-18 Thread julien2412
grr, forgot to mark this as "solved". -- View this message in context: http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p4044604.html Sent from the Dev mailing list archive at Nabble.com. _

Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

2013-03-18 Thread julien2412
All of the sudden my 2 neurons connected :-) I pushed the patch on master. See http://cgit.freedesktop.org/libreoffice/core/commit/?id=91c8b357ee2a27e50da0e99386e53d351e55cfda Thank you Lubos! Julien -- View this message in context: http://nabble.documentfoundation.org/cppcheck-Variables-rea

[Libreoffice-commits] core.git: vcl/unx

2013-03-18 Thread Julien Nabet
vcl/unx/kde4/KDESalFrame.cxx |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit 91c8b357ee2a27e50da0e99386e53d351e55cfda Author: Julien Nabet Date: Mon Mar 18 22:03:52 2013 +0100 Cppcheck: Variables reassigned before the old one has been use See

Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

2013-03-18 Thread Lubos Lunak
On Monday 18 of March 2013, julien2412 [via Document Foundation Mail Archive] wrote: > Hi Lubos, > > But which ones are the useless? > QPalette::WindowText and QPalette::Window > or > QPalette::ButtonText and QPalette::Button The ones which are not used. -- Lubos Lunak l.lu...@suse.cz --

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/qa sc/source

2013-03-18 Thread Kohei Yoshida
sc/qa/unit/ucalc.cxx | 82 +- sc/source/core/tool/token.cxx | 40 ++-- 2 files changed, 78 insertions(+), 44 deletions(-) New commits: commit f974be31a7881c4ad72d9c29b4db3c435bd99ba5 Author: Kohei Yoshida Date: Mon Mar 18 16:

Re: Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-18 Thread Markus Mohrhard
2013/3/16 Eric Seynaeve : > I have (finally) created a mock with the new features added. There was a > mistake in it first which cause me to loose quite some time in a wild > goose-chase :-( I attach it so this mail and place it under MPL/LGPLv3. > > > > On Friday 08 March 2013 09:55:53 Markus Mohr

I am Vincent, I am glad to join libreoffice gsoc

2013-03-18 Thread vincent
Hello everyone, I am Vincent, I am glad to join libreoffice. Following are some information about Me. 1. I am a student from Beijing University of Aeronautics and Astronautics, China, major at Computer science. this year is my third-year on university. 2. I am good at C++ programming, and I love

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - formula/inc formula/source sc/inc sc/source

2013-03-18 Thread Kohei Yoshida
formula/inc/formula/tokenarray.hxx |1 formula/source/core/api/token.cxx | 52 - sc/inc/tokenarray.hxx |2 + sc/source/core/tool/token.cxx | 52 + 4 files changed, 54 insertions(+), 53 deletions

Re: [Libreoffice-commits] core.git: use startsWith() instead of compareToAscii()

2013-03-18 Thread Julien Nabet
On 18/03/2013 09:07, Lionel Elie Mamane wrote: Lionel, could this point explain these logs I had put in https://bugs.freedesktop.org/show_bug.cgi?id=61725#c7) : warn:legacy.osl:22802:1:dbaccess/source/core/misc/dsntypes.cxx:369: ODsnTypeCollection::implDetermineType : missing the second colon ! w

QA Field in FDO - What's the Purpose (discussion)

2013-03-18 Thread Joel Madero
During our last QA call we had a continuing discussion about the QA field that Rainer began a few weeks back [1] Basically the conversation is "what's the point of the QA field" There are multiple opinions: 1. QA Field should represent exactly what Dev field represents, ie. QA contact is respons

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/qa

2013-03-18 Thread Kohei Yoshida
sc/qa/unit/ucalc.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit 873c4bed403133b39ddf90858976ee431f1a4a09 Author: Kohei Yoshida Date: Mon Mar 18 14:37:34 2013 -0400 Fix minor stuff in the test code... Change-Id: I6c1ebf29d357c1a575a8b7d542104

[PATCH libreoffice-4-0] error bar range is also part of chart range, related fdo#521...

2013-03-18 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2820 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/2820/1 error bar range is also part of chart range, related fdo#52159 Change-Id: I38db559de8435dcc26e2be4597c385724

[PATCH libreoffice-4-0] we need to register data sequences during import, fdo#52159

2013-03-18 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2821 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/2821/1 we need to register data sequences during import, fdo#52159 Change-Id: I203be719a6ee19c87ed232218f7700d875c2871f

[PATCH libreoffice-4-0] for internal data providers this makes no sense

2013-03-18 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2819 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/2819/1 for internal data providers this makes no sense Change-Id: Ic2651defd0ec8846dc0b0a81faee5dd6743310fb (cherry pic

[PATCH libreoffice-4-0] use the right range representation, fdo#52159

2013-03-18 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2818 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/2818/1 use the right range representation, fdo#52159 Change-Id: I36ede89ccb8836708a4f87c4815bbe2fb6d6f3cf (cherry picke

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - formula/source sc/inc sc/qa sc/source

2013-03-18 Thread Kohei Yoshida
formula/source/core/api/token.cxx | 49 +++ sc/inc/column.hxx |2 + sc/inc/document.hxx |4 ++ sc/inc/table.hxx |2 + sc/qa/unit/ucalc.cxx | 52 ++ sc/sou

Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

2013-03-18 Thread julien2412
Hi Lubos, But which ones are the useless? QPalette::WindowText and QPalette::Window or QPalette::ButtonText and QPalette::Button Julien -- View this message in context: http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p

[Libreoffice-commits] core.git: sal/osl

2013-03-18 Thread Tor Lillqvist
sal/osl/w32/dllentry.c | 19 - sal/osl/w32/interlck.c | 101 - 2 files changed, 120 deletions(-) New commits: commit 0a21cce0c90a639918d8e58ac5daa4b8f674666f Author: Tor Lillqvist Date: Mon Mar 18 20:07:31 2013 +0200 Use Interlock

[Libreoffice-commits] core.git: 2 commits - svl/source

2013-03-18 Thread Eike Rathke
svl/source/numbers/zformat.cxx | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) New commits: commit 9a46e5614f5a0e0bdce3c497f81ca529da8fb5c0 Author: Eike Rathke Date: Mon Mar 18 18:59:09 2013 +0100 renamed method, it determines if symbol combines Ch

icerun busts unit tests ?

2013-03-18 Thread Michael Meeks
Hi there, Just poking at a deliberately instrumented sc_ucalc unit test - with a random SEGV thrown in. It seems that 'make check' passes nicely if 'icerun' is included in the command: - icerun $O/bin/cppunit/cppunittester $W/LinkTarget/CppunitTest/libtest_sc_ucalc.so ... || e

[Libreoffice-commits] core.git: 3 commits - vcl/inc

2013-03-18 Thread Tor Lillqvist
vcl/inc/aqua/atsui/salgdi.h |2 -- vcl/inc/coretext/salgdi.h |2 -- vcl/inc/headless/svpbmp.hxx |2 +- vcl/inc/headless/svpframe.hxx | 12 ++-- vcl/inc/headless/svpgdi.hxx | 37 ++--- vcl/inc/headless/svpinst.hxx | 40 +++

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - svl/source

2013-03-18 Thread Eike Rathke
svl/source/numbers/zformat.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6690e18c5f45e24d013bcccdc47a2d32a3b2f050 Author: Eike Rathke Date: Mon Mar 18 18:24:24 2013 +0100 make empty subformat code work again Broken with 842c95519a35174238c72

[Libreoffice-commits] core.git: setup_native/source

2013-03-18 Thread Rene Engelhard
setup_native/source/packinfo/packinfo_office.txt | 29 --- 1 file changed, 29 deletions(-) New commits: commit 4c6721542a53e017e555c8c12bfcbb0e2b6e1b3c Author: Rene Engelhard Date: Mon Mar 18 18:27:13 2013 +0100 one time is enough ;) Change-Id: I298433a242ed

[Libreoffice-commits] core.git: svl/source

2013-03-18 Thread Eike Rathke
svl/source/numbers/zformat.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit ca0074829af6b68ee8f00ce0231de4fcd17b7b2b Author: Eike Rathke Date: Mon Mar 18 18:24:24 2013 +0100 make empty subformat code work again Broken with 842c95519a35174238c

[Libreoffice-commits] core.git: 2 commits - solenv/gbuild solenv/gcc-wrappers

2013-03-18 Thread Luboš Luňák
solenv/gbuild/platform/com_GCC_defs.mk |2 -- 1 file changed, 2 deletions(-) New commits: commit adfb7ecb4f77c4ccb70156044a41505648df0ad4 Author: Luboš Luňák Date: Mon Mar 18 18:17:46 2013 +0100 Revert "add -Wundef to compiler flags" This reverts commit 22771babcc47b294d52

[Libreoffice-commits] core.git: 2 commits - scp2/source setup_native/source

2013-03-18 Thread Rene Engelhard
scp2/source/base/module_base.scp |3 - scp2/source/ooo/module_pdfimport.scp |2 scp2/source/ooo/module_reportbuilder.scp |5 + setup_native/source/packinfo/packinfo_office.txt | 60 +++ 4 files changed, 65 insertions(+), 5 dele

Closing Old NEEDINFO Bugs

2013-03-18 Thread Joel Madero
Hi All, Just a heads up that QA will be moving forward this week with closing bugs that have been dead for >6 months. After long deliberation and many conversations during calls and through email, we think that overall this will be a very positive thing for the project. I will be doing the first

Re: NumericBox unsafe double conversion

2013-03-18 Thread Zolnai Tamás
Hi Kendy, Can you please point exactly to the code in question, like > filename:line_number, or ClassName::MethodName, or something similar? > It helps a lot to understand what you have in mind, and saves the > guessing if it was (in this case) MetricField::ConvertValue() from > vcl/source/control

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b6/9333045a54fb8ac0d5aabbf01b1fd125985e81

2013-03-18 Thread Eike Rathke
b6/9333045a54fb8ac0d5aabbf01b1fd125985e81 |1 + 1 file changed, 1 insertion(+) New commits: commit c5595359f69812d0538571084f391fa51171611f Author: Eike Rathke Date: Mon Mar 18 17:53:47 2013 +0100 Notes added by 'git notes add' diff --git a/b6/9333045a54fb8ac0d5aabbf01b1fd125985e81

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 9c/7d0d72e5e1d8a2cb42405b4914ca1f43de1875

2013-03-18 Thread Eike Rathke
9c/7d0d72e5e1d8a2cb42405b4914ca1f43de1875 |1 + 1 file changed, 1 insertion(+) New commits: commit b047cd4f9bcdcad2a3264ac8a3247bd5146ddfd0 Author: Eike Rathke Date: Mon Mar 18 17:53:20 2013 +0100 Notes added by 'git notes add' diff --git a/9c/7d0d72e5e1d8a2cb42405b4914ca1f43de1875

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - e3/d6b7ed9528bcf4ed83e1df0de46a7f033c20c1

2013-03-18 Thread Eike Rathke
e3/d6b7ed9528bcf4ed83e1df0de46a7f033c20c1 |1 + 1 file changed, 1 insertion(+) New commits: commit 49b76826570f9ffd29a82de535546c448f1874c4 Author: Eike Rathke Date: Mon Mar 18 17:50:34 2013 +0100 Notes added by 'git notes add' diff --git a/e3/d6b7ed9528bcf4ed83e1df0de46a7f033c20c1

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 47/4752f6a5b318bed467c745b8a7c8477c76d079

2013-03-18 Thread Eike Rathke
47/4752f6a5b318bed467c745b8a7c8477c76d079 |1 + 1 file changed, 1 insertion(+) New commits: commit b7641dbb17d46b3c99070c8fe1eec9157195d02c Author: Eike Rathke Date: Mon Mar 18 17:50:07 2013 +0100 Notes added by 'git notes add' diff --git a/47/4752f6a5b318bed467c745b8a7c8477c76d079

[Libreoffice-commits] core.git: 3 commits - shell/source

2013-03-18 Thread Eike Rathke
shell/source/unix/misc/senddoc.sh | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) New commits: commit e837d5570af3de1a420ad21ec035463cf9babdb7 Author: Eike Rathke Date: Mon Mar 18 17:48:59 2013 +0100 quote URI_ENCODE Change-Id: Ib3bb6065b02eee

Re: Profiling LibreOfficeDev.app on OSX with XCode Instruments, Sudden Termination, and Unprotected File System Access

2013-03-18 Thread Alexander Thurgood
Le 18/03/13 17:06, Tor Lillqvist a écrit : > > I guess these "unprotected file access" things are for stuff that > would access files outside of the sandbox, *if* LibreOffice was a > sandboxed process. But it isn't. If and when we (for some value of > "us") wish to distribute a build of it throug

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/inc sc/source

2013-03-18 Thread Michael Meeks
sc/inc/document.hxx |1 + sc/inc/table.hxx |1 + sc/source/core/data/cell.cxx |5 + sc/source/core/data/column3.cxx |4 sc/source/core/data/documen9.cxx |8 sc/source/core/data/table6.cxx |6 ++ 6 files changed, 25 i

Re: [RFC] add --pidfile switch to write libo pid to a file

2013-03-18 Thread Riccardo Magliocchetti
Hi Michael, Il 18/03/2013 16:21, Michael Meeks ha scritto: On Mon, 2013-03-18 at 14:41 +0100, Riccardo Magliocchetti wrote: The standard practice is to use just a plain file with the pid inside, other tools won't parse an ini file just to find the pid. Seems unlikely to cause any rea

[Bug 60270] LibreOffice 4.1 most annoying bugs

2013-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60270 Bug 60270 depends on bug 61651, which changed state. Bug 61651 Summary: MinGW: Tinderbox @7 does not deliver 4.1 Master builds https://bugs.freedesktop.org/show_bug.cgi?id=61651 What|Removed |Added

[Bug 60270] LibreOffice 4.1 most annoying bugs

2013-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60270 Rainer Bielefeld changed: What|Removed |Added Depends on||62478 --- Comment #9 from Rainer Biel

Re: #ifdef vs #if for feature checks

2013-03-18 Thread Lubos Lunak
On Monday 18 of March 2013, Tor Lillqvist wrote: > > Sounds great to me too; though of course I'd prefer to keep the diff > > smaller and not replace all the header guards: > > > > #ifndef INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX > > #define INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX This is not abou

[Libreoffice-commits] core.git: 13 commits - basic/source config_host/config_kde4.h.in config_host/README connectivity/source cppuhelper/source cppunit/UnpackedTarball_cppunit.mk cppunit/wundef.patch

2013-03-18 Thread Luboš Luňák
basic/source/sbx/sbxcurr.cxx |8 +- config_host/README |9 ++ config_host/config_kde4.h.in |3 connectivity/source/drivers/mork/MNSFolders.cxx|2 connectivity/source/dr

Re: Profiling LibreOfficeDev.app on OSX with XCode Instruments, Sudden Termination, and Unprotected File System Access

2013-03-18 Thread Tor Lillqvist
Seems a bit misleading to me, as the same LibreOffice runs just fine otherwise, right? I guess these "unprotected file access" things are for stuff that would access files outside of the sandbox, *if* LibreOffice was a sandboxed process. But it isn't. If and when we (for some value of "us") wish t

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 91/10bec22f3dafa416e9a51ac763404dd5382d0c

2013-03-18 Thread Eike Rathke
91/10bec22f3dafa416e9a51ac763404dd5382d0c |1 + 1 file changed, 1 insertion(+) New commits: commit 9c3ede7363523db777a7d36dbe42815199ea3efe Author: Eike Rathke Date: Mon Mar 18 17:03:41 2013 +0100 Notes added by 'git notes add' diff --git a/91/10bec22f3dafa416e9a51ac763404dd5382d0c

Profiling LibreOfficeDev.app on OSX with XCode Instruments, Sudden Termination, and Unprotected File System Access

2013-03-18 Thread Alexander Thurgood
Hi all, So, seeing as I don't know how to code in anything remotely useful to the project, and at present, I don't have the time to learn, I've started playing around with a tool that Apple provides called Instruments.app, which is supplied as part of the XCode developer suite. One of the profile

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 3b/a7f7c1e74ec1d2283ebd5b9cbe62f80c276b6a

2013-03-18 Thread Eike Rathke
3b/a7f7c1e74ec1d2283ebd5b9cbe62f80c276b6a |1 + 1 file changed, 1 insertion(+) New commits: commit ce21843ce0ec20b2264c043320103609451fd488 Author: Eike Rathke Date: Mon Mar 18 16:47:41 2013 +0100 Notes added by 'git notes add' diff --git a/3b/a7f7c1e74ec1d2283ebd5b9cbe62f80c276b6a

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 9d/f4b5b7c873ea460628819a3ab01a49985398da

2013-03-18 Thread Michael Meeks
9d/f4b5b7c873ea460628819a3ab01a49985398da |1 + 1 file changed, 1 insertion(+) New commits: commit 3a76a66fd60f585ff1dd90667e66267fdbdbb40e Author: Michael Meeks Date: Mon Mar 18 15:37:43 2013 + Notes added by 'git notes add' diff --git a/9d/f4b5b7c873ea460628819a3ab01a49985398da

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - e2/4f37d1aea63942168af7bf3c15e4f0878647b0

2013-03-18 Thread Michael Meeks
e2/4f37d1aea63942168af7bf3c15e4f0878647b0 |1 + 1 file changed, 1 insertion(+) New commits: commit d721e4db1203a0431209c1118b0083e9f9cabeef Author: Michael Meeks Date: Mon Mar 18 15:35:17 2013 + Notes added by 'git notes add' diff --git a/e2/4f37d1aea63942168af7bf3c15e4f0878647b0

[PUSHED] fdo#61950 move report builder from bundled extensions to pla...

2013-03-18 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2718 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2718 To unsubscribe, vi

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 7e/1023e9803c7ad9d5555e068ee59b010f173277

2013-03-18 Thread Michael Meeks
7e/1023e9803c7ad9de068ee59b010f173277 |1 + 1 file changed, 1 insertion(+) New commits: commit 605d8def0dd7b506bf03c936f376eac4b035486d Author: Michael Meeks Date: Mon Mar 18 15:43:46 2013 + Notes added by 'git notes add' diff --git a/7e/1023e9803c7ad9de068ee59b010f173277

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 31/999435967860c0c7188f16ba30c7fc65b79962

2013-03-18 Thread Michael Meeks
31/999435967860c0c7188f16ba30c7fc65b79962 |1 + 1 file changed, 1 insertion(+) New commits: commit cf3e3f9a2e1a2e426c67f5eb58add27d54ea099e Author: Michael Meeks Date: Mon Mar 18 15:43:19 2013 + Notes added by 'git notes add' diff --git a/31/999435967860c0c7188f16ba30c7fc65b79962

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 07/e91c3c400d6f480579c1f32e447d41f9cec7e6

2013-03-18 Thread Michael Meeks
07/e91c3c400d6f480579c1f32e447d41f9cec7e6 |1 + 1 file changed, 1 insertion(+) New commits: commit 41c6211baebf1a262b1676547d2c7c03befe00ad Author: Michael Meeks Date: Mon Mar 18 15:40:19 2013 + Notes added by 'git notes add' diff --git a/07/e91c3c400d6f480579c1f32e447d41f9cec7e6

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 6f/0193eeaa04b89ccbc58dacfbd498e562ea69e2

2013-03-18 Thread Michael Meeks
6f/0193eeaa04b89ccbc58dacfbd498e562ea69e2 |1 + 1 file changed, 1 insertion(+) New commits: commit b4996468ee1a0af04edf430c35b2dfdcef642ac1 Author: Michael Meeks Date: Mon Mar 18 15:39:49 2013 + Notes added by 'git notes add' diff --git a/6f/0193eeaa04b89ccbc58dacfbd498e562ea69e2

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b4/9e6a67f69c92740777ab621d918a076af24313

2013-03-18 Thread Michael Meeks
b4/9e6a67f69c92740777ab621d918a076af24313 |1 + 1 file changed, 1 insertion(+) New commits: commit 65bbb1a7257062176f2a8cc23b9ed18c9d3f9145 Author: Michael Meeks Date: Mon Mar 18 15:39:33 2013 + Notes added by 'git notes add' diff --git a/b4/9e6a67f69c92740777ab621d918a076af24313

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - f5/2935898ce57622c06eb9c04bef63f047fcbe7d

2013-03-18 Thread Michael Meeks
f5/2935898ce57622c06eb9c04bef63f047fcbe7d |1 + 1 file changed, 1 insertion(+) New commits: commit 23c66128ad2f380dd8b0c48167284544ae1822ab Author: Michael Meeks Date: Mon Mar 18 15:37:06 2013 + Notes added by 'git notes add' diff --git a/f5/2935898ce57622c06eb9c04bef63f047fcbe7d

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 18/07162bc9f87971e5a0fae2d7ba95fad6fa6904

2013-03-18 Thread Michael Meeks
18/07162bc9f87971e5a0fae2d7ba95fad6fa6904 |1 + 1 file changed, 1 insertion(+) New commits: commit bf1b0795ff2212c105e1b54d41f1ebaccef226f5 Author: Michael Meeks Date: Mon Mar 18 15:36:44 2013 + Notes added by 'git notes add' diff --git a/18/07162bc9f87971e5a0fae2d7ba95fad6fa6904

Can we localize math commands?

2013-03-18 Thread Tadele Assefa
Dear all, I have two questions: Can we localize the LO Math commands like, sum, from %alpha, %theta etc? Regards, -- Regards,* ___ Tadele Assefa Managing Director* * Cell: +25-911-84-13-84* *Think Green – Please do not print this email unless you really need to*

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 0c/e5e664b83fddfbc5557b63102416835f51b716

2013-03-18 Thread Michael Meeks
0c/e5e664b83fddfbc5557b63102416835f51b716 |1 + 1 file changed, 1 insertion(+) New commits: commit 127e4348fbd2f731feea160696383bc2625e6690 Author: Michael Meeks Date: Mon Mar 18 15:34:52 2013 + Notes added by 'git notes add' diff --git a/0c/e5e664b83fddfbc5557b63102416835f51b716

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 38/3d0ef226e449a4104b14348030c332f58146c8

2013-03-18 Thread Michael Meeks
38/3d0ef226e449a4104b14348030c332f58146c8 |1 + 1 file changed, 1 insertion(+) New commits: commit 213bf655e75e423f1c22abcb8d87b1d0af7f8b5d Author: Michael Meeks Date: Mon Mar 18 15:34:35 2013 + Notes added by 'git notes add' diff --git a/38/3d0ef226e449a4104b14348030c332f58146c8

Re: Tips to create an extension for digital signature

2013-03-18 Thread Andrea Castellani
Il 18/03/2013 13:12, Miklos Vajna ha scritto: http://wiki.openoffice.org/wiki/MediaWiki:Collections/Developer%27s_Guide_-_Extensions is still the reference, just use http://api.libreoffice.org/ when looking into the individual interfaces. Miklos Thank you, Miklos. I'll read this guides and I wi

Re: [RFC] add --pidfile switch to write libo pid to a file

2013-03-18 Thread Michael Meeks
On Mon, 2013-03-18 at 14:41 +0100, Riccardo Magliocchetti wrote: > The standard practice is to use just a plain file with the pid inside, > other tools won't parse an ini file just to find the pid. Seems unlikely to cause any real harm to me :-) Out of interest, did you see the

[Libreoffice-commits] core.git: extensions/source

2013-03-18 Thread Miklos Vajna
extensions/source/update/ui/updatecheckui.cxx | 36 +- 1 file changed, 18 insertions(+), 18 deletions(-) New commits: commit 35bc07513c46cfa40fa85ec1053f7ce5c1e9c318 Author: Miklos Vajna Date: Mon Mar 18 15:33:52 2013 +0100 extensions: remove RTL_CONSTASCII_STRIN

Re: Comment translation ger - eng in sw/source/ui/wrtsh/

2013-03-18 Thread Jan Holesovsky
Hi Matthias, Thank you for your patch! Only a small nitpick: Matthias Freund (via Code Review) píše v Ne 17. 03. 2013 v 22:17 +: > -/* #108049# Only move instead of deleting if we > +/** #108049# Only move instead of deleting if we >

[PUSHED libreoffice-4-0] fdo#61909 fix import of RTF_HIGHLIGHT and of default font wi...

2013-03-18 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2817 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2817 To unsubscribe, vis

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - f5/8ffc9e83ceee71536310d7ab54016ab2bf14f1

2013-03-18 Thread Eike Rathke
f5/8ffc9e83ceee71536310d7ab54016ab2bf14f1 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 743f8fa25787df6a65228d9fe40e8e35b02e8de3 Author: Eike Rathke Date: Mon Mar 18 15:58:14 2013 +0100 Notes added by 'git notes add' diff --git a/f5/8ffc9e83ceee71536310d7ab

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sw/qa writerfilter/source

2013-03-18 Thread Miklos Vajna
sw/qa/extras/rtfimport/data/fdo61909.rtf | 28 + sw/qa/extras/rtfimport/rtfimport.cxx | 11 + writerfilter/source/rtftok/rtfdocumentimpl.cxx |7 +- 3 files changed, 45 insertions(+), 1 deletion(-) New commits: commit 65f42760736d656b4999

[Libreoffice-commits] core.git: sc/source

2013-03-18 Thread Eike Rathke
sc/source/ui/docshell/impex.cxx | 32 1 file changed, 16 insertions(+), 16 deletions(-) New commits: commit 9dba77d1b5bb2d513e8d6b67c83dc6e858e35f66 Author: Eike Rathke Date: Mon Mar 18 15:53:21 2013 +0100 resolved #i119960# paste single line with quotes

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/source

2013-03-18 Thread Michael Meeks
sc/source/core/data/column.cxx |3 ++- sc/source/core/data/column2.cxx |1 - sc/source/core/data/column3.cxx | 15 +-- 3 files changed, 15 insertions(+), 4 deletions(-) New commits: commit 54f57794cf73d09a3e9b1dc6308011e2c4286698 Author: Michael Meeks Date: Mon Mar 18 14

[PUSHED libreoffice-4-0-2] fdo#61952: sw: fix left/right-only page styles and first-pag...

2013-03-18 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2813 Approvals: Petr Mladek: Verified; Looks good to me, approved Fridrich Strba: Looks good to me, but someone else must approve -- To view

[PATCH libreoffice-4-0] fdo#61909 fix import of RTF_HIGHLIGHT and of default font wi...

2013-03-18 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2817 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/2817/1 fdo#61909 fix import of RTF_HIGHLIGHT and of default font without RTF_PLAIN (cherry picked from commits 60c17b28

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0-2' - sw/inc sw/source

2013-03-18 Thread Michael Stahl
sw/inc/pagedesc.hxx| 39 - sw/source/core/layout/flowfrm.cxx |7 +++-- sw/source/core/layout/frmtool.cxx |9 --- sw/source/core/layout/pagechg.cxx | 28 --- sw/source/core/layout/pagedesc.cxx

  1   2   3   >