issue with disable gnome vfs switch when compilng master for android

2012-12-30 Thread Jonathan Aquilina
Good morning everyone, I am attempting to compile master for my Google Nexus 7 tablet. When running autogen.sh with the disable gnome vfs switch it seems to ignore it all together and complains that its not finding gnome vfs. Any ideas or suggestions would be greatly appreciated. _

[PATCH] More fixes to fdo#57422

2012-12-30 Thread Ahmad Harthi (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1521 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/1521/1 More fixes to fdo#57422 * Code cleanup + replacing drawText() with drawTextLayout(). This solves mirrored LTR te

[Libreoffice-commits] .: 2 commits - sc/source

2012-12-30 Thread Libreoffice Gerrit user
sc/source/core/data/conditio.cxx |4 ++-- sc/source/ui/view/cellsh1.cxx|1 + 2 files changed, 3 insertions(+), 2 deletions(-) New commits: commit d6fd3ccb105e164fdc826f1cafff2f5323194794 Author: Markus Mohrhard Date: Mon Dec 31 04:27:44 2012 +0100 handle strings correctly in S

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - sc/source

2012-12-30 Thread Libreoffice Gerrit user
sc/source/core/data/conditio.cxx |4 ++-- sc/source/ui/view/cellsh1.cxx|1 + 2 files changed, 3 insertions(+), 2 deletions(-) New commits: commit 3ea8026aefc358483292b459aaaead830e1f667d Author: Markus Mohrhard Date: Mon Dec 31 04:27:44 2012 +0100 handle strings correctly in S

[PATCH] Removal rtl and string cleanup

2012-12-30 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1520 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1520/1 Removal rtl and string cleanup This commit removes ::rtl:: prefixes and string cleanup in oox Change-Id: I43446

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2012-12-30 Thread Ioan Radu (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1519 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1519/1 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT Changed some OSL_ and DBG_ to SAL_ Change-Id: I192994238b949ffc5169

[PUSHED] fdo#39440 - cppcheck cleanliness

2012-12-30 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1518 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1518 To unsubscribe, vi

[Libreoffice-commits] .: lotuswordpro/source

2012-12-30 Thread Libreoffice Gerrit user
lotuswordpro/source/filter/lwpbackgroundstuff.cxx |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit 3b1da9e650db388baa6d649219e2a0e45b58f062 Author: Radu Ioan Date: Mon Dec 31 01:27:47 2012 +0200 fdo#39440 - cppcheck cleanliness removed some cppc

[PATCH] fdo#39440 - cppcheck cleanliness

2012-12-30 Thread Ioan Radu (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1518 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/1518/1 fdo#39440 - cppcheck cleanliness removed some cppcheck warning Change-Id: I81963001e4737c583764b07bea9abf59a61d

[Libreoffice-commits] .: 7 commits - Module_cross_tail_build.mk redland/ExternalPackage_raptor.mk redland/ExternalPackage_rasqal.mk redland/ExternalPackage_redland.mk redland/ExternalProject_raptor.mk

2012-12-30 Thread Libreoffice Gerrit user
Module_cross_tail_build.mk |1 - redland/ExternalPackage_raptor.mk |2 +- redland/ExternalPackage_rasqal.mk |2 +- redland/ExternalPackage_redland.mk |2 +- redland/ExternalProject_raptor.mk |6 -- redland/ExternalProject_rasqal.mk |5 +++-- redland/External

[Libreoffice-commits] .: sw/qa writerfilter/source

2012-12-30 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/fdo54612.rtf | 34 + sw/qa/extras/rtfimport/rtfimport.cxx | 10 +++ writerfilter/source/rtftok/rtfdocumentimpl.cxx | 17 3 files changed, 55 insertions(+), 6 deletions(-) New commits: commit 08b4efb4e1cd013

[Libreoffice-commits] .: solenv/bin

2012-12-30 Thread Libreoffice Gerrit user
dev/null |binary 1 file changed New commits: commit f84bd3f065b31e3f7a8acb5590a6561838b5aa7c Author: Norbert Thiebaud Date: Sun Dec 30 15:27:59 2012 -0600 remove accidental adding of concat-deps Change-Id: Ia0e60c5246e5e45b934548ebbf09a2f67910785e diff --git a/solenv/bin/concat

[Libreoffice-commits] .: vcl/source

2012-12-30 Thread Libreoffice Gerrit user
vcl/source/gdi/pdfwriter_impl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b18519cc1373e82b61e6c75b585903ff491c49e9 Author: Julien Nabet Date: Sun Dec 30 22:04:55 2012 +0100 Fix Memory leak: buffer Change-Id: I300b329de802aa88c71bdf9da0a878a157

[SOLVED] Re: Question about operator = overloaded in reportdesign module

2012-12-30 Thread Julien Nabet
On 30/12/2012 21:48, Markus Mohrhard wrote: Hey, Cppcheck reported this: [reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style) 'OXMLComponent::operator=' should return 'OXMLComponent&'. [reportdesign/source/filter/xml/xmlFunction.hxx:41]: (style) 'OXMLFunction::operator=' should return

[Libreoffice-commits] .: reportdesign/source

2012-12-30 Thread Libreoffice Gerrit user
reportdesign/source/filter/xml/xmlCell.hxx |2 +- reportdesign/source/filter/xml/xmlComponent.hxx |2 +- reportdesign/source/filter/xml/xmlFunction.hxx |2 +- reportdesign/source/filter/xml/xmlGroup.hxx |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) New commits:

[PATCH] Remove some unused functions

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1517 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/1517/1 Remove some unused functions Change-Id: I618de5d34d891b1b183cca12b71aff4128b2f92e Signed-off-by: Marcos Paulo de

Re: Question about operator = overloaded in reportdesign module

2012-12-30 Thread Markus Mohrhard
Hey, > Cppcheck reported this: > [reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style) > 'OXMLComponent::operator=' should return 'OXMLComponent &'. > [reportdesign/source/filter/xml/xmlFunction.hxx:41]: (style) > 'OXMLFunction::operator=' should return 'OXMLFunction &'. > [reportdesign/s

Question about operator = overloaded in reportdesign module

2012-12-30 Thread julien2412
Hello, Cppcheck reported this: [reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style) 'OXMLComponent::operator=' should return 'OXMLComponent &'. [reportdesign/source/filter/xml/xmlFunction.hxx:41]: (style) 'OXMLFunction::operator=' should return 'OXMLFunction &'. [reportdesign/source/filte

Re: Question about sc/source/core/tool/interpr2.cxx and lcl_GetArabicValue

2012-12-30 Thread Julien Nabet
On 30/12/2012 18:24, Markus Mohrhard wrote: Hey, Cppcheck reported this: [sc/source/core/tool/interpr2.cxx:2656]: (style) The scope of the variable 'bIsDec2' can be reduced Here are the lines: 2651 while( bValid&& (nCharIndex< nCharCount) ) 2652 { 2653

[Libreoffice-commits] .: sc/source

2012-12-30 Thread Libreoffice Gerrit user
sc/source/core/data/table4.cxx |2 +- sc/source/core/tool/interpr2.cxx|4 +++- sc/source/ui/cctrl/dpcontrol.cxx|3 +-- sc/source/ui/docshell/arealink.cxx |3 +-- sc/source/ui/docshell/docsh8.cxx|2 +- sc/source/ui/drawfunc/fusel.cxx

Simple fix for fdo#58766

2012-12-30 Thread LeMoyne Castle (via Code Review)
LeMoyne Castle has abandoned this change. Change subject: Simple fix for fdo#58766 .. Patch Set 2: Abandoned Did local git reset --hard and stranded this commit. Core mistake was hacking in local master instead of hacking in

(incomplete) Cleanup OUString etc. in desktop

2012-12-30 Thread LeMoyne Castle (via Code Review)
LeMoyne Castle has abandoned this change. Change subject: (incomplete) Cleanup OUString etc. in desktop .. Patch Set 2: Abandoned Did local git reset --hard and stranded this commit. Core mistake was hacking in local master in

Re: Question about sc/source/core/tool/interpr2.cxx and lcl_GetArabicValue

2012-12-30 Thread Markus Mohrhard
Hey, > > Cppcheck reported this: > [sc/source/core/tool/interpr2.cxx:2656]: (style) The scope of the variable > 'bIsDec2' can be reduced > > Here are the lines: >2651 while( bValid && (nCharIndex < nCharCount) ) >2652 { >2653 sal_uInt16 nDigit1 = 0; >265

[Libreoffice-commits] .: solenv/gbuild

2012-12-30 Thread Libreoffice Gerrit user
solenv/gbuild/Executable.mk | 25 - solenv/gbuild/TargetLocations.mk | 25 + 2 files changed, 25 insertions(+), 25 deletions(-) New commits: commit e4cb67b4dabe40fdf8ce703d6739db7863c52fb4 Author: David Tardon Date: Sun Dec 30 18:13:09 2

[Libreoffice-commits] .: sc/source

2012-12-30 Thread Libreoffice Gerrit user
sc/source/core/tool/chgtrack.cxx |4 - sc/source/core/tool/interpr3.cxx | 59 + sc/source/filter/excel/excform.cxx |2 sc/source/filter/xml/xmlcelli.cxx |2 sc/source/ui/app/inputhdl.cxx |

[Libreoffice-commits] .: dictionaries helpcontent2

2012-12-30 Thread Libreoffice Gerrit user
dictionaries |2 +- helpcontent2 |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 34f9e32c6f5b1233976f356dfeb1fe846cc095af Author: Norbert Thiebaud Date: Sun Dec 30 10:36:49 2012 -0600 restore submodules Change-Id: If2178d8143b2c1bf8a10fd92ee575

[Libreoffice-commits] .: translations

2012-12-30 Thread Libreoffice Gerrit user
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ec851e995426c770dee42e62638a5687be4bcc31 Author: David Tardon Date: Sun Dec 30 17:33:11 2012 +0100 Revert "change translations" This reverts commit 7cdd83467a51c4a83b43ddc01e645dcc0fd549cb.

Question about sc/source/core/tool/interpr2.cxx and lcl_GetArabicValue

2012-12-30 Thread julien2412
Hello, Cppcheck reported this: [sc/source/core/tool/interpr2.cxx:2656]: (style) The scope of the variable 'bIsDec2' can be reduced Here are the lines: 2651 while( bValid && (nCharIndex < nCharCount) ) 2652 { 2653 sal_uInt16 nDigit1 = 0; 2654 sal

[Libreoffice-commits] .: 4 commits - i18npool/CustomTarget_breakiterator.mk i18npool/CustomTarget_collator.mk i18npool/CustomTarget_indexentry.mk i18npool/CustomTarget_localedata.mk i18npool/CustomTar

2012-12-30 Thread Libreoffice Gerrit user
RepositoryExternal.mk | 71 + i18npool/CustomTarget_breakiterator.mk |8 -- i18npool/CustomTarget_collator.mk |2 i18npool/CustomTarget_indexentry.mk|2 i18npool/CustomTarget_localedata.mk

[PATCH] fdo#57950: Fix some chained appends in basic

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1515 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1515/1 fdo#57950: Fix some chained appends in basic Change-Id: Icac8ec992d993748a063aa95cc6f58c24fa87444 Signed-off-by:

[PATCH] fdo#57950: One more chained append in basic

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1516 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/1516/1 fdo#57950: One more chained append in basic Change-Id: I179b5bfd1d85152a53bb821ab9eeb78efb8a6083 Signed-off-by:

[PATCH] fdo#57203 Unknown option: -Embedding

2012-12-30 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1514 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/1514/1 fdo#57203 Unknown option: -Embedding Ignore this option on Windows. This work-arounds a regression introduced by

fdo#57203 Unknown option: -Embedding

2012-12-30 Thread via Code Review
Aurimas Fišeras has abandoned this change. Change subject: fdo#57203 Unknown option: -Embedding .. Patch Set 1: Abandoned Rebased and resubmitted as https://gerrit.libreoffice.org/#/c/1514/ -- To view, visit https://gerrit.li

Re: Addin exceptions in SvStream

2012-12-30 Thread Marc-André Laverdière
@Michael. I am studying in a software reegineering lab - I do have a small clue ;) We had a Masters' student who implemented his own C grammar. 3 months of work for one bullet in one slide. No fun. I know that C++ is an horrible monster to parse. My question was why pick a tool over another. Maybe

[Libreoffice-commits] .: Module_cross_tail_build.mk

2012-12-30 Thread Libreoffice Gerrit user
Module_cross_tail_build.mk |1 + 1 file changed, 1 insertion(+) New commits: commit ecc9896c9be9669ec1ea13a99c9aa624356b07aa Author: Peter Foley Date: Sun Dec 30 10:17:14 2012 -0500 fix redland for android Change-Id: I98f0c80d6dc4634b64aed7ae2a1e90f90027b90e diff --git a/Mod

[PATCH] Remove all occurences of RTL_* and ::rtl prefix from basic

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1513 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1513/1 Remove all occurences of RTL_* and ::rtl prefix from basic This is a big commit, so thanks for your time reviewi

[PUSHED] convert redland to gbuild and add to tail_build

2012-12-30 Thread Peter Foley (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1493 Approvals: Peter Foley: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1493 To unsubscribe, visit

[Libreoffice-commits] .: desktop/source

2012-12-30 Thread Libreoffice Gerrit user
desktop/source/deployment/registry/package/dp_package.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c20147bb64dd12248b26a0ef5437dd89651bba70 Author: Peter Foley Date: Sun Dec 30 09:55:01 2012 -0500 fix fallout from string cleanup Change-Id: Ibd1

[PATCH] Remove all rtl:: prefix and RTL_* from basic/qa/cppunit/test...

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1512 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1512/1 Remove all rtl:: prefix and RTL_* from basic/qa/cppunit/test_scanner.cxx Change-Id: Ie9bb6018955faa41c359d18c6b2

[Libreoffice-commits] .: desktop/source

2012-12-30 Thread Libreoffice Gerrit user
desktop/source/deployment/manager/dp_commandenvironments.cxx |6 desktop/source/deployment/manager/dp_extensionmanager.cxx| 107 ++ desktop/source/deployment/manager/dp_informationprovider.cxx |9 desktop/source/deployment/manager/dp_manager.cxx | 196 --- d

[Libreoffice-commits] .: desktop/source

2012-12-30 Thread Libreoffice Gerrit user
desktop/source/app/app.cxx |2 desktop/source/app/cmdlineargs.cxx | 86 - desktop/source/app/configinit.cxx |4 - desktop/source/app/dispatchwatcher.cxx | 69 -- desktop/source/app/langselect.cxx | 26

[Libreoffice-commits] .: desktop/source

2012-12-30 Thread Libreoffice Gerrit user
desktop/source/deployment/dp_log.cxx |9 desktop/source/deployment/dp_persmap.cxx |4 desktop/source/deployment/inc/lockfile.hxx | 14 - desktop/source/deployment/misc/dp_dependencies.cxx | 52 +--- desktop/source/deployment/mis

[Libreoffice-commits] .: desktop/source

2012-12-30 Thread Libreoffice Gerrit user
desktop/source/migration/migration.cxx | 94 +--- desktop/source/migration/services/basicmigration.cxx|8 - desktop/source/migration/services/jvmfwk.cxx| 26 +-- desktop/source/migration/services/oo3extensionmigration.cxx | 28 +-- des

[Libreoffice-commits] .: desktop/source dictionaries helpcontent2

2012-12-30 Thread Libreoffice Gerrit user
desktop/source/deployment/misc/dp_misc.cxx | 57 +++-- desktop/source/deployment/misc/dp_platform.cxx | 149 +++-- desktop/source/deployment/misc/dp_resource.cxx | 18 +-- desktop/source/deployment/misc/dp_ucb.cxx |9 - desktop/source/deployment/misc/dp_up

[Libreoffice-commits] .: basegfx/source

2012-12-30 Thread Libreoffice Gerrit user
basegfx/source/polygon/b2dsvgpolypolygon.cxx |4 1 file changed, 4 deletions(-) New commits: commit e67cea929c62609526b65d36945b8dc4abf48be3 Author: Chr. Rossmanith Date: Sun Dec 30 09:26:17 2012 +0100 Revert "SVG: add check if polygon is closed" This reverts commit 0144

[Libreoffice-commits] .: desktop/source

2012-12-30 Thread Libreoffice Gerrit user
desktop/source/deployment/gui/dp_gui_dialog2.cxx | 22 ++--- desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx | 18 ++-- desktop/source/deployment/gui/dp_gui_extlistbox.cxx | 27 +++--- desktop/source/deployment/gui/dp_gui_service.cxx |6 - de