[PATCH] OUString cleanup in basctl

2012-10-19 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/892 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/892/1 OUString cleanup in basctl Change-Id: I9644427f6d3bb4b2f488325eb520b365115a8e82 --- M basctl/source/basicide/basid

[Libreoffice-commits] .: 3 commits - sw/inc sw/source sw/uiconfig sw/UI_swriter.mk vcl/source

2012-10-19 Thread Libreoffice Gerrit user
sw/UI_swriter.mk|1 sw/inc/helpid.h |9 sw/inc/index.hrc|3 sw/inc/swabstdlg.hxx|2 sw/source/ui/app/app.src| 12 + sw/source/ui/dialog/swdlgfact.cx

[Libreoffice-commits] .: helpers/help_hid.lst source/text

2012-10-19 Thread Libreoffice Gerrit user
helpers/help_hid.lst|8 source/text/swriter/01/04120300.xhp | 32 2 files changed, 16 insertions(+), 24 deletions(-) New commits: commit 6e855787c1fa512546f8e72766606fa2f90d0854 Author: Caolán McNamara Date: Fri Oct 19 19:00:30 2

[Libreoffice-commits] .: helpcontent2

2012-10-19 Thread Libreoffice Gerrit user
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 76a1bc49b6c7b9f97cc6591e4d149d16ec7a69ec Author: Caolán McNamara Date: Fri Oct 19 19:00:30 2012 +0100 Updated core Project: help 6e855787c1fa512546f8e72766606fa2f90d0854 update helpids for

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 V.K. changed: What|Removed |Added Depends on||47838 --- Comment #150 from V.K. --- Add Bug 478

[Libreoffice-commits] .: config_host.mk.in

2012-10-19 Thread Libreoffice Gerrit user
config_host.mk.in |2 -- 1 file changed, 2 deletions(-) New commits: commit 8e7829a0e88eb2323bffee3eb8dcdc937c12148d Author: Matúš Kukan Date: Fri Oct 19 23:10:09 2012 +0200 remove unset & unused variables Change-Id: I565a3110c10eb94945ad08daabe29f0034ed0ddd diff --git a/c

Re: Errors with Makefile.top for building Windows

2012-10-19 Thread Julien Nabet
On 19/10/2012 23:00, Matúš Kukan wrote: On 19 October 2012 22:40, Julien Nabet wrote: I attached it and noticed this: export WORKDIR=D:/compile-libreoffice/libo/workdir/wntmsci12 export WORKDIR_FOR_BUILD=D:/compile-libreoffice/libo/workdir/wntmsci12 Hmm, sorry, no idea. I hope the '-' in compi

Re: Errors with Makefile.top for building Windows

2012-10-19 Thread Matúš Kukan
On 19 October 2012 22:40, Julien Nabet wrote: > I attached it and noticed this: > export WORKDIR=D:/compile-libreoffice/libo/workdir/wntmsci12 > export WORKDIR_FOR_BUILD=D:/compile-libreoffice/libo/workdir/wntmsci12 Hmm, sorry, no idea. I hope the '-' in compile-libreoffice does not make problem.

Re: Errors with Makefile.top for building Windows

2012-10-19 Thread Julien Nabet
On 19/10/2012 22:30, Matúš Kukan wrote: On 18 October 2012 22:28, julien2412 wrote: Hello, On Vista SP2 (32 bits) and with Cygwin 1.7 installed some days ago, I've got these errors: /cygdrive/d/compile-libreoffice/libo/Makefile.top:325: target `D' doesn't match the target pattern /cygdrive/d/c

Re: Errors with Makefile.top for building Windows

2012-10-19 Thread Matúš Kukan
On 18 October 2012 22:28, julien2412 wrote: > Hello, > > On Vista SP2 (32 bits) and with Cygwin 1.7 installed some days ago, I've got > these errors: > /cygdrive/d/compile-libreoffice/libo/Makefile.top:325: target `D' doesn't > match the target pattern > /cygdrive/d/compile-libreoffice/libo/Makefi

[PUSHED] Change in core[libreoffice-3-6]: fdo#46669 sw: RTF paste should not change page styles

2012-10-19 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/878 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/878 To unsubscribe, vis

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source writerfilter/inc writerfilter/source

2012-10-19 Thread Libreoffice Gerrit user
sw/source/filter/rtf/swparrtf.cxx |4 +++- writerfilter/inc/dmapper/DomainMapper.hxx |3 ++- writerfilter/source/dmapper/DomainMapper.cxx |5 +++-- writerfilter/source/dmapper/DomainMapper_Impl.cxx | 11 +-- writerfilter/source/dmapper/DomainMappe

warn free build of dmake(unix), solenv, and silenced lpsolve

2012-10-19 Thread via Code Review
René Kjellerup has restored this change. Change subject: warn free build of dmake(unix), solenv, and silenced lpsolve .. Patch Set 2: Restored -- To view, visit https://gerrit.libreoffice.org/885 To unsubscribe, visit https://g

Re: Errors with Makefile.top for building Windows

2012-10-19 Thread julien2412
Flavio Moringa wrote > you have to use another "make" for libreoffice. > > Check this: > http://wiki.documentfoundation.org/User:Foral/Build_Win#Cygwin Badfully, I've got exactly the same result as before with this make. Any other idea? Julien. -- View this message in context: http://nabble

warn free build of dmake(unix), solenv, and silenced lpsolve

2012-10-19 Thread via Code Review
René Kjellerup has abandoned this change. Change subject: warn free build of dmake(unix), solenv, and silenced lpsolve .. Patch Set 2: Abandoned redid the commit from scratch, sorry -- To view, visit https://gerrit.libreoffice

[PATCH] warn free build of dmake, concat-deps and lpsolve

2012-10-19 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/891 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/891/1 warn free build of dmake, concat-deps and lpsolve I've added if test to silence compiler warnings like this: "warn

Easy Hacks -- Link for 50+ Proposed

2012-10-19 Thread Joel Madero
Hi All, Well it seems like the QA team has listened and we have a solid list of proposed easy hacks that need developer input. I hope that this helps with streamlining some of these easier bugs. Please see the link below :-D https://bugs.freedesktop.org/buglist.cgi?list_id=147895&status_whiteboar

Re: BSA + New Wiki = No Good

2012-10-19 Thread Joel Madero
That stuff is all way above my knowledge. I'll wait for someone to fix it and then I'll try again to use it after I update FDO with new version(s). Thanks for the update, glad it looks like a minor problem Regards, Joel On Fri, Oct 19, 2012 at 6:22 AM, Christian Lohmaier < lohmaier+libreoff...@g

Re: Change in core[master]: fdo#55034 Update default Hebrew font from Lucida Sans to Luc...

2012-10-19 Thread Lior Kaplan
On Fri, Oct 19, 2012 at 5:25 PM, Petr Mladek wrote: > On Fri, 2012-10-19 at 15:27 +0200, Lior Kaplan wrote: > > (replying to the list, as I don't think gerrit is the right platform > > for discussions about patches) > > Yup, it is a bit strange. I think that you could press the "Review" > button

[Libreoffice-commits] .: vcl/Library_vcl.mk

2012-10-19 Thread Libreoffice Gerrit user
vcl/Library_vcl.mk |6 ++ 1 file changed, 6 insertions(+) New commits: commit 1a6a3a12a9247ad18bc68d77b48229e457c7a9c0 Author: Tor Lillqvist Date: Fri Oct 19 18:42:56 2012 +0300 In the 10.7 SDK CoreText is in the ApplicationServices framework Although I don't understand w

Re: RuntimeException while building

2012-10-19 Thread Ruslan Kabatsayev
On Fri, Oct 19, 2012 at 6:26 PM, Stephan Bergmann wrote: > On 10/19/2012 04:13 PM, Ruslan Kabatsayev wrote: >> >> I'm trying to build current libo master, and build fails with this >> log: http://pastebin.com/d191HeiH >> Here's the backtrace: http://pastebin.com/6T7CCAZL . >> >> LibO did build OK

Re: Change in core[master]: fdo#55034 Update default Hebrew font from Lucida Sans to Luc...

2012-10-19 Thread Petr Mladek
On Fri, 2012-10-19 at 15:27 +0200, Lior Kaplan wrote: > (replying to the list, as I don't think gerrit is the right platform > for discussions about patches) Yup, it is a bit strange. I think that you could press the "Review" button and just leave the comment. Well, you can't do inline comments th

Re: [REVIEW 3-6-3 1/3] fix fdo#47669: check for started hyperlink before closing

2012-10-19 Thread Petr Mladek
On Fri, 2012-10-12 at 21:11 +0700, Korrawit Pruegsanusak wrote: > Hello all, > > I'd like to propose the attached patch fixing fdo#47669 into -3-6 and > -3-6-3 branches. Explanation is in commit message. > > I've compiled and tested on -3-6 branch at > 0eee6469304ba15f42bcafb6707cc98bcbff9112, an

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-10-19 Thread Libreoffice Gerrit user
sw/source/filter/ww8/docxattributeoutput.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit d401dcc51cec798c8c19febcc25c4325ddafa178 Author: Korrawit Pruegsanusak Date: Fri Oct 12 21:09:42 2012 +0700 Fix fdo#47669: also check if we started the tag before

Re: [REVIEW 3-6-3 2/3][ fix for fdo#55712, ignore broadcaster cells to fill autofilter dialog

2012-10-19 Thread Petr Mladek
On Fri, 2012-10-19 at 10:20 +0200, David Tardon wrote: > Hi, > > On Wed, Oct 17, 2012 at 04:26:22PM +0200, Markus Mohrhard wrote: > > Hey, > > > > [1] fixes the problem that cells referenced in a formula where added > > to the autofilter dialog. > > Pushed with my sign-off. The commit in the 3-

Re: Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date

2012-10-19 Thread V Stuart Foote
David, Grabbed the build, and unfortunately it still has the MSI installer Error 1935 ( fdo#55290 ) affecting it. But, in reading the build info and the Tinderbox Wiki the number

Re: RuntimeException while building

2012-10-19 Thread Stephan Bergmann
On 10/19/2012 04:13 PM, Ruslan Kabatsayev wrote: I'm trying to build current libo master, and build fails with this log: http://pastebin.com/d191HeiH Here's the backtrace: http://pastebin.com/6T7CCAZL . LibO did build OK at the time of "Version 3.7.0.0.alpha0+ (Build ID: ecf56e)". This *might*

RuntimeException while building

2012-10-19 Thread Ruslan Kabatsayev
Hello, I'm trying to build current libo master, and build fails with this log: http://pastebin.com/d191HeiH Here's the backtrace: http://pastebin.com/6T7CCAZL . LibO did build OK at the time of "Version 3.7.0.0.alpha0+ (Build ID: ecf56e)". Any ideas how to solve this? Thanks, Ruslan ___

Re: [REVIEW 3-6-3 2/3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn

2012-10-19 Thread Petr Mladek
On Fri, 2012-10-19 at 10:46 +0200, David Tardon wrote: > Hi, > > On Wed, Oct 17, 2012 at 04:28:27PM +0200, Markus Mohrhard wrote: > > Hey, > > > > [1] fixes the problem that blank cells, like broadcaster, cells are > > considerend non empty for the "visible" methods. > > Pushed with my sign-off.

Re: [REVIEW 3-6-3 2/3] fdo#53870, write sort list information into the item set

2012-10-19 Thread Petr Mladek
On Fri, 2012-10-19 at 11:06 +0200, David Tardon wrote: > Hi, > > On Wed, Oct 17, 2012 at 04:30:50PM +0200, Markus Mohrhard wrote: > > Hey, > > > > [1] writes the custom sort list information into the SfxItemSet. > > Otherwise the old information is lost and a new default custom sort > > list info

Re: Build Error

2012-10-19 Thread Stephan Bergmann
On 10/19/2012 07:07 AM, Joel Madero wrote: /usr/lib/libuno_sal.so.3: version `LIBO_UDK_3.7' not found (required by /data/git/libo/workdir/unxlngx6.pro/LinkTarget/CppunitTest/libtest_sal_osl_file.so) This means that our code trying to test newly built libraries instead by error picks up ones th

Re: [PUSHED 3-6-3] fix for fdo#53482, exchange sort options between tab pages

2012-10-19 Thread Petr Mladek
On Fri, 2012-10-19 at 13:10 +0200, Kohei Yoshida wrote: > On Wed, Oct 17, 2012 at 11:16 AM, Markus Mohrhard > wrote: > > Hey, > > > > I just reviewed Noel's old patch for the sort problems around the sort > > dialog. His patch fixes several problems at once where the sort > > options are not excha

[Libreoffice-commits] .: Branch 'libreoffice-3-6-3' - sc/source

2012-10-19 Thread Libreoffice Gerrit user
sc/source/ui/dbgui/tpsort.cxx | 12 sc/source/ui/inc/tpsort.hxx |8 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 3f1219d1a659111f35302b6f1305fe7ce281501c Author: Noel Power Date: Wed Oct 17 11:01:15 2012 +0200 exchange sort settings

Re: Change in core[master]: fdo#55034 Update default Hebrew font from Lucida Sans to Luc...

2012-10-19 Thread Lior Kaplan
(replying to the list, as I don't think gerrit is the right platform for discussions about patches) Hi Petr, I've done the patch in https://gerrit.libreoffice.org/883 to be as minimal as possible. I guess that it's indeed an unneeded repetetion, but as it appear about 100 times in the same file

Re: BSA + New Wiki = No Good

2012-10-19 Thread Christian Lohmaier
Hi *, On Fri, Oct 19, 2012 at 12:25 PM, Christian Lohmaier wrote: > [...] > The additional html tags in the wiki-output on the tag makes > the removal of the xmlns tag that is added by tidy fail. > > i.e. perl -pe 's|xmlns="http://www.w3.org/1999/xhtml";||' does > nothing, since it is not > ht

[Libreoffice-commits] .: sc/source vcl/source vcl/unx

2012-10-19 Thread Libreoffice Gerrit user
sc/source/ui/inc/tabview.hxx |2 - sc/source/ui/view/tabview.cxx| 27 +-- sc/source/ui/view/tabview4.cxx | 36 +-- vcl/source/control/scrbar.cxx| 12 +- vcl/unx/gtk/gdi/salnativewidgets-

[Libreoffice-commits] .: 2 commits - sd/source tools/inc

2012-10-19 Thread Libreoffice Gerrit user
sd/source/ui/framework/module/ResourceManager.cxx | 37 +- sd/source/ui/framework/module/ResourceManager.hxx |1 tools/inc/tools/poly.hxx |4 +- 3 files changed, 18 insertions(+), 24 deletions(-) New commits: commit 91e81cd4bd8917ee06cd4fc0f

[Libreoffice-commits] .: sw/source

2012-10-19 Thread Libreoffice Gerrit user
sw/source/core/text/portxt.cxx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit 936ac94d08572fbdcdfb0a18611a387af8b30c5f Author: gerhard oettl Date: Sat Oct 13 11:31:24 2012 +0200 rtl::OUString to OUString Change-Id: I75bf4d851036

Re: [REVIEW 3-6-3] fix for fdo#53482, exchange sort options between tab pages

2012-10-19 Thread Kohei Yoshida
On Wed, Oct 17, 2012 at 11:16 AM, Markus Mohrhard wrote: > Hey, > > I just reviewed Noel's old patch for the sort problems around the sort > dialog. His patch fixes several problems at once where the sort > options are not exchanged between the tab pages. > > I already pushed it to 3-6 but I'd lik

[PUSHED] remove unused define

2012-10-19 Thread Norbert Thiebaud (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/890 Approvals: Norbert Thiebaud: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/890 To unsubscribe,

[Libreoffice-commits] .: tools/inc

2012-10-19 Thread Libreoffice Gerrit user
tools/inc/tools/solar.h |1 - 1 file changed, 1 deletion(-) New commits: commit e5090510cbc1e6130d0a173f3ceacba880d48ea4 Author: Norbert Thiebaud Date: Fri Oct 19 06:00:44 2012 -0500 remove unused define Change-Id: Ia000af4680ea5a58db52ca0c341b1a454b3de4c1 Reviewed-on: ht

[PATCH] remove unused define

2012-10-19 Thread Norbert Thiebaud (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/890 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/890/1 remove unused define Change-Id: Ia000af4680ea5a58db52ca0c341b1a454b3de4c1 --- M tools/inc/tools/solar.h 1 file cha

[PUSHED] replace sxub_Unicode by sal_Unicode

2012-10-19 Thread Norbert Thiebaud (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/887 Approvals: Norbert Thiebaud: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/887 To unsubscribe,

[Libreoffice-commits] .: binfilter

2012-10-19 Thread Libreoffice Gerrit user
binfilter |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bd5921b7371c41267ec42a2784778e7b34641ac5 Author: Norbert Thiebaud Date: Fri Oct 19 05:53:26 2012 -0500 Updated core Project: binfilter e9e2d065b33d441ffa8838cc15f70a99155893de null Change u

[Libreoffice-commits] .: bf_basic/source bf_starmath/source bf_svx/source bf_sw/source inc/bf_starmath inc/bf_sw

2012-10-19 Thread Libreoffice Gerrit user
bf_basic/source/sbx/sbxbool.cxx |4 bf_basic/source/sbx/sbxbyte.cxx |4 bf_basic/source/sbx/sbxchar.cxx | 24 +- bf_basic/source/sbx/sbxcurr.cxx |2 bf_basic/source/sbx/sbxdate.cxx |2 bf_basic/source/sbx/sbxdbl.cxx |2 bf

[Libreoffice-commits] .: writerfilter/source

2012-10-19 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/DomainMapper_Impl.hxx |1 - 1 file changed, 1 deletion(-) New commits: commit d9ebb89f935a2a8bcbd70deaae9115c3634a90f4 Author: Miklos Vajna Date: Fri Oct 19 12:47:18 2012 +0200 writerfilter: remove unused ctor Change-Id: I17ec2a253e35f90b4f670bb298

[PATCH] replace sxub_Unicode by sal_Unicode

2012-10-19 Thread Norbert Thiebaud (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/887 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/887/1 replace sxub_Unicode by sal_Unicode Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831 --- M basic/source/sbx/sb

[PATCH] Change ucb_Unicode to sal_Unicode

2012-10-19 Thread Norbert Thiebaud (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/888 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/888/1 Change ucb_Unicode to sal_Unicode Change-Id: Ibc933a1a5d1f7b78a360364da75f49765607aa80 --- M sw/source/core/bastyp

[Libreoffice-commits] .: sw/qa writerfilter/source

2012-10-19 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/dppolyline.rtf |6 sw/qa/extras/rtfimport/rtfimport.cxx | 11 writerfilter/source/rtftok/rtfdocumentimpl.cxx | 34 - writerfilter/source/rtftok/rtfdocumentimpl.hxx |2 + 4 files changed, 52 insertions(+), 1

Re: BSA + New Wiki = No Good

2012-10-19 Thread Christian Lohmaier
Hi Joel, *, On Fri, Oct 19, 2012 at 7:48 AM, Joel Madero wrote: > On 10/18/2012 10:27 PM, Joel Madero wrote: Someone else (can't remember who) talked to me earlier in IRC and told me >> that they had permissions to update BSA site but that make was failing and >> spitting out errors about th

[PUSHED] Change in core[libreoffice-3-6]: deb#690717 fix bashism in /bin/sh script

2012-10-19 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/886 Approvals: Petr Mladek: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/886 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - desktop/scripts

2012-10-19 Thread Libreoffice Gerrit user
desktop/scripts/soffice.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 68628c7d714110e4474ed61982d6423e936b56aa Author: Rene Engelhard Date: Thu Oct 18 10:53:03 2012 +0200 deb#690717 fix bashism in /bin/sh script Change-Id: I43b0065e56b234a5aa748a

[Libreoffice-commits] .: librsvg/ExternalPackage_librsvg.mk

2012-10-19 Thread Libreoffice Gerrit user
librsvg/ExternalPackage_librsvg.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9e51601833718b529fe2fe5446ec0470d4ee5173 Author: Tor Lillqvist Date: Fri Oct 19 13:10:09 2012 +0300 At least for me these two headers are slightly differently named?!

[Libreoffice-commits] .: desktop/scripts

2012-10-19 Thread Libreoffice Gerrit user
desktop/scripts/soffice.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 293f16bb2d2a6fe3a7c1452474c4c6966547f033 Author: Rene Engelhard Date: Fri Oct 19 12:08:17 2012 +0200 move 2>&1 where it belongs in soffice.sh, thanks mst Change-Id: I5cc08e3fd8

Re: BSA + New Wiki = No Good

2012-10-19 Thread Rob Snelders
Hi All, I did say that yesterday on the IRC. Since a little while I have been working a bit on the BSA. I seems that with the change of the wiki that the HTML-output of the BugReport_Details has been changed. After the conference I want to look at it. I can run a diff on the old and the new ou

Windows build broken -- multiple target patterns

2012-10-19 Thread Peter Foley
On windows the build fails with this error: make -rsC animations C:/libreoffice/workdir/wntmsci14.pro/Dep/LinkTarget/Library/ianimcore.lib.d:1: *** multiple target patterns. Stop. I think it is caused by concat-deps.exe being broken by either commit d0bf151 or 1402818. I've attached the dep fi

Re: GSoC improvement discussion minutes

2012-10-19 Thread Cor Nouws
Hi Cedric, all, Cedric Bosdonnat wrote (18-10-12 16:03) Here are the notes I wrote from our discussion about how to improve our GSoC processes. I may have missed some bits, feel free to amend it. [...] Though I'm not involved, one addition: maybe it's useful to ask applicants to tell specifi

[PUSHED] Change in core[libreoffice-3-6]: fdo#52208 DOCX import: don't always ignore cont sect break a...

2012-10-19 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/877 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/877 To unsubscribe, vis

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2012-10-19 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/DomainMapper.cxx | 12 ++-- writerfilter/source/dmapper/PropertyMap.hxx |1 + 2 files changed, 11 insertions(+), 2 deletions(-) New commits: commit b7cc2a8a22d3723a1efff515eb07669166f158a8 Author: Miklos Vajna Date: Mon Oct 15 12:53:05 2012 +0200

[PUSHED] Change in core[libreoffice-3-6]: fdo#55493 fix RTF import of specific PNG image

2012-10-19 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/860 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/860 To unsubscribe, vis

Re: BSA + New Wiki = No Good

2012-10-19 Thread Florian Effenberger
Hi, I am not subscribed to the FDO list, so please keep me in Cc for your replies. Joel Madero wrote on 2012-10-19 07:48: Now it's confirmed, here is the error: I have no idea what the script does, so I probably cannot be of too much help here. :( I guess it's a parsing error. All previousl

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2012-10-19 Thread Libreoffice Gerrit user
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) New commits: commit 9a2f97b9539f8101745467758fe03d5e76c0346f Author: Miklos Vajna Date: Thu Oct 11 16:48:55 2012 +0200 fdo#55493 fix RTF import of specific PNG image

Re: fdo#51004: some progress and 10 years old bug pending

2012-10-19 Thread Lionel Elie Mamane
On Thu, Oct 18, 2012 at 10:26:29PM +0200, David Ostrovsky wrote: > Am 17.10.2012 13:24, schrieb Lionel Elie Mamane: >> On Tue, Oct 16, 2012 at 08:07:53AM +0200, David Ostrovsky wrote: But take into considreation that on windows old mozab driver still used. >> Sorry, I didn't follow this

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-10-19 Thread Libreoffice Gerrit user
sc/source/ui/app/scmod.cxx |3 +++ sc/source/ui/optdlg/tpusrlst.cxx |2 ++ 2 files changed, 5 insertions(+) New commits: commit 07cc274256ebff259e228e7285bc27e6ddc94fdc Author: Markus Mohrhard Date: Wed Oct 17 15:45:18 2012 +0200 write the custom sort list info into the item

Re: [REVIEW 3-6-3][REVIEWED 3-6] fdo#53870, write sort list information into the item set

2012-10-19 Thread David Tardon
Hi, On Wed, Oct 17, 2012 at 04:30:50PM +0200, Markus Mohrhard wrote: > Hey, > > [1] writes the custom sort list information into the SfxItemSet. > Otherwise the old information is lost and a new default custom sort > list information is created. Cherry picked. D. ___

[Libreoffice-commits] .: unotools/inc unotools/source

2012-10-19 Thread Libreoffice Gerrit user
unotools/inc/unotools/textsearch.hxx | 13 + unotools/source/i18n/textsearch.cxx |2 +- 2 files changed, 2 insertions(+), 13 deletions(-) New commits: commit ac60fba3b5a506f6659f268a8b4fa8e1da600603 Author: Markus Mohrhard Date: Thu Oct 18 12:19:04 2012 +0200 delegating

Re: [REVIEW 3-6-3][REVIEWED 3-6] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn

2012-10-19 Thread David Tardon
Hi, On Wed, Oct 17, 2012 at 04:28:27PM +0200, Markus Mohrhard wrote: > Hey, > > [1] fixes the problem that blank cells, like broadcaster, cells are > considerend non empty for the "visible" methods. Pushed with my sign-off. Correct me if I am mistaken, but shouldn't the same check be used in Ge

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-10-19 Thread Libreoffice Gerrit user
sc/source/core/data/column2.cxx | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) New commits: commit 23e6bac62ef6482c287bb0f55c662ac2047ebb33 Author: Markus Mohrhard Date: Wed Oct 17 13:10:09 2012 +0200 only use non blank cells in the visible data methods, fdo#54552

[Libreoffice-commits] .: 8 commits - sc/CppunitTest_sc_subsequent_filters_test.mk sc/Module_sc.mk sc/qa sc/source unotools/source

2012-10-19 Thread Libreoffice Gerrit user
sc/CppunitTest_sc_subsequent_filters_test.mk |1 + sc/Module_sc.mk |6 ++ sc/qa/unit/data/contentCSV/spreadsheet-functions.csv |1 + sc/qa/unit/data/ods/formats.ods |binary sc/qa/unit/data/ods/functions.ods

Re: Errors with Makefile.top for building Windows

2012-10-19 Thread Flavio Moringa
I, you have to use another "make" for libreoffice. Check this: http://wiki.documentfoundation.org/User:Foral/Build_Win#Cygwin Cheers -- *Flávio Moringa* Project Leader Caixa Mágica Software Energia Open Source Rua Soeiro Pereira Gomes, Lote 1 - 4.º B, Edifício Espanha, 1600-196 Lisboa - Port

[Libreoffice-commits] .: 2 commits - compilerplugins/clang solenv/gbuild

2012-10-19 Thread Libreoffice Gerrit user
compilerplugins/clang/sallogareas.cxx |8 compilerplugins/clang/sallogareas.hxx |1 + solenv/gbuild/LinkTarget.mk |2 +- 3 files changed, 10 insertions(+), 1 deletion(-) New commits: commit 1b3dc82a01a97b917c2cba402ffd8c2d5238910c Author: Lubos Lunak Date: Thu Oc

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-10-19 Thread Libreoffice Gerrit user
sc/source/core/data/column3.cxx |4 1 file changed, 4 insertions(+) New commits: commit 637096b75f2989640967e72aee41e48b07a5a602 Author: Markus Mohrhard Date: Wed Oct 17 12:28:27 2012 +0200 ignore broadcaster cells to fill autofilter dialog, fdo#55712 Change-Id: Iacd3f8c

Re: [REVIEW 3-6-3][REVIEWED 3-6] fix for fdo#55712, ignore broadcaster cells to fill autofilter dialog

2012-10-19 Thread David Tardon
Hi, On Wed, Oct 17, 2012 at 04:26:22PM +0200, Markus Mohrhard wrote: > Hey, > > [1] fixes the problem that cells referenced in a formula where added > to the autofilter dialog. Pushed with my sign-off. D. ___ LibreOffice mailing list LibreOffice@lists

[PATCH] Change in core[libreoffice-3-6]: deb#690717 fix bashism in /bin/sh script

2012-10-19 Thread Rene Engelhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/886 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/886/1 deb#690717 fix bashism in /bin/sh script Change-Id: I43b0065e56b234a5aa748ac1593c29a44fdb1647 --- M desktop/script

Re: Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date

2012-10-19 Thread David Tardon
Hi, On Tue, Oct 16, 2012 at 06:23:01PM -0700, V Stuart Foote wrote: > David, > > Nominated the fdo#53474 as a most annoying for 3.6. It is a regression from > 3.5 and has been with us now for four build/QA reviews. > > Not sure of the etiquette but are you willing to take assignment of the bug?

[Libreoffice-commits] .: 5 commits - sw/source vcl/inc vcl/source

2012-10-19 Thread Libreoffice Gerrit user
sw/source/ui/cctrl/actctrl.cxx |2 - vcl/inc/svids.hrc |2 + vcl/inc/vcl/edit.hxx|2 - vcl/inc/vcl/fixed.hxx |3 ++ vcl/source/control/combobox.cxx |6 ++-- vcl/source/control/edit.cxx |4 +- vcl/source/control/fixed.cxx| 35 ++

Re: Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date

2012-10-19 Thread David Tardon
Hi, On Mon, Oct 15, 2012 at 08:46:17AM -0700, V Stuart Foote wrote: > Hope the fix is a simple as that! > > Since I reopened the FDO#53474 > bug, I am happy to > re-test, but I'm not set up to build. > > Assume I would grab the below 3.6 bu

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Rainer Bielefeld changed: What|Removed |Added Depends on||51023 --- Comment #149 from Rainer Bi

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on|51023 | -- You are receiving this mail beca