(replying to the list, as I don't think gerrit is the right platform for discussions about patches)
Hi Petr, I've done the patch in https://gerrit.libreoffice.org/883 to be as minimal as possible. I guess that it's indeed an unneeded repetetion, but as it appear about 100 times in the same file (and effect different languages), I would prefer to leave removing the condensed form to another change. If someone has any other clean up for officecfg/registry/data/org/openoffice/VCL.xcu let me know, and I'll be happy to do them. p.s. I'm not subscribed to the list, please CC me. On Fri, Oct 19, 2012 at 2:52 PM, Petr Mladek (via Code Review) < ger...@gerrit.libreoffice.org> wrote: > Petr Mladek has posted comments on this change. > > Change subject: fdo#55034 Update default Hebrew font from Lucida Sans to > Lucida Sans Unicode > ...................................................................... > > > Patch Set 1: I would prefer that you didn't submit this > > Just a small change. Please, do we really need "lucidasansunicode"? > > I guess that "Lucida Sans Unicode" is enough. At least, I see only this > form in the other languages. > > I would prefer to use only the correct form. You know, if people see the > other (lowecase+condesed) form in the VCL file, it might cause confusion ;-) > > Or did I miss anything? > > -- > To view, visit https://gerrit.libreoffice.org/883 > To unsubscribe, visit https://gerrit.libreoffice.org/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: Ia2204dda0cb452a4ce38a44db61d17d6802b5a38 > Gerrit-PatchSet: 1 > Gerrit-Project: core > Gerrit-Branch: master > Gerrit-Owner: Lior Kaplan <kaplanl...@gmail.com> > Gerrit-Reviewer: Petr Mladek <pmla...@suse.cz> >
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
