[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sw/source writerfilter/Library_ooxml.mk writerfilter/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/filter/ww8/docxattributeoutput.cxx | 11 +++ writerfilter/Library_ooxml.mk |1 + writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |9 +++-- 3 files changed, 15 insertions(+), 6 deletions(-) New commits: commit a2d8a3364fac34d14

[PATCH] Change in core[libreoffice-3-6]: gbuild: also in libmerge case library needs to depend on all...

2012-08-23 Thread Gerrit
>From Matúš Kukan : Matúš Kukan has uploaded a new change for review. Change subject: gbuild: also in libmerge case library needs to depend on all headers .. gbuild: also in libmerge case library needs to depend on all headers

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source writerfilter/Library_writerfilter.mk writerfilter/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/filter/ww8/docxattributeoutput.cxx | 11 +++ writerfilter/Library_writerfilter.mk |1 + writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |9 +++-- 3 files changed, 15 insertions(+), 6 deletions(-) New commits: commit 44bdf23e3fa29f1b3

[PUSHED] gbuild: also in libmerge case library needs to depend on all...

2012-08-23 Thread Gerrit
>From Tomáš Chvátal : Tomáš Chvátal has submitted this change and it was merged. Change subject: gbuild: also in libmerge case library needs to depend on all headers .. gbuild: also in libmerge case library needs to depend on

[Libreoffice-commits] .: solenv/gbuild

2012-08-23 Thread Libreoffice Gerrit user
solenv/gbuild/LinkTarget.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e1db0bd299f3b9a3ed6785a3f434b010a1174feb Author: Matúš Kukan Date: Thu Aug 23 23:19:10 2012 +0200 gbuild: also in libmerge case library needs to depend on all headers Change

[no subject]

2012-08-23 Thread Joseph Brown
"All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license" ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: basic/source

2012-08-23 Thread Libreoffice Gerrit user
basic/source/runtime/methods.cxx | 38 +++--- basic/source/runtime/methods1.cxx | 14 +++--- basic/source/runtime/stdobj.cxx |6 +++--- basic/source/runtime/step0.cxx| 12 ++-- basic/source/runtime/step2.cxx| 30 +++

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/core/doc/docnew.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 7f18b80a3bd2b3c126ac852c7ecd5ceb376f389d Author: Luboš Luňák Date: Thu Aug 23 18:09:59 2012 +0200 initialize member Introduced by b95d203bc17c83ec0fe5139f519d53ed1d842d3a . Chan

[PUSHED] Change in core[libreoffice-3-6]: SwHeaderFooterWin: memory leak

2012-08-23 Thread Gerrit
>From Bosdonnat Cedric : Bosdonnat Cedric has submitted this change and it was merged. Change subject: SwHeaderFooterWin: memory leak .. SwHeaderFooterWin: memory leak Change-Id: Ie8322b93745c48970766c2033a23cca2c710a516 (cher

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/ui/docvw/HeaderFooterWin.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 8aad87be76ba86a9ce5bd5e6b358c48eb35fbd42 Author: Ivan Timofeev Date: Thu Aug 23 20:15:51 2012 +0400 SwHeaderFooterWin: memory leak Change-Id: Ie8322b93745c48970766c2033a23cca2c710a

[Libreoffice-commits] .: 3 commits - sfx2/inc sfx2/Library_sfx.mk sfx2/Package_inc.mk sfx2/source

2012-08-23 Thread Libreoffice Gerrit user
sfx2/Library_sfx.mk|6 sfx2/Package_inc.mk|4 sfx2/inc/sfx2/templateabstractview.hxx |2 sfx2/inc/sfx2/templatelocalview.hxx|6 sfx2/inc/sfx2/templateonlineview.hxx | 64 sfx2/inc/sfx2/

[PATCH] Change in core[libreoffice-3-6]: fdo#53888: svx: do not link against dbtools

2012-08-23 Thread Gerrit
>From Matúš Kukan : Matúš Kukan has uploaded a new change for review. Change subject: fdo#53888: svx: do not link against dbtools .. fdo#53888: svx: do not link against dbtools dbtools were added in 01089138cc76f5717244bd04f25a

[Libreoffice-commits] .: connectivity/Library_dbtools.mk connectivity/Package_inc.mk solenv/gbuild svx/Library_svx.mk

2012-08-23 Thread Libreoffice Gerrit user
connectivity/Library_dbtools.mk |4 connectivity/Package_inc.mk |3 +++ solenv/gbuild/LinkTarget.mk |2 +- svx/Library_svx.mk |1 - 4 files changed, 4 insertions(+), 6 deletions(-) New commits: commit 33b1750f4ae8a9bc26f29440726c24f551041d94 Author: Matú

Related fdo#53872: CRASH - opening database report

2012-08-23 Thread Gerrit
>From Julien Nabet : Julien Nabet has abandoned this change. Change subject: Related fdo#53872: CRASH - opening database report .. Patch Set 1: Abandoned You're right Michael. I was so happy to remove the crash that I missed t

[Libreoffice-commits] .: 2 commits - extras/source

2012-08-23 Thread Libreoffice Gerrit user
extras/source/shellnew/soffice.html | 12 extras/source/shellnew/soffice.odt |binary 2 files changed, 12 deletions(-) New commits: commit e155a555c97db9e3f54d7500f912fe88f634dc99 Author: Andras Timar Date: Fri Aug 24 00:18:05 2012 +0200 remove unused soffice.html

Re: tail_build fail on missing includes

2012-08-23 Thread Matúš Kukan
On 23 August 2012 23:48, Tomáš Chvátal wrote: > 2012/8/23 Matúš Kukan : >> exactly, I was never sure I've done it right, but it seemed to be >> working so far. >> >> Matus > > Well to be honest I never had issue with it before the 3.6 release, > but seems that with certain use options it became un

[PATCH] gbuild: also in libmerge case library needs to depend on all...

2012-08-23 Thread Gerrit
>From Matúš Kukan : Matúš Kukan has uploaded a new change for review. Change subject: gbuild: also in libmerge case library needs to depend on all headers .. gbuild: also in libmerge case library needs to depend on all headers

Re: tail_build fail on missing includes

2012-08-23 Thread Tomáš Chvátal
2012/8/23 Matúš Kukan : > exactly, I was never sure I've done it right, but it seemed to be > working so far. > > Matus Well to be honest I never had issue with it before the 3.6 release, but seems that with certain use options it became unstable. Should I disable it as whole (always experimental

Re: Usage of memset to eradicate string content

2012-08-23 Thread Tor Lillqvist
> that is true for the document that is protected by the password. > but in practice that same password may not only give access to that one > document, but also let an attacker do other nefarious things like log on > to twitter and impersonate the user's cat. > Hmm, but why use password-protected

Re: tail_build fail on missing includes

2012-08-23 Thread Matúš Kukan
On 23 August 2012 22:54, Norbert Thiebaud wrote: >> Well, it should work like this (simplifying): I mean really simplifying.. or ignoring details.. so it also may become untrue. >> avmedia links against (and depends on) sfx and sfx depends on sfx2_inc >> package. > > on face value that would no

Re: [Libreoffice-commits] Revert "installer: Use hashref for replace_all_ziplistvariables_in_rtffile"

2012-08-23 Thread Matúš Kukan
On 23 August 2012 10:43, Michael Meeks wrote: > > It's a shame to loose Tim's nice unit test too - I love tests for > make_installer.pl :-) Might be nice as/when this is nailed to have some > gnumake guru to help connect them into the build. > Bah, you don't need to be gnumake guru. You ju

Re: tail_build fail on missing includes

2012-08-23 Thread Norbert Thiebaud
On Thu, Aug 23, 2012 at 3:47 PM, Matúš Kukan wrote: > Hi Tomáš, > > On 23 August 2012 20:38, Tomáš Chvátal wrote: >> I am not exactly sure why the deps are not picked by >> gbuild but when I fiddled with it and added the direct dep over >> sfx2_inc the code built bit further and again it died on

Re: tail_build fail on missing includes

2012-08-23 Thread Matúš Kukan
Hi Tomáš, On 23 August 2012 20:38, Tomáš Chvátal wrote: > I am not exactly sure why the deps are not picked by > gbuild but when I fiddled with it and added the direct dep over > sfx2_inc the code built bit further and again it died on missing > svtools_inc. When that worked it proceeded to anoth

[PATCH] Change in core[libreoffice-3-6]: actually set P_SEP aka. PATH_SEPERATOR on kFreeBSD to fix Ja...

2012-08-23 Thread Gerrit
>From Rene Engelhard : Rene Engelhard has uploaded a new change for review. Change subject: actually set P_SEP aka. PATH_SEPERATOR on kFreeBSD to fix Java builds... .. actually set P_SEP aka. PATH_SEPERATOR on kFreeBSD to fix J

[PUSHED] Change in core[libreoffice-3-6]: actually set P_SEP aka. PATH_SEPERATOR on kFreeBSD to fix Ja...

2012-08-23 Thread Gerrit
>From Norbert Thiebaud : Norbert Thiebaud has submitted this change and it was merged. Change subject: actually set P_SEP aka. PATH_SEPERATOR on kFreeBSD to fix Java builds... .. actually set P_SEP aka. PATH_SEPERATOR on kFree

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - configure.in

2012-08-23 Thread Libreoffice Gerrit user
configure.in |2 ++ 1 file changed, 2 insertions(+) New commits: commit a11a3352ff049ae7f4d9780fd1c694cc560dc8e4 Author: Rene Engelhard Date: Thu Aug 23 22:31:26 2012 +0200 actually set P_SEP aka. PATH_SEPERATOR on kFreeBSD to fix Java builds... Change-Id: I5e84cf342ab9a7017b

Re: Usage of memset to eradicate string content

2012-08-23 Thread Michael Stahl
On 23/08/12 22:15, Tor Lillqvist wrote: > But if the password is used to load or save encrypted documents, then > the contents of the document (which the so carefully erased password > protects) is loaded into memory in plain-text, and is equally readable > by an adversary that has access to the vi

[Libreoffice-commits] .: configure.in

2012-08-23 Thread Libreoffice Gerrit user
configure.in |2 ++ 1 file changed, 2 insertions(+) New commits: commit 361991a27183d340ae183178147bb22cd166a19c Author: Rene Engelhard Date: Thu Aug 23 22:31:26 2012 +0200 actually set P_SEP aka. PATH_SEPERATOR on kFreeBSD to fix Java builds... Change-Id: I5e84cf342ab9a7017b

Re: Usage of memset to eradicate string content

2012-08-23 Thread Tor Lillqvist
But if the password is used to load or save encrypted documents, then the contents of the document (which the so carefully erased password protects) is loaded into memory in plain-text, and is equally readable by an adversary that has access to the virtual memory of your process, and might get page

remove two empty methods

2012-08-23 Thread Gerrit
>From Norbert Thiebaud : Norbert Thiebaud has abandoned this change. Change subject: remove two empty methods .. Patch Set 1: Abandoned already fix some other way by caolan -- To view, visit https://gerrit.libreoffice.org/440

Re: Usage of memset to eradicate string content

2012-08-23 Thread Michael Stahl
On 23/08/12 21:12, Tor Lillqvist wrote: > 1. Don't eradicate the string content, > > I vote for this. Overwriting password in memory after use is security > theater. well it doesn't protect against every threat but i wouldn't call it mere theater; if you don't overwrite the password it may w

Re: [PATCH] Modified the wording of the Save-on-Exit-Dialog

2012-08-23 Thread Jean-Tiare LE BIGOT
Wow, Much nicer this way ! Le 2012-08-23 21:47, Samuel Mehrbrodt a écrit : Hi, I have a suggestion to change the wording of the Dialog which appears when you close a document and unsaved changes exist. See attached images with the difference before/after. I wrote a mail to the ux-advise list

[PATCH] Modified the wording of the Save-on-Exit-Dialog

2012-08-23 Thread Samuel Mehrbrodt
Hi, I have a suggestion to change the wording of the Dialog which appears when you close a document and unsaved changes exist. See attached images with the difference before/after. I wrote a mail to the ux-advise list [1] before and asked if this could be changed, but there was no reply (exc

[GSOC-UPDATE](23.08) Impress Remote

2012-08-23 Thread Andrzej J. R. Hunt
Hi everyone, Today I did the following: - Disabled bluetooth (Linux) for glib < 2.26 since dbus isn't available in gio until then. (Is it worth looking into using dbus-glib instead? I only do one dbus call at startup, and possibly one at shutdown -- everything else is via sockets.) - Added ma

Re: [GSOC] Calc Performance Project End

2012-08-23 Thread Daniel Bankston
On 08/21/2012 10:50 AM, Michael Meeks wrote: Thanks for applying, and working dilligently; hopefully you can spread the news about how cool it is to hack on LibreOffice for GSOC and we'll have you & your friends back again next year ? :-) All the best, Michael. I've already been telling people

[Libreoffice-commits] .: 4 commits - android/experimental android/qa basebmp/CppunitTest_basebmp.mk basebmp/Module_basebmp.mk basebmp/StaticLibrary_basebmp.mk Library_merged.mk Repository.mk solenv/gb

2012-08-23 Thread Libreoffice Gerrit user
Library_merged.mk |5 ++ Repository.mk | 19 +++ android/experimental/DocumentLoader/Makefile |2 - android/experimental/LibreOffice4Android/Makefile |1 android/qa/desktop/Makefile

Re: Usage of memset to eradicate string content

2012-08-23 Thread Tor Lillqvist
> > >1. Don't eradicate the string content, > > I vote for this. Overwriting password in memory after use is security theater. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoff

Usage of memset to eradicate string content

2012-08-23 Thread Arnaud Versini
Hi everyone, I noticed in the code some annihilation of O[U]String content by using memset or rtl_zeroMemory directly on the content as a password security. It breaks encapsulation and the string immutability, not so good. I think there is four possibilities, in order of my personal preference ;-)

Re: tail_build fail on missing includes

2012-08-23 Thread Norbert Thiebaud
On Thu, Aug 23, 2012 at 1:38 PM, Tomáš Chvátal wrote: > > So for now I have no clue how to fix it and I would really welcome any > help for it because this could rate as most annoying bug for Gentoo as > 1/3rd of users are hit by this stuff... I have it reproducing machine > at work so anyone from

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-23 Thread Michael Stahl
On 23/08/12 18:09, John Smith wrote: > Hi, > > > I just finished a first full run of lcov. There was one 'make check' > failure though, and there were a lot of 'warnings' running lcov that > may need some further investigation. Also, there is some stuff > included ('/usr/include/boost', for examp

[Libreoffice-commits] .: android/sdremote

2012-08-23 Thread Libreoffice Gerrit user
android/sdremote/res/menu/selector_contextmenu.xml |4 android/sdremote/res/values/strings.xml |1 android/sdremote/src/org/libreoffice/impressremote/SelectorActivity.java |

[Libreoffice-commits] .: sysui/desktop

2012-08-23 Thread Libreoffice Gerrit user
sysui/desktop/macosx/Info.plist |2 ++ 1 file changed, 2 insertions(+) New commits: commit 4908c8d79745057ebece07c7834e318a7366d6d0 Author: Dave Date: Thu Aug 23 19:43:57 2012 +0200 Fix for fdo#46858 Have us show up in Productivity category in Finder Change-Id: I19416bdef0e04

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-23 Thread bfo
John Smith wrote > > Anyway, the generated html report as it currently is can be found here : > http://dev-builds.libreoffice.org/lcov_reports/ > Hi. Great work! I hope both reports will be generated regularly and help improve quality of LO codebase. Best regards. -- View this message in cont

Re: improving "from" address in gerrit emails to commits list?

2012-08-23 Thread Philipp Riemer
2012/8/23 Miklos Vajna : > On Thu, Aug 23, 2012 at 09:52:53AM +0200, Noel Grandin > wrote: >> Is it possible to munge the "From:" address in the gerrit emails >> that go to the commit list? >> >> I got kind of used to seeing who did the commit in the "from" column >> of my email client, and I mis

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-23 Thread Philipp Riemer
That's great news! Thank you very much for your work! Unfortunately, the report currently looks pretty red... But now we have evidence and a way to trace pieces that need more tests. Philipp 2012/8/23 John Smith : > Hi, > > > I just finished a first full run of lcov. There was one 'make check' >

[PATCH] Change in core[libreoffice-3-5]: SwHeaderFooterWin: memory leak

2012-08-23 Thread Gerrit
>From Ivan Timofeev : Ivan Timofeev has uploaded a new change for review. Change subject: SwHeaderFooterWin: memory leak .. SwHeaderFooterWin: memory leak Change-Id: Ie8322b93745c48970766c2033a23cca2c710a516 (cherry picked from

Re: [Libreoffice-commits] Revert "installer: Use hashref for replace_all_ziplistvariables_in_rtffile"

2012-08-23 Thread Tim Retout
On Aug 23, 2012 9:13 AM, "Stephan Bergmann" wrote: > > On 08/23/2012 09:59 AM, Libreoffice Gerrit user wrote: >> >> commit 52755d6d2cf1c6addaf3c91b93bb86d66b730409 >> Author: Stephan Bergmann >> Date: Thu Aug 23 09:47:13 2012 +0200 >> >> Revert "installer: Use hashref for replace_all_zipli

[PATCH] Change in core[libreoffice-3-6]: SwHeaderFooterWin: memory leak

2012-08-23 Thread Gerrit
>From Ivan Timofeev : Ivan Timofeev has uploaded a new change for review. Change subject: SwHeaderFooterWin: memory leak .. SwHeaderFooterWin: memory leak Change-Id: Ie8322b93745c48970766c2033a23cca2c710a516 (cherry picked from

Re: LibreOffice code coverage

2012-08-23 Thread bfo
Michael Stahl-2 wrote > >> Did anyone make such report for LibreOffice codebase? > no, unfortunately we don't know how the unit test coverage ranks exactly > on a scale from "far too low" to "infinitesimal" :-/ > Hi. Thanks to work of John Smith such report is available at http://dev-builds.lib

Re: 'make check' failure

2012-08-23 Thread John Smith
On Thu, Aug 23, 2012 at 11:45 AM, Michael Stahl wrote: > > reading the log you posted no you don't get a core file because > soffice.bin didn't actually crash. > Ok, so how do we go about getting more detailed info that can assist in solving the issue, then ? (assuming I can reproduce, of course)

[Libreoffice-commits] .: dictionaries/da_DK

2012-08-23 Thread Libreoffice Gerrit user
dictionaries/da_DK/help/da/help.tree | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) New commits: commit d87fd7680041ffcb3546c94240505d1d4a020a99 Author: Andras Timar Date: Thu Aug 23 18:21:36 2012 +0200 Danish dictionary help tree snippet Change-Id: Ic171c

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-23 Thread Noel Grandin
Now that is very cool! On 2012-08-23 18:09, John Smith wrote: Hi, I just finished a first full run of lcov. There was one 'make check' failure though, and there were a lot of 'warnings' running lcov that may need some further investigation. Also, there is some stuff included ('/usr/include/boo

[Libreoffice-commits] .: sw/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/core/doc/docnew.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit f35aacfc765b5c296d62b4f2a32e6b0bb9bbe7e5 Author: Luboš Luňák Date: Thu Aug 23 18:09:59 2012 +0200 initialize member Introduced by b95d203bc17c83ec0fe5139f519d53ed1d842d3a . Chan

[Libreoffice-commits] .: sw/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/ui/docvw/HeaderFooterWin.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 442d0766eb9575a45572e29f2018bed2831c177f Author: Ivan Timofeev Date: Thu Aug 23 20:15:51 2012 +0400 SwHeaderFooterWin: memory leak Change-Id: Ie8322b93745c48970766c2033a23cca2c710a

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-23 Thread John Smith
Hi, I just finished a first full run of lcov. There was one 'make check' failure though, and there were a lot of 'warnings' running lcov that may need some further investigation. Also, there is some stuff included ('/usr/include/boost', for example) that might not be desired in the report ? I gu

[Libreoffice-commits] .: sw/qa

2012-08-23 Thread Libreoffice Gerrit user
sw/qa/extras/ooxmlimport/data/n775906.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 19 ++- 2 files changed, 18 insertions(+), 1 deletion(-) New commits: commit 93d22852564b8d77b98fae902ce5f879272ca818 Author: Miklos Vajna Date: Thu Aug 23 17:54:54 2012 +0200

[Libreoffice-commits] .: 7 commits - framework/source sc/source sd/source sfx2/source vcl/inc vcl/source vcl/unx

2012-08-23 Thread Libreoffice Gerrit user
framework/source/layoutmanager/toolbarlayoutmanager.cxx |4 - sc/source/ui/app/inputwin.cxx | 23 +-- sc/source/ui/inc/inputwin.hxx |1 sd/source/ui/view/ViewShellBase.cxx |7 +- sfx2/source/view/impviewfram

[Libreoffice-commits] .: 5 commits - sc/inc sc/source

2012-08-23 Thread Libreoffice Gerrit user
sc/inc/datauno.hxx |6 +++--- sc/source/core/data/cell.cxx|3 ++- sc/source/filter/oox/workbookhelper.cxx | 27 +++ sc/source/filter/xml/xmlimprt.cxx |2 -- sc/source/ui/docshell/docsh.cxx |3 ++- 5 files chan

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/inc vcl/source

2012-08-23 Thread Libreoffice Gerrit user
vcl/inc/vcl/layout.hxx| 10 - vcl/inc/vcl/window.hxx| 16 vcl/inc/window.h |5 ++ vcl/source/window/layout.cxx | 37 +--- vcl/source/window/window.cxx |5 ++ vcl/source/window/window2.cxx | 75 +

[Libreoffice-commits] .: 2 commits - writerfilter/source

2012-08-23 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/DomainMapper.cxx | 41 ++ writerfilter/source/dmapper/DomainMapper_Impl.cxx | 31 writerfilter/source/dmapper/DomainMapper_Impl.hxx |3 + 3 files changed, 47 insertions(+), 28 deletions(-) New commits: commit 5fd1516f82

[Libreoffice-commits] .: starmath/qa sw/qa

2012-08-23 Thread Libreoffice Gerrit user
dev/null |binary starmath/qa/testdocuments/README |2 sw/qa/extras/ooxmlexport/data/math-accents.docx |binary sw/qa/extras/ooxmlexport/data/math-d.docx|binary sw/qa/extras/ooxml

Re: [PATCH] factorise common code

2012-08-23 Thread Michael Stahl
On 23/08/12 17:22, Lionel Elie Mamane wrote: > On Thu, Aug 23, 2012 at 01:26:40PM +, Gerrit wrote: > >> Lionel Elie Mamane has uploaded a new change for review. > >> Change subject: factorise common code > > I explicitly draw your attention on the fact that I submitted that for > review beca

Re: [PATCH] factorise common code

2012-08-23 Thread Lionel Elie Mamane
On Thu, Aug 23, 2012 at 01:26:40PM +, Gerrit wrote: > Lionel Elie Mamane has uploaded a new change for review. > Change subject: factorise common code I explicitly draw your attention on the fact that I submitted that for review because this is based on the assumption that the code:       

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/inc vcl/source

2012-08-23 Thread Libreoffice Gerrit user
vcl/inc/vcl/builder.hxx | 20 +-- vcl/source/window/builder.cxx | 55 ++ 2 files changed, 37 insertions(+), 38 deletions(-) New commits: commit 367dfa8dd0cea9558d3922a0e0ab6e0c81e6fdbc Author: Caolán McNamara Date: Thu Aug 23 15:38

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/inc vcl/source

2012-08-23 Thread Libreoffice Gerrit user
vcl/inc/vcl/layout.hxx |5 + vcl/inc/vcl/tabctrl.hxx| 13 + vcl/source/control/tabctrl.cxx | 105 - vcl/source/window/layout.cxx | 53 vcl/source/window/window2.cxx | 38 -- 5 files changed,

[Libreoffice-commits] .: sc/source

2012-08-23 Thread Libreoffice Gerrit user
sc/source/filter/excel/xeextlst.cxx | 11 +++ sc/source/filter/inc/xeextlst.hxx | 11 ++- 2 files changed, 21 insertions(+), 1 deletion(-) New commits: commit a2cc10e02375aebd32ba0df49d83ee01235a709b Author: Markus Mohrhard Date: Thu Aug 23 16:03:38 2012 +0200 add mi

[Libreoffice-commits] .: solenv/bin

2012-08-23 Thread Libreoffice Gerrit user
solenv/bin/modules/installer/simplepackage.pm |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 7b4394f35b3557ffe61c8e9b0f0b630b31ca0977 Author: Stephan Bergmann Date: Thu Aug 23 15:51:34 2012 +0200 ...but remove obsolete prereg-specific code again

[Libreoffice-commits] .: svtools/source

2012-08-23 Thread Libreoffice Gerrit user
svtools/source/misc/langtab.src |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 51b0ada7403b7959cd0753218bff34b7cd4a7a24 Author: Andras Timar Date: Thu Aug 23 15:36:27 2012 +0200 Moldovan -> Romanian (Moldova) Change-Id: I5d754099ca0ce2a82d1d89df4

[PATCH] factorise common code

2012-08-23 Thread Gerrit
>From Lionel Elie Mamane : Lionel Elie Mamane has uploaded a new change for review. Change subject: factorise common code .. factorise common code Change-Id: I2d86714a0d951930de2389d920ea2cd04474e432 --- M reportdesign/source/f

[Libreoffice-commits] .: binfilter/bf_starmath

2012-08-23 Thread Libreoffice Gerrit user
binfilter/bf_starmath/source/cfgitem.hxx |9 --- binfilter/bf_starmath/source/starmath_cfgitem.cxx | 64 -- 2 files changed, 73 deletions(-) New commits: commit a0184a7ee6df0484ef62c4d4b6d5acce6a129848 Author: Caolán McNamara Date: Wed Aug 22 09:23:19 2012 +

[Libreoffice-commits] .: connectivity/inc connectivity/source unusedcode.easy

2012-08-23 Thread Libreoffice Gerrit user
connectivity/inc/connectivity/CommonTools.hxx |1 connectivity/source/commontools/CommonTools.cxx | 62 unusedcode.easy |1 3 files changed, 64 deletions(-) New commits: commit ff74564b39c6f0b2063158ffe7eb8faa99f12c4b Author:

[PATCH] Change in core[libreoffice-3-6]: installer: remove empty directories again:

2012-08-23 Thread Gerrit
>From Michael Stahl : Michael Stahl has uploaded a new change for review. Change subject: installer: remove empty directories again: .. installer: remove empty directories again: An "archive" installer contains one empty share/

[PUSHED] Change in core[libreoffice-3-6]: fdo#53888: svx: fix dependencies:

2012-08-23 Thread Gerrit
>From Miklos Vajna : Miklos Vajna has submitted this change and it was merged. Change subject: fdo#53888: svx: fix dependencies: .. fdo#53888: svx: fix dependencies: It appears that since cd0046bca0691fdca45a030903b7cde3bfee54

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - svx/Library_svx.mk svx/source

2012-08-23 Thread Libreoffice Gerrit user
svx/Library_svx.mk |1 + svx/source/inc/filtnav.hxx |1 - 2 files changed, 1 insertion(+), 1 deletion(-) New commits: commit 3e0f363d828618e86a0d6c7dac89040bfd37bed1 Author: Michael Stahl Date: Wed Aug 22 12:49:08 2012 +0200 fdo#53888: svx: fix dependencies: It ap

[PUSHED] Change in core[libreoffice-3-6]: fdo#51514: SwXBookmarks: only consider real bookmarks:

2012-08-23 Thread Gerrit
>From Miklos Vajna : Miklos Vajna has submitted this change and it was merged. Change subject: fdo#51514: SwXBookmarks: only consider real bookmarks: .. fdo#51514: SwXBookmarks: only consider real bookmarks: Since CWS swrefact

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/core/unocore/unocoll.cxx | 74 ++--- 1 file changed, 60 insertions(+), 14 deletions(-) New commits: commit 5ae1369a87ddc0293f6a78ef368179b6f8e43495 Author: Michael Stahl Date: Wed Aug 22 23:04:34 2012 +0200 fdo#51514: SwXBookmarks: only consider

[PUSHED] Change in core[libreoffice-3-6]: SwTokenWindow::InsertAtSelection: fix STL assertion:

2012-08-23 Thread Gerrit
>From Miklos Vajna : Miklos Vajna has submitted this change and it was merged. Change subject: SwTokenWindow::InsertAtSelection: fix STL assertion: .. SwTokenWindow::InsertAtSelection: fix STL assertion: error: attempt to cop

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/ui/index/cnttab.cxx | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) New commits: commit 3f88a4b00c6140c4294583cbaf75954486f5f5b6 Author: Michael Stahl Date: Wed Aug 22 21:45:27 2012 +0200 SwTokenWindow::InsertAtSelection: fix STL assertion: error: at

[Libreoffice-commits] .: android/sdremote

2012-08-23 Thread Libreoffice Gerrit user
android/sdremote/AndroidManifest.xml |4 android/sdremote/res/layout/dialog_addserver.xml | 46 ++ android/sdremote/res/menu/selector_activity.xml

[Libreoffice-commits] .: extensions/source

2012-08-23 Thread Libreoffice Gerrit user
extensions/source/propctrlr/formcomponenthandler.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e4b0ce8887a743d30a0107bc7b8f652b0e3b074c Author: Joel Madero Date: Tue Aug 21 12:14:34 2012 -0700 fdo#53001 disable unlink graphics in image control dialog in

[PUSHED:master 3-6] [PATCH] fdo#53001:REPORT BUILDER UI: Unlink picture action in Image control file dialog without effect

2012-08-23 Thread Lionel Elie Mamane
On Tue, Aug 21, 2012 at 01:44:54PM -0700, Joel Madero wrote: > As always, feel free to comment. Incredibly simple fix but took forever to > locate the code. Many thanks to everyone who helped locate it. Pushed to master and libreoffice-3-6. -- Lionel _

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - extensions/source

2012-08-23 Thread Libreoffice Gerrit user
extensions/source/propctrlr/formcomponenthandler.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 95cedcc822ec1faa88f74771e3d435da926850d4 Author: Joel Madero Date: Tue Aug 21 12:14:34 2012 -0700 fdo#53001 disable unlink graphics in image control dialog in

[Libreoffice-commits] .: reportbuilder/java

2012-08-23 Thread Libreoffice Gerrit user
reportbuilder/java/com/sun/star/report/ImageService.java | 6 +- reportbuilder/java/com/sun/star/report/SOImageService.java | 21 +- reportbuilder/java/com/sun/star/report/pentaho/output/ImageProducer.java | 20 - 3 files changed, 24 insertio

[Libreoffice-commits] .: 3 commits - solenv/bin sw/Library_swd.mk sw/source

2012-08-23 Thread Libreoffice Gerrit user
solenv/bin/modules/installer/simplepackage.pm| 19 + solenv/bin/modules/installer/systemactions.pm| 47 +++ sw/Library_swd.mk|1 sw/source/ui/chrdlg/break.cxx|6 -- sw/source/ui/chrdlg/chardlg.cxx

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - sw/source vcl/inc vcl/source

2012-08-23 Thread Libreoffice Gerrit user
sw/source/ui/misc/linenum.cxx |4 ++-- vcl/inc/vcl/builder.hxx |2 +- vcl/source/window/builder.cxx |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 45a8c44d5f39d8055003130595f7201b2cd8645a Author: Caolán McNamara Date: Thu Aug 23 13:33:53 2012 +01

[Libreoffice-commits] .: 2 commits - writerperfect/source

2012-08-23 Thread Libreoffice Gerrit user
writerperfect/source/filter/DocumentHandler.cxx | 31 ++--- writerperfect/source/filter/OdgGenerator.cxx| 35 ++-- 2 files changed, 37 insertions(+), 29 deletions(-) New commits: commit 7afb1fffefb1806205ddcef3cba1d2a559e9b39e Author: Fridrich Å trba D

[Libreoffice-commits] .: sw/qa sw/source writerfilter/Library_writerfilter.mk writerfilter/source

2012-08-23 Thread Libreoffice Gerrit user
sw/qa/extras/ooxmlexport/ooxmlexport.cxx |3 --- sw/qa/extras/rtfexport/rtfexport.cxx |3 --- sw/source/filter/ww8/docxattributeoutput.cxx | 11 +++ sw/source/filter/ww8/rtfattributeoutput.cxx | 18 +- writerfilte

Re: [PUSHED 3-6] Fix for fdo#53929 - Case insensitive strings in pivot table

2012-08-23 Thread Kohei Yoshida
Hi Michael, On 08/23/2012 04:13 AM, Michael Meeks wrote: set; surely it's smaller and easier to just do the pointer compare: if (mpString == r.mpString) is just as good presumably ? Yes. That's probably better and short-and-sweet since it avoids one equality comparison and

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/source

2012-08-23 Thread Libreoffice Gerrit user
vcl/source/window/builder.cxx | 12 1 file changed, 12 insertions(+) New commits: commit 35c4c62c178f1ed2d08267c0845b7c05a2590f35 Author: Caolán McNamara Date: Thu Aug 23 12:40:01 2012 +0100 map gtk-media-next and gtk-media-previous stock items Change-Id: Id5c9739

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/source

2012-08-23 Thread Libreoffice Gerrit user
vcl/source/window/builder.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit c2c4ce8d78286aa5691de57d9e75cbbe389c3590 Author: Caolán McNamara Date: Thu Aug 23 12:29:26 2012 +0100 map GtkSeparator to FixedLine Change-Id: I89b4663d94af7a57d915ea4386d5354a8d661

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - 2 commits - vcl/source

2012-08-23 Thread Libreoffice Gerrit user
vcl/source/window/builder.cxx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit 00348dbd4f98095a32fb026a2bd8f5d1d17b8f8f Author: Caolán McNamara Date: Thu Aug 23 12:21:28 2012 +0100 map GtkImage to FixedImage Change-Id: Ia5c3ab0099fc68e90

[Libreoffice-commits] .: sc/source

2012-08-23 Thread Libreoffice Gerrit user
sc/source/filter/excel/xeextlst.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit c5d5e06c1578f8ecae9e4e6fb55f1bdb529feb7d Author: Markus Mohrhard Date: Thu Aug 23 13:04:45 2012 +0200 fix ambigous overload diff --git a/sc/source/filter/excel/xeextlst.cx

[Libreoffice-commits] .: sw/inc sw/source writerfilter/source

2012-08-23 Thread Libreoffice Gerrit user
sw/inc/IDocumentSettingAccess.hxx |3 +- sw/inc/doc.hxx |1 sw/source/core/doc/doc.cxx |4 ++ sw/source/core/doc/docnew.cxx |1 sw/source/core/layout/frmtool.cxx | 39 +++- s

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/inc vcl/qa vcl/source

2012-08-23 Thread Libreoffice Gerrit user
vcl/inc/vcl/button.hxx |1 vcl/inc/vcl/dialog.hxx |1 vcl/inc/vcl/layout.hxx | 29 - vcl/qa/cppunit/builder/demo.ui | 114 +++ vcl/source/control/button.cxx |5 + vcl/source/window/builder.cxx |2 vcl/source/wi

Re: improving "from" address in gerrit emails to commits list?

2012-08-23 Thread Miklos Vajna
On Thu, Aug 23, 2012 at 09:52:53AM +0200, Noel Grandin wrote: > Is it possible to munge the "From:" address in the gerrit emails > that go to the commit list? > > I got kind of used to seeing who did the commit in the "from" column > of my email client, and I miss that :-) The script to hack is:

[Libreoffice-commits] .: 2 commits - oox/source sc/inc sc/Library_scfilt.mk sc/source

2012-08-23 Thread Libreoffice Gerrit user
oox/source/token/tokens.txt |2 sc/Library_scfilt.mk |1 sc/inc/colorscale.hxx|5 sc/source/filter/excel/excdoc.cxx|8 - sc/source/filter/excel/xecontent.cxx | 34 sc/source/filter/excel/xeextlst.cxx | 246 +++

[Libreoffice-commits] .: configure.in

2012-08-23 Thread Libreoffice Gerrit user
configure.in |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit afeab46e4754d886dd828ba654520902a755964f Author: Tor Lillqvist Date: Thu Aug 23 12:49:52 2012 +0300 Typo, fdo#53950 Change-Id: I82b4b59e868bb4f332cfe0e617c916a160cb549a diff --git a/con

Re: [Libreoffice-commits] Revert "installer: Use hashref for replace_all_ziplistvariables_in_rtffile"

2012-08-23 Thread Michael Meeks
On Thu, 2012-08-23 at 11:03 +0200, Noel Grandin wrote: > On 2012-08-23 10:43, Michael Meeks wrote: > > When I last looked at some of this horrific line-by-line substitution > > magic, it turned out to be faster to concatenate all the lines into a > > single string, run the regexp and split it

[Libreoffice-commits] .: android/experimental android/qa

2012-08-23 Thread Libreoffice Gerrit user
android/experimental/DocumentLoader/Makefile |3 +++ android/experimental/DocumentLoader/jni/Application.mk |3 --- android/qa/sc/Makefile |3 +++ android/qa/sc/jni/Application.mk |2 -- 4 files changed, 6 insertions(+

Re: 'make check' failure

2012-08-23 Thread Michael Stahl
On 23/08/12 10:19, Stephan Bergmann wrote: > On 08/23/2012 09:22 AM, John Smith wrote: >> On Thu, Aug 23, 2012 at 9:14 AM, Stephan Bergmann >> wrote: >>> >>> you should always run those tests with (bash etc.:) 'ulimit -c unlimited'; >>> the gbuild logic will automatically print backtraces in case

  1   2   >