On 23/08/12 17:22, Lionel Elie Mamane wrote: > On Thu, Aug 23, 2012 at 01:26:40PM +0000, Gerrit wrote: > >> Lionel Elie Mamane has uploaded a new change for review. > >> Change subject: factorise common code > > I explicitly draw your attention on the fact that I submitted that for > review because this is based on the assumption that the code: > > // start <text:p> > SvXMLElementExport > aParagraphContent(*this,XML_NAMESPACE_TEXT, XML_P, sal_True,sal_False);
that will have a side effect, the SvXMLElementExport constructor opens a <text:p> element via the SAX interface reachable in some way from "this" and the destructor will close it. > _ Reference<XServiceInfo> > xElement(aColIter->xElement,uno::UNO_QUERY); > Reference<XReportComponent> xReportComponent = > aColIter->xElement; > > Does not have any significant side effects (calling only constructors). > _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
