Re: [PUSHED] Bug 48140 - [EasyHack] remove uno calls from xlsx import

2012-04-17 Thread Miklos Vajna
On Tue, Apr 17, 2012 at 09:05:52PM +0200, Markus Mohrhard wrote: > I finally pushed you patch with the small correction that was > necessary for the shared formula import. Marking as such. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [ANDROID-UI-PATCH] [PUSHED] Starting of code for menu list for potential start center.

2012-04-17 Thread Tor Lillqvist
OK, I applied and pushed it. I dropped the .gitignore file from the patch as we already have an android/.gitignore that lists bin and gen. I changed the .classpath in the project directory to be .classpath.in instead and use @ANDROID_SDK_HOME@ to expand the SDK location. (You had hardcoded your hom

Re: cookies ucb interaction handler ...

2012-04-17 Thread Stephan Bergmann
On 04/17/2012 04:45 PM, Michael Meeks wrote: It seems that the ucb has this: 'HandleCookiesRequest' UNO struct used by the InteractionHandler. This then creates some chunk of code, which can create an awful dialog showing an image: icon-themes/galaxy/res/cookie.png I gue

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-17 Thread Tor Lillqvist
> MacOSX is one of the few platform that has consistently been built > with --enable-werror. > removing the benefit of it just for a micro-optimization seems an overkill. I agree with Norbert here. The more tinderboxes we have that (continue to) use --enable-werror, the better. (If with significa

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 dE changed: What|Removed |Added Depends on||35158 -- Configure bugmail: https://bugs.freedeskt

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 dE changed: What|Removed |Added Depends on||31217 -- Configure bugmail: https://bugs.freedeskt

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 dE changed: What|Removed |Added Depends on||42144 -- Configure bugmail: https://bugs.freedeskt

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 dE changed: What|Removed |Added Depends on||42720 -- Configure bugmail: https://bugs.freedeskt

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #282 from dE 2012-04-17 20:22:48 UTC --- (In reply to comment #281) > Adding again Bug 44861. I ask dE not to remove other people's bugs and not to > discuss them here. The title clearly says "LibreOffice 3.5 most annoying bugs"... y

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-17 Thread Norbert Thiebaud
On Tue, Apr 17, 2012 at 4:39 PM, Lubos Lunak wrote: > On Tuesday 17 of April 2012, CaolXXn McNamara wrote: >>  writerfilter/source/dmapper/GraphicHelpers.cxx |    4 ++-- >>  1 file changed, 2 insertions(+), 2 deletions(-) >> >> New commits: >> commit b92de73fdd81acc5fdb92005af34b3ce9f8ed37b >> Aut

Re: [PATCH] Use global constants for initial tab count bounds checking

2012-04-17 Thread Kohei Yoshida
On Wed, 2012-04-18 at 00:41 +0200, Albert Thuswaldner wrote: > Hi Kohei, > This patch makes the bounds checking of the initial tab count more > consistent with the actual limits. Actually we intentionally limit the number of initial sheets to 1024 even though the document can have up to 1 shee

Re: [PATCH] fdo#48473 No object information in status bar

2012-04-17 Thread Regina Henschel
Markus Mohrhard schrieb: Hey Regina, commit 29ac03994484cb65725ec697cb7615a31b117b58 translated some comments. It translated a String constant too, but left out one occurrences of that constant. This patch adds the missing translation. As explained in Hamburg this is not the right fix for t

[PATCH] Use global constants for initial tab count bounds checking

2012-04-17 Thread Albert Thuswaldner
Hi Kohei, This patch makes the bounds checking of the initial tab count more consistent with the actual limits. /Albert From f15fe62c41aa85b5698141e3d004648a36c642dc Mon Sep 17 00:00:00 2001 From: Albert Thuswaldner Date: Wed, 18 Apr 2012 00:31:02 +0200 Subject: [PATCH] Use global constants for in

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

2012-04-17 Thread Daniel Bankston [danthedev]
On 04/17/2012 02:05 PM, Markus Mohrhard wrote: Hey Daniel, On Tue, 2012-04-17 at 08:45 -0400, Kohei Yoshida wrote: I'll look through your changes to see what change might have caused the shared formula import issue. This change -Reference< XNamedRange> xNamedRange = createNamedRangeObj

Licence Statement

2012-04-17 Thread Artur Dorda
Hello, All past, present and future contributions by me to the LibreOffice project are under LGPLv3+/GPLv3+/MPL until further notice. Best regards, Artur Dorda ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-17 Thread Lubos Lunak
On Tuesday 17 of April 2012, CaolXXn McNamara wrote: > writerfilter/source/dmapper/GraphicHelpers.cxx |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > New commits: > commit b92de73fdd81acc5fdb92005af34b3ce9f8ed37b > Author: Caolán McNamara > Date: Tue Apr 17 20:11:20 2012 +010

Re: [PUSHED] Update Bugassistant

2012-04-17 Thread Thorsten Behrens
Rob Snelders wrote: > How/When will this be on the website? > Now. :) -- Thorsten pgpMtPTiTX4dK.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW][3-5] Re: [PUSHED][3-5] fdo#38635: sw: printing border lines gaps regression

2012-04-17 Thread Michael Stahl
On 17/04/12 10:24, Miklos Vajna wrote: > On Mon, Apr 16, 2012 at 05:24:44PM +0200, Michael Stahl > wrote: >> proposing for libreoffice-3-5: >> >> with the old border painting code, there is a special case for printing >> where the vertical borders are shortened so they don't overlap with the >> h

Re: [PUSHED] Update Bugassistant

2012-04-17 Thread Rob Snelders
Hi Thorsten, How/When will this be on the website? -- Greetings, Rob Snelders Op di 17 apr 2012 09:38:01 CEST, Thorsten Behrens schreef: Rob Snelders wrote: Sometimes the text that the bug is submitted displays below on the page. This will make sure it is always displayed above in the page. T

Re: [PATCH] Removed duplicate set/get methods for initial tab count (fails while linking vbaobj.uno.so)

2012-04-17 Thread Kohei Yoshida
Hi Albert, On Tue, 2012-04-17 at 21:44 +0200, Albert Thuswaldner wrote: > On Tue, Apr 17, 2012 at 21:10, Markus Mohrhard > wrote: > > > > You need to export GetDefaultsOptions with SC_DLLPUBLIC in scmod.hxx. > > > > Ok, that was simple enough. I have of course seen this SC_DLLPUBLIC > thing bef

Re: [PATCH] fdo#48473 No object information in status bar

2012-04-17 Thread Markus Mohrhard
Hey Regina, >>> commit 29ac03994484cb65725ec697cb7615a31b117b58 translated some comments. >>> It >>> translated a String constant too, but left out one occurrences of that >>> constant. This patch adds the missing translation. >>> >> >> As explained in Hamburg this is not the right fix for the pr

Re: [REVIEW 3-5] [PUSHED 3-5] resolved rhbz#813280 - Sheets cannot be moved in calc

2012-04-17 Thread Kohei Yoshida
On Tue, 2012-04-17 at 21:05 +0200, Eike Rathke wrote: > Hi, > > Please review and cherry-pick to 3-5 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e1ca72ca9f783a2f956f1445ce82cd3eacffe4a2 > > Fixes https://bugzilla.redhat.com/show_bug.cgi?id=813280 Looks good. Pushed to the 3-5 bran

Re: [PATCH] fdo#48473 No object information in status bar

2012-04-17 Thread Regina Henschel
Hi Markus, Markus Mohrhard schrieb: Hey Regina, 2012/4/17 Regina Henschel: Hi all, commit 29ac03994484cb65725ec697cb7615a31b117b58 translated some comments. It translated a String constant too, but left out one occurrences of that constant. This patch adds the missing translation. As expla

Re: [PATCH] Removed duplicate set/get methods for initial tab count (fails while linking vbaobj.uno.so)

2012-04-17 Thread Albert Thuswaldner
Hi Markus, On Tue, Apr 17, 2012 at 21:10, Markus Mohrhard wrote: > > You need to export GetDefaultsOptions with SC_DLLPUBLIC in scmod.hxx. > Ok, that was simple enough. I have of course seen this SC_DLLPUBLIC thing before, but never really understood the need for that. Now I do, thanks Markus!

Re: [PATCH] fdo#48473 No object information in status bar

2012-04-17 Thread Markus Mohrhard
Hey Regina, 2012/4/17 Regina Henschel : > Hi all, > > commit 29ac03994484cb65725ec697cb7615a31b117b58 translated some comments. It > translated a String constant too, but left out one occurrences of that > constant. This patch adds the missing translation. > As explained in Hamburg this is not th

[PATCH] fdo#48473 No object information in status bar

2012-04-17 Thread Regina Henschel
Hi all, commit 29ac03994484cb65725ec697cb7615a31b117b58 translated some comments. It translated a String constant too, but left out one occurrences of that constant. This patch adds the missing translation. Kind regards Regina From e95bd0d370f78a7a544a6ee014543884924f5d49 Mon Sep 17 00:00:00

Re: [REVIEW:3-5] [PUSHED 3-5] fdo#46983 Macros: Macro to set filter in Calc does not work with .StringValue

2012-04-17 Thread Kohei Yoshida
On Wed, 2012-04-18 at 03:56 +0900, Takeshi Abe wrote: > Hi all, > > Please review the commit > http://cgit.freedesktop.org/libreoffice/core/commit/?id=84a1ca6d9136c71bf20514307876824c1f915c0a > asking approval to go for 3-5. Pushed to 3-5 with my sign-off. Thanks a lot. Apparently we don't have

Re: [PATCH] Removed duplicate set/get methods for initial tab count (fails while linking vbaobj.uno.so)

2012-04-17 Thread Markus Mohrhard
Hello Albert, 2012/4/17 Albert Thuswaldner : > Hi, > This patch removes the duplicate Get/Set methods in appoptio.hxx which > the vba api uses. There was a long discussion back in the day about > this: > > http://lists.freedesktop.org/archives/libreoffice/2011-June/013114.html > > I CC:ing Noel Po

[PATCH] Removed duplicate set/get methods for initial tab count (fails while linking vbaobj.uno.so)

2012-04-17 Thread Albert Thuswaldner
Hi, This patch removes the duplicate Get/Set methods in appoptio.hxx which the vba api uses. There was a long discussion back in the day about this: http://lists.freedesktop.org/archives/libreoffice/2011-June/013114.html I CC:ing Noel Power if he as some opinion regarding this. Now to the proble

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

2012-04-17 Thread Markus Mohrhard
Hey Daniel, >> >> On Tue, 2012-04-17 at 08:45 -0400, Kohei Yoshida wrote: >>> I'll look through your changes to see what change might have caused >>> the shared formula import issue. >> >> This change >> >> -    Reference< XNamedRange > xNamedRange = createNamedRangeObject( aName, >> rTokens, 0 )

[REVIEW 3-5] resolved rhbz#813280 - Sheets cannot be moved in calc

2012-04-17 Thread Eike Rathke
Hi, Please review and cherry-pick to 3-5 http://cgit.freedesktop.org/libreoffice/core/commit/?id=e1ca72ca9f783a2f956f1445ce82cd3eacffe4a2 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=813280 Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuP

Re: [PATCH] fdo#45904: [EasyHack] move java based api tests to c++

2012-04-17 Thread Markus Mohrhard
Hello Artur, I finally reviewed the patch and found several compiler errors. Can you please next time compile before submitting a patch. You would have immediately see that there are still errors in the patch and that the test would have never passed. You find the corrected patch at http://cgit.f

Re: [PATCH] [PUSHED] Have operators of ScViewOptions and ScPrintOptions return bool instead of int

2012-04-17 Thread Kohei Yoshida
On Tue, 2012-04-17 at 20:21 +0200, Albert Thuswaldner wrote: > Hi Kohei, > I have various small fixes related to Calc options in store which > accumulated while poking around in this part of the code. > > Here is the first one. Yup. Looks good. Pushed. Kohei -- Kohei Yoshida, LibreOffice hac

[REVIEW:3-5] fdo#46983 Macros: Macro to set filter in Calc does not work with .StringValue

2012-04-17 Thread Takeshi Abe
Hi all, Please review the commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=84a1ca6d9136c71bf20514307876824c1f915c0a asking approval to go for 3-5. Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http:/

[PATCH] Have operators of ScViewOptions and ScPrintOptions return bool instead of int

2012-04-17 Thread Albert Thuswaldner
Hi Kohei, I have various small fixes related to Calc options in store which accumulated while poking around in this part of the code. Here is the first one. /Albert From 44c021da20b3695385ab48623c194c6e172ed8ba Mon Sep 17 00:00:00 2001 From: Albert Thuswaldner Date: Sun, 15 Apr 2012 17:15:20 +02

[PATCH] Opengrok remote attribute

2012-04-17 Thread Andrew Higginson
Hi, BUG: https://bugs.freedesktop.org/show_bug.cgi?id=48387 Patch is at https://bugs.freedesktop.org/attachment.cgi?id=60199 This patch to opengrok adds a 'remote' id the the body tag when ?remote=true is given in the URL (and as a result in CSS, hides some extra chrome, like the header) This i

Re: [ANDROID-UI-PATCH] Starting of code for menu list for potential start center.

2012-04-17 Thread Jonathan Aquilina
On 17/04/12 11:56, Tor Lillqvist wrote: The patch still creates files in an "android/UI" subdirectory (which gives the wrong impression, that they would be *the* UI for LO on Android, uses a weird "LO_UI" project name in the .project file and a weird LO_UIActivity class name, and the LO_UIActivit

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||45084 -- Configure bugmail: https://bugs.

[PUSHED][3-5] misc stuff

2012-04-17 Thread Michael Meeks
On Tue, 2012-04-17 at 15:15 +0200, Michael Stahl wrote: > some misc commits that would make sense for libreoffice-3-5: These all look nice to me; reviewed, pushed and running a test build. Hopefully they'll get into 3.5.3. Thanks ! Michael. -- michael.me...@sus

RE: Question about Bug 33599

2012-04-17 Thread Dézsi Szabolcs
It must be something in my build.. Libreoffice installed on OpenSuSe 12.1 x64 system is OK. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffi

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 42537, which changed state. Bug 42537 Summary: RTL UI [AR]: "active indication" background with border (for icons) in menu at left instead at right https://bugs.freedesktop.org/show_bug.cgi?id=42537 What|

[PATCH] convert PTRARR usage in xmloff module

2012-04-17 Thread Noel Grandin
Hi This patch series converts SV_*_PTRARR usage in the xmloff module. Depending on the usage, std::vector, boost::ptr_vector, or boost::ptr_set was used. It passed "make xmloff.subsequentcheck" and most of "make subsequentcheck" (the rest is failing because there is a glitch with current ma

RE: Question about Bug 33599

2012-04-17 Thread Dézsi Szabolcs
Hi, while working on this bug (33599) I found an issue which causes writer to crash. Here are the steps to reproduce it: 1. Open new writer document. 2. Insert new comment by pressing Ctrl+Alt+C or by selecting Insert/Comment 3. Write 'Test' into the comment. 4. Press Alt+Tab to switch t

Re: [PUSHED:3-5] Fix fdo#47484 - use older ODF encryption by default.

2012-04-17 Thread Petr Mladek
Thorsten Behrens píše v Út 17. 04. 2012 v 16:26 +0200: > Hi Petr, all, > > as per my ESC action item, a last-minute addition to libreoffice-3-5 > - please note, that this is explicitely *not* meant for master. Yup, we wanted this. I have pushed it, see http://cgit.freedesktop.org/libreoffice/core

broken links causing assert/abort

2012-04-17 Thread Noel Power
whilst trying to test some export stuff I was suffering from libreoffice bailing out due to an assert. Problem is in the mysterious UCP layer :-) If you have a broken link in a directory the ucp sniffs then the abort occurs ( e.g. in my case for some reason I had the libreoffice file selector e

Re: [PUSHED] fdo#42537: fix RTL menu rendering on Windows

2012-04-17 Thread Andras Timar
2012/4/14 Ivan Timofeev : > Hi! > > The bug: https://bugs.freedesktop.org/show_bug.cgi?id=42537 > > The fix for libreoffice-3-5 attached. It consists of the following commits: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4cc4d3ec982ac61100b337125983afa0bb6fbc3 > http://cgit.freedeskto

cookies ucb interaction handler ...

2012-04-17 Thread Michael Meeks
Hi there, It seems that the ucb has this: 'HandleCookiesRequest' UNO struct used by the InteractionHandler. This then creates some chunk of code, which can create an awful dialog showing an image: icon-themes/galaxy/res/cookie.png I guess this dates back to the 'browser'

[PATCH] Fix fdo#47484 - use older ODF encryption by default.

2012-04-17 Thread Thorsten Behrens
Hi Petr, all, as per my ESC action item, a last-minute addition to libreoffice-3-5 - please note, that this is explicitely *not* meant for master. Cheers, -- Thorsten From 9e59955324609de3819ccf1619feb32df360c0a0 Mon Sep 17 00:00:00 2001 From: Thorsten Behrens Date: Tue, 17 Apr 2012 16:10:37 +0

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

2012-04-17 Thread Markus Mohrhard
Hey Kohei, Daniel, sorry that I did not respond earlier but I'm a bit busy this week. 2012/4/17 Kohei Yoshida : > Hi Daniel, > > On Tue, 2012-04-17 at 08:45 -0400, Kohei Yoshida wrote: >> I'll look through your changes to see what change might have caused >> the shared formula import issue. > > T

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on|45084 | -- Configure bugmail: https://bugs.freed

License statement

2012-04-17 Thread Gökçen Eraslan
Hello, All of my past and future contributions to the LibreOffice project are under LGPLv3+/GPLv3+/MPL until further notice. Regards. -- Gökçen Eraslan signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@li

Re: Make ordering (Re: namespace / typing thrash ...)

2012-04-17 Thread Bjoern Michaelsen
On Tue, Apr 17, 2012 at 03:05:26PM +0200, Lubos Lunak wrote: > Is the library dependency tree in LO so narrow that the build > would be repeatedly stuck waiting for just one library to be linked? For an incremental full build it would be a safe bet that it has a severe performance impact. And onc

[REVIEW][3-5] misc stuff

2012-04-17 Thread Michael Stahl
some misc commits that would make sense for libreoffice-3-5: EMF+ valgrind warning http://cgit.freedesktop.org/libreoffice/core/commit/?id=24b449b7fcaaee20ef8feebfd64fc761535f77a8 headless UI dialogs blocking terminate fix: http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb237af5aa0a5d8

Re: Make ordering (Re: namespace / typing thrash ...)

2012-04-17 Thread Noel Grandin
On 2012-04-17 15:05, Lubos Lunak wrote: dependencies is not enough. That also means that simple make patching probably won't do, and it'd need to be changed to prefer depth-first search for targets to build next. I thought gmake was depth-first? That's certainly what the documentation seems

Re: Make ordering (Re: namespace / typing thrash ...)

2012-04-17 Thread Lubos Lunak
On Tuesday 17 of April 2012, Bjoern Michaelsen wrote: > On Tue, Apr 17, 2012 at 02:19:59PM +0200, Lubos Lunak wrote: > > I don't think it would hurt parallelism much, because the linking of svx > > needs to be done somewhen, and make should have enough of other stuff to > > do. On the other hand,

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

2012-04-17 Thread Kohei Yoshida
Hi Daniel, On Tue, 2012-04-17 at 08:45 -0400, Kohei Yoshida wrote: > I'll look through your changes to see what change might have caused > the shared formula import issue. This change -Reference< XNamedRange > xNamedRange = createNamedRangeObject( aName, rTokens, 0 ); -OSL_ENSURE( xNam

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

2012-04-17 Thread Kohei Yoshida
On Mon, 2012-04-16 at 09:44 -0500, Daniel Bankston [danthedev] wrote: > May I please have a copy of that test document so that I can try to > resolve the problem you mentioned? (When time permits, that is.) Hi Daniel, First of all, thanks a lot for submitting the additional patch I've asked for

Re: SVG import: svgreader -> internal-style-ref

2012-04-17 Thread Thorsten Behrens
Christina Roßmanith wrote: > To get a better understanding: > What is the intent of internal-style-ref? > Which items should get identical values? Are identical values > allowed at all? > Are empty values allowed? (Probably not because in that case the > text doesn't show up) > Hi Christina,

Re: [Libreoffice-ux-advise] [PATCH] Mouse centered zooming

2012-04-17 Thread Tim Hardeck
Hi, so I did some testing and I think the most confusing part is the reversed shifting during zoom out. Since the image section is increased during zoom out normally no additional focus is needed that's why I have disabled shifting during zoom out. This again might result into a little problem w

Re: Make ordering (Re: namespace / typing thrash ...)

2012-04-17 Thread Bjoern Michaelsen
On Tue, Apr 17, 2012 at 02:19:59PM +0200, Lubos Lunak wrote: > I don't think it would hurt parallelism much, because the linking of svx > needs to be done somewhen, and make should have enough of other stuff to do. > On the other hand, I doubt such one change would change much. Could gbuild be

Re: namespace / typing thrash ...

2012-04-17 Thread Lubos Lunak
On Tuesday 17 of April 2012, Stephan Bergmann wrote: > On 04/16/2012 06:23 PM, Lubos Lunak wrote: > > On Monday 16 of April 2012, Michael Meeks wrote: > >>Oh - and finally (Lubos) I pushed an item to the ESC agenda to discuss > >> whether we should be exposing tons of classes and their symbols

Re: namespace / typing thrash ...

2012-04-17 Thread Lubos Lunak
On Monday 16 of April 2012, Markus Mohrhard wrote: > 2012/4/16 Lubos Lunak : > > On Monday 16 of April 2012, Michael Meeks wrote: > >>       Oh - and finally (Lubos) I pushed an item to the ESC agenda to > >> discuss whether we should be exposing tons of classes and their symbols > >> in the produc

Re: [PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

2012-04-17 Thread Noel Grandin
And here is the second patch in the series. This patch actually converts chart2uno.cxx from tools/table.hxx to std::map This was the last file using tools/table in the LO tree. This patch passes "make sc.subsequentcheck". (I can't do a check on the full tree because the build still has linking

Make ordering (Re: namespace / typing thrash ...)

2012-04-17 Thread Lubos Lunak
On Monday 16 of April 2012, Matúš Kukan wrote: > On 16 April 2012 18:23, Lubos Lunak wrote: > >  It is made even worse by the fact that make+gbuild order build commands > > so that allmost all compiles go first and linking goes last > > As I've seen complaining about this, I was thinking.. > Now,

[PATCH] Hackfest

2012-04-17 Thread Italo Vignoli
As the attachment has been stripped by the system when I have sent it the first time, I am resending the patch to the Impress Help file which adds text shortcuts. Please review it carefully, as I have added quite a large number of lines (for a tech illiterate). -- Italo Vignoli - it...@italovigno

Re: [PUSHED] fdo#46538 Easyhack: Add support for more bug trackers to get-bugzilla-attachments-by-mimetype

2012-04-17 Thread Thorsten Behrens
> While testing KDE bugzilla I noticed a bug. This patch fixes that, can > you push this one as well? > Nice, thanks, pushed as well. -- Thorsten pgpjdeg7eRzUD.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.o

Re: [PUSHED:3-5]patches for 35 MAB fdo#45376 already in master ..

2012-04-17 Thread Petr Mladek
Noel Power píše v Po 16. 04. 2012 v 10:18 +0100: > On 16/04/12 09:49, Petr Mladek wrote: > > Cor Nouws píše v Ne 15. 04. 2012 v 16:08 +0200: > >> Hi, > >> > >> I see Bug 45376 - [FORMATTING] Incorrect text wrapping around drawing > >> shape, one of the 3.5 MAB issues, that seems to be fixed with tw

SVG import: svgreader -> internal-style-ref

2012-04-17 Thread Christina Roßmanith
Hi, I've created a small svg sample file just containing some text. If I remove the x and y attribute this has influence on the value of the internal-style-ref attribute. Maybe this is a hint where some problems might have their origin. To get a better understanding: What is the intent of

Re: [Libreoffice-commits] .: 2 commits - configure.in

2012-04-17 Thread Lubos Lunak
On Tuesday 17 of April 2012, Tomáš Chvátal wrote: > Dne 17.4.2012 10:11, Lubos Lunak napsal(a): > > On Tuesday 17 of April 2012, Tom ChvXXtal wrote: > >> --enable-ext-languagetool requires --with-java now bit more sanely. ... > >> AC_MSG_CHECKING([for LanguageTool extension integration]) >

Re: [PUSHED] fdo#46538 Easyhack: Add support for more bug trackers to get-bugzilla-attachments-by-mimetype

2012-04-17 Thread Gmail
On 17-04-2012 10:44, Thorsten Behrens wrote: > Hi Gökçen, > Hello, > thanks a lot, nice improvement - pushed > While testing KDE bugzilla I noticed a bug. This patch fixes that, can you push this one as well? Cheers. > -- Thorsten > > -- Gökçen Eraslan >From b048d701420a107d9f62f0edae095

Re: [PUSHED] [fdo#40778] Remove dictionary choice when adding new entry to the spellchecker

2012-04-17 Thread Rob Snelders
Miklos Vajna schreef op 17.04.2012 12:19: On Sat, Apr 14, 2012 at 02:02:05PM +0200, Rob Snelders wrote: Ah yes.. sorry about that.. Hi Rob, Thanks for this! Pushed now. Two suggestions, though: - Please use git config user.email to set something better than "ertai@idefix.(none)" :) I fix

Re: [PATCH] fdo#45904: [EasyHack] move java based api tests to c++

2012-04-17 Thread Markus Mohrhard
Hey Miklos, > On Sun, Apr 15, 2012 at 03:16:35AM +0200, Artur Dorda > wrote: >> This patch is transferring XPrintAreas test to c++, from >> qaDevOOo/tests/java/ifc/sheet to test/inc/test/ and test/source/ > > Great! > >> Though not all tests are transferred, I'm sending this so it could be >> re

Re: [PUSHED] [fdo#40778] Remove dictionary choice when adding new entry to the spellchecker

2012-04-17 Thread Miklos Vajna
On Sat, Apr 14, 2012 at 02:02:05PM +0200, Rob Snelders wrote: > Ah yes.. sorry about that.. Hi Rob, Thanks for this! Pushed now. Two suggestions, though: - Please use git config user.email to set something better than "ertai@idefix.(none)" :) - The same problem is there when you right-click

Re: [PUSHED-3-5] Fix fdo#33591 - edge-case trans gradients came out empty

2012-04-17 Thread Petr Mladek
Thorsten Behrens píše v Po 16. 04. 2012 v 16:00 +0200: > Hi there, > > could someone please review > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=983c27402e151126c5bef6623eeb07f333456243 > > and cherry-pick to -3-5? Great catch, makes sense, works fine => pushed to 3-5, see htt

Re: [ANDROID-UI-PATCH] Starting of code for menu list for potential start center.

2012-04-17 Thread Tor Lillqvist
The patch still creates files in an "android/UI" subdirectory (which gives the wrong impression, that they would be *the* UI for LO on Android, uses a weird "LO_UI" project name in the .project file and a weird LO_UIActivity class name, and the LO_UIActivity.java file says "import lo.UI.R". Could y

Re: [PATCH] fdo#45904: [EasyHack] move java based api tests to c++

2012-04-17 Thread Miklos Vajna
Hi Artur, On Sun, Apr 15, 2012 at 03:16:35AM +0200, Artur Dorda wrote: > This patch is transferring XPrintAreas test to c++, from > qaDevOOo/tests/java/ifc/sheet to test/inc/test/ and test/source/ Great! > Though not all tests are transferred, I'm sending this so it could be > reviewed, becaus

Re: [PUSHED 3-5][PATCH] Re: librO python & ssl support

2012-04-17 Thread Petr Mladek
Caolán McNamara píše v Út 17. 04. 2012 v 10:16 +0100: > On Tue, 2012-04-10 at 16:33 +0100, Caolán McNamara wrote: > > On Tue, 2012-04-10 at 16:14 +0100, Caolán McNamara wrote: > > > Now proposing the above commit for 3-5. > > > > Rats, macosx buildbot tells me that our internal expat, which is now

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45171, which changed state. Bug 45171 Summary: Can't open or create libreoffice documents with password https://bugs.freedesktop.org/show_bug.cgi?id=45171 What|Old Value |New Value --

Re: [PUSHED 3-5] Fix regression in rendering Thai texts

2012-04-17 Thread Petr Mladek
Kohei Yoshida píše v Po 16. 04. 2012 v 22:10 -0400: > Hi there, > > I'd like to have > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e57525b61af70a6ee33c26f979e724740cca8655 > > cherry-picked to the 3-5 branch to fix > > https://bugs.freedesktop.org/show_bug.cgi?id=48431 > > It's a

Re: [PUSHED] translated German comments and removed redundant ones

2012-04-17 Thread Miklos Vajna
Hi Florian, On Sun, Apr 15, 2012 at 07:50:04PM +0200, Florian Allmann-Rahn wrote: > After some time I have another load of translated German comments ready. > The patch is attached and after applying it the directories > connectivity, cppuhelper and cui should be completely cleared of > German c

[PUSHED-3-5] fix download and unpack-sources for .xz source tarballs

2012-04-17 Thread Fridrich Strba
DONE! On 16/04/12 17:55, Petr Mladek wrote: > Petr Mladek píše v Pá 13. 04. 2012 v 18:36 +0200: >> Petr Mladek píše v Pá 13. 04. 2012 v 18:00 +0200: >>> Korrawit Pruegsanusak píše v Pá 13. 04. 2012 v 22:40 +0700: Hello again Petr, On Fri, Apr 13, 2012 at 21:34, Petr Mladek wrote: >

Re: [REVIEW 3-5][PATCH] Re: librO python & ssl support

2012-04-17 Thread Caolán McNamara
On Tue, 2012-04-10 at 16:33 +0100, Caolán McNamara wrote: > On Tue, 2012-04-10 at 16:14 +0100, Caolán McNamara wrote: > > Now proposing the above commit for 3-5. > > Rats, macosx buildbot tells me that our internal expat, which is now > picked up instead of the system macosx expat, is missing > _X

Re: [PUSHED: 3-5] fdo#33914 sound in presenter console

2012-04-17 Thread Petr Mladek
Petr Mladek píše v Út 17. 04. 2012 v 11:06 +0200: > David Tardon píše v Po 16. 04. 2012 v 08:21 +0200: > > Hi all, > > > > When the presenter console is used and there is a sound in the > > presentation, it is played in both the presentaion and the console. > > Commit a4b8a1c9f50bca3b557efca75100d

Re: [PUSHED-3-5] fsync less often ...

2012-04-17 Thread Stephan Bergmann
On 04/15/2012 03:41 AM, Michael Meeks wrote: The attached is not that pleasant, but (I hope) solves fdo#47983 slow-down, while not loosing people's data on dodgy, modern file-systems :-) I'd love to get it into LibreOffice 3.5.3 What a hack. :) Anyway, cherry-picked into -3-5

Re: [REVIEW: 3-5] fdo#33914 sound in presenter console

2012-04-17 Thread Petr Mladek
David Tardon píše v Po 16. 04. 2012 v 08:21 +0200: > Hi all, > > When the presenter console is used and there is a sound in the > presentation, it is played in both the presentaion and the console. > Commit a4b8a1c9f50bca3b557efca75100d9532a404ec6 fixes that. Looks fine. Also Cor said that it wor

Re: [PUSHED] Cleaning of Basic Help files

2012-04-17 Thread Italo Vignoli
Thorsten Behrens wrote: > thanks a lot, pushed - and yeah, most of the comments seem to be > used in lieu of commit messages. Once I have finished cleaning the useless ones, I will start looking into the comments with a reference to check what has been done there (and possibly close the loop). Th

Re: Thanks for a fantastic Hackfest!

2012-04-17 Thread Miklos Vajna
On Mon, Apr 16, 2012 at 04:43:42PM +0200, Luc Castermans wrote: > Apart from pasta cooking (looked nice!!), any outcomes, progrress > which can be shared here? See http://planet.documentfoundation.org/ ___ LibreOffice mailing list LibreOffice@lists.fre

Re: [PUSHED] Cleaning of Basic Help files

2012-04-17 Thread Thorsten Behrens
Italo Vignoli wrote: > Help files need some real love, after the cleaning of the useless > comments. > Hi Italo, thanks a lot, pushed - and yeah, most of the comments seem to be used in lieu of commit messages. Cheers, -- Thorsten pgppSIOgiTjRw.pgp Description: PGP signature __

Re: [PUSHED][3-5] fdo#38635: sw: printing border lines gaps regression

2012-04-17 Thread Miklos Vajna
On Mon, Apr 16, 2012 at 05:24:44PM +0200, Michael Stahl wrote: > proposing for libreoffice-3-5: > > with the old border painting code, there is a special case for printing > where the vertical borders are shortened so they don't overlap with the > horizontal borders (the old borders were rectang

Re: [PUSHED] fdo#46538 Easyhack: Add support for more bug trackers to get-bugzilla-attachments-by-mimetype

2012-04-17 Thread Thorsten Behrens
Hi Gökçen, thanks a lot, nice improvement - pushed -- Thorsten pgpybMvj6BSaF.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Make clean for bugassistent

2012-04-17 Thread Thorsten Behrens
Rob Snelders wrote: > I want to improve the bug-assistent. I have created a simple patch > that allows you to do a make clean in the bug-directory of the > website. > Thanks a lot, pushed! -- Thorsten pgpdKLuVV3Oj9.pgp Description: PGP signature ___ L

[PUSHED] Update Bugassistant

2012-04-17 Thread Thorsten Behrens
Rob Snelders wrote: > Sometimes the text that the bug is submitted displays below on the > page. This will make sure it is always displayed above in the page. > This patch is for the website-repository. > Thanks Rob, pushed. -- Thorsten pgpMucU2UlzLY.pgp Description: PGP signature _

Licence Statement

2012-04-17 Thread Andrzej J. R. Hunt
All past, present and future contributions by me to the LibreOffice project are under LGPLv3+/GPLv3+/MPL until further notice. Regards, Andrzej Hunt ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/l

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Timur changed: What|Removed |Added Depends on||44861 --- Comment #281 from Timur 2012-04-17 00